From: "Ni, Ray" <ray.ni@intel.com>
To: "Fedorowicz, Jakub" <jakub.fedorowicz@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
Subject: Re: [PATCH v3] IntelSiliconPkg/BaseConfigBlockLib: Add function to iterate over Config Blocks
Date: Thu, 25 Nov 2021 06:55:55 +0000 [thread overview]
Message-ID: <BN0PR11MB5696A967126D3174F25EAE888C629@BN0PR11MB5696.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BYAPR11MB2709C45E6A98A43B768D5C90849B9@BYAPR11MB2709.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
+EFI_STATUS
+EFIAPI
+GetNextConfigBlock (
+ IN VOID *ConfigBlockTableAddress,
+ IN VOID *ConfigBlockAddress,
+ OUT VOID **NextConfigBlockAddress
+ )
How about using following prototype?
CONFIG_BLOCK *
GetNextConfigBlock (
IN CONFIG_BLOCK_TABLE_HEADER *ConfigBlockTable
IN CONFIG_BLOCK *ConfigBlock,
IN GUID *Guid
);
The API searches within ConfigBlockTable from ConfigBlock to find the next one whose GUID matches to Guid.
The new API is more flexible than yours because it allows caller to supply a different GUID.
By the way, do you have a plan to change existing library APIs to replace "VOID *" with "CONFIG_BLOCK_TABLE_HEADER *" or "CONFIG_BLOCK *"?
Thanks,
Ray
[-- Attachment #2: Type: text/html, Size: 3893 bytes --]
prev parent reply other threads:[~2021-11-25 6:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 13:47 [PATCH v3] IntelSiliconPkg/BaseConfigBlockLib: Add function to iterate over Config Blocks Fedorowicz, Jakub
2021-11-25 6:55 ` Ni, Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN0PR11MB5696A967126D3174F25EAE888C629@BN0PR11MB5696.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox