From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.1843.1637550545143781249 for ; Sun, 21 Nov 2021 19:09:05 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=S5JLfi6c; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10175"; a="295522194" X-IronPort-AV: E=Sophos;i="5.87,253,1631602800"; d="scan'208";a="295522194" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2021 19:09:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,253,1631602800"; d="scan'208";a="649176810" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP; 21 Nov 2021 19:09:04 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sun, 21 Nov 2021 19:09:04 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sun, 21 Nov 2021 19:09:03 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Sun, 21 Nov 2021 19:09:03 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Sun, 21 Nov 2021 19:09:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eRnfvujviewN+KKMPC5GQDUYhPf5QtaN+2zHfic4OAzCNkjUipSyiZIxqvDCL1p15xbWQDHnhbsVnU6+ExLv6zL3GY6NhSvVOETA8GVuiJlQA2vlOwZ5B05cKe7HBd2mpsl3ekxpU0pAGjtp47nTBS0sRAZ3qC4g9x+un5qkYn94NeSwg8L2/Z0mEtRGLWlQhGu5l03hVRQrRpGUNuoZyJU/SQx6CToTJdo4rPblhHaaTSShX0McV8EzoGUGKmT0jbnpu4dBeGzkfJMD7LrRh+LqFYWNAu9Kv4uT7wm7mQa6C0f2kXiJmjvF6VnD6z7+y0k8Cn19m50ivHJ14IGGhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B8BOXzoR1byf6dovu039450LhmtnyFNuFBNL8fw611U=; b=GTt4fZzyQE7Nqf3QURZ+ukEg+Z1R+uuZ5oi6hppcJHcmoaesGCpFeH7mFFfOo9lWs5lMSnbc2cpJ3rX4RlpbQcHQ8p/J1HJiVinlK1Wbgh6qcsoSrps3Po7/NW/bKlZEtUhwKW8OYVGS52/m6aT+6iNqZWYkF6fGoqlKXXNzDHTQv1oG4bEQTsDRY9BFnC3tFJc7EIcBwfIxR8AV95saXIqhTUlJOeXrlNoxRQcQ3x4oPVDDQP4mJ22UqXedO9LrOuDqkSKnQfuuEaS7K1olzByCt10Of6jG2HE1UDoqSvyNhj7bzWays6WIuS3xPx08bObt/Ir8PpnrdyhW+p2uvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B8BOXzoR1byf6dovu039450LhmtnyFNuFBNL8fw611U=; b=S5JLfi6cmku9kQ7sQHkRJz2lHyjJr4w3nCNsqKKtDx+VPqUewtxybfV2P3FwBH2hFmZbPnX7PFi8p15fp00hPAmG/apbQ0jkM7SW+JksLNqVIIid+oAnLb1/cADMHIZJDFTkn5N/ZbF2rIi75O5QdGVprD6NhC3jsgHYW99y5Yk= Received: from BN0PR11MB5696.namprd11.prod.outlook.com (2603:10b6:408:14b::11) by BN6PR11MB1875.namprd11.prod.outlook.com (2603:10b6:404:104::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.27; Mon, 22 Nov 2021 03:09:02 +0000 Received: from BN0PR11MB5696.namprd11.prod.outlook.com ([fe80::49dc:7490:201e:9fc9]) by BN0PR11MB5696.namprd11.prod.outlook.com ([fe80::49dc:7490:201e:9fc9%7]) with mapi id 15.20.4690.029; Mon, 22 Nov 2021 03:09:01 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "kraxel@redhat.com" , "Xu, Min M" CC: Brijesh Singh , Erdem Aktas , James Bottomley , "Yao, Jiewen" , Tom Lendacky , "Dong, Eric" , "Kumar, Rahul1" Subject: Re: [edk2-devel] [PATCH V3 23/29] UefiCpuPkg: Update AddressEncMask in CpuPageTable Thread-Topic: [edk2-devel] [PATCH V3 23/29] UefiCpuPkg: Update AddressEncMask in CpuPageTable Thread-Index: AQHXzyMD5YdwlWwkvkqFrm4vlZptDavxYpkAgB2bDBA= Date: Mon, 22 Nov 2021 03:09:01 +0000 Message-ID: References: <2885c5213149eadbc99bfc579a9a27cccf080109.1635769996.git.min.m.xu@intel.com> <20211103070008.ker73xikocbxtkfa@sirius.home.kraxel.org> In-Reply-To: <20211103070008.ker73xikocbxtkfa@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d8dccafa-3d9c-4106-7555-08d9ad656f47 x-ms-traffictypediagnostic: BN6PR11MB1875: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8n2U+SPM48SEk911+t+MfPkRWj45dM7GETU6ybos1mHXNFpdLFooridVU+COZdULC7/vRxsNm0ttBapuAw7kBW1TaVF4EXZBF/x8ele9nTJJ3CA46F7jGo1ekQVQaClembp07feMub3o5zPliOnNKW1IEPL8ydbOZziZXQ8QtdhDECqxS3PpPOPczh64X2N+1OKEGN5PE9V77NDt3GmIjWhgI07nVQk/10kNuTHWgRvGtl/8gr6HEfH1L4MJvt3svZP8t5dkX8izBUgWj6wpduN96D4m1/0TV+7H7cfojFZtHgz8ciDM85aYq0pXOagsBkJ9BxJA4GiNyMn7R4kNj+yU1m6ZDdCYZgulJlNrEhl3xlVM4puQ2opBPuo+j3uNJGEzq/Yrb8Gubu8Xvfltk+72OAqbQVgBIS93FJLJiyiV9X+XdjPZcaVMWCLmeKDgkqmUcbZeQWwV33F05S4ZdlENR8dfiAaKdvOtL26ns8FP9I0gul4//dBjR+cTcP1DVB+EA2iCcQUA171tWbMp4VygEUQ+5DTLqxuxB3nGFZCRBq2C8nL8N6X//BhjMV93emdJa2ju3pDzTUEOXgCcDCbChqhadhPYshd2BmQ71nhKOReEObkXaJ3tYSxqZGS0EDHPMzPVj5FYwuJMWNi+eGW5z6JgcswB0CGsa8Lxg4KDv5dwFr9eZiMcqsItToDu6WSUAmYaNt6ah7OnZnfaqLoCgmcl9OroEDKKTt1lxZ47TfBhLTFOycgJREgK78GYwVNJDWBocNXEd1GMvIgrZVeZsVZL1z6kySE8lfqCe51TDJdfu9418JEcQwiZZGn6QWkguBqd4K87HoGtwbp8gg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN0PR11MB5696.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(53546011)(76116006)(15650500001)(38100700002)(64756008)(110136005)(83380400001)(66556008)(66446008)(66476007)(7696005)(5660300002)(82960400001)(107886003)(9686003)(54906003)(55016002)(38070700005)(26005)(122000001)(6506007)(8936002)(6636002)(33656002)(8676002)(2906002)(86362001)(71200400001)(508600001)(966005)(316002)(186003)(66946007)(52536014)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Xo/00M3Na28uFe+AsqcjZimfAOCPEaq+LTy86DNwCF8+ym6uiDXHxqtZqVoO?= =?us-ascii?Q?qyG62NQQKvM2kurqtpJPFXmr30yAccba+mPnl0OpwvGjd9WEkZBJuYAUsJ5M?= =?us-ascii?Q?mNoccNGrea8gYLQngA72Vy13gQJwSLgFafAtI1xm9z4n4GpXMBKn8+cNwxAl?= =?us-ascii?Q?kw8h4BW2WEWAEOaf8wBGBW4x60a2xcTXOi5loreiGcRpDRP0Sf5mrmWoOQCM?= =?us-ascii?Q?09or8U5xQHUFHxiM8XrKLPLgYJKg1deOXvR6p5O/TsthM+9pl7X9DOvXQP10?= =?us-ascii?Q?GIC/xukx6lRv6CKpoiAHDiInV6vd5AlMlDsZG96neOE7+QizNxtkalMuKhUl?= =?us-ascii?Q?GJu16cTISsYdJVXTbXBxqO2q80cprzve5bPMNY+k24PuyJd3xscTI7bBsDAl?= =?us-ascii?Q?geJXtqtfQcjpTC6lr3qKrsrHpiH3Cp9t6+w951PQMS+1n753KSQTuIYtfKjY?= =?us-ascii?Q?mh3KBSJYcF6kz+ZEktrX7p8xOEGh4sKr6hBamfX5fa/CFGjYwQJr0Y3e4h3k?= =?us-ascii?Q?PIooDjgoRAmChuWToktg0f8rP2IrBm/tnrupLBbeTSRE/4KN+wAmDx6yYMRC?= =?us-ascii?Q?uAgM21DH/H4wz7+Z5ReC80ZeHP5cBA8xOmLVKxZSZ2f+CEO4VE6HbeVOiEH4?= =?us-ascii?Q?1NvyiE4XDsNtOEurFPV+px8lTi3eyultmWfbw4R0fOzThkTFPkf+gdk5vYhy?= =?us-ascii?Q?FonJTHrfk6h8BJSRAs6pmy3FWu1mSxLgU9y6zEfhSisTLHrsd+ppQaSR0jeJ?= =?us-ascii?Q?RVDpHNyASLfNhW7rsfQ97vfiVA9Bc8HsiQucoCg6DcHfB0KqZspu/0fka1dE?= =?us-ascii?Q?EaAkJC3XOPnn7KWP2ePY3uf3puVO4jEj002fARhv8aeAHzFaqp8S73bixeBw?= =?us-ascii?Q?6MzP/bwqBy4XagZnoXoFDacPF9e48qOyZ+p1AX8SP3dHbZtETPcc/iwYWjmY?= =?us-ascii?Q?2LDHLDhS/6nbCONDdorKlFLhGfbAq+56N9DfaKEjzaKE6jgH0llYzQO4m/c7?= =?us-ascii?Q?WlYraOMgh2Mf7ADF+UkqdB5N+wdmu2HblGg2sdqYgFQok1mMqhXw4g/8jYX9?= =?us-ascii?Q?icfBmhQYreTfK8OafHvBvOQQMRY6f+0fSHqBqF9GCvom2wtpzAUT4u4IH8e3?= =?us-ascii?Q?7DzrSEPtlU3NkgyLpGBxQpqln84JEC6ETdB+YOqc/ndL1xYu95bOo7HSsWSB?= =?us-ascii?Q?N/zqwNGrpkCxQBwGNjguzxDaJCN8ZmTScp2nZrUggVZgyM5yhaFVd7svAkaA?= =?us-ascii?Q?4dal4i4wkq39Q1C1ZAMIuqyBIexMZliKoJhJY30MrYfhi3/qapCHZVr7gBLL?= =?us-ascii?Q?apWN7u7qmwfN1BccskAPNg2gUVTfNyEle1bCD7BafvkJhF9w7eSaZeAeb1i3?= =?us-ascii?Q?/fHRYqCMQV6upS/VQOb0BMh4JcgJ2nYLC7LT3f/PcServduiOLy6Q/LFKNzc?= =?us-ascii?Q?M1JLXvJILF3ZnF0lip2W91yaI8oi7q5DD490RrLhZlAniNzhwRga0Eb6WN21?= =?us-ascii?Q?MzzM4Fl/782N3KIKgKdUEAJkfosTvTubxubBm56DjMPw50f0WtbxUHQ4bMMU?= =?us-ascii?Q?wHCRo41uZKxDkdwfia/DNIPxFBMfQusLxM5PbwJBZvnsHY4NXRI6ZPfuqAXb?= =?us-ascii?Q?yAVWtwENf80Mjz2WvxGc0Ns=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5696.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8dccafa-3d9c-4106-7555-08d9ad656f47 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2021 03:09:01.8557 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Rol/d0hNNQsayfgh6t/yLCU6AiZ7KtKNtcG8fGFyaGwCzLQCRb/CqslOQvbMc/SvGLUq933iwdpUExktkemCSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1875 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Gerd, thanks. I am about to raise the same comments... -----Original Message----- From: devel@edk2.groups.io On Behalf Of Gerd Hoffman= n Sent: Wednesday, November 3, 2021 3:00 PM To: Xu, Min M Cc: devel@edk2.groups.io; Brijesh Singh ; Erdem Akta= s ; James Bottomley ; Yao, Jiewe= n ; Tom Lendacky ; Dong, Eri= c ; Ni, Ray ; Kumar, Rahul1 Subject: Re: [edk2-devel] [PATCH V3 23/29] UefiCpuPkg: Update AddressEncMas= k in CpuPageTable Hi, > + gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask = ## CONSUMES > AddressEncMask =3D PcdGet64 (PcdPteMemoryEncryptionAddressOrMask) &=20 > PAGING_1G_ADDRESS_MASK_64; > + if (AddressEncMask =3D=3D 0) { > + AddressEncMask =3D PcdGet64 (PcdTdxSharedBitMask) &=20 > + PAGING_1G_ADDRESS_MASK_64; } Looks like two PCDs for basically the same thing. Should we create a common CC PCD here? take care, Gerd