public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* MdeModulePkg/Universal/Disk/PartitionDxe/Gpt.c
@ 2018-07-10  1:02 Robinson, Herbie
  0 siblings, 0 replies; only message in thread
From: Robinson, Herbie @ 2018-07-10  1:02 UTC (permalink / raw)
  To: edk2-devel@lists.01.org

I noticed this code in MdeModulePkg/Universal/Disk/PartitionDxe/Gpt.c:



  //

  // Verify that the Protective MBR is valid

  //

  for (Index = 0; Index < MAX_MBR_PARTITIONS; Index++) {

    if (ProtectiveMbr->Partition[Index].BootIndicator == 0x00 &&

        ProtectiveMbr->Partition[Index].OSIndicator == PMBR_GPT_PARTITION &&

        UNPACK_UINT32 (ProtectiveMbr->Partition[Index].StartingLBA) == 1

        ) {

      break;

    }



I was wondering why the code is checking for BootIndicator being zero when the UEFI spec states in two places that UEFI should ignore that field?  Is this some kind of security thing?  I couldn't find anything in the git history.






^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-07-10  1:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-10  1:02 MdeModulePkg/Universal/Disk/PartitionDxe/Gpt.c Robinson, Herbie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox