From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=216.205.24.131; helo=us-smtp-1.mimecast.com; envelope-from=herbie.robinson@stratus.com; receiver=edk2-devel@lists.01.org Received: from us-smtp-1.mimecast.com (us-smtp-delivery-131.mimecast.com [216.205.24.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B6A0A202E53E3 for ; Mon, 9 Jul 2018 18:02:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=StratusTechnologies.onmicrosoft.com; s=selector1-stratus-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xbf4kXnrild387pDG1QSpfcLgFYQM8AircOo0mckuvA=; b=r5hMjxQQdcYrai6vDjkJStzNmfg18vgKGc7QU5jLQHIPT5SsUJ1IhuSGPkqXIU7ILcMWt932IvcIFTHUn3TGqolV+I5EK4JruxuIpPedH5VrZ67TXNVmYeOq1hoNxdbKwZLHEVBgjWFIUdVRe14ROmb6MURPg2F6R5JDoKtbgAM= Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02lp0021.outbound.protection.outlook.com [216.32.180.21]) (Using TLS) by us-smtp-1.mimecast.com with ESMTP id us-mta-273-9BeVqr3PPNyA84q_d8jjdQ-1; Mon, 09 Jul 2018 21:02:39 -0400 Received: from BN1PR08MB107.namprd08.prod.outlook.com (10.242.212.20) by BN1PR08MB121.namprd08.prod.outlook.com (10.242.212.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.930.21; Tue, 10 Jul 2018 01:02:37 +0000 Received: from BN1PR08MB107.namprd08.prod.outlook.com ([fe80::cd92:8f36:3813:4f02]) by BN1PR08MB107.namprd08.prod.outlook.com ([fe80::cd92:8f36:3813:4f02%13]) with mapi id 15.20.0930.022; Tue, 10 Jul 2018 01:02:37 +0000 From: "Robinson, Herbie" To: "edk2-devel@lists.01.org" Thread-Topic: MdeModulePkg/Universal/Disk/PartitionDxe/Gpt.c Thread-Index: AdQX6Gy6T+al9+5cTUG4vuAwOqvy1A== Date: Tue, 10 Jul 2018 01:02:37 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [198.97.42.5] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BN1PR08MB121; 7:2I1kGD9jAoZxebOR+vatzEfJMLcHgl0Vg/m9dmj6/mbt0mzgtO6fIcQqZpOT4Efn4nuwxyuyAsdzFeWwGywRIBtRfHG54J1VL7RCC02nH4MueAOTqdR/qpgnkCzvXLeAPODfTHQp2UfRKhIGFQexkWHop8W351NKMCi+nIUFeZqEn4wAEGl3YbX8NE/W9rAKPEkH8ArAyXEhfabWuuBd2YXjIWmL5D4CBp6SxHKDj+y99VrNrQMqGbV4XL6Fyrdu; 20:oYsQrtoFTN7xmIjrAE67e2cmym0JjOju88sn+1gUU5EZd5sHeR2wCgWlcfu21wcAaPuY2DtuM62BWMSjbzH87NB5L4ZbDakOxLIdpAMyNEPRLSSXOmrESmGPhukCopgugHkYwKjpeNprb2pVAIVRDurBpfNaWsDZUCC8py3/ozQ= x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 99d642d1-a267-4851-7745-08d5e600d3e0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BN1PR08MB121; x-ms-traffictypediagnostic: BN1PR08MB121: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(192374486261705)(21748063052155); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(3002001)(3231311)(944501410)(52105095)(93006095)(93001095)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:BN1PR08MB121; BCL:0; PCL:0; RULEID:; SRVR:BN1PR08MB121; x-forefront-prvs: 0729050452 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(136003)(39850400004)(396003)(376002)(346002)(189003)(199004)(68736007)(25786009)(14454004)(790700001)(53936002)(6916009)(5660300001)(486006)(81166006)(8676002)(8936002)(81156014)(3846002)(74316002)(14444005)(256004)(7736002)(86362001)(72206003)(97736004)(2501003)(478600001)(2351001)(5250100002)(6116002)(2900100001)(6506007)(33656002)(106356001)(316002)(99286004)(7696005)(186003)(102836004)(105586002)(26005)(2906002)(6436002)(476003)(66066001)(54896002)(5640700003)(9686003)(6306002)(55016002)(190663001); DIR:OUT; SFP:1102; SCL:1; SRVR:BN1PR08MB121; H:BN1PR08MB107.namprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-microsoft-antispam-message-info: GyTlfumojvjPEVgFU3UtcUksyFFUBbCh9b/STOPmmO1idUXXDDnkakm/dh0vkKY3AXWNvjHB3XyZ77CfmNNkSapbT1mvry12N87/G+MRJhraW8jRkp11w1N+UHpIXFTpmTvtg64xeG6ncIqduEysKlFud+P486zJ+D9dNnj1+VNFoeO1XqkIvlyZFBvTtXwpWxc4OV2slkjq9gL1sDzCZac7rQVeMopxtCNKzfZcFxp1MlGTdRsk/PiRWEQZygE7vokIaxejR/M9nysvXOrl1JmJo+Az6vQXdy4KXDdRevBLuqEsphMv386AvAoPIW5hHY0Ag8WYH9Ik1hicr4x5yPacdOxV+mNZMlgy2mBbza4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: stratus.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99d642d1-a267-4851-7745-08d5e600d3e0 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2018 01:02:37.0478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: de36b473-b8ad-46ff-837f-9da16b8d1b77 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR08MB121 X-MC-Unique: 9BeVqr3PPNyA84q_d8jjdQ-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.27 Subject: MdeModulePkg/Universal/Disk/PartitionDxe/Gpt.c X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2018 01:02:44 -0000 Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable I noticed this code in MdeModulePkg/Universal/Disk/PartitionDxe/Gpt.c: // // Verify that the Protective MBR is valid // for (Index =3D 0; Index < MAX_MBR_PARTITIONS; Index++) { if (ProtectiveMbr->Partition[Index].BootIndicator =3D=3D 0x00 && ProtectiveMbr->Partition[Index].OSIndicator =3D=3D PMBR_GPT_PARTITI= ON && UNPACK_UINT32 (ProtectiveMbr->Partition[Index].StartingLBA) =3D=3D = 1 ) { break; } I was wondering why the code is checking for BootIndicator being zero when = the UEFI spec states in two places that UEFI should ignore that field? Is = this some kind of security thing? I couldn't find anything in the git hist= ory.