From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.67]) by mx.groups.io with SMTP id smtpd.web12.15104.1586881683986635110 for ; Tue, 14 Apr 2020 09:28:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=As8uUmaa; spf=pass (domain: vmware.com, ip: 40.107.220.67, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n4ab0JrC3IDam0R+IqArbY1uflr6oyqZZusxAWx0qrNyDxCiFHc0pXbW5htmofGGwYGMH/WpoVvhsIa3WwpwrBb4BMGRYNED2gBd8YoDICIQ8k/ySlKfwKq2riHQvNLKuiEfpBfp3y63MlL4vtIhvlzY3NOcQ23vLk1oza6wqK4Apm6RPZPIdb/IKzHJaRcq4lXlaNNu4poURZv5kAYY49aREQBRZpGmOBoey4ZeWOzCgcP43gNia+K+UhRHfLqMKwqB5OM2eR212XBQXx6/i7wcn24cLCjiDClVUp9M17Lsf3190p69pTLM7f6sxEoC8ZXbQrj7YGVODG16ynblRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YgvUmLTLq94Rc1R+z/y0VtU/e/KhP7vc+OPeOxHRxss=; b=KcHA+NHwwhB5OJOVp/+Z/ThRDf/8KZ/oSDxmldU3hegVW2qa7aQShdp7hmgu4E7Cir1vBaQiTPVrSxcKmR/TpK3erSvvAUSeN4GRoAqaWyZ1aA7Pv8GFfs2jv3jfVZnxn7ks6+v7ecN/fb2Un8GZ8ZWoRvT6yNO89HjKjeUttkUoBSumUX5c7QK9ZgmrrKT40ZKtgDfQa0VIXCLbZUBeB2Ka9MPgxeG9Wx4+hsGCbF35idvtN61halF+TG4c1Zf1ili6OPIsRbNwjE5tvMKOH4hjraVuJFaFVgjR6SPcuqeDrdLZkTJF4tX6m2Qv7LE8/H8elli46TNairEkPsazmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YgvUmLTLq94Rc1R+z/y0VtU/e/KhP7vc+OPeOxHRxss=; b=As8uUmaaqxKAVX3kW3RmeA079Wx0d9oGLRaPREtVGFP0jTqD/Q0WxSIZix6dR3YtlYrtsSZ6EH40imew1wm/phEs8CPHTbrzsxfQey7lApxyHQCMA1OKyMEC6/DkgmcruB8ldGtR+8tCepOikLkN0ZF1oxVBiksStU7Ouhmh7QI= Received: from BN6PR05MB3411.namprd05.prod.outlook.com (2603:10b6:405:43::23) by BN6PR05MB3300.namprd05.prod.outlook.com (2603:10b6:405:3e::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.23; Tue, 14 Apr 2020 16:28:02 +0000 Received: from BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::5df3:40e3:521a:7f84]) by BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::5df3:40e3:521a:7f84%5]) with mapi id 15.20.2921.024; Tue, 14 Apr 2020 16:28:02 +0000 From: "Andrei Warkentin" To: "devel@edk2.groups.io" , "samer@elhajmahmoud.com" CC: Leif Lindholm , Ard Biesheuvel , Pete Batard Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/3] Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe Thread-Topic: [edk2-devel] [edk2-platform][PATCH v1 1/3] Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe Thread-Index: AQHWEBm9pTetgg3DTkCLTEBJ2m1Oiah40xfW Date: Tue, 14 Apr 2020 16:28:02 +0000 Message-ID: References: <20200411155611.632-1-samer@elhajmahmoud.com>,<20200411155611.632-2-samer@elhajmahmoud.com> In-Reply-To: <20200411155611.632-2-samer@elhajmahmoud.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=awarkentin@vmware.com; x-originating-ip: [98.214.99.181] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 272fe0f1-9b12-4611-f1c4-08d7e090cd9d x-ms-traffictypediagnostic: BN6PR05MB3300: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0373D94D15 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR05MB3411.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(39860400002)(396003)(346002)(136003)(376002)(366004)(2906002)(19627405001)(76116006)(66946007)(66476007)(66556008)(64756008)(66446008)(52536014)(45080400002)(478600001)(8676002)(81156014)(86362001)(8936002)(966005)(66574012)(6506007)(53546011)(9686003)(54906003)(55016002)(110136005)(19627235002)(71200400001)(26005)(316002)(4326008)(33656002)(7696005)(5660300002)(186003);DIR:OUT;SFP:1101; received-spf: None (protection.outlook.com: vmware.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2yAMG/it19VdE3APkpnekKubiZsRKNnRDGuMHIe5aN28173kJlexrxcEHEFdYKKBVHi9kVE4ARumN6WP5Qtbc+usqtihvl6KccBm62NW5IkeC2CAWtJngT1jixy+wCsFb22V+mqyV23bjoUarNeSuML1ukwMnW4XNrJQtWiIPZSVObvAfUJzduLzzhePXJ45g6eWi2bBaGxcZaJp8JTyHxMfhaAuDvAzV5Y7TfoeY9+zDuDqMxKJa41B0eJKFA8ViwbqjgWEbLugzCCCLjzGI38rGqu+trL76Ld/yghdbqXS0SlvDyqtTLktp+aa7I14zrWQ2hHBxhIWVeP7VJbALrmNJMZv/KgCSlfzSLrXp1VLAVnCajpxnA2VtLPjB6xUJ7aGPKpSBNs9dzcfyyhKnDOgKgfW2Jt1KREoKIysjn3wx4gjLtlhGQJCJCKY1Y6X7kk3vhnm2nyGOkCepBcFe1ms8lT/bpCAFZ99WZUVwRdalBBs3WLiFYQh+wN9qKANuM+zPZ+9Erl/6IbmEzoUFg== x-ms-exchange-antispam-messagedata: GUrJ0f76gT4LohgPPdSTprDQxWsPgZGYA5bJOmrdOJXc5ZHQLtg/qOZjM6fn53crcB7w6rexjVBOaCUfB5SHVkdcQiavMifCjWEEIHdhM5kvmC0MG2JoCwSVkuegav/zMDW6zXHGLcf7GPI4MKN3vg== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-Network-Message-Id: 272fe0f1-9b12-4611-f1c4-08d7e090cd9d X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2020 16:28:02.3888 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PYWnJeJn3/4mz5XWSD8lQTrqiXMywVtlJzR3GZqRjkkHIfk0QUWZVIe1MNHcN5Zr/VJNpkCpqlujY31Rfz6WIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR05MB3300 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BN6PR05MB3411160B3BC1F2FF083FCE20B9DA0BN6PR05MB3411namp_" --_000_BN6PR05MB3411160B3BC1F2FF083FCE20B9DA0BN6PR05MB3411namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Andrei Warkentin Looks good to me - there's little reason for using a custom GraphicsConsol= eDxe now (historically, the screenshot facility lived there, there's a priv= ate interface there for messing with terminal scrolling (unused) and I move= d to a different font with my box drawing chars, but the font issue can/nee= ds to be tackled in a different way that Tiano already supports). ________________________________ From: devel@edk2.groups.io on behalf of Samer El-Ha= j-Mahmoud via groups.io Sent: Saturday, April 11, 2020 10:56 AM To: devel@edk2.groups.io Cc: Leif Lindholm ; Ard Biesheuvel ; Pete Batard Subject: [edk2-devel] [edk2-platform][PATCH v1 1/3] Platform/RaspberryPi/R= Pi4: Switch to common GraphicsConsoleDxe Switch from the PI specific GraphicsConsoleDxe driver to the common driver in MdeModulePkg. There is no need to carry RPi specific version. This resolves https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%= 3A%2F%2Fgithub.com%2Fpftf%2FRPi4%2Fissues%2F32&data=3D02%7C01%7Cawarken= tin%40vmware.com%7C58784054ddf14f87e7aa08d7de30de80%7Cb39138ca3cee4b4aa4d6c= d83d9dd62f0%7C0%7C0%7C637222173782452455&sdata=3D9lmKLPXe6ZfLum3er0eOx2= VIm7i5Dn2kgepiAvC8yq8%3D&reserved=3D0 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi4/RPi4.dsc | 2 +- Platform/RaspberryPi/RPi4/RPi4.fdf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi= 4/RPi4.dsc index 4fe4d810a0bc..785ac9b65633 100644 --- a/Platform/RaspberryPi/RPi4/RPi4.dsc +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc @@ -582,7 +582,7 @@ [Components.common] MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf - Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.inf + MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.in= f MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf MdeModulePkg/Universal/SerialDxe/SerialDxe.inf Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.inf diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf b/Platform/RaspberryPi/RPi= 4/RPi4.fdf index a59d3b601a86..b21643639131 100644 --- a/Platform/RaspberryPi/RPi4/RPi4.fdf +++ b/Platform/RaspberryPi/RPi4/RPi4.fdf @@ -194,7 +194,7 @@ [FV.FvMain] # INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf - INF Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.= inf + INF MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDx= e.inf INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf INF Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.inf -- 2.17.1 --_000_BN6PR05MB3411160B3BC1F2FF083FCE20B9DA0BN6PR05MB3411namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Andrei Warkentin <andrey.warkentin@gmail.com>

Looks good to me - there's little reason for using a custom GraphicsConsol= eDxe now (historically, the screenshot facility lived there, there's a priv= ate interface there for messing with terminal scrolling (unused) and I move= d to a different font with my box drawing chars, but the font issue can/needs to be tackled in a different = way that Tiano already supports).

From: devel@edk2.groups.io= <devel@edk2.groups.io> on behalf of Samer El-Haj-Mahmoud via groups.= io <samer=3Delhajmahmoud.com@groups.io>
Sent: Saturday, April 11, 2020 10:56 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ard= .biesheuvel@linaro.org>; Pete Batard <pete@akeo.ie>
Subject: [edk2-devel] [edk2-platform][PATCH v1 1/3] Platform/Raspbe= rryPi/RPi4: Switch to common GraphicsConsoleDxe
 
Switch from the PI specific GraphicsConsoleDxe dr= iver to the
common driver in MdeModulePkg. There is no need to carry RPi specific
version.

This resolves https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub= .com%2Fpftf%2FRPi4%2Fissues%2F32&amp;data=3D02%7C01%7Cawarkentin%40vmwa= re.com%7C58784054ddf14f87e7aa08d7de30de80%7Cb39138ca3cee4b4aa4d6cd83d9dd62f= 0%7C0%7C0%7C637222173782452455&amp;sdata=3D9lmKLPXe6ZfLum3er0eOx2VIm7i5= Dn2kgepiAvC8yq8%3D&amp;reserved=3D0

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Pete Batard <pete@akeo.ie>
Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
---
 Platform/RaspberryPi/RPi4/RPi4.dsc | 2 +-
 Platform/RaspberryPi/RPi4/RPi4.fdf | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi= 4/RPi4.dsc
index 4fe4d810a0bc..785ac9b65633 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -582,7 +582,7 @@ [Components.common]
 
   MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.= inf
   MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.= inf
-  Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe= .inf
+  MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsCons= oleDxe.inf
   MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf    MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
   Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.inf
diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf b/Platform/RaspberryPi/RPi= 4/RPi4.fdf
index a59d3b601a86..b21643639131 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.fdf
+++ b/Platform/RaspberryPi/RPi4/RPi4.fdf
@@ -194,7 +194,7 @@ [FV.FvMain]
   #
   INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatform= Dxe.inf
   INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter= Dxe.inf
-  INF Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsol= eDxe.inf
+  INF MdeModulePkg/Universal/Console/GraphicsConsoleDxe/Graphics= ConsoleDxe.inf
   INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.in= f
   INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
   INF Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.inf --
2.17.1




--_000_BN6PR05MB3411160B3BC1F2FF083FCE20B9DA0BN6PR05MB3411namp_--