[edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Hide RamMoreThan3GB setting

[edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Hide RamMoreThan3GB setting

[Samer El-Haj-Mahmoud]

Hide the RamMoreThan3GB HII seting when the feature is not support
(i.e. on RPi with less than 4GB RAM) instead of graying it out.

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
---
 Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr
index d5615d7af0c5..e122b5b9ff5c 100644
--- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr
+++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr
@@ -155,7 +155,7 @@ formset
         title  = STRING_TOKEN(STR_ADVANCED_FORM_TITLE);
         subtitle text = STRING_TOKEN(STR_NULL_STRING);
 
-        grayoutif ideqval RamMoreThan3GB.Supported == 0;
+        suppressif ideqval RamMoreThan3GB.Supported == 0;
           oneof varid = RamLimitTo3GB.Enabled,
               prompt      = STRING_TOKEN(STR_ADVANCED_3GB_PROMPT),
               help        = STRING_TOKEN(STR_ADVANCED_3GB_HELP),
-- 
2.17.1

Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Hide RamMoreThan3GB setting

[Andrei Warkentin]

[-- Attachment #1: Type: text/plain, Size: 1759 bytes --]

Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>

Hiding is a good idea.

A


________________________________
From: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Sent: Wednesday, June 17, 2020 1:32 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>; Pete Batard <pete@akeo.ie>; Andrei Warkentin <awarkentin@vmware.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Hide RamMoreThan3GB setting

Hide the RamMoreThan3GB HII seting when the feature is not support
(i.e. on RPi with less than 4GB RAM) instead of graying it out.

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
---
 Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr
index d5615d7af0c5..e122b5b9ff5c 100644
--- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr
+++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr
@@ -155,7 +155,7 @@ formset
         title  = STRING_TOKEN(STR_ADVANCED_FORM_TITLE);
         subtitle text = STRING_TOKEN(STR_NULL_STRING);

-        grayoutif ideqval RamMoreThan3GB.Supported == 0;
+        suppressif ideqval RamMoreThan3GB.Supported == 0;
           oneof varid = RamLimitTo3GB.Enabled,
               prompt      = STRING_TOKEN(STR_ADVANCED_3GB_PROMPT),
               help        = STRING_TOKEN(STR_ADVANCED_3GB_HELP),
--
2.17.1


[-- Attachment #2: Type: text/html, Size: 4139 bytes --]