From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.65]) by mx.groups.io with SMTP id smtpd.web12.15259.1589213211253799346 for ; Mon, 11 May 2020 09:06:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=juaP2Bux; spf=pass (domain: vmware.com, ip: 40.107.244.65, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O17Qu28Fs3Uir82WlpqT1OrvePje5hSPgZ4bqtUtlrCet61Ri8veMIUGTFmn+DvnNcttQQsw33J6Da6JkKtnIFdmvpMMMqkAymQamx5sX8/66kJ1f3SBZIh8waKEcqvpBN9o6dgmWZAhLwQOtKlIno5oH7GzJ4atEC0suUT6/KqXwml9X9w4kFJxmjkOD7AMCxcqhMfOpelIo9mjszduNhp6i8dA/bhrkSdKpHiiAstqa0Rp54/vdERzZK1Or7x1wWWn/dHdAJ5z/e4w2nhGLjqQ6zecy9q6WWypTtj9jFH7YLgU8qxOEhNDrfwrM8jSkMoHrcIbOIoV/UVCsuZIoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3iyMhT43zKdkNvqAQNKcFdZW2otuVSpzZq689/PLgIw=; b=PRhI7Motd9WzsHG5jpJhIiBA/vBc9CnYOrxXEPAYLafo19z0ncoHBcNUmvuwHBdE26Goh3AVHRWm7hWQRwTxh/+j3YfEKkxx16b9blYvbT4c72HR+xqXVguSEFAIiC/5+6RgMyROyULfve/D0lBVf5qLHFF2Wx5oN+NKuFiq9qrLti6sG2Q/Iadj4/PYnomgV1LYQM59W/wNidmRV/oJ7zVFDE7J5pyxos21DXifLOtFvIHzqmCaEFTURUGRxXeUC/6eLak0m8b/4W4DWj9m/2UVHgpPCq4ZbuZK2PXaUCcQMR904UBgvly+zSEXkoqVO681d9ERZEoj9p3p1bSHfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3iyMhT43zKdkNvqAQNKcFdZW2otuVSpzZq689/PLgIw=; b=juaP2Buxp0gIvhQW16s+0zLBB8dhVu8g05xqhMEU8m4XQfSjhVcR9Syd5/HKcSuka3XD2T2EbSOXsoKc0QCul8QjHUNWjFpa/qREpV5FH9KxeD2gVEAkBWtdEeUHbZDY8hcxPcO46NdQaj1LK/f2kLpw0Wo4kKZHYlxJx8N25m4= Received: from BN6PR05MB3411.namprd05.prod.outlook.com (2603:10b6:405:43::23) by BN6PR05MB3299.namprd05.prod.outlook.com (2603:10b6:405:45::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.14; Mon, 11 May 2020 16:06:47 +0000 Received: from BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::f463:db64:43d8:5a0f]) by BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::f463:db64:43d8:5a0f%3]) with mapi id 15.20.3000.016; Mon, 11 May 2020 16:06:47 +0000 From: "Andrei Warkentin" To: Ard Biesheuvel , "devel@edk2.groups.io" CC: Pete Batard , Jared McNeill , Samer El-Haj-Mahmoud , Jeremy Linton Subject: Re: [PATCH edk2-platforms v4 9/9] Platform/RaspberryPi4: remove ASIX 88772b driver Thread-Topic: [PATCH edk2-platforms v4 9/9] Platform/RaspberryPi4: remove ASIX 88772b driver Thread-Index: AQHWJ6RIvwomtWe+Sk6tKzM5ZiQfz6ijDOG4 Date: Mon, 11 May 2020 16:06:47 +0000 Message-ID: References: <20200511145527.23453-1-ard.biesheuvel@arm.com>,<20200511145527.23453-10-ard.biesheuvel@arm.com> In-Reply-To: <20200511145527.23453-10-ard.biesheuvel@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=vmware.com; x-originating-ip: [98.214.99.181] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 47ff438b-a561-4355-2fc3-08d7f5c54f00 x-ms-traffictypediagnostic: BN6PR05MB3299: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1201; x-forefront-prvs: 04004D94E2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /WZpccY58+abWnud4utrjI5HdO43EzliSUvbFAkl5Iu1Z/oyZ3IokRFSkYbt3SwGyiDPHfg8hNQpCPbt33pI37QGIq+Vk1HNStfzyPB5hW1avp+z0ziRxwACM/Z6gJjlxxrLDDF4dRajwN4B3EsfRBCYs8admw1HLG2ugQkKGhcbxRi5qBooiOdZf1vrvf9rV8oG6NJtJKUOefCaPdVgYbYPPbAH13us0oKMJ8K8cDcsIDO8e8uSC3UJd3KEN9lmfOlLqyxPc22PpKDS9g/VmCgd6iTk5/cd+rFyY0LCJXOMSHpX4DWDWIPGR7fqx9wX6TeXuOA6tLFSg22WyWCB+wcN8TM3kPTtdLmJ3bcrI3DQy8vvrMWiuA9NuyPTKf7xipJs7eRyonKvzi/S/YjANCHvuMAX90xA3QOBIgWZJGof5Trikc3PYzWMaQ7eJBnMyiS93LxMFFqJ75XxEtao59pDtObso9vJlYsIcSpOqHtUT2fzFKrdFJ5zpoRWeZEFiSQyFA6F10c+PeI2S6UH7w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR05MB3411.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(396003)(366004)(346002)(39860400002)(376002)(33430700001)(316002)(53546011)(110136005)(52536014)(2906002)(71200400001)(19627235002)(4326008)(54906003)(26005)(55016002)(7696005)(9686003)(66476007)(66446008)(64756008)(8676002)(66556008)(86362001)(66946007)(6506007)(5660300002)(8936002)(76116006)(186003)(33656002)(33440700001)(478600001)(19627405001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: ctH/TF6dP3iHm/n9SRR0ul6sV2YDxY96lSQ70nGDCNSgLQuy0M41qI+yQtIJd4BlfJAWIdMg+mwxEsG512KEdk+4SqO8XzxIm92nFGub5mMMZ3v7xittCaxrl+fb6yjA/ibJaHx9yiYnfgazOBg4yrOludWEVu1jRWECY5Dqp2JzzVHlHSFpBPbD/6B7Gr59RE8l+ds9JYPi6G6f799JAHPSQr1Rbv9GX0ZaGzGglTV6EJ6MSZwW/4SsZlwelfYHhVGXB06BMud5wLGVQAs83ZJduVdleK6JtvP2vUGjgahl+AfvnpSezEhdj8jfgmWwMzUI3dot7yoKLJ6EXFQJqNiSENyrIwhaNDXjB4riGGsIvx1YBcBN6RUWcLJmkGgrLSwsZOkyNU0na4K7LYXZtw7JCEqt9pc700D4CfQXHOJIX6PHV9wIx9kcjZ7HdZnBdKf/BkvdY3+xOdgGlDA+WEMCTrtWJ6XrcvXq1PbnP2Y= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47ff438b-a561-4355-2fc3-08d7f5c54f00 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2020 16:06:47.8229 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eaBr30ecyOJAgvjL/xWvuvWN3xbOlmeaq/UaWjcywXQkB9iYvXMWZw3ckRCohmz0OMzCmKVxWWqS3Pu6aqGGVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR05MB3299 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BN6PR05MB3411359E8564ABF841EBEECEB9A10BN6PR05MB3411namp_" --_000_BN6PR05MB3411359E8564ABF841EBEECEB9A10BN6PR05MB3411namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable LGTM Reviewed-by: Andrei Warkentin ________________________________ From: Ard Biesheuvel Sent: Monday, May 11, 2020 9:55 AM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Pete Batard ; Ja= red McNeill ; Andrei Warkentin ; Samer El-Haj-Mahmoud ; Jeremy Linton Subject: [PATCH edk2-platforms v4 9/9] Platform/RaspberryPi4: remove ASIX 8= 8772b driver The Raspberry Pi4 has gigabit ethernet builtin, for which we now have a UEFI driver. So no need for the ASIX 88772b driver. Signed-off-by: Ard Biesheuvel --- Platform/RaspberryPi/RPi4/RPi4.dsc | 1 - Platform/RaspberryPi/RPi4/RPi4.fdf | 1 - 2 files changed, 2 deletions(-) diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4= /RPi4.dsc index 5910082deb04..cbff9d9946e2 100644 --- a/Platform/RaspberryPi/RPi4/RPi4.dsc +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc @@ -669,7 +669,6 @@ [Components.common] MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf - Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf # # SD/MMC support diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf b/Platform/RaspberryPi/RPi4= /RPi4.fdf index b1f7aa2387df..1e13909a57ba 100644 --- a/Platform/RaspberryPi/RPi4/RPi4.fdf +++ b/Platform/RaspberryPi/RPi4/RPi4.fdf @@ -293,7 +293,6 @@ [FV.FvMain] INF MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf INF MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf - INF Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf # # SD/MMC support -- 2.17.1 --_000_BN6PR05MB3411359E8564ABF841EBEECEB9A10BN6PR05MB3411namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
LGTM

Reviewed-by: Andrei Warkentin <andrey.warkentin@gmail.com>

From: Ard Biesheuvel <ar= d.biesheuvel@arm.com>
Sent: Monday, May 11, 2020 9:55 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>; Pete Batard <p= ete@akeo.ie>; Jared McNeill <jmcneill@invisible.ca>; Andrei Warken= tin <awarkentin@vmware.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Ma= hmoud@arm.com>; Jeremy Linton <jeremy.linton@arm.com>
Subject: [PATCH edk2-platforms v4 9/9] Platform/RaspberryPi4: remove= ASIX 88772b driver
 
The Raspberry Pi4 has gigabit ethernet builtin, fo= r which we now
have a UEFI driver. So no need for the ASIX 88772b driver.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
 Platform/RaspberryPi/RPi4/RPi4.dsc | 1 -
 Platform/RaspberryPi/RPi4/RPi4.fdf | 1 -
 2 files changed, 2 deletions(-)

diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4= /RPi4.dsc
index 5910082deb04..cbff9d9946e2 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -669,7 +669,6 @@ [Components.common]
   MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf
   MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
   MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf -  Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf  
   #
   # SD/MMC support
diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf b/Platform/RaspberryPi/RPi4= /RPi4.fdf
index b1f7aa2387df..1e13909a57ba 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.fdf
+++ b/Platform/RaspberryPi/RPi4/RPi4.fdf
@@ -293,7 +293,6 @@ [FV.FvMain]
   INF MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf
   INF MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
   INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.i= nf
-  INF Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.in= f
 
   #
   # SD/MMC support
--
2.17.1

--_000_BN6PR05MB3411359E8564ABF841EBEECEB9A10BN6PR05MB3411namp_--