From: "Andrei Warkentin" <awarkentin@vmware.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Andrei Warkentin" <andrey.warkentin@gmail.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Bret Barkelew" <brbarkel@microsoft.com>,
"Dandan Bi" <dandan.bi@intel.com>,
"Jian J Wang" <jian.j.wang@intel.com>,
"pete@akeo.ie" <pete@akeo.ie>
Cc: "ard.biesheuvel@arm.com" <ard.biesheuvel@arm.com>,
"leif@nuviainc.com" <leif@nuviainc.com>,
Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again.
Date: Thu, 19 Nov 2020 19:53:08 +0000 [thread overview]
Message-ID: <BN6PR05MB3411405A80F39D24E9DD04F7B9E00@BN6PR05MB3411.namprd05.prod.outlook.com> (raw)
In-Reply-To: <634feced-94f9-d61d-99f9-13451a1d1507@akeo.ie>
[-- Attachment #1: Type: text/plain, Size: 5053 bytes --]
Sorry, folks, is there anything actionable for me here to do?
It does appear that all the other edk2-platforms are broken/affected as well.
A
________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Pete Batard via groups.io <pete=akeo.ie@groups.io>
Sent: Thursday, November 19, 2020 11:33 AM
To: Philippe Mathieu-Daudé <philmd@redhat.com>; Andrei Warkentin <andrey.warkentin@gmail.com>; devel@edk2.groups.io <devel@edk2.groups.io>; Bret Barkelew <brbarkel@microsoft.com>; Dandan Bi <dandan.bi@intel.com>; Jian J Wang <jian.j.wang@intel.com>
Cc: ard.biesheuvel@arm.com <ard.biesheuvel@arm.com>; leif@nuviainc.com <leif@nuviainc.com>; Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again.
Hi Philippe,
On 2020.11.19 17:28, Philippe Mathieu-Daudé wrote:
> On 11/19/20 6:14 PM, Pete Batard wrote:
>> For reference, this breakage was introduced with edk2 commit
>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fcommit%2Fb6490426e3208de7d6cbd756276a02e4329cd85a&data=04%7C01%7Cawarkentin%40vmware.com%7C912c541f65924d5c6a6108d88cb139b8%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637414040092341605%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=K%2Fe45o3ZvD29UaHNFzCKLBMil8lJ1adSB2mRiC0uVy0%3D&reserved=0
>> (MdeModulePkg: Connect VariablePolicy business logic to VariableServices).
>
> It is better if Andrei Cc the developers involved (Cc'ed them now).
Good point.
>
>>
>> It'll probably be worth adding a reference to it in the commit message
>> during integration.
>
> This can be added before the S-o-b:
>
> Fixes: b6490426e320 ("MdeModulePkg: Connect VariablePolicy business
> logic to VariableServices")
Just going to nitpick that since we're patching in edk2-platforms and
referencing an edk2 commit, we'll want:
Fixes: tianocore/edk2@b6490426e320 ("MdeModulePkg: Connect
VariablePolicy business logic to VariableServices")
For GitHub to produce a clickable link.
Regards,
/Pete
>
>>
>> With this:
>>
>> On 2020.11.19 00:01, Andrei Warkentin wrote:
>>> Add VariablePolicyLib and its dependency.
>>>
>>> Testing: Pi 4 boot.
>>>
>>> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
>>> ---
>>> Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +++
>>> Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++
>>> 2 files changed, 6 insertions(+)
>>>
>>> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc
>>> b/Platform/RaspberryPi/RPi3/RPi3.dsc
>>> index 325d7bdb..9408138d 100644
>>> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
>>> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
>>> @@ -169,6 +169,8 @@
>>>
>>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>>>
>>> !endif
>>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>>> +
>>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
>>>
>>> +
>>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>>>
>>> GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf
>>> [LibraryClasses.common.SEC]
>>> @@ -218,6 +220,7 @@
>>>
>>> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
>>> EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf
>>> ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf
>>> +
>>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
>>>
>>> !if $(SECURE_BOOT_ENABLE) == TRUE
>>> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
>>> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc
>>> b/Platform/RaspberryPi/RPi4/RPi4.dsc
>>> index c994f56d..4e5a36ed 100644
>>> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
>>> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
>>> @@ -169,6 +169,8 @@
>>>
>>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>>>
>>> !endif
>>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>>> +
>>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
>>>
>>> +
>>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>>>
>>> GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf
>>> #
>>> @@ -226,6 +228,7 @@
>>>
>>> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
>>> EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf
>>> ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf
>>> +
>>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
>>>
>>> !if $(SECURE_BOOT_ENABLE) == TRUE
>>> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
>>>
>>
>> Reviewed-by: Pete Batard <pete@akeo.ie>
>>
>
[-- Attachment #2: Type: text/html, Size: 8403 bytes --]
next prev parent reply other threads:[~2020-11-19 19:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 0:01 [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again Andrei Warkentin
2020-11-19 17:14 ` Pete Batard
2020-11-19 17:28 ` Philippe Mathieu-Daudé
2020-11-19 17:33 ` Pete Batard
2020-11-19 19:53 ` Andrei Warkentin [this message]
2020-11-20 7:20 ` 回复: [edk2-devel] " gaoliming
2020-11-20 15:09 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR05MB3411405A80F39D24E9DD04F7B9E00@BN6PR05MB3411.namprd05.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox