From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.82]) by mx.groups.io with SMTP id smtpd.web12.2133.1592463538797253228 for ; Wed, 17 Jun 2020 23:58:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=vTMlaCqS; spf=pass (domain: vmware.com, ip: 40.107.93.82, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nGVhaWyI76sZ6TyFTAz7OwsB0nvQK7awbdBZTSIEmJkxVVMCkatPVUblt6Gr1/oiMmhXXZTpK+vCgUhiNa2deQm5fBhH8uy7JO5TeIbJxyUW81QxaEyJYOTyVtuSM242ge80hze9ZBnb9EvIRuuVLhrBPPCx9tyECeBBB6eneDnJSiU+zEXTuyh9r9leX85BBJ9tei7XOM2gRfOxYTzmCB1SyLvYXkkcowixz5eByWqV8OfIp9XgZw9t+9mYXs0rRxKlJ3agQXdObC+cAivAD8nBnEOEM9Tra6QwUrvChvW1LRoxVUYbHbp89nYh0X9AwMEzWeYF2abwwYovLWmgdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gBmcJmgbu2Gopxu4WVWWTKmKd25E8g7PMPQQ7MXSxG0=; b=n/wvdCfbMqCrSlqeD88gtmswDjrDir8ur3oBkVtXAbVYUs1AnHUzdBUZN3GwNuvkWNUZzpGxEmYcJQDFfXKK7oHltthDFyl4Jzrt76W6qvxNRuBc6nWO08h+vVoQhCsQbW6rAI86fXqidwSDjbF7OhEdfiG6Nfwcs/0kbfyEpVzJ2pkhXfmB6dWuS2psbAnRD1CyUjaRRnz1RwBmUP9HGgROtAp9az1uToDsou3PQCpVnN9zCQ9N9RxX+OhspzVNEipyE6aLVgRMStQsw1ZTGhfxRpo8IfOvlAaJpa1tFCHZspM3tPUl15PSKVyPOpRsyeLPqlpgiYHjLR0dro2ZDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gBmcJmgbu2Gopxu4WVWWTKmKd25E8g7PMPQQ7MXSxG0=; b=vTMlaCqSsIij9nyZxJ8wmYYDl77T5eXKFxsW9S3KDeaeDq4n3UD3xrJGpz5UwQG1aUhBfNfYUC6sZwxJ/bFPozKRMzJTLv6MDyh3ZZjH7sWd27bX/ZVuPA6o5MI1iTtBJBcIxgPZBqLgc6NA2uQFnUrQGfnZwuy0YznSJA20JuE= Received: from BN6PR05MB3411.namprd05.prod.outlook.com (2603:10b6:405:43::23) by BN7PR05MB5827.namprd05.prod.outlook.com (2603:10b6:408:3d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.7; Thu, 18 Jun 2020 06:58:56 +0000 Received: from BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::e1ef:31eb:c802:aef0]) by BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::e1ef:31eb:c802:aef0%3]) with mapi id 15.20.3109.018; Thu, 18 Jun 2020 06:58:56 +0000 From: "Andrei Warkentin" To: Samer El-Haj-Mahmoud , "devel@edk2.groups.io" CC: Ard Biesheuvel , Leif Lindholm , Pete Batard Subject: Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix SMBIOS Type 9 Thread-Topic: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix SMBIOS Type 9 Thread-Index: AQHWRSdNZ6hXKEE2mUiCT2VHwOYyPKjd8WlM Date: Thu, 18 Jun 2020 06:58:56 +0000 Message-ID: References: <20200618041648.15692-1-Samer.El-Haj-Mahmoud@arm.com> In-Reply-To: <20200618041648.15692-1-Samer.El-Haj-Mahmoud@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=vmware.com; x-originating-ip: [98.214.99.181] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bc670bd0-4e47-4816-f250-08d8135511f6 x-ms-traffictypediagnostic: BN7PR05MB5827: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 0438F90F17 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9A4CjREF87B4VsfW9hlV2IuWmrMdFO2lOU4fyLO0i1ZYMUver62CyJIWNFrPywTiq1j92FD+KYA//Gxqk0mcMZJE/56C3R6lbs/+jMi3vU0BS4UZS5TAnMCQ9qW7bE5skFAo02wM3Yvb//UzBbpYbmLhjgqVqLcsV111Go6r0UFQEYKnSdtiF4aUP/8Qy1llTvY0P0B15cK1Mp5tJPHTKyLAsSbsiOPvXETPRj90+DcLUq/TI+hcw6w3Je1jlXBXRwNQrdI/qcgqJ2cSWdD57Q/c9l4/KhV3WruFOeFe8vec+x0UYxbVRaSKm7bnN/unB+nXU0kHK74zSJ5IAcsE2DACBwths3jbqzEk7tBTXNmxIWEO2XXLCYttQ+At8ctZRGI6sU6xFTgzRlr2N7/PUg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR05MB3411.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(136003)(376002)(39860400002)(346002)(396003)(4326008)(83380400001)(478600001)(5660300002)(33656002)(45080400002)(166002)(71200400001)(66946007)(76116006)(66476007)(64756008)(9686003)(55016002)(66556008)(110136005)(66446008)(86362001)(52536014)(54906003)(53546011)(19627405001)(2906002)(966005)(6506007)(8676002)(7696005)(316002)(186003)(26005)(8936002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: IY+VktBnU5WMkqaIKuom3N2HBQv7cdeIxXxkssJ+NEhU5OZGXVC6yR6wRS4bOtFkn3NzOM5bIqE7T9Fyfcya5MKJw9Lw7A+uoYOVLaKjO4Olh0M07iIIbX//awoz4E5dZuZqtAg1Xs5N3Tma3GJspSLbF1OYw9eQ7Sn4k/xGwTp4U2KNp00Yudz6AALNWBq7Jylv4xJfld4XQWUqLaZ8I/buLy7Teqhi/lqoSY+vtOKGD4t0fKm2vtc+Vf0O7cMIYRLpyCFVgyP6T8czCTVguKTbTBDPCRH0f1Aw9oLmzDwELDHA+/P8WSqoAl8xIjBCPSMd4cS1roWHX0GtoMXOJcmcdPguYuotBjQu16T7cuXlEd7vjzAllEm8sl/3jyMQbz/z20zGPTzIdvLMcYc2XpbK6t7UmLp65K7mR3brV2nP+nup5teGmETg+KYXTxeiUD2+Hg65kFzIe9lyzt5t9B6uc3tdLvd+Y2OP0JSB9Da3MiaZ5hd3QcRGs7M6t9Lh x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc670bd0-4e47-4816-f250-08d8135511f6 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2020 06:58:56.5910 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IneEOF5aK+6wLaNVB8GpuIkSB2I7+IAO/fVWX9GeUnE0emSJZ5lJg/C81dkJW/bQ1rSz8zCEWby7oQoPM3omaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR05MB5827 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BN6PR05MB3411624702E25F46809F51BBB99B0BN6PR05MB3411namp_" --_000_BN6PR05MB3411624702E25F46809F51BBB99B0BN6PR05MB3411namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Andrei Warkentin A ________________________________ From: Samer El-Haj-Mahmoud Sent: Wednesday, June 17, 2020 11:16 PM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Leif Lindholm ; Andrei Warkentin ; Pete Batard Subject: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix SMBIOS Ty= pe 9 FWTS reports an error with SMBIOS Type 9 Segment-Bus-DevFunc fields. The SMBIOS specification requires that for non-PCIe slot devices to have these fields reported as 0xFFFFF-0xFF-xFF. Instead, they were being reported as 0x0000-0x00-0x00. This fixes the FWTS SMBIOS Type 9 failure reported here: https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.= com%2Fpftf%2FRPi4%2Fissues%2F75&data=3D02%7C01%7Cawarkentin%40vmware.co= m%7C12c3f18cf4c542508b1008d8133e6ec5%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0= %7C1%7C637280506159613646&sdata=3DSOdVyajdUz021jZ9PrJMTSw%2B3zef8FR88WM= Rp6Xckio%3D&reserved=3D0 Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Andrei Warkentin Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 6 +++= --- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosD= xe.c b/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c index 7b86e76a1248..78bdda18eb2d 100644 --- a/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c +++ b/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c @@ -380,9 +380,9 @@ SMBIOS_TABLE_TYPE9 mSysSlotInfoType9 =3D { 0, // SmbusSignalSupported :1; 0, // Reserved :5; ///< Set to 0. }, - 0, // SegmentGroupNum; - 0, // BusNum; - 0, // DevFuncNum; + 0xFFFF, // SegmentGroupNum; + 0xFF, // BusNum; + 0xFF, // DevFuncNum; }; CHAR8 *mSysSlotInfoType9Strings[] =3D { "SD Card", -- 2.17.1 --_000_BN6PR05MB3411624702E25F46809F51BBB99B0BN6PR05MB3411namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>

A
From: Samer El-Haj-Mahmoud = <Samer.El-Haj-Mahmoud@arm.com>
Sent: Wednesday, June 17, 2020 11:16 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>; Leif Lindholm <= ;leif@nuviainc.com>; Andrei Warkentin <awarkentin@vmware.com>; Pet= e Batard <pete@akeo.ie>
Subject: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix SM= BIOS Type 9
 
FWTS reports an error with SMBIOS Type 9 Segment-B= us-DevFunc fields.
The SMBIOS specification requires that for non-PCIe slot devices to have these fields reported as 0xFFFFF-0xFF-xFF. Instead, they were being
reported as 0x0000-0x00-0x00.

This fixes the FWTS SMBIOS Type 9 failure reported here:
https://nam04.safelink= s.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.com%2Fpftf%2FRPi4%2Fis= sues%2F75&amp;data=3D02%7C01%7Cawarkentin%40vmware.com%7C12c3f18cf4c542= 508b1008d8133e6ec5%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C63728050615= 9613646&amp;sdata=3DSOdVyajdUz021jZ9PrJMTSw%2B3zef8FR88WMRp6Xckio%3D&am= p;amp;reserved=3D0

Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Cc: Pete Batard <pete@akeo.ie>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com> ---
 Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | = 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosD= xe.c b/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c index 7b86e76a1248..78bdda18eb2d 100644
--- a/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c +++ b/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSm= biosDxe.c
@@ -380,9 +380,9 @@ SMBIOS_TABLE_TYPE9  mSysSlotInfoType9 =3D {      0,  // SmbusSignalSupported   = :1;
     0,  // Reserved     =            :5;  ///&= lt; Set to 0.
   },
-  0,    // SegmentGroupNum;
-  0,    // BusNum;
-  0,    // DevFuncNum;
+  0xFFFF, // SegmentGroupNum;
+  0xFF,   // BusNum;
+  0xFF,   // DevFuncNum;
 };
 CHAR8 *mSysSlotInfoType9Strings[] =3D {
   "SD Card",
--
2.17.1

--_000_BN6PR05MB3411624702E25F46809F51BBB99B0BN6PR05MB3411namp_--