From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.45]) by mx.groups.io with SMTP id smtpd.web10.14643.1586881440482631198 for ; Tue, 14 Apr 2020 09:24:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=lJABxbZe; spf=pass (domain: vmware.com, ip: 40.107.236.45, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XxMdjMSu5o+kPJn2LoviUeiTT8xqA16uj67zIp4qXBxAsheBAuY90KbQfa7JgE9mbZ5Su0fTbpNr1fGkcG1KEc95Ug6rVsQWVzRI1m0epjbj0GFtcFmWfbnKdWpMjew6ydMtpdbjEJpfSTu/TNfcUBVB40gd4Fq+vs61zsRObA8ztTwW1qW/zwMsUj7SgoMD0N3djduBvtwkJ7274/RkkiUMjFjhzupcMmoT6rOQYQFcdz/cpAlROklRMr80BDkvEQCXe6Xd9plKqXS6EetI/y5KlWWRUJRtDTuamjpcC0gb5ABf+aPvonccn+VC9Z4EhlBh5/HI58qzWMktmhdpKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vOxZeje5AuRyB1YgSuHoheeNzMCBGSinGlcNGyn6P9o=; b=VQiV7K0mVxWbqNxm8AIB0C96L4TqjSNDNwjjBd3xYk8M1rixpCiFne/kC9pjvo4MuqV7gXAREULEhOULCun9TlFaKynR3ejYaRg0GLtinst49sCJyhFZV6fUzxjmBfOfCO+7ZOBgQC8JFpQ4dNe8YH7ta+mJXezd6kfg+LQOtWg0mZfXYxqdQDmhEokcdRirO30djEb/v22vgx8OckPcRrKS6Mwa5MfRt6TSJ0LttI3r4G8Nl3BuM1wxD6IAd8XUK/cISUj0YZO1ye82Qf9JVdFy7F2NR4xFOpK1jAo07lAUeABbRQGxLU4KmetDQAM29VGc0Uk+FDatFHtGInlSxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vOxZeje5AuRyB1YgSuHoheeNzMCBGSinGlcNGyn6P9o=; b=lJABxbZeq8hqBKFgBAP59iFYo4gqjbDxia7ZHZtharnrgB0SbNvHMEmrjThh1dRUDQv7rkRQ5OyYAdXnia/PXI/UiA7gpAPy2Y0iQnDLQwpwSBCbbVHXrtOor6YcVgDs0sp45ufmjriLBA2xPOFWbfXT+RXplOtn0xU2HHCiSac= Received: from BN6PR05MB3411.namprd05.prod.outlook.com (2603:10b6:405:43::23) by BN6PR05MB2849.namprd05.prod.outlook.com (2603:10b6:404:2c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.21; Tue, 14 Apr 2020 16:23:56 +0000 Received: from BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::5df3:40e3:521a:7f84]) by BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::5df3:40e3:521a:7f84%5]) with mapi id 15.20.2921.024; Tue, 14 Apr 2020 16:23:56 +0000 From: "Andrei Warkentin" To: Samer El-Haj-Mahmoud , "devel@edk2.groups.io" CC: Leif Lindholm , Ard Biesheuvel , Pete Batard Subject: Re: [edk2-platform][PATCH v2 0/3] Platform/RaspberryPi : Switch to common GraphicsConsoleDxe Thread-Topic: [edk2-platform][PATCH v2 0/3] Platform/RaspberryPi : Switch to common GraphicsConsoleDxe Thread-Index: AQHWEnOHGWI7lPlhN0yB0tTfs79lgKh4y/fy Date: Tue, 14 Apr 2020 16:23:56 +0000 Message-ID: References: <20200414154358.5161-1-samer@elhajmahmoud.com> In-Reply-To: <20200414154358.5161-1-samer@elhajmahmoud.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=awarkentin@vmware.com; x-originating-ip: [98.214.99.181] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 788dab91-cb42-4e4f-81d2-08d7e0903ad5 x-ms-traffictypediagnostic: BN6PR05MB2849: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 0373D94D15 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR05MB3411.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(376002)(396003)(366004)(39860400002)(346002)(136003)(966005)(7696005)(33656002)(186003)(66556008)(478600001)(54906003)(316002)(66446008)(66476007)(110136005)(64756008)(66946007)(53546011)(5660300002)(6506007)(76116006)(45080400002)(9686003)(19627405001)(71200400001)(66574012)(52536014)(55016002)(86362001)(26005)(8936002)(4326008)(8676002)(2906002)(81156014);DIR:OUT;SFP:1101; received-spf: None (protection.outlook.com: vmware.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SMJ7TFrzMF6yUmL7PcGo9brsYnhQqEXdGTqXvDk5ZJfQseqSZuiggRLEjEI14Mto0nCqropaxHb9IRkj01B2PoWQA7DuN8hGXZaxpLB56lcsk7Js42mJTWmAVyjJIUDMlGbWPUUnaNHt4bMdACLegIo/cCyTLMYmLjVY3aVlHB1Rd5uZ013lvhWaX9QRwKLpUXetDkBKjG8AIYkBQAi18h16eRVUAvYW3mRIT3rZDuT4WSI+qXo6J1GUeM3Q1CMSEfxaxaaUFfM9z+ecuKVXHB1rtveOg6yR+D4CVvxD80InUDCQ4rgXUuGzpBZ0kTxQNOFMkuis/bKUpocD5znKdbqsdrs+sMRtzdLYHAF23beWVzQbhPvOwqy/F/WBDIxGdQDPM0gwmCj4B8+IMxG+UC8K+0wYciKL7oef3Tg4ihJxP3JPo4A2xVhXNHYvZ0kD7zd0KLDqPz8405h0AuCVye1K3vrnA+6CgdF2vOw18XOcg5PLsXp8q/RjcSpIrilpR90IU0uxUxIT5bw2t2ZDFQ== x-ms-exchange-antispam-messagedata: N+9ZkISULLAflvizJZrgJ8UWN53S573yXaPthMvFspt0Iaa/IJTlN1pkRUaMc3mYI6FzIY33yxR8gzbxibcfRS1gjILAj4K1sNrNNhaUT10OQMX1TpttpoktFxTuZsMoOUey6xtn5hIUG2RPMbgq2Q== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-Network-Message-Id: 788dab91-cb42-4e4f-81d2-08d7e0903ad5 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2020 16:23:56.1568 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qkIAZ1r4S/aMungUnY77NfoNaeN8GH6LEInr0LPFsMYHRG17l+n9j0tW1ZNqfuOk9ZV4D04RJBXHDUlCLnp0Cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR05MB2849 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BN6PR05MB34117C33FED5B5D4F14A214FB9DA0BN6PR05MB3411namp_" --_000_BN6PR05MB34117C33FED5B5D4F14A214FB9DA0BN6PR05MB3411namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Andrei Warkentin Looks good to me - there's little reason for using a custom GraphicsConsole= Dxe now (historically, the screenshot facility lived there, there's a priva= te interface there for messing with terminal scrolling (unused) and I moved= to a different font with my box drawing chars, but the font issue can/need= s to be tackled in a different way that Tiano already supports). A ________________________________ From: Samer El-Haj-Mahmoud Sent: Tuesday, April 14, 2020 10:43 AM To: devel@edk2.groups.io Cc: Leif Lindholm ; Ard Biesheuvel ; Pete Batard ; Andrei Warkentin Subject: [edk2-platform][PATCH v2 0/3] Platform/RaspberryPi : Switch to com= mon GraphicsConsoleDxe Switch RaspberryPi from using a private GraphicsConsoleDxe to the common Gr= aphicsConsoleDxe in MdeModulePkg. Code pushed to https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%= 3A%2F%2Fgithub.com%2Fsamerhaj%2Fedk2-platforms%2Ftree%2Frpi_switch_graphics= console_v2&data=3D02%7C01%7Cawarkentin%40vmware.com%7C8f89ce43af3343c32= 3e508d7e08aa7e2%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C63722475844820= 8191&sdata=3D1%2BAuUTypo9r95E0zrVTEhc7NIQADBd0x8iWCH4OdM%2FQ%3D&res= erved=3D0 version 1: https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2= F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F57256&data=3D02%7C01%7Cawark= entin%40vmware.com%7C8f89ce43af3343c323e508d7e08aa7e2%7Cb39138ca3cee4b4aa4d= 6cd83d9dd62f0%7C0%7C1%7C637224758448208191&sdata=3DwGKJZNRhtcnU6UVJHTws= M92sTrPtFqzPh0likpNpC%2Bc%3D&reserved=3D0 version 2 changes: - Set PcdUgaConsumeSupport to FALSE [Ard] Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Samer El-Haj-Mahmoud (3): Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe Platform/RaspberryPi/RPi3: Switch to common GraphicsConsoleDxe Platform/RaspberryPi:Remove RPi GraphicsConsoleDxe Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +- Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +- Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +- Platform/RaspberryPi/RPi4/RPi4.fdf | 2 +- .../GraphicsConsoleDxe/GraphicsConsoleDxe.inf | 68 - .../GraphicsConsoleDxe/GraphicsConsole.h | 585 ------ .../GraphicsConsoleDxe/ComponentName.c | 177 -- .../GraphicsConsoleDxe/GraphicsConsole.c | 1831 ----------------- .../Drivers/GraphicsConsoleDxe/NewFont.c | 281 --- .../GraphicsConsoleDxe/GraphicsConsoleDxe.uni | 12 - .../GraphicsConsoleDxeExtra.uni | 12 - 11 files changed, 6 insertions(+), 2970 deletions(-) delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/Graphic= sConsoleDxe.inf delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/Graphic= sConsole.h delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/Compone= ntName.c delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/Graphic= sConsole.c delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/NewFont= .c delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/Graphic= sConsoleDxe.uni delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/Graphic= sConsoleDxeExtra.uni -- 2.17.1 --_000_BN6PR05MB34117C33FED5B5D4F14A214FB9DA0BN6PR05MB3411namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Andrei Warkentin <andrey.warkentin@gmail.com>

Looks good to me - there's little reason for using a custom GraphicsCo= nsoleDxe now (historically, the screenshot facility lived there, there's a = private interface there for messing with terminal scrolling (unused) and I = moved to a different font with my box drawing chars, but the font issue can/needs to be tackled in a differe= nt way that Tiano already supports).

A
From: Samer El-Haj-Mahmoud = <samer@elhajmahmoud.com>
Sent: Tuesday, April 14, 2020 10:43 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ard.= biesheuvel@arm.com>; Pete Batard <pete@akeo.ie>; Andrei Warkentin = <awarkentin@vmware.com>
Subject: [edk2-platform][PATCH v2 0/3] Platform/RaspberryPi : Switch= to common GraphicsConsoleDxe
 
Switch RaspberryPi from using a private GraphicsCo= nsoleDxe to the common GraphicsConsoleDxe in MdeModulePkg.

Code pushed to https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.= com%2Fsamerhaj%2Fedk2-platforms%2Ftree%2Frpi_switch_graphicsconsole_v2&= amp;data=3D02%7C01%7Cawarkentin%40vmware.com%7C8f89ce43af3343c323e508d7e08a= a7e2%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637224758448208191&am= p;sdata=3D1%2BAuUTypo9r95E0zrVTEhc7NIQADBd0x8iWCH4OdM%2FQ%3D&amp;reserv= ed=3D0

version 1: https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2.gr= oups.io%2Fg%2Fdevel%2Fmessage%2F57256&amp;data=3D02%7C01%7Cawarkentin%4= 0vmware.com%7C8f89ce43af3343c323e508d7e08aa7e2%7Cb39138ca3cee4b4aa4d6cd83d9= dd62f0%7C0%7C1%7C637224758448208191&amp;sdata=3DwGKJZNRhtcnU6UVJHTwsM92= sTrPtFqzPh0likpNpC%2Bc%3D&amp;reserved=3D0
version 2 changes:
 - Set PcdUgaConsumeSupport to FALSE [Ard]

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>

Samer El-Haj-Mahmoud (3):
  Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe
  Platform/RaspberryPi/RPi3: Switch to common GraphicsConsoleDxe
  Platform/RaspberryPi:Remove RPi GraphicsConsoleDxe

 Platform/RaspberryPi/RPi3/RPi3.dsc      = ;      |    3 +-
 Platform/RaspberryPi/RPi4/RPi4.dsc      = ;      |    3 +-
 Platform/RaspberryPi/RPi3/RPi3.fdf      = ;      |    2 +-
 Platform/RaspberryPi/RPi4/RPi4.fdf      = ;      |    2 +-
 .../GraphicsConsoleDxe/GraphicsConsoleDxe.inf |   68 -
 .../GraphicsConsoleDxe/GraphicsConsole.h     = ; |  585 ------
 .../GraphicsConsoleDxe/ComponentName.c     &= nbsp;  |  177 --
 .../GraphicsConsoleDxe/GraphicsConsole.c     = ; | 1831 -----------------
 .../Drivers/GraphicsConsoleDxe/NewFont.c     = ; |  281 ---
 .../GraphicsConsoleDxe/GraphicsConsoleDxe.uni |   12 -
 .../GraphicsConsoleDxeExtra.uni      &n= bsp;        |   12 -
 11 files changed, 6 insertions(+), 2970 deletions(-)
 delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/Gr= aphicsConsoleDxe.inf
 delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/Gr= aphicsConsole.h
 delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/Co= mponentName.c
 delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/Gr= aphicsConsole.c
 delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/Ne= wFont.c
 delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/Gr= aphicsConsoleDxe.uni
 delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/Gr= aphicsConsoleDxeExtra.uni

--
2.17.1

--_000_BN6PR05MB34117C33FED5B5D4F14A214FB9DA0BN6PR05MB3411namp_--