Reviewed-by: Andrei Warkentin <andrey.warkentin@gmail.com>
________________________________
From: Pete Batard <pete@akeo.ie>
Sent: Wednesday, August 26, 2020 6:23 PM
To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>; Andrei Warkentin <awarkentin@vmware.com>
Subject: Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build error in DisplayDxe

On 2020.08.27 00:20, Samer El-Haj-Mahmoud wrote:
> Commit 0c2af04985f0bf152ac3edc70d9c6d9fe884cdcb added mDriverBinding
> extern module global, but did not remove the STATIC declaration, which
> caused the build to break. Fix the build error by removing STATIC for
> that module global variable.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Pete Batard <pete@akeo.ie>
> Cc: Andrei Warkentin <awarkentin@vmware.com>
> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> ---
>   Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
> index ae4b2735820c..3eba98e5aa87 100644
> --- a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
> +++ b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
> @@ -87,7 +87,7 @@ DisplayBlt (
>     IN  UINTN                                   Delta         OPTIONAL
>     );
>
> -STATIC EFI_DRIVER_BINDING_PROTOCOL mDriverBinding = {
> +EFI_DRIVER_BINDING_PROTOCOL mDriverBinding = {
>     DriverSupported,
>     DriverStart,
>     DriverStop,
>

Reviewed-by: Pete Batard <pete@akeo.ie>