From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.57]) by mx.groups.io with SMTP id smtpd.web11.12444.1598506077570051366 for ; Wed, 26 Aug 2020 22:27:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=L7dXUWdg; spf=pass (domain: vmware.com, ip: 40.107.237.57, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fGSIQwXSXVE7hq00hhqMf79yAXAZNeSroli6KH0ogDBY5q/tftwv+Sg83CN8SwXEjpp7vzBihax7pkeb/4feSp0iXuJED5cZVOKCrzec9x6I7WNFwDe2uISTyAimLBZqUX20KegLe47vh+CQKCnHFREHOj+3j5icCD2/mCDzNorGZEhNLRDLHqMMVTbveF1PrGAnxVVOf6QSOjrKt9prosS1nvY3TuNMkI/SY6z7vlMauRhWuofohpEhVq19CXg4swYpoSGsYXglKgQoRCVK6Q7xOLLb41qIC0EoJ28ryRWZ4+6k3OLib+8JaUdbasKrCJvVM/h033QAZVPr/UCmhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kqWKVseEFCw4LFZ2WW+gv5cN+jKGaXTAU+ZCP+R5s0M=; b=TfnipYIYc9pOAPwvnptPzRPRmQpGhPwggSamXjkiUzKb3dHnnBflaYVbC4COhOz/o8gPa/Mk9NY01gd9QYT1XR3NOWlucxS00XudNzOKTyqEEceYMtZiSz+Myen0tHwqZfRrh/wvDu1D0KZJuArT1sKqjsOL1064LnO4EitUaQgkETvlogBW4K7KcJxSwFzH8jMdVEdGk1k056YqhQiUfba/q95UAEL3GhmBEiBXTjJExy0hRsP6Rm33CLBbTn6rfzyXXSwIKOrmkoU3ry1/O0A6TNVfprfVpzEScp0eBUvabI3RI2Ek+Tvg+kpzKQ23W4Nfc+1+fEA0i7tKg7ND7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kqWKVseEFCw4LFZ2WW+gv5cN+jKGaXTAU+ZCP+R5s0M=; b=L7dXUWdgdzaXVK4IwSZLhB12nOq1kg/x8wK9jAZrJ5EOwmscrvMLF7KWvJ/Unr2+ity9NJnYQggbfsikXw9WxyUUYwWCMecWqI0aklgdZ6yotC2aNY+IOuMc+FdbyI9p2dM0hkUp7S9HlnHXtpJUiQRaRa/UPY+ULO+4SS7xdls= Received: from BN6PR05MB3411.namprd05.prod.outlook.com (2603:10b6:405:43::23) by BN8PR05MB6177.namprd05.prod.outlook.com (2603:10b6:408:66::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.5; Thu, 27 Aug 2020 05:27:54 +0000 Received: from BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::79d1:7b4a:fbda:c003]) by BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::79d1:7b4a:fbda:c003%7]) with mapi id 15.20.3305.021; Thu, 27 Aug 2020 05:27:54 +0000 From: "Andrei Warkentin" To: Pete Batard , Samer El-Haj-Mahmoud , "devel@edk2.groups.io" CC: Leif Lindholm , Ard Biesheuvel Subject: Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build error in DisplayDxe Thread-Topic: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build error in DisplayDxe Thread-Index: AQHWe/93UoXe1cTOLk+jEJgRg0Wz4KlLB9YAgABlsL4= Date: Thu, 27 Aug 2020 05:27:53 +0000 Message-ID: References: <20200826232015.9030-1-Samer.El-Haj-Mahmoud@arm.com>,<7fcfa2f2-b6ad-21b1-894d-8bdb4a7642dd@akeo.ie> In-Reply-To: <7fcfa2f2-b6ad-21b1-894d-8bdb4a7642dd@akeo.ie> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: akeo.ie; dkim=none (message not signed) header.d=none;akeo.ie; dmarc=none action=none header.from=vmware.com; x-originating-ip: [2601:240:4100:3c80:9daa:ce7f:b683:6f68] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ba69217f-9bcf-4d36-2c3f-08d84a49f2d6 x-ms-traffictypediagnostic: BN8PR05MB6177: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iWc333sy+LuvdF1rIXFKTgxkJi4YxoNaN9n1o8Fo/5iJAEFNcDzmxXIFb38tv1l/tT4YWAPvlAe8yCuX+qHE08TXZvTGf1S/sZxvVzTwjBWujKsJqHQHRwOmg0reZuNnj5h3gzGve8XvIpBntXOHtuc5pMLVnGz2NzZ30dvRwmp+NwA77Gb1oOYsMiaERKy1hrYIimY/PexGCLzz8MKlQIEPhEmgm2VhTGBpu9TZdhbpvXu4GD6QFslrwfoGpct/dg7KOuphSC0J5IckGGk+dMU8GjQF2FpTC3vqYXtzmyT3xwnhfLUiKBdynEvTk6dU x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR05MB3411.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(366004)(346002)(39860400002)(396003)(19627405001)(71200400001)(86362001)(52536014)(76116006)(66476007)(83380400001)(478600001)(64756008)(66446008)(66556008)(33656002)(66946007)(186003)(53546011)(5660300002)(8676002)(6506007)(4326008)(7696005)(9686003)(2906002)(8936002)(55016002)(110136005)(54906003)(316002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: acNqyCNNBceb79Vjl4MLr/E8pgTLwPIjmaLOFVWso9bR/p/yOst+w8Fp5Li5Sh27fzjR15+JrdzMyI0bzZ4qBnBtYfncSb29oVF1eUuy+RJjUQD5vGQPWoTIDGAhnjCltDAuq5DGn1QOyx2oyCSlDGA6/bkDqM6nl7QyNTJ8H6DdL0dUNldsQPE+4J+yn3Coawm34GpgJaZfugbfigxPVDfGnj6XUb+c1MLyxujaHJEISvjKT61l99FGwbCzw9WjFXxH6lRVD4Am0PF2vmtCMhu0ilzZ7eksgwXTYI4LuvaLLadeqf1ZnrYZ0jrkH58QnT5lt4dKbZKI8SkaXsGl6DP2tn1NZQyJdnyN5HDEx5OPm82MtaUwVq6CMcf4Ix/SLTBiplGZdt/viWLqj4wwtiK5iOdw+97FJhx/ZY84+3DcOXnq8UoERuzPbRg9ZtD+sIHqDaKYHj9YINUY6rpm0fLbe0HmwXwC/LDdM7cing8BLJuuOq/CnQh4GSvp7fW+8Lpi3MYZrKKqCEVcOgJ0bXg4jCWB4O9ToyC04RbKhlpTWSruKpTnjPmgDrtRBOLmxWguVhDNLoKr54qmae5zPFnyvLoveFjqjXbV+9XiRq8zzv9W4kbE4XmKRPpxBD4amhk2VyrzVpKtYiBNTCeHoeFZsR3O/ae8ZnpAUP6qOJyIF150EyhubSPJfN137SCWj+FIdX8IqMaQocfK836hKA== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR05MB3411.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba69217f-9bcf-4d36-2c3f-08d84a49f2d6 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Aug 2020 05:27:53.8496 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UpnMdAcTKUihS54vF8Aa/Xyx+OuwdcMCZjceFkYWYtfaXvyiU1Ifs7ohT43ZWnZqaFpMPcNLKG8/Lh2rS/+naw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR05MB6177 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BN6PR05MB34118AA62B9BB8B45BB6538DB9550BN6PR05MB3411namp_" --_000_BN6PR05MB34118AA62B9BB8B45BB6538DB9550BN6PR05MB3411namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Andrei Warkentin ________________________________ From: Pete Batard Sent: Wednesday, August 26, 2020 6:23 PM To: Samer El-Haj-Mahmoud ; devel@edk2.groups.= io Cc: Leif Lindholm ; Ard Biesheuvel ; Andrei Warkentin Subject: Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build= error in DisplayDxe On 2020.08.27 00:20, Samer El-Haj-Mahmoud wrote: > Commit 0c2af04985f0bf152ac3edc70d9c6d9fe884cdcb added mDriverBinding > extern module global, but did not remove the STATIC declaration, which > caused the build to break. Fix the build error by removing STATIC for > that module global variable. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Pete Batard > Cc: Andrei Warkentin > Signed-off-by: Samer El-Haj-Mahmoud > --- > Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c b/Platf= orm/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c > index ae4b2735820c..3eba98e5aa87 100644 > --- a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c > +++ b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c > @@ -87,7 +87,7 @@ DisplayBlt ( > IN UINTN Delta OPTIONAL > ); > > -STATIC EFI_DRIVER_BINDING_PROTOCOL mDriverBinding =3D { > +EFI_DRIVER_BINDING_PROTOCOL mDriverBinding =3D { > DriverSupported, > DriverStart, > DriverStop, > Reviewed-by: Pete Batard --_000_BN6PR05MB34118AA62B9BB8B45BB6538DB9550BN6PR05MB3411namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Andrei Warkentin <andrey.warkentin@gmail.com>
From: Pete Batard <pete@= akeo.ie>
Sent: Wednesday, August 26, 2020 6:23 PM
To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; devel= @edk2.groups.io <devel@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ard.= biesheuvel@arm.com>; Andrei Warkentin <awarkentin@vmware.com>
Subject: Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fi= x build error in DisplayDxe
 
On 2020.08.27 00:20, Samer El-Haj-Mahmoud wrote: > Commit 0c2af04985f0bf152ac3edc70d9c6d9fe884cdcb added mDriverBinding > extern module global, but did not remove the STATIC declaration, which=
> caused the build to break. Fix the build error by removing STATIC for<= br> > that module global variable.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Pete Batard <pete@akeo.ie>
> Cc: Andrei Warkentin <awarkentin@vmware.com>
> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com&g= t;
> ---
>   Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 2 += -
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c b/Pl= atform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
> index ae4b2735820c..3eba98e5aa87 100644
> --- a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
> +++ b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
> @@ -87,7 +87,7 @@ DisplayBlt (
>     IN  UINTN     &n= bsp;            = ;            &n= bsp;    Delta        = ; OPTIONAL
>     );
>  
> -STATIC EFI_DRIVER_BINDING_PROTOCOL mDriverBinding =3D {
> +EFI_DRIVER_BINDING_PROTOCOL mDriverBinding =3D {
>     DriverSupported,
>     DriverStart,
>     DriverStop,
>

Reviewed-by: Pete Batard <pete@akeo.ie>
--_000_BN6PR05MB34118AA62B9BB8B45BB6538DB9550BN6PR05MB3411namp_--