From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.77.82]) by mx.groups.io with SMTP id smtpd.web10.1642.1605741687216411573 for ; Wed, 18 Nov 2020 15:21:27 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=M5Kg7uWJ; spf=pass (domain: vmware.com, ip: 40.107.77.82, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YkkIqw+ve7dyLKTP3hpiXeyk7i12g+JEfkm0YF5KAJ58rMgzi0yFHEZ7Jf2zs/SRFlLXAidCSaKQzGQDWxPt9eQalE5RphzLYnKtR6g5uZMkfTbvN3p0LzVhkP4gKeGFVI1Z4MKSCgpPnKVkwU1mhOrpO52KSPRwqjL3biEJjiqCl8gQOF+iqN8TlkUOeCcoXvV7uxAJBwO3KXujbiw5OL4gA597TXHQBTTqs77qY94WU/zSkkzMtjQNUpxPW7RFVKSgheBjtc/wRZ/oRodelj1hglazaa8BW7OZBbuF/T//0tDe9BNtKu6pFPMTqF8xq17fnSTNHTkYbwOvBpcr2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k3AT6B29jl+/nSy+xDBad+QpYNxk5EGir9H7PlbMqrk=; b=WiJCck9/MRa/xLNrDYwwMThCsMXKcAPql3QvPpVFECLt8B1+atzPc7Om0kCQd+uDIKuLhqGqR0iVmmP4pBKIwd3lYyWsBRYq5cEeGxFhTrK2kFUwgMVrYt4mZTj8nW4XimjC6S4FIjVFLsY+2ABmzZvFXTEGkNSwfr//12jc0DFcxlq5i227YhNAeeFe0ylmW+3cG5anAXNWWXey4m6Ufh2Oy+ATpgCbgpyOctKCjihZTkGfyLcqTCnUkYuq3YZ6LTrvQtfRWaXi47snyqCS+UvHZpnQOeywVeZhkeqXT5uaHZ1fyJrS5eIs8V6CsKC7vyINyFUC6KBaYOyqyIQTfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k3AT6B29jl+/nSy+xDBad+QpYNxk5EGir9H7PlbMqrk=; b=M5Kg7uWJPd5RVzXUV0UbUD8hG59oGbFuL5LGIdSYZmixrFeHpXtupIS+ubUdftCAqfCTEnUm9+s4DT56ccDuv9+vGqbxcmQHn3yunz2hhFLKGrToDLXNpUtMGCwnpmQ229/6lXLObJ5yr3v1jSyypmgruF1aL6umggGVwVZPnC8= Received: from BN6PR05MB3411.namprd05.prod.outlook.com (2603:10b6:405:43::23) by BN6PR05MB3603.namprd05.prod.outlook.com (2603:10b6:405:46::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.16; Wed, 18 Nov 2020 23:21:24 +0000 Received: from BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::20c6:8760:cb3a:78b3]) by BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::20c6:8760:cb3a:78b3%7]) with mapi id 15.20.3611.009; Wed, 18 Nov 2020 23:21:24 +0000 From: "Andrei Warkentin" To: Andrei Warkentin , "devel@edk2.groups.io" , "leif@nuviainc.com" CC: "ard.biesheuvel@arm.com" , "pete@akeo.ie" , "philmd@redhat.com" Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs Thread-Topic: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs Thread-Index: AQHWuzmrrJeeF/bgGkClUemghRo9AqnMf8WAgAIMOsI= Date: Wed, 18 Nov 2020 23:21:24 +0000 Message-ID: References: <20201115102527.2993-1-andrey.warkentin@gmail.com>,<20201117160255.GG1664@vanye> In-Reply-To: <20201117160255.GG1664@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=vmware.com; x-originating-ip: [98.214.99.181] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fe68ff02-b94a-4c55-4d00-08d88c18aac6 x-ms-traffictypediagnostic: BN6PR05MB3603: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ECgORxB5yy0Qey6Mf+LICqMo6OLPQ6Nu9RVZyOtRHQKr7hsLOMj2K6U3cL00demlPFULp3GT77BAuQIvzcy0DKZryTO/Bqf7RoT0raQaggJmshIHdttN5sKTdPkdz+YHqLtjhiD+wps/gobvjPJORbXqfr3D+IJ9q3KJDqigQYooZNtn3T9kwSvD1bNCpiK0+WHmV/B1Urvp3fbT8DsxxDSBt1NDMVv0KBZhc6FLcIIr8asYii0gHEpiKTwbUKOP1KkDUGGKvDwrkpyi95eFBFoo5QOTCW5ihKvTBrtVTuqNHloGu9aPx3zmeyBhIodRshnINOI+XrMBb1Z0YjC0tzGBbJS9zSXCPze2rJqPD/YQRNA93z1pcejR/H4bmo4VXVxCjbPFbqfxPXQbNH+jAg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR05MB3411.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(346002)(366004)(136003)(39860400002)(86362001)(478600001)(91956017)(26005)(5660300002)(7696005)(54906003)(83380400001)(55016002)(71200400001)(966005)(19627405001)(166002)(6506007)(33656002)(66476007)(66446008)(64756008)(9686003)(8936002)(45080400002)(53546011)(186003)(110136005)(76116006)(316002)(66946007)(66556008)(52536014)(4326008)(8676002)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: aKoD2ergEhEVgKI6Vk+6HG7QoEelaJg6v6UlFCLOqwwzHixWOw7yeR3TmT1mz/kSvEBU2xVEYY5EDCZHJyxR+YVPEftow/B9OteYP3gXoe1M8R67ovjfqN1OY7K8tOEH9WQoKyrTuecniXO0CerQWgH4zx+6ZfYubB9zrkG6WuJsabRxUvf2khfmVAO61BLYPnFfqho9M9VFJJS3/FhHoaU30+fd6AFTiuAfaxrTCQHDzY6oELbHwqfErQMxaDVQr4fjJEwLORGIx0vqhaBdIP5ehCeYPLk4LUQGk/U9UwGJhwbXqhGrMnw4M+rTqvQLrgKOO8wrWHiAgeY21ZcI5pC2Ioqd7zZb/wrsMXmnlfv8+MXyT8nJTB57l95vrPsgbDgC89ampHiaGr9FNRvA5Wp2BCd7OFTgwgOyVm7fsG9xqU41hnB7y+cXtBfJEmu3JYHK1ivAsz1VO1qX/3anj/XSK7RQCq2R/otMPaJJQ+8QbdmGDI88m7t/sLhPsn1eOyAgOj1ergZDXSPoJorXy95LbZmOvYT8U2ZY1LMcaPHI/oEcq/2aXUMRGfmA9+TLcNzs0yp93oANOlxFN83iKbsZawq9UsfUizaYs7LmET9GZOceJgonNfBPSYChhoH2CIRW+Tg1CDlVkiAepydhE5oSjCt2dlBj3RzARHtyyfUwxzfv4CRiOUSzJazAc2IrdIh7UcO2jTLFZxj86EdZO6GSzvzhcdsDv1j1SsmgNEUbd7bmWdZ9u0TmhqbL1zyrT0vvnWrqkl+SJaYJlOLc7NPoMw+xg2nKKsxsTFQEkat5k32dKOpXIx7TGZ6b2k1l2y9uYfY0UQ6tAko5JifgD6D48k+dWDdWbGMciSUmzq7qzn/fEzSulEo4PHtaZV6scJJRJhnI2KE+KrlCGy4gXA== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR05MB3411.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe68ff02-b94a-4c55-4d00-08d88c18aac6 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2020 23:21:24.4291 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2O1/nBqPNkB2Rwlx9sUiaKoyA/d8zY+ls5ssWHq38pyc1slprOyqlGK0w0jpRKeE7fD/4D66GN5zb7l16iXiVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR05MB3603 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BN6PR05MB341193E9AFC671AB462D56FCB9E10BN6PR05MB3411namp_" --_000_BN6PR05MB341193E9AFC671AB462D56FCB9E10BN6PR05MB3411namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, I got these from https://www.raspberrypi.org/documentation/hardware/raspbe= rrypi/revision-codes/README.md A ________________________________ From: devel@edk2.groups.io on behalf of Leif Lindho= lm via groups.io Sent: Tuesday, November 17, 2020 10:02 AM To: Andrei Warkentin Cc: devel@edk2.groups.io ; ard.biesheuvel@arm.com ; pete@akeo.ie ; philmd@redhat.com Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryP= i: add CM4 and 400 as BCM2711 designs Hi Andrei, On Sun, Nov 15, 2020 at 04:25:27 -0600, Andrei Warkentin wrote: > Like the Pi 4B, the 3GB/4GB choices apply to it as well. > > Signed-off-by: Andrei Warkentin Patch looks straghtforward enough, but ideally I'd like someone to chime in with tested-by. That hasn't happened so far - are these documented anywhere I could easily sanity check myself? / Leif > --- > Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.= c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > index 5302ccd8..ade91c9f 100644 > --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > @@ -596,6 +596,10 @@ RpiFirmwareGetModelName ( > return "Raspberry Pi Compute Module 3+"; > case 0x11: > return "Raspberry Pi 4 Model B"; > + case 0x13: > + return "Raspberry Pi 400"; > + case 0x14: > + return "Raspberry Pi Compute Module 4"; > default: > return "Unknown Raspberry Pi Model"; > } > @@ -670,6 +674,8 @@ RPiFirmwareGetModelFamily ( > *ModelFamily =3D 3; > break; > case 0x11: // Raspberry Pi 4 Model B > + case 0x13: // Raspberry Pi 400 > + case 0x14: // Raspberry Pi Computer Module 4 > *ModelFamily =3D 4; > break; > default: > -- > 2.20.1 > --_000_BN6PR05MB341193E9AFC671AB462D56FCB9E10BN6PR05MB3411namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi Leif,


A
From: devel@edk2.groups.io= <devel@edk2.groups.io> on behalf of Leif Lindholm via groups.io <= leif=3Dnuviainc.com@groups.io>
Sent: Tuesday, November 17, 2020 10:02 AM
To: Andrei Warkentin <andrey.warkentin@gmail.com>
Cc: devel@edk2.groups.io <devel@edk2.groups.io>; ard.biesheuv= el@arm.com <ard.biesheuvel@arm.com>; pete@akeo.ie <pete@akeo.ie>= ;; philmd@redhat.com <philmd@redhat.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/Ras= pberryPi: add CM4 and 400 as BCM2711 designs
 
Hi Andrei,

On Sun, Nov 15, 2020 at 04:25:27 -0600, Andrei Warkentin wrote:
> Like the Pi 4B, the 3GB/4GB choices apply to it as well.
>
> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
Patch looks straghtforward enough, but ideally I'd like someone to
chime in with tested-by. That hasn't happened so far - are these
documented anywhere I could easily sanity check myself?

/
    Leif

> ---
>  Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | = 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareD= xe.c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
> index 5302ccd8..ade91c9f 100644
> --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > @@ -596,6 +596,10 @@ RpiFirmwareGetModelName (
>      return "Raspberry Pi Compute Modul= e 3+";
>    case 0x11:
>      return "Raspberry Pi 4 Model B&quo= t;;
> +  case 0x13:
> +    return "Raspberry Pi 400";
> +  case 0x14:
> +    return "Raspberry Pi Compute Module 4";=
>    default:
>      return "Unknown Raspberry Pi Model= ";
>    }
> @@ -670,6 +674,8 @@ RPiFirmwareGetModelFamily (
>        *ModelFamily =3D 3;
>        break;
>    case 0x11:       = ;   // Raspberry Pi 4 Model B
> +  case 0x13:        &nb= sp; // Raspberry Pi 400
> +  case 0x14:        &nb= sp; // Raspberry Pi Computer Module 4
>        *ModelFamily =3D 4;
>        break;
>    default:
> --
> 2.20.1
>





--_000_BN6PR05MB341193E9AFC671AB462D56FCB9E10BN6PR05MB3411namp_--