From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.44]) by mx.groups.io with SMTP id smtpd.web10.12177.1595392284283912500 for ; Tue, 21 Jul 2020 21:31:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=qlj5PGgK; spf=pass (domain: vmware.com, ip: 40.107.244.44, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gCZMSQJ4IK2PxKMIg/4SrOR/lfsI1CVQ9vKrpZ2j9c9lRs1HE5m6VK/VTX15+JTXEZKPJzwFnY5UNqH3+FT+4OKQyDC1Z+hzc3eSBLIYL37TLvVwe+P5kJ+z4L/hP4P8CMcWYyB/Xzfs961M0PvvG51T2A3MCeWVVxjw4JWd9c4+pKRoEtt2GDcTkyunKQml6tJe8XvDiwkBOnFeQvKRoYIPkgX34XDTtcZYhziRZM0OhyMp6nqHKjknhc6HL/IepPhY4eqLd9qif82BulqxgEqzbB1u5b0gEPZ47o2PbdnilzyVlvdi06meAdKl+T4A2Wz+p/ECZC8luwii3rV6Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rkyP1WmgVnImFVpIxvhzj14ZCeEgN19eDH3KSpdBD7I=; b=CsBRQwr0s3LYrqlaL80Vgtl05L1A+ysK+t9AZ+ynlBurtbsabBbLq37xrSm7M1tgZYE/KMcZVOlpPK7QhUWNTsr+65cRLSmnXfJ6e0/55SuZXfuo3fqhjp7NVpyTdqrNFZ+vGjfmoWoUEAj0X1lG3nWl5IYilCT5anRCyxm7LnmI+9W0QfHinOOwWiS32UQJepfdbSVmV89YZCiW7dqUnJ66wdLrQ06PFyZiPjO+wbrfA8+J2AUW/5hB58oNbh0Cb4BEBMZANjllGXzGZc6h2gb0j35RgNZWhyZBztify4REsFLhNXykW+UtJrL2BJ4GXlutGriSeqNoHalNPspabw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rkyP1WmgVnImFVpIxvhzj14ZCeEgN19eDH3KSpdBD7I=; b=qlj5PGgKg7LWy2O/H2ItA4lFmuvsHl10d2Ug/OecvdWm+rh9k9uLrZ4nRYMZ8XS4YhJsG3ZLQ6BTF4IuDBIDdujxraYaP4p+TbY7LrruiZvO8xVEwU+KDR0XD77bvWSbc60+Lm8QlpR7Ay8IbEJsbSFbDcomUkHXg5Uq49EKvGk= Received: from BN6PR05MB3411.namprd05.prod.outlook.com (2603:10b6:405:43::23) by BN8PR05MB5986.namprd05.prod.outlook.com (2603:10b6:408:42::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.17; Wed, 22 Jul 2020 04:31:22 +0000 Received: from BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::e1ef:31eb:c802:aef0]) by BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::e1ef:31eb:c802:aef0%3]) with mapi id 15.20.3216.017; Wed, 22 Jul 2020 04:31:22 +0000 From: "Andrei Warkentin" To: Samer El-Haj-Mahmoud , "devel@edk2.groups.io" CC: Leif Lindholm , Pete Batard , Ard Biesheuvel Subject: Re: [edk2-platform][PATCH v1 2/3] Platforms/RaspberryPi: Return GOP PixelInformation in QueryMode() Thread-Topic: [edk2-platform][PATCH v1 2/3] Platforms/RaspberryPi: Return GOP PixelInformation in QueryMode() Thread-Index: AQHWX8v2CqBylwv/8UiUOdy+FDGGJqkTAaNK Date: Wed, 22 Jul 2020 04:31:22 +0000 Message-ID: References: <20200722020103.11808-1-Samer.El-Haj-Mahmoud@arm.com>,<20200722020103.11808-3-Samer.El-Haj-Mahmoud@arm.com> In-Reply-To: <20200722020103.11808-3-Samer.El-Haj-Mahmoud@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=vmware.com; x-originating-ip: [98.214.99.181] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7e96c6ae-4c07-4d13-1408-08d82df8168d x-ms-traffictypediagnostic: BN8PR05MB5986: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rz6hViRqgjfBv7MPzld0LMjlStC4zPGRoWX6YBvZZKpQKIs4oBDZT93ggGEAEY3ehaSeiCZh6DCobOB1ZS1kPcQA+uTLDeAsEajAYyXGxAkGEGaE44O7+F+v6TAmff9pOeVw02IycyP8NhE8jlWJy5Tj316XQstRyD8bLiQFMePhywwNnPNXkYrp5QSFfDjT54Vma5CJDFNzwqP14RHbj/BqfcZyvxWZypOAczSFH3Qi+drQvX5aQlQMbwuJIVKUA2ey+iufp9QvcACjNl9qdus+sqFhB54+PNzq73QQcW+38CiZScwTPXIcmS5R8DzFDyzia/hWmqKvfItgyUlsc6+Bk2EfCYL0k0hymf8R6QcUvU8CgKCNtl045wytLnuWNQjbiU1uwlueGo++08a7yA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR05MB3411.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(366004)(376002)(136003)(346002)(39860400002)(83380400001)(7696005)(45080400002)(71200400001)(55016002)(166002)(9686003)(4326008)(66946007)(8936002)(33656002)(66556008)(66446008)(19627405001)(76116006)(86362001)(5660300002)(316002)(2906002)(8676002)(66476007)(186003)(6506007)(966005)(53546011)(64756008)(110136005)(478600001)(54906003)(52536014)(26005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: Q+cFPKtOCt9ciZxyz+6Gq4SqKgbBAczBxc0waK++pad54+L5WhileyxiqZaQgcJwslD2t6eGSRs2vRaqCp2gEe2pc6Q+hiTYIeC00B+CZ2QusQ+kPlG5Xg7Kk3tVM1OESOkVyRP5INqiHpkW2n7CIQGe5PQu7936xub7Pp22kuzxVc5oggF1MmCdf+tQmEOvtcRcViSPiiD9NwsdOsl3F+MskdjO5jBIuBa7hs6RdxXcfPohxuF54nEExdz0GbKjCRZOgoNFDsvZm7EMOvv/M6ZgK5MZqZfGTpu29FCpycYIaEQaQe/v/pnu4XgBIaxxq0m9KrRJ+D9uvS9HVGaBrMlZfxXHMviDJQa/rDHQ5eXdMZPHHUwBIklcDWLUnA0+f/IOkzyYlq0du/10oXzTkvp3rJEB0V5y15HewaqeTwhoSTQhqmGUHxzKLc7g56y8SbpJoUlSManAAjjr7Q0e121azf26/deli2Kv3EiwWHCcLJ91RSc9pZW+aVOdgYtY x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR05MB3411.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e96c6ae-4c07-4d13-1408-08d82df8168d X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2020 04:31:22.4480 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IjAi3AYS9NYOSGyvewx4PDjdWgfYMsfi7fnG3bAIs2w2MnPEI8f+e80rH2sAulBNaurSJSi0tIUVbQd2WWRdDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR05MB5986 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BN6PR05MB34119BA1BC3FDC9F1FB1350FB9790BN6PR05MB3411namp_" --_000_BN6PR05MB34119BA1BC3FDC9F1FB1350FB9790BN6PR05MB3411namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Andrei Warkentin ________________________________ From: Samer El-Haj-Mahmoud Sent: Tuesday, July 21, 2020 9:01 PM To: devel@edk2.groups.io Cc: Leif Lindholm ; Pete Batard ; Andrei W= arkentin ; Ard Biesheuvel Subject: [edk2-platform][PATCH v1 2/3] Platforms/RaspberryPi: Return GOP Pi= xelInformation in QueryMode() Return correct values of PixelInformation in QueryMode(). This fixes the QueryMode_Func failures reported by SCT tests at https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.= com%2Fpftf%2FRPi4%2Fissues%2F73&data=3D02%7C01%7Cawarkentin%40vmware.co= m%7C97fe0ab6da2a480623a208d82de317f2%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0= %7C1%7C637309800678332179&sdata=3DwecctIMVYrU2YhzqOouRS6THUMosi%2Bu7kt2= e2gH4oIY%3D&reserved=3D0 Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c b/Platfor= m/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c index 80d0f7b2cb3c..f50ffc816cf1 100644 --- a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c +++ b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c @@ -191,6 +191,10 @@ DisplayQueryMode ( (*Info)->HorizontalResolution =3D Mode->Width; (*Info)->VerticalResolution =3D Mode->Height; (*Info)->PixelFormat =3D This->Mode->Info->PixelFormat; + (*Info)->PixelInformation.RedMask =3D This->Mode->Info->PixelInformation= .RedMask; + (*Info)->PixelInformation.GreenMask =3D This->Mode->Info->PixelInformati= on.GreenMask; + (*Info)->PixelInformation.BlueMask =3D This->Mode->Info->PixelInformatio= n.BlueMask; + (*Info)->PixelInformation.ReservedMask =3D This->Mode->Info->PixelInform= ation.ReservedMask; (*Info)->PixelsPerScanLine =3D Mode->Width; return EFI_SUCCESS; -- 2.17.1 --_000_BN6PR05MB34119BA1BC3FDC9F1FB1350FB9790BN6PR05MB3411namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>
From: Samer El-Haj-Mahmoud = <Samer.El-Haj-Mahmoud@arm.com>
Sent: Tuesday, July 21, 2020 9:01 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>; Pete Batard <pete@ak= eo.ie>; Andrei Warkentin <awarkentin@vmware.com>; Ard Biesheuvel &= lt;ard.biesheuvel@arm.com>
Subject: [edk2-platform][PATCH v1 2/3] Platforms/RaspberryPi: Return= GOP PixelInformation in QueryMode()
 
Return correct values of PixelInformation in Query= Mode().

This fixes the QueryMode_Func failures reported by SCT tests at
https://nam04.safelink= s.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.com%2Fpftf%2FRPi4%2Fis= sues%2F73&amp;data=3D02%7C01%7Cawarkentin%40vmware.com%7C97fe0ab6da2a48= 0623a208d82de317f2%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C63730980067= 8332179&amp;sdata=3DwecctIMVYrU2YhzqOouRS6THUMosi%2Bu7kt2e2gH4oIY%3D&am= p;amp;reserved=3D0

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com> ---
 Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c b/Platfor= m/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
index 80d0f7b2cb3c..f50ffc816cf1 100644
--- a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
+++ b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
@@ -191,6 +191,10 @@ DisplayQueryMode (
   (*Info)->HorizontalResolution =3D Mode->Width;
   (*Info)->VerticalResolution =3D Mode->Height;
   (*Info)->PixelFormat =3D This->Mode->Info->PixelFo= rmat;
+  (*Info)->PixelInformation.RedMask =3D This->Mode->Info->= ;PixelInformation.RedMask;
+  (*Info)->PixelInformation.GreenMask =3D This->Mode->Info-&= gt;PixelInformation.GreenMask;
+  (*Info)->PixelInformation.BlueMask =3D This->Mode->Info-&g= t;PixelInformation.BlueMask;
+  (*Info)->PixelInformation.ReservedMask =3D This->Mode->Inf= o->PixelInformation.ReservedMask;
   (*Info)->PixelsPerScanLine =3D Mode->Width;
 
   return EFI_SUCCESS;
--
2.17.1

--_000_BN6PR05MB34119BA1BC3FDC9F1FB1350FB9790BN6PR05MB3411namp_--