From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.42]) by mx.groups.io with SMTP id smtpd.web12.15020.1586881491696096016 for ; Tue, 14 Apr 2020 09:24:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=YiItkwf1; spf=pass (domain: vmware.com, ip: 40.107.220.42, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XjK1QcKFIfc6bO6sAb+Wa1mbGnNmb3orbnD1YMt2/+wgNaTTeoejO3YsIgq4qU1la7WJ29AvEq1Q1BEobCsCJujQWZ9EXjtv/51QN/qsDpV33nruE7q4JTr4T5M4F+463PGI4cZ4DEIqiPiZNV3zAjA8bXHSQd/Dh20xypvqU6iJAvV4fYkaJ3A5nxjNTig9GSNnRkxyngKx/KWMKuiI+87oHNb6a5TccgSO6BO+5f2t3J4umqlcmcYlCYuiIhVcRyFeLNZ+a6kmEfgl6jsNzBVJkHh6IG7kukth/ytXW/1/GK4WVIyHqbYLcKvW+4sTsBVT7+RMUVQWeKroDX8Yzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bqwWMdKkEE9qu9NiZRFf2U0G/dJyBUXWHj9XcrdRxxE=; b=mroAoG6YL9EdCKOrcUcJu93U9wEU5BFFuzA66qwX5anEJr5XKb91f64EKWLKCd3bw65ud3Fx1qgqZi6pmQ0FrLZYlFG5RFxNDDQP2LD+OrgpzAvEcqPr+25prXEjrNCXWTIYnwKLbG1iM26LTY7m+J7fcRSNU1YLQxiyfXX1NlUyv0e3Z74qn/0xYGYoz1kO2C5JPpGp2k8131Df1ESx/ES1oeyht/+G8sUI15/dTRNESdpNF1oy3tKVuBSZ6B9Hem8mgfp2E+0UL/TdK2lXYuYgaid0Pz1Pf6/XN3PfcYeLBr/U1nqEz4ynra2VFyqOUXMz7xrmQI3SHJl9PDyTIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bqwWMdKkEE9qu9NiZRFf2U0G/dJyBUXWHj9XcrdRxxE=; b=YiItkwf1rB81d/8ThzZ/L6xu25EkgLTr7DrWTWR7gDfKYo7ytpAZAIv2dRj5nOKwzGVZsSK7IhCFRGqbKR87vBEoBnFH6Sbrnai7QObyb5b+w8gavW3LV3gjv4tdOWzXmQe+Sd9SA3GVK17+5OuvuAGDgkVNdfWpJcurTiAQkdM= Received: from BN6PR05MB3411.namprd05.prod.outlook.com (2603:10b6:405:43::23) by BN6PR05MB3300.namprd05.prod.outlook.com (2603:10b6:405:3e::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.23; Tue, 14 Apr 2020 16:24:47 +0000 Received: from BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::5df3:40e3:521a:7f84]) by BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::5df3:40e3:521a:7f84%5]) with mapi id 15.20.2921.024; Tue, 14 Apr 2020 16:24:47 +0000 From: "Andrei Warkentin" To: Samer El-Haj-Mahmoud , "devel@edk2.groups.io" CC: Leif Lindholm , Ard Biesheuvel , Pete Batard Subject: Re: [edk2-platform][PATCH v2 2/3] Platform/RaspberryPi/RPi3: Switch to common GraphicsConsoleDxe Thread-Topic: [edk2-platform][PATCH v2 2/3] Platform/RaspberryPi/RPi3: Switch to common GraphicsConsoleDxe Thread-Index: AQHWEnOHn9EMRF98/kKiWUDqLcn9dqh4zW5S Date: Tue, 14 Apr 2020 16:24:47 +0000 Message-ID: References: <20200414154358.5161-1-samer@elhajmahmoud.com>,<20200414154358.5161-3-samer@elhajmahmoud.com> In-Reply-To: <20200414154358.5161-3-samer@elhajmahmoud.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=awarkentin@vmware.com; x-originating-ip: [98.214.99.181] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 50040387-9202-43e9-9d4e-08d7e0905989 x-ms-traffictypediagnostic: BN6PR05MB3300: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 0373D94D15 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR05MB3411.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(39860400002)(396003)(346002)(136003)(376002)(366004)(2906002)(19627405001)(76116006)(66946007)(66476007)(66556008)(64756008)(66446008)(52536014)(45080400002)(478600001)(8676002)(81156014)(86362001)(8936002)(966005)(66574012)(6506007)(53546011)(9686003)(54906003)(55016002)(110136005)(19627235002)(71200400001)(26005)(316002)(4326008)(33656002)(7696005)(5660300002)(186003);DIR:OUT;SFP:1101; received-spf: None (protection.outlook.com: vmware.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7eg5RxI0xT/tIafyisAPHDQgO96TXAJVreILQZYkbmuuruxhRQUMkyDPReJk8vVZHmD9/j6Cd6u+IMLljaQNASVa2sUjOCrkpelPfDsps/Gl21G0lgZigVF/b5Eq7JMSs/YtlodnFRMrr39wRFCxOtN456AnvEDdk9BWnwMbAP7mfj+RUsOHKNr9L95VoE4L6iJayekw5p9Vy96Eh5hkpEECguqcbvA+lvdq1CY86veMUeawdUNS4W+5/yaFMVuRsRlZJ2o8bSjrPOtdRN+THQcHyREz5DuGvZyErxTgBOmppZ2BB4o/1gxXAIKg5E16ixCX6SI7hCovCpgErP1u0LLLxBmISXkY1AOCYbsXwH1XK941rrIROTMSik1g6usxajwIegAcnoZC+GWGOkWcQv1PQ+/Xvvn16E0koBLBwf63nZxl4HrqFEpVV07r/wlM6Pg57WyW67utKpaLoCYMMyn00oNefjfOMiNmAzFWHRZfR//AUz4iSs7vJhIuN2DM8VI5QvR+t9W5H40HVZwl6Q== x-ms-exchange-antispam-messagedata: YXix1NK6NYadkW/xGnAFdiW4ul3cX0nDDSDmZhdbvRXnw1+M3F3orZ3NNh5mj4WF83FctNwrBEME3ovO0SXh94xHVL58RfTHdFvFS71qwzbfZY79Ip4rX+ahjcVnSs/dLEJAaiCV5gtok6PLT4dfnw== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50040387-9202-43e9-9d4e-08d7e0905989 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2020 16:24:47.6029 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dhmwL7zkZWj29IldcHJB7+k0sc/gptCmF22pvoOajuTAE/JDv1fTmo/GMTN66vjmDQnPqRGMdIR54Qrx9ZZEjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR05MB3300 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BN6PR05MB3411C72008AE34F4A61B2CA7B9DA0BN6PR05MB3411namp_" --_000_BN6PR05MB3411C72008AE34F4A61B2CA7B9DA0BN6PR05MB3411namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Andrei Warkentin Looks good to me - there's little reason for using a custom GraphicsConsole= Dxe now (historically, the screenshot facility lived there, there's a priva= te interface there for messing with terminal scrolling (unused) and I moved= to a different font with my box drawing chars, but the font issue can/need= s to be tackled in a different way that Tiano already supports). ________________________________ From: Samer El-Haj-Mahmoud Sent: Tuesday, April 14, 2020 10:43 AM To: devel@edk2.groups.io Cc: Leif Lindholm ; Ard Biesheuvel ; Pete Batard ; Andrei Warkentin Subject: [edk2-platform][PATCH v2 2/3] Platform/RaspberryPi/RPi3: Switch to= common GraphicsConsoleDxe Switch from the PI specific GraphicsConsoleDxe driver to the common driver in MdeModulePkg. There is no need to carry RPi specific version. This resolves https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3= A%2F%2Fgithub.com%2Fpftf%2FRPi4%2Fissues%2F32&data=3D02%7C01%7Cawarkent= in%40vmware.com%7Cb8a0cb0f0c7d4aa1f8b908d7e08aa8c2%7Cb39138ca3cee4b4aa4d6cd= 83d9dd62f0%7C0%7C1%7C637224758455357637&sdata=3D0TVwjw%2BzBX%2BSEp0YG3N= v2H6%2BlN2faehM9jaNvVrTmoM%3D&reserved=3D0 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud --- Notes: v2: - Set PcdUgaConsumeSupport to FALSE [Ard] Platform/RaspberryPi/RPi3/RPi3.dsc | 3 ++- Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3= /RPi3.dsc index 9ceb0f11c7fe..a451e2a82b59 100644 --- a/Platform/RaspberryPi/RPi3/RPi3.dsc +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc @@ -240,6 +240,7 @@ [PcdsFeatureFlag.common] # It could be set FALSE to save size. gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE + gEfiMdePkgTokenSpaceGuid.PcdUgaConsumeSupport|FALSE [PcdsFixedAtBuild.common] gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000 @@ -545,7 +546,7 @@ [Components.common] MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf - Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.inf + MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf MdeModulePkg/Universal/SerialDxe/SerialDxe.inf Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.inf diff --git a/Platform/RaspberryPi/RPi3/RPi3.fdf b/Platform/RaspberryPi/RPi3= /RPi3.fdf index 66c2cbada59b..e467b5cd31df 100644 --- a/Platform/RaspberryPi/RPi3/RPi3.fdf +++ b/Platform/RaspberryPi/RPi3/RPi3.fdf @@ -206,7 +206,7 @@ [FV.FvMain] # INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf - INF Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.i= nf + INF MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe= .inf INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf INF Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.inf -- 2.17.1 --_000_BN6PR05MB3411C72008AE34F4A61B2CA7B9DA0BN6PR05MB3411namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Andrei Warkentin <andrey.warkentin@gmail.com>

Looks good to me - there's little reason for using a custom GraphicsConsole= Dxe now (historically, the screenshot facility lived there, there's a priva= te interface there for messing with terminal scrolling (unused) and I moved= to a different font with my box drawing chars, but the font issue can/needs to be tackled in a different w= ay that Tiano already supports).

From: Samer El-Haj-Mahmoud = <samer@elhajmahmoud.com>
Sent: Tuesday, April 14, 2020 10:43 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ard.= biesheuvel@arm.com>; Pete Batard <pete@akeo.ie>; Andrei Warkentin = <awarkentin@vmware.com>
Subject: [edk2-platform][PATCH v2 2/3] Platform/RaspberryPi/RPi3: Sw= itch to common GraphicsConsoleDxe
 
Switch from the PI specific GraphicsConsoleDxe dri= ver to the
common driver in MdeModulePkg. There is no need to carry RPi specific
version.

This resolves https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.= com%2Fpftf%2FRPi4%2Fissues%2F32&amp;data=3D02%7C01%7Cawarkentin%40vmwar= e.com%7Cb8a0cb0f0c7d4aa1f8b908d7e08aa8c2%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0= %7C0%7C1%7C637224758455357637&amp;sdata=3D0TVwjw%2BzBX%2BSEp0YG3Nv2H6%2= BlN2faehM9jaNvVrTmoM%3D&amp;reserved=3D0

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
---

Notes:
    v2:
    - Set PcdUgaConsumeSupport to FALSE [Ard]

 Platform/RaspberryPi/RPi3/RPi3.dsc | 3 ++-
 Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3= /RPi3.dsc
index 9ceb0f11c7fe..a451e2a82b59 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.dsc
+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
@@ -240,6 +240,7 @@ [PcdsFeatureFlag.common]
   #  It could be set FALSE to save size.
   gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
   gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
+  gEfiMdePkgTokenSpaceGuid.PcdUgaConsumeSupport|FALSE
 
 [PcdsFixedAtBuild.common]
   gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000=
@@ -545,7 +546,7 @@ [Components.common]
 
   MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.i= nf
   MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.i= nf
-  Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.= inf
+  MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConso= leDxe.inf
   MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
   MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
   Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.inf
diff --git a/Platform/RaspberryPi/RPi3/RPi3.fdf b/Platform/RaspberryPi/RPi3= /RPi3.fdf
index 66c2cbada59b..e467b5cd31df 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.fdf
+++ b/Platform/RaspberryPi/RPi3/RPi3.fdf
@@ -206,7 +206,7 @@ [FV.FvMain]
   #
   INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformD= xe.inf
   INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterD= xe.inf
-  INF Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsole= Dxe.inf
+  INF MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsC= onsoleDxe.inf
   INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf=
   INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
   INF Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.inf
--
2.17.1

--_000_BN6PR05MB3411C72008AE34F4A61B2CA7B9DA0BN6PR05MB3411namp_--