From: "Andrei Warkentin" <awarkentin@vmware.com>
To: Pete Batard <pete@akeo.ie>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: Re: [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Set RPi4 Language supported to English
Date: Mon, 20 Jul 2020 13:42:48 +0000 [thread overview]
Message-ID: <BN6PR05MB3411DF9D276ED4F8697FAC55B97B0@BN6PR05MB3411.namprd05.prod.outlook.com> (raw)
In-Reply-To: <0daaec65-e9b1-dc48-632f-6cdf35c18785@akeo.ie>
[-- Attachment #1: Type: text/plain, Size: 2402 bytes --]
Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>
A
________________________________
From: Pete Batard <pete@akeo.ie>
Sent: Monday, July 20, 2020 7:08 AM
To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>; Andrei Warkentin <awarkentin@vmware.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: Re: [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Set RPi4 Language supported to English
On 2020.07.19 00:04, Samer El-Haj-Mahmoud wrote:
> Set the supported RPi4 platform language to English (US),
> and remove French.
>
> This fixes https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpftf%2FRPi4%2Fissues%2F35&data=02%7C01%7Cawarkentin%40vmware.com%7Cb4f1633a5be240abb30508d82ca599f5%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637308437048337633&sdata=%2BsazEjNWrQkdIvdtPAvzCdCPpYtSaWNuOYzHIaGGdeg%3D&reserved=0
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Pete Batard <pete@akeo.ie>
> Cc: Andrei Warkentin <awarkentin@vmware.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> ---
> Platform/RaspberryPi/RPi4/RPi4.dsc | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index c481c3534263..68c0e670648f 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -1,6 +1,6 @@
> # @file
> #
> -# Copyright (c) 2011 - 2019, ARM Limited. All rights reserved.
> +# Copyright (c) 2011 - 2020, ARM Limited. All rights reserved.
> # Copyright (c) 2017 - 2018, Andrei Warkentin <andrey.warkentin@gmail.com>
> # Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
> # Copyright (c) 2014, Linaro Limited. All rights reserved.
> @@ -352,6 +352,9 @@ [PcdsFixedAtBuild.common]
>
> gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
>
> + # Default platform supported RFC 4646 languages: (American) English
> + gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultPlatformLangCodes|"en-US"
> +
> [LibraryClasses.common]
> ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
> ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
>
Reviewed-by: Pete Batard <pete@akeo.ie>
[-- Attachment #2: Type: text/html, Size: 4284 bytes --]
next prev parent reply other threads:[~2020-07-20 13:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-18 23:04 [edk2-platform][PATCH v1 0/2] Platform/RaspberryPi : Set supported platform Language to English Samer El-Haj-Mahmoud
2020-07-18 23:04 ` [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Set RPi4 Language supported " Samer El-Haj-Mahmoud
2020-07-20 12:08 ` Pete Batard
2020-07-20 13:42 ` Andrei Warkentin [this message]
2020-07-18 23:04 ` [edk2-platform][PATCH v1 2/2] Platforms/RaspberryPi: Set RPi3 " Samer El-Haj-Mahmoud
2020-07-20 12:08 ` Pete Batard
2020-08-13 13:55 ` [edk2-platform][PATCH v1 0/2] Platform/RaspberryPi : Set supported platform Language " Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR05MB3411DF9D276ED4F8697FAC55B97B0@BN6PR05MB3411.namprd05.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox