From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.46]) by mx.groups.io with SMTP id smtpd.web12.2156.1592463682502358516 for ; Thu, 18 Jun 2020 00:01:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=xld33k1n; spf=pass (domain: vmware.com, ip: 40.107.94.46, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g7ihtyZXgt3wguFEAsFr+Y5OWjnFSN5c/DX7n84o8jsnHl/XXu6Pk0usQ5AI7SDaIQus8IshnHZsB3568jMllkX0bg/rxSJzaqet+Ss20Xfh7LELgPfSgTSi8VS77hr1Lege++eMrsZGSBdGPFFWT7kvqAMq3UjxFvomj+aPGI7TGGbtn5egogod6thnE2ZI86RHte/GlqqdJE3VyQ1GmNAVuGeyswRhovXsBFfI0gJ5KgKEU6GkXd2b7vu66dxGNsQcLrwIgyutG6gGwFG8Sd8BrFPTUG7mVf2aFYM7VHjRBsmy7uZB1xKUq5xe8+lxVWSD75AwMe5wuvCk91lM7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RbAfAgbeI2+qV2a33qTlnWj8Fxp2DYbHn3nvFErPaRM=; b=kVu4WbRvXqY3lCHCMELX6IOWJsVxSx6OEASHNMDnKud+3Z3TcUi0noQOl5R19TwkRGMKqb9YDqlV9i/90O+JceXZkk1JS58KoGYZbhsRoHj13WyS1AVn1XGTgosHQhaNiW3WC236d3JwXxIp7dlZ5Fd3Bv2MeqMtPEwMno22wbX0YYQqBUoJBxylMdMd+ADJSHPvj8kWFMnKRIA33Z9JirniO1thhUKwghrXmETG0eUomgpBa3I8+cjD7zz5DJV7xFhNZJtElqiCD7lnM75x5GXRPQescNGQtJj44W3DF+krnr9Zuhgk2HNubrlOzyTekllPKnhSjVNTl7927hnVgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RbAfAgbeI2+qV2a33qTlnWj8Fxp2DYbHn3nvFErPaRM=; b=xld33k1nrATx/eAnL8kz8cqiBpBli3wHe2xWbZAmCtNgQFxUWgpHQvrgesqC0gkOGUPkMviOawkliOLBUDponLKw7UxDUDiumHET3ycLhKF/wuswD0HYdnUw627Z2V9wsYkIAEtfbHk2c86TGRvVT4wPsJq1/UqHo9KcTAwSgKg= Received: from BN6PR05MB3411.namprd05.prod.outlook.com (2603:10b6:405:43::23) by BN7PR05MB5827.namprd05.prod.outlook.com (2603:10b6:408:3d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.7; Thu, 18 Jun 2020 07:01:20 +0000 Received: from BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::e1ef:31eb:c802:aef0]) by BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::e1ef:31eb:c802:aef0%3]) with mapi id 15.20.3109.018; Thu, 18 Jun 2020 07:01:20 +0000 From: "Andrei Warkentin" To: Samer El-Haj-Mahmoud , "devel@edk2.groups.io" CC: Ard Biesheuvel , Leif Lindholm , Pete Batard Subject: Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Add SMBIOS Type 11 Thread-Topic: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Add SMBIOS Type 11 Thread-Index: AQHWRSgnPrUskda+dUGy4lfn8yIObKjd8akt Date: Thu, 18 Jun 2020 07:01:20 +0000 Message-ID: References: <20200618042257.16093-1-Samer.El-Haj-Mahmoud@arm.com> In-Reply-To: <20200618042257.16093-1-Samer.El-Haj-Mahmoud@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=vmware.com; x-originating-ip: [98.214.99.181] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0ab95471-8ef6-4025-4a01-08d8135567ee x-ms-traffictypediagnostic: BN7PR05MB5827: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-forefront-prvs: 0438F90F17 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yrd6jmWgMpDfxBtYlPnlJhaKfdl2JmhivddvxCxNYEng+bQ744A6ZkluGGMJzrJtL6rU8IJbvIExdsjpXudIvLxWzuEnLWTuOgMtMEpeH62DlqlL6q+VHPdsYjYz0yZtNlYiXCqMBX895RhmvIaC9IoVBZreshvbpwqQBaeqZX9hKCoSG8bB2adFdHDLXb23flXr/UkN44PLihwuD8YNKjf8z79m2YVnMYw4tmw/ioLTjbKbzvbUqeYAu9GvnYGGcrCF9N/ZXV/ZYmuxmA8L+kB4/k4hzqFADu1xyqi63Ua876j3qsFUTfKfrwIdJs+NFHRfPByiPfX1gdBznO/g9g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR05MB3411.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(136003)(376002)(39860400002)(346002)(396003)(4326008)(83380400001)(478600001)(5660300002)(33656002)(166002)(19627235002)(71200400001)(66946007)(76116006)(66476007)(64756008)(9686003)(55016002)(66556008)(110136005)(66446008)(86362001)(52536014)(54906003)(53546011)(19627405001)(2906002)(6506007)(8676002)(7696005)(316002)(186003)(26005)(8936002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: 0MmbZDFghj4evj+u57U9IQ0HILjpY7zd0swrlRjGCKDOmKHFce2+pFDDhN7GCbWdsd4FZWylImVD/5mRM0HN0wpE+LJupL3vmJxeraSGJHdPn70Q30Diso9tsVwFa4PO/dIjZz9PNLzk0zTcVmjpoygahDRxRuZy4KdZJaAiGGvvV9GzUWUJjLwv31qeu3HcWUCw0sUhZM6JAOb3N1AJHVy8pm07A1tJSNHNuRVz9aqWhrZD7BmC9mTfMvIAl082z/KMsMKAZXJ3Lc+5REUdQx3AlERCQOaJ14KnrXS67V76T+E8s168ZLUkw7UQMhUMb7t3epJCnA2K4wGKSxmmOvl4iu82KrZ45D4meClsyTuz3ghEWAYuzfWfUS2n6yXH6zoCETGaa3sh4e1m5BT3kqM6ipxS92jSfpv2Q5vVinj5uS5kvIE6KHRHIUBGteBvL+Db7bf7WSiSxFmf3nGnoYppLhoEoVvw2zVLYWp1nQ2nsG93vuiXc66QJAZ6j5wC x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ab95471-8ef6-4025-4a01-08d8135567ee X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2020 07:01:20.8223 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GBe0KSG4RHMyqM33X2XvThL+jWG4D8EE80lWj4dMdhMoAmyI2V1b8ftbgXZOXDbdavfPKIi9CJ6ThOKmSUhiMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR05MB5827 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BN6PR05MB3411EE1CFC0AF27025144667B99B0BN6PR05MB3411namp_" --_000_BN6PR05MB3411EE1CFC0AF27025144667B99B0BN6PR05MB3411namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Andrei Warkentin ________________________________ From: Samer El-Haj-Mahmoud Sent: Wednesday, June 17, 2020 11:22 PM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Leif Lindholm ; Andrei Warkentin ; Pete Batard Subject: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Add SMBIOS Ty= pe 11 SMBIOS Type 11 (OEM Strings) is recommended in SBBR 1.2. Add a simlpe implementation to the RPi. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Andrei Warkentin Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 27 ++= ++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosD= xe.c b/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c index 7b86e76a1248..f336084520a9 100644 --- a/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c +++ b/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c @@ -389,6 +389,20 @@ CHAR8 *mSysSlotInfoType9Strings[] =3D { NULL }; + +/*********************************************************************** + SMBIOS data definition TYPE 11 OEM Strings +************************************************************************/ + +SMBIOS_TABLE_TYPE11 mOemStringsType11 =3D { + { EFI_SMBIOS_TYPE_OEM_STRINGS, sizeof (SMBIOS_TABLE_TYPE11), SMBIOS_HAND= LE_PI_RESERVED }, + 1 // StringCount +}; +CHAR8 *mOemStringsType11Strings[] =3D { + "https://github/tianocore/edk2-platforms/Platform/RaspberryPi/", + NULL +}; + /*********************************************************************** SMBIOS data definition TYPE16 Physical Memory ArrayInformation ************************************************************************/ @@ -854,6 +868,17 @@ SysSlotInfoUpdateSmbiosType9 ( LogSmbiosData ((EFI_SMBIOS_TABLE_HEADER*)&mSysSlotInfoType9, mSysSlotInf= oType9Strings, NULL); } +/*********************************************************************** + SMBIOS data update TYPE11 OEM Strings +************************************************************************/ +VOID +OemStringsUpdateSmbiosType11 ( + VOID + ) +{ + LogSmbiosData ((EFI_SMBIOS_TABLE_HEADER*)&mOemStringsType11, mOemStrings= Type11Strings, NULL); +} + /*********************************************************************** SMBIOS data update TYPE16 Physical Memory Array Information ************************************************************************/ @@ -961,6 +986,8 @@ PlatformSmbiosDriverEntryPoint ( SysSlotInfoUpdateSmbiosType9 (); + OemStringsUpdateSmbiosType11 (); + PhyMemArrayInfoUpdateSmbiosType16 (); MemDevInfoUpdateSmbiosType17 (); -- 2.17.1 --_000_BN6PR05MB3411EE1CFC0AF27025144667B99B0BN6PR05MB3411namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Andrei Warken= tin <awarkentin@vmware.com>
From: Samer El-Haj-Mahmoud = <Samer.El-Haj-Mahmoud@arm.com>
Sent: Wednesday, June 17, 2020 11:22 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>; Leif Lindholm <= ;leif@nuviainc.com>; Andrei Warkentin <awarkentin@vmware.com>; Pet= e Batard <pete@akeo.ie>
Subject: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Add SM= BIOS Type 11
 
SMBIOS Type 11 (OEM Strings) is recommended in SBB= R 1.2.
Add a simlpe implementation to the RPi.

Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Cc: Pete Batard <pete@akeo.ie>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com> ---
 Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | = 27 ++++++++++++++&#= 43;+++++
 1 file changed, 27 insertions(+)

diff --git a/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosD= xe.c b/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c index 7b86e76a1248..f336084520a9 100644
--- a/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c +++ b/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSm= biosDxe.c
@@ -389,6 +389,20 @@ CHAR8 *mSysSlotInfoType9Strings[] =3D {
   NULL
 };
 
+
+/*********************************************************************= **
+        SMBIOS data definition = ; TYPE 11  OEM Strings
+**********************************************************************= **/
+
+SMBIOS_TABLE_TYPE11 mOemStringsType11 =3D {
+  { EFI_SMBIOS_TYPE_OEM_STRINGS, sizeof (SMBIOS_TABLE_TYPE11), SM= BIOS_HANDLE_PI_RESERVED },
+  1 // StringCount
+};
+CHAR8 *mOemStringsType11Strings[] =3D {
+  "https://github/tianocore/edk2-platforms/Platform/Raspberry= Pi/",
+  NULL
+};
+
 /********************************************************************= ***
         SMBIOS data definition&nbs= p; TYPE16  Physical Memory ArrayInformation
 *********************************************************************= ***/
@@ -854,6 +868,17 @@ SysSlotInfoUpdateSmbiosType9 (
   LogSmbiosData ((EFI_SMBIOS_TABLE_HEADER*)&mSysSlotInfoType= 9, mSysSlotInfoType9Strings, NULL);
 }
 
+/*********************************************************************= **
+        SMBIOS data update  TY= PE11  OEM Strings
+**********************************************************************= **/
+VOID
+OemStringsUpdateSmbiosType11 (
+  VOID
+  )
+{
+  LogSmbiosData ((EFI_SMBIOS_TABLE_HEADER*)&mOemStringsType11= , mOemStringsType11Strings, NULL);
+}
+
 /********************************************************************= ***
         SMBIOS data update  T= YPE16  Physical Memory Array Information
 *********************************************************************= ***/
@@ -961,6 +986,8 @@ PlatformSmbiosDriverEntryPoint (
 
   SysSlotInfoUpdateSmbiosType9 ();
 
+  OemStringsUpdateSmbiosType11 ();
+
   PhyMemArrayInfoUpdateSmbiosType16 ();
 
   MemDevInfoUpdateSmbiosType17 ();
--
2.17.1

--_000_BN6PR05MB3411EE1CFC0AF27025144667B99B0BN6PR05MB3411namp_--