From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (NAM04-SN1-obe.outbound.protection.outlook.com [40.107.70.66]) by mx.groups.io with SMTP id smtpd.web12.6368.1601179133357305656 for ; Sat, 26 Sep 2020 20:58:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=eZbJAOdC; spf=pass (domain: vmware.com, ip: 40.107.70.66, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RNm3CsBH/AKaoHfwAP5A7PwaFC9BDqMuPxobJXcyb/L2Zv3F4NekqTlu0e6x3TqGiy48E3uJ5CjuAdAUvjqpG8kLSHbiXGGp5vBznfxW8TVOVHvdvC4WbytMuS3+0SljQauqXhLsSXwvgGXkI4qg2GNfKNOrDf0qB19O5UbYbCAQVh8mrQyayCj/m4h+DEsVVvDxzTtLJjKc3rEHqJ5+PEC2fwNP4X/YajyNFTPKAFhosr/S0M5IzRqVmhK3JYEfvx3bIqg6gfe86vXeLVPyH2Giv3lRVtju5/NhcRQsV3rtQODewYTcdOCs+Ge2ULNqm3+li9eNG9zF3bFgaQT4eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qNpGRj/SbMICF9c/LSYQwEfCcauut0sk/LPi1qRrnZc=; b=amRk8gWOEnu9cvy/FDF+OG02FCDdxtl8AUaD8SaaO5+WcH5X2nl2+/7iZWrUNYZewKyivqln+evyMDsimVLNUEUSQ4fPPGYcbApuviftm1DLXjJ9MQ9tu8tl7vZ31QeOH0beq/rnSOkU54H2c2rxLZPnP+3UCI/x6Vyl9vLM71E1XombgfLF1YI5PKH26TzaGzqM3PdllYFwg6dOQ2HJWHb+MQ/i0Y2NhR2HlYXVEkPOAlq4hGgHsU0bZ0V8cLRPfttTSoyVPdvVit5YOY3HWCrsnp6idWU8x2A15lhYETgQIx62qnDbo/+gURKu2W6mbJ4t2iBh7k/de8LbRoIUkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qNpGRj/SbMICF9c/LSYQwEfCcauut0sk/LPi1qRrnZc=; b=eZbJAOdCfXgev8ZXXrxaON1NzwzMtd5BfqX/JyMOibwigEHo2hKTs490fJdpApkCU5agwm+/d1p+3RbJ9uj0qEVpwBFwpMl/T8eheDWqed0pcCzUhUM7LWTIOTO+YmQ9LeYaELUqWkD6I7R0JWGy47g4sjK6IwCLprCv/nxriWc= Received: from BN6PR05MB3411.namprd05.prod.outlook.com (2603:10b6:405:43::23) by BN3PR05MB2435.namprd05.prod.outlook.com (2a01:111:e400:7bb3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.14; Sun, 27 Sep 2020 03:58:49 +0000 Received: from BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::b03c:e0bf:2c43:f362]) by BN6PR05MB3411.namprd05.prod.outlook.com ([fe80::b03c:e0bf:2c43:f362%2]) with mapi id 15.20.3433.026; Sun, 27 Sep 2020 03:58:48 +0000 From: "Andrei Warkentin" To: Samer El-Haj-Mahmoud , "devel@edk2.groups.io" CC: Leif Lindholm , Ard Biesheuvel , Pete Batard Subject: Re: [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Fix RPi4 RngLib build error Thread-Topic: [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Fix RPi4 RngLib build error Thread-Index: AQHWlBSz6XLZga2fQEmk464eXz9PJql73KNF Date: Sun, 27 Sep 2020 03:58:48 +0000 Message-ID: References: <20200926145230.5332-1-Samer.El-Haj-Mahmoud@arm.com>,<20200926145230.5332-2-Samer.El-Haj-Mahmoud@arm.com> In-Reply-To: <20200926145230.5332-2-Samer.El-Haj-Mahmoud@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=vmware.com; x-originating-ip: [69.174.145.89] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c5e65b31-b6e4-46d2-6847-08d86299a3a5 x-ms-traffictypediagnostic: BN3PR05MB2435: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1751; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: inl46UeIlADFgDETY+lq6DnvdFmcHQmQ3q3mGakrQFITqg00UWt47HxZE9I2H/sAz2ns3+PTMQ/5rzZIZS7yM1U3ahX6PQYEr0Kg1JopSl4CeWDHhoLMbeZbyzbF1oLRvR3xO/QuGDhMwvu4e99EFJ3+fesNdoHR2n3oH0JzB2D1epalqWyACN+YLAl4RQUZtJNUUzrlm1zyUDm/AuyitHYLOM9+ig6NQeNbTGibnwD/SxVLMjJKM7qIUsCsIZaFRZbjg6egzLYAA1k7kWivPeaVjZAMgKDLC4P1Qr4icUvYsYaqpG2GKgtGvwr29EeOeFuVkRC/qW1TF+2SQdk5lg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR05MB3411.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(346002)(39860400002)(366004)(396003)(66476007)(54906003)(76116006)(71200400001)(66556008)(110136005)(7696005)(6506007)(5660300002)(2906002)(26005)(186003)(66446008)(52536014)(19627405001)(53546011)(19627235002)(86362001)(316002)(33656002)(55016002)(478600001)(66946007)(8676002)(4326008)(9686003)(8936002)(64756008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: fThfpeunun9KGjS8Qjv2wW0XMow1n/YsF8XCV4JYsqQ8vV9afZZMPliriJu0Kv0CbLt04LAFritZ6wSLFlhtqEimDIO26hXqfaXGmH2lqyre6Bz8VFsbVY91JnLbVid5ebEt8jEiJkx7JrxC9pGUouaakNRDGn6/nx4k0TX5WKtul9ixoe8sPdYLEmSViJ1tDiYE53L8AWpWkjJTnSlrQiUf2hLxKbL1pcLo2wK7YOsXAUT3iPGB2Mq0J1tmbDo5FcBx9dgi06cwxWqike/29Fd7AJoL/3Ag4kisCQmiUhJN9Y0EyoO3lcHwazX0o0UQXrifMfC78Ct3riYLitQllp4G6dvWeE1Mu8OLAlvWNcPqw52AOgQswognTwF7hfeJ93FISajkbGlhdB+hizzn+0MVYRkr7xMaryiuzlVxLsafi6vAX247zS0NjxOUMKxIsUCA6oMljrKhtf1EUwT0h9asc4VVyu4S/KMOQnWPtgdVHQZrSFYTUXEPUCv37jXVQitHo0XbkbKtFTogm7ipbSfLlYScfEujoC9/ZyKKZMARk9dC3BryEeW67Eq2tYE2IdYrgp9wdTwk+d4oqiYXOWvHwRWTOeJVFCPFFaF2Ywd9fkaXuF2gfiywcGNi/+frORs7ajZSzqA9oDDBbdzfUg== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR05MB3411.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5e65b31-b6e4-46d2-6847-08d86299a3a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2020 03:58:48.6090 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kjfpPYIhoYli2g72gt3Y8+4MnHx/3mdH3V3j29Ll0EtF2L+y2y/TmoCBNbbuav9egfypYLlveU7n+nkX/cfo3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR05MB2435 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BN6PR05MB3411F984609BD017BC74A6FEB9340BN6PR05MB3411namp_" --_000_BN6PR05MB3411F984609BD017BC74A6FEB9340BN6PR05MB3411namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Andrei Warkentin ________________________________ From: Samer El-Haj-Mahmoud Sent: Saturday, September 26, 2020 9:52 AM To: devel@edk2.groups.io Cc: Leif Lindholm ; Ard Biesheuvel ; Pete Batard ; Andrei Warkentin Subject: [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Fix RPi4 RngL= ib build error Commit b5701a4c7a0fb185e0c5b9db9525939c78664bfd introduced RngLib dependency for OpensslLib, and caused the RPi build to break for lack of an RngLib instance. This patch adds RngLib using the DxeRngLib flavor, which is a wrapper around the the EFI_RNG_PROTOCOL that the platform already produces. Tested booting OSes and running the SCT test for EFI_RNG_PROTOCOL. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi4/RPi4.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4= /RPi4.dsc index 823c9fc007d4..c994f56d658d 100644 --- a/Platform/RaspberryPi/RPi4/RPi4.dsc +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc @@ -130,6 +130,7 @@ [LibraryClasses.common] SerialPortLib|Platform/RaspberryPi/Library/DualSerialPortLib/DebugDualSe= rialPortLib.inf # Cryptographic libraries + RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf -- 2.17.1 --_000_BN6PR05MB3411F984609BD017BC74A6FEB9340BN6PR05MB3411namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>
From: Samer El-Haj-Mahmoud = <Samer.El-Haj-Mahmoud@arm.com>
Sent: Saturday, September 26, 2020 9:52 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ard.= biesheuvel@arm.com>; Pete Batard <pete@akeo.ie>; Andrei Warkentin = <awarkentin@vmware.com>
Subject: [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Fix RP= i4 RngLib build error
 
Commit b5701a4c7a0fb185e0c5b9db9525939c78664bfd in= troduced RngLib
dependency for OpensslLib, and caused the RPi build to break for lack
of an RngLib instance.

This patch adds RngLib using the DxeRngLib flavor, which is a wrapper
around the the EFI_RNG_PROTOCOL that the platform already produces.

Tested booting OSes and running the SCT test for EFI_RNG_PROTOCOL.

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com> ---
 Platform/RaspberryPi/RPi4/RPi4.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4= /RPi4.dsc
index 823c9fc007d4..c994f56d658d 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -130,6 +130,7 @@ [LibraryClasses.common]
   SerialPortLib|Platform/RaspberryPi/Library/DualSerialPortLib/D= ebugDualSerialPortLib.inf
 
   # Cryptographic libraries
+  RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf
   IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf    BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf    OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
--
2.17.1

--_000_BN6PR05MB3411F984609BD017BC74A6FEB9340BN6PR05MB3411namp_--