From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on060c.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe48::60c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C33AC21BBC439 for ; Thu, 22 Jun 2017 02:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cadence.onmicrosoft.com; s=selector1-cadence-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ds5wKOpjwf6c8TGbqf2UkclJ+JsaLnQTqmvsan4CbjM=; b=gxA+K1O/ZCuGPYYjCRZrw1t60RqXLy4gY8G4WxC41Vvz4vC3DpXP5ibTkuE41bXemtlFJ3s8f6QFOZARQNesoghysT0muY5Kb7cBt8H3rdByT7TCygSGeNeUPYEWZg2ftI9UU2YXprgtf10zE194Wb5ZuKhQtx7AjygffdWq0dg= Received: from BN6PR07MB3154.namprd07.prod.outlook.com (10.172.105.136) by BN6PR07MB3156.namprd07.prod.outlook.com (10.172.105.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1178.14; Thu, 22 Jun 2017 09:24:13 +0000 Received: from BN6PR07MB3154.namprd07.prod.outlook.com ([10.172.105.136]) by BN6PR07MB3154.namprd07.prod.outlook.com ([10.172.105.136]) with mapi id 15.01.1199.016; Thu, 22 Jun 2017 09:24:13 +0000 From: Scott Telford To: Leif Lindholm CC: "edk2-devel@ml01.01.org" , "ard.biesheuvel@linaro.org" , "graeme.gregory@linaro.org" , "afish@apple.com" , "michael.d.kinney@intel.com" Thread-Topic: [staging/cadence-aarch64 PATCH v2 1/6] CadencePkg: Add libraries for Cadence CSP platform. Thread-Index: AQHS3emgj8JHsAApFk+u1As32N4eCaIWgaoAgBjw3/A= Date: Thu, 22 Jun 2017 09:24:13 +0000 Message-ID: References: <1496659828-28702-1-git-send-email-stelford@cadence.com> <1496659828-28702-2-git-send-email-stelford@cadence.com> <20170605171118.GT7556@bivouac.eciton.net> In-Reply-To: <20170605171118.GT7556@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcc3RlbGZvcmRcYXBwZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZiODRiYTI5ZTM1Ylxtc2dzXG1zZy04NmQzOWYwZS01NzJjLTExZTctOWUwOC01ODkxY2Y3N2FjOTRcYW1lLXRlc3RcODZkMzlmMGYtNTcyYy0xMWU3LTllMDgtNTg5MWNmNzdhYzk0Ym9keS50eHQiIHN6PSIxNDUwIiB0PSIxMzE0MjU5NzA1MTY2NDI3NTgiIGg9InJtU1hWSnIxa1VuQ04ySk12TzFGQVJNWDlOMD0iIGlkPSIiIGJsPSIwIiBibz0iMSIvPjwvbWV0YT4= authentication-results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=cadence.com; x-originating-ip: [213.131.238.28] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BN6PR07MB3156; 20:xTVXRLvUoie9WiRptBqCEw/27l5mSaCIC2FFiv8Mhta23v9rXKy8aidNJ840bRMeumh/aZpxQsRYQzr+6aDdpZd3ZOMkmAQdFaZlQ/6PTcU5JKnbsmSeDMziawFcl2yrYT7rDNnh1wDrJq3zrS+Vx1gu78q1KxomQU/xX8Nz6j/xw3CVM44WQVLfZdox4gqEdOOBM+scaoOuRuhSja1+BL3BbZ0/7CowYWdMkVIMIcfubtETS8NTpAC+fkHeRSJd x-ms-office365-filtering-correlation-id: 8eb6bd87-52a8-4790-cc3c-08d4b9507247 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075); SRVR:BN6PR07MB3156; x-ms-traffictypediagnostic: BN6PR07MB3156: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(31960201722614)(72806322054110)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6041248)(20161123558100)(20161123564025)(20161123555025)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR07MB3156; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR07MB3156; x-forefront-prvs: 03468CBA43 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39410400002)(39450400003)(39400400002)(39840400002)(39850400002)(13464003)(110136004)(77096006)(53936002)(6246003)(229853002)(189998001)(54906002)(55016002)(8666007)(38730400002)(99286003)(9686003)(53546010)(14454004)(3660700001)(86362001)(6916009)(2900100001)(2950100002)(3280700002)(2906002)(8676002)(81166006)(5660300001)(7696004)(122556002)(7736002)(8936002)(25786009)(33656002)(305945005)(3846002)(6506006)(6436002)(4326008)(76176999)(478600001)(74316002)(66066001)(54356999)(6116002)(50986999)(102836003)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3156; H:BN6PR07MB3154.namprd07.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: cadence.com X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2017 09:24:13.0506 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3156 Subject: Re: [staging/cadence-aarch64 PATCH v2 1/6] CadencePkg: Add libraries for Cadence CSP platform. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jun 2017 09:22:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, sorry for the delay in replying, got sidetracked by other issues. > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: 05 June 2017 18:11 > To: Scott Telford > Cc: edk2-devel@ml01.01.org; ard.biesheuvel@linaro.org; > graeme.gregory@linaro.org; afish@apple.com; michael.d.kinney@intel.com > Subject: Re: [staging/cadence-aarch64 PATCH v2 1/6] CadencePkg: Add > libraries for Cadence CSP platform. > > + > > + gCadenceCspTokenSpaceGuid.PcdPcie1RootPortBaseAddress > > + gCadenceCspTokenSpaceGuid.PcdPcieRootPortBaseAddress > > + gCadenceCspTokenSpaceGuid.PcdPciConfigurationSpaceBaseAddress > > + gCadenceCspTokenSpaceGuid.PcdPciConfigurationSpaceSize > > + gArmTokenSpaceGuid.PcdPciMmio32Base > > + gArmTokenSpaceGuid.PcdPciMmio32Size > > + gArmTokenSpaceGuid.PcdPciMmio64Base > > + gArmTokenSpaceGuid.PcdPciMmio64Size >=20 > All of my comments from round 1 have been addressed, apart from the > paragraph of Pcds above probably not being needed. > That's not actually correct at the moment, but if adjusting the memory > map setup based on Ard's comments, I think these could go? Some of these are actually still required as they are used in ArmPlatformGe= tVirtualMemoryMap() in CadenceCspLibMem.c. Regards, Scott.