From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.2845.1612410672762253376 for ; Wed, 03 Feb 2021 19:51:12 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=OAiPcAVo; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: vWl0lSouSBD7C8U3z772SGaqu8D3P55TAMVOktJGCh5dknUnEJSk+OaG/jidcmjUVbNTmdjZgQ OUEtKbtH1r4A== X-IronPort-AV: E=McAfee;i="6000,8403,9884"; a="178605113" X-IronPort-AV: E=Sophos;i="5.79,400,1602572400"; d="scan'208";a="178605113" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2021 19:51:11 -0800 IronPort-SDR: gxnwLVWB+p8+BQ3SOAyQMrunfdoQwUNFaYjM/3yjiUOcclX718FPV2jWwVWyCAyb8Uj6N9hfvg 5gFFjAEdiUeQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,400,1602572400"; d="scan'208";a="357016674" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga003.jf.intel.com with ESMTP; 03 Feb 2021 19:51:11 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 3 Feb 2021 19:51:11 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 3 Feb 2021 19:51:10 -0800 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.57) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 3 Feb 2021 19:51:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m00RfryOZqumbOPBEWqvBJSWqORWYo30sVHu5afoPERelx1uUJrKbB1yUgLmJJrjei3nNbaxshYVon/PsE7msyzIBtqRvRmxlbMu1cxY7z5cE+IagtzubAlnRRdQUkrcRtHIrtkXEN2AhbGAVh/A2Sg1Bq5GE4Oq7mEv6OZSuMBhqrFwFwfctU4iMvxNnzZERCfWf3Pig31DUHjmZ7QupkYqFnrEdYFp6Ry3e7NE3CHvgTOdHfHWGkcZkx4IUk1v7TjlzHpE5DBLReewgMXfpUZ0Viu54I38yaaNrLBLolUaAGziNAi9E0TX+kNMwAlODNW3C+zfiq0+KVyZMp5eWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qpbq3sNfNOKJMrBQNkH2BhDppthXv1f97p6MxdApL0s=; b=iU/4GV3hoTY4xM+QNThNZXjlC8lT32+z8UXRAfGLJFyV94J9tB+t9SO8icrf0g7xTnxGHs6XAC+bPpL8ZqASq9e2mHtAQfN0vSTCrX+vaiC/nOnjGkJHRu9Y+R3jVYnGEA5wD9uQkl9BToaZD+AYX9AA4EWBCzQmBwjUJKt+efN7lgPa+0RGYk83Gftt22j66wev/mcYevyemgHRnc9Dr72yI1FSMbB+tXS3365UKw7x4pHLL9SeAUXVMKQZ5VrzckoORK7Do8LUbBIr803v7cpsuZbB4iSlI//HbQ2czkEW5p0srUKylt7jYB/Rl/LBjGirN2yEC5oJMSK39ZPuaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qpbq3sNfNOKJMrBQNkH2BhDppthXv1f97p6MxdApL0s=; b=OAiPcAVo2PcYmUGtqLmnqbCxK159zNY9s8T6xS8FAzPJGfu5E/CWyh8Vq3N0YAvlWFXxgzWc2jFiJKC+hOIwsQ6VJAAzM7iybav7Npgh1UoY1GZnZUcwm7o1T32oecsw1VcluNdlGFpO3QmVNvMemzpyN4CPAi/BBUf5kmLFgZo= Received: from BN6PR1101MB2147.namprd11.prod.outlook.com (2603:10b6:405:57::23) by BN6PR11MB1329.namprd11.prod.outlook.com (2603:10b6:404:47::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.19; Thu, 4 Feb 2021 03:51:09 +0000 Received: from BN6PR1101MB2147.namprd11.prod.outlook.com ([fe80::203e:ed6b:a572:6453]) by BN6PR1101MB2147.namprd11.prod.outlook.com ([fe80::203e:ed6b:a572:6453%3]) with mapi id 15.20.3805.024; Thu, 4 Feb 2021 03:51:09 +0000 From: "Nate DeSimone" To: "Luo, Heng" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" Subject: Re: [PATCH 40/40] Maintainers.txt: Add TigerlakeSiliconPkg maintainers Thread-Topic: [PATCH 40/40] Maintainers.txt: Add TigerlakeSiliconPkg maintainers Thread-Index: AQHW+Drw7kiE8O/OSk+31K6gjjhY4apHXaog Date: Thu, 4 Feb 2021 03:51:09 +0000 Message-ID: References: <20210201013657.1833-1-heng.luo@intel.com> <20210201013657.1833-40-heng.luo@intel.com> In-Reply-To: <20210201013657.1833-40-heng.luo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c50c3979-ec30-458a-671a-08d8c8c01b8e x-ms-traffictypediagnostic: BN6PR11MB1329: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oEa2tmwzBzX67va51Yt5tOIBH7qQCG9ElvtMWblReWXXRw8SN2e6DLhIhPPwb6wJAP9cONH9bR++1vtKaiRyk1pH6e/j4HK9KPArP0g3Ul0RG6fmMO1d2sF0rWO+7cdOHzpLoQlAAHoxRlKNCDNTjz0nvuxHan0MPBaqTzV6dJzlj3nfiGNqr0eHNalqngv3MNeC03LPZ37gSOe4g3ri773Nkm7O6d6TytcgjdWZMa2IX3xlxIceTjlJNeoBTeCbB4Ou/V08XeDqVQwcX4NUSNpr/YzZ9N2INyQgvaVxykfD7qiOO7pV0RaQGqVqcGRJ+xxyX5H3aRXef+b+MTdp7ArcpRJBtTxCkPiAMpCg/Q9hFhq8xWt+JAlvsZGJ/EAlQ5eE2F6z/YnY6ex6Cr3MCQJGmH14knxEKwv+8aIjGS4u8A1qkMA30TTQ1Y5meGqgz/dTqj+QcxOT6IQ1SjhOcRZNYOPSc/MK2cjIkBe6qOlgWSFZE//D0/q9W3kY9jm8joNYkKOv590fBUDUQHy1dEvLtdQZD41LgTaZT8nxDf1Ew4HAuYdpYOHFwFQoqdvx2etzo8b0qfgfnRmKQKUkMFPs3wXLPau3r+StwvXTHDY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1101MB2147.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(346002)(136003)(366004)(376002)(39860400002)(7696005)(966005)(52536014)(86362001)(83380400001)(76116006)(66476007)(9686003)(66446008)(8936002)(26005)(107886003)(478600001)(19627235002)(5660300002)(64756008)(4326008)(186003)(110136005)(55016002)(71200400001)(66946007)(8676002)(53546011)(33656002)(2906002)(66556008)(316002)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ZOroFqgfbHJYAlI6NdddiPCnSHkh7PvbonVDwGkgUjMEM3cbEs18LooyoZvj?= =?us-ascii?Q?F5ALn9oBduM743wQSrvhuT7rZznsIHeoXax69NXgG+gnqIkA2JgQx3jlDjy7?= =?us-ascii?Q?1hxis4wM7O5WAryd8h2VWmMbjvr4UEUZo4vr/AZ49NkMkh4Go7q5t17OA9hX?= =?us-ascii?Q?aVARCzIcEg+KgqEIzu27y41AXcSfIgSdgB74hFz63VmALhii3io3tt9ECE6R?= =?us-ascii?Q?HKxSZzlJKxukXuRJdds44YE3oB1QlOagR2F0X4+bexdNfI9AnaXwAC05x7bc?= =?us-ascii?Q?fPnTTi1Zc4dJXy3EySpkRtdZxd4TBSYFs4NCzgqXw308Q9BJaxfkCym+BygD?= =?us-ascii?Q?GcDPqn6lCMCF4sEPjfOgZnJnxhjQto6h/rlV6GJvPIcW3N+Z6oXn86+QwNAU?= =?us-ascii?Q?UKYKZDR4Lowa43JAVMsCFPK8QgrTWJCjSrDFPPvcfLc3ry5GodE+/+q9NQPd?= =?us-ascii?Q?UwF2K/XFCJt5g+NRpFdDrnQOJOfeWgEpU+4mqt7RWknIx7R58IcJ5Hre/O/0?= =?us-ascii?Q?1HkGLW6nqwf9PtsDESP8oL+iDeprCcjZIR608azOiUcwLkVk5RK41O9pTLOD?= =?us-ascii?Q?wJQR52B8PFp3/rjXcVxpmZjgpk2pwW6/yB61i01P40MExoA6sape9T0/XsKF?= =?us-ascii?Q?vlQQ9utD6/z6yxnv25CSgnu5JLcCqgyUj/Ticu/jGuQfB15mtUIrZeW5Nl72?= =?us-ascii?Q?suNqrtMbGVRp7Rq6K8hHzW7pSfc4GZ3XlKU5FjrtUjF0sIaZ6fcq7BEUfhdj?= =?us-ascii?Q?1SpUpDvKd/snul88324G8nfWKJdnccpLLAylGDDTkCV1dl9OWYy96nqtTEYy?= =?us-ascii?Q?ynvSIlMbM4+p8qreoPnI5ClBocopl8G04suod11WgI+qIms4PYMLN5yD3AcP?= =?us-ascii?Q?y47kiv7RH6vNXmcF+hG0W7SBuEpZMQpwL74igms+jRr8jj/gtNfJyrfJSHj+?= =?us-ascii?Q?1IcHOye4kvklsku/+6E9vz1sFQcs5BBe/ZSaE1ymPxjBA0+J/RxdUvoNUYXE?= =?us-ascii?Q?TR5rdb5P2NJUEJ7OC0IdEwZQjc/M3pm2HeS3NV3WTtw5yPbgFsmP+CC0RnYO?= =?us-ascii?Q?mxe3acPMVB9PulVFWzfCjSHFLr2BcWUtXDPqSrBgTVfFlRC/XUN8c0M2mN+l?= =?us-ascii?Q?rNbETmJxHURz3qYzoScg6dQhJRfh8np7k69Wr+wpGmeyD4YbrY1Bsc5X+FwP?= =?us-ascii?Q?UdiZNRG1ix5ZFjkjQvKjZlLr4yC1LEAk10bETIIQqmQHGWDhzDdIA/2mpW4T?= =?us-ascii?Q?JSZGYPHsoVJYcZjRLuGOnc7RG6OcFt6H5QcIamvkIUX7JFtJvbtrta+D4H/A?= =?us-ascii?Q?stl0YLNEXvUYXcNWOOHE1mgK?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR1101MB2147.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c50c3979-ec30-458a-671a-08d8c8c01b8e X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2021 03:51:09.3419 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KisHU+69FNZBDhhT9G+tSUon3gHXBil2gPHRY8szOGveXBXvRK5JCt95IUP3tm9Mity7N0zivd8XcTrzskY3Yz5GLIiG4FrTvGztJcDGidA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1329 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Heng, Thank you so much for all your work on this! I have a couple of minor comme= nts, however due to the size of this patch series I produced a summary of t= hese comments here for your convenience: [PATCH 01/40] #1) CpuPcieConfigGen3.h is only used on Rocket Lake boards for backwards so= cket compatibility with Comet Lake. It is not needed for Tiger Lake. Please= remove it. #2) CpuPcieConfig.h - CPU_PCIE_CONFIG Is missing the following from its def= inition: CPU_PCIE_ROOT_PORT_CONFIG2 RootPort2[CPU_PCIE_MAX_ROOT_PORTS]; PCIE_COMMON_CONFIG2 PcieCommonConfig2; [PATCH 02/40] #1) FspmArchConfigPpi.h is a duplicate of a header file in IntelFsp2Pkg, pl= ease remove this duplicate #2) SiPolicy.h - Please also remove the #include for CpuPcieConfigGen3.h [PATCH 34/40] #1) DxeSaPolicyLib.c - There is an old comment that is no longer relevant, = please delete. #2) DxeSaPolicyLibrary.h - Please also remove the #include for CpuPcieConfi= gGen3.h [PATCH 35/40] #1) DxeVtdInitFruLib.c - Comment on line 2 has a typo "Flu" should be "FRU" [PATCH 36/40] #1) PchSmiHelper.h - Comment on line 2 has a typo: "eSPI SMI Dispatch heade= r" should be "PCH SMI Helper Header" [PATCH 39/40] #1) SiPkgCommonLib.dsc - The DEFINE PCH =3D Cnl is unused, please delete i= t. Thanks, Nate > -----Original Message----- > From: Luo, Heng > Sent: Sunday, January 31, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH 40/40] Maintainers.txt: Add TigerlakeSiliconPkg maintaine= rs >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3171 >=20 > Cc: Sai Chaganty > Cc: Nate DeSimone > Signed-off-by: Heng Luo > --- > Maintainers.txt | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/Maintainers.txt b/Maintainers.txt index 56e16fc48c..34f0b585= 81 > 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -242,6 +242,12 @@ F: Silicon/Intel/KabylakeSiliconPkg/ > M: Chasel Chiu M: Sai Chaganty > +Silicon/Intel/TigerlakeSiliconPkg+F: > Silicon/Intel/TigerlakeSiliconPkg/+M: Sai Chaganty > +M: Nate DeSimone > +R: Heng Luo + > Silicon/Intel/SimicsX58SktPkg F: Silicon/Intel/SimicsX58SktPkg/ M: Agyema= n > Prince -- > 2.24.0.windows.2