From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.3263.1613010126291601268 for ; Wed, 10 Feb 2021 18:22:06 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=mGwh6kaW; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: f+VDn5hvopKuUrVYPjdxW9isNzkUpmh1mUK9BSVRW+OXjPzCG2yK9DFhcnyJhFPv97AJ1iSHJU xKNoyv84blmQ== X-IronPort-AV: E=McAfee;i="6000,8403,9891"; a="243671611" X-IronPort-AV: E=Sophos;i="5.81,169,1610438400"; d="scan'208";a="243671611" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2021 18:22:05 -0800 IronPort-SDR: zjvJuWUK/lN/as+yCEU7Gxg7NEmYm3cQO4YuitIjMVCXtdxuCX7f6Ex3gF/JMVzAkRNIwY9apn pHnwLe/rlpQQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,169,1610438400"; d="scan'208";a="362355536" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga006.jf.intel.com with ESMTP; 10 Feb 2021 18:22:05 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 10 Feb 2021 18:22:04 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 10 Feb 2021 18:22:04 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 10 Feb 2021 18:22:04 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 10 Feb 2021 18:22:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ChPP3mbp+18xlOSbaY7QR5tf02ZyRIiIn2WxRt4iAbLyc/YpJmMFZRoiYLU+bsT696kTa9A5A4nb3OM+s3t8XxQUIgnkaeEB3hZcdCj4qbUaltEZJ7Aj0nqzAs3lyxBKsAV4q6QqHGG+wru1naGpPJPs/sgvRP9OtxspAz0w4LJNnzuCQxcZ46j2iMrOAYlIzFdzRn9hK7jrUDEQ5I1q66sXQVHolO2DTv7u/K3LGFglK+ck/eXGKG8n26gE2prORcRxw6ghM/HpUxqmc0H+EGRLmjRAz0xg9pxZrIftW7rZZjtv1EbTyENeTL7k0ZzKTCj7qBZc99xWgRLcHeDglQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hYN9mR6aN1NVDmsIggsNlw5w41kKOsrNDWWzeCr8LcU=; b=S9hFOHG89xL+cEmEGtmzOgOASVsQbN0nR+iON/IlJQmR3NB+DNgZFX9Xjr0tVhrHN7Dr/WVjM6st62ynyANe0NAxH3t9cgQMtBHmQ6ciPemsKTK0m6rV9nSGBQynkceBsGBH2BAplC1eFOQXa7+Hwz5UwfkWiatNcNiW94K3nn9IwbvQnJ8a79ATdJUepa0+/72pmbbwY0fj7rZOpQZlyDAnwyAMR4VjvQTv8N41OQlGZX44FGxqDiur6epEmFEs6/DjAA0E8mBDiYlq9T1UIUXaw6D9M1LCYgv/g1HyE6qPTjrgq2bSUWqmqCOZOBGc3kF9R0BxjyjWbpuxMdsPaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hYN9mR6aN1NVDmsIggsNlw5w41kKOsrNDWWzeCr8LcU=; b=mGwh6kaWJEDbBcSLb3NuFaIycwEFR4WCA07JeF2v/Dk7uPHCQeiTUbwUOmdzunDGxZA+E7UuEmgy22kn0e3F68BVKsd5taSEz/inWEbYvqHxeOry/gQwWdPc2k96r/jVLGOnlYvtG/bh7+rMaZIn97gClXFKzgLr2IwEgscW5/U= Received: from BN6PR1101MB2147.namprd11.prod.outlook.com (2603:10b6:405:57::23) by BN6PR1101MB2148.namprd11.prod.outlook.com (2603:10b6:405:52::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.23; Thu, 11 Feb 2021 02:22:02 +0000 Received: from BN6PR1101MB2147.namprd11.prod.outlook.com ([fe80::203e:ed6b:a572:6453]) by BN6PR1101MB2147.namprd11.prod.outlook.com ([fe80::203e:ed6b:a572:6453%3]) with mapi id 15.20.3825.030; Thu, 11 Feb 2021 02:22:02 +0000 From: "Nate DeSimone" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-platforms][PATCH v1 1/3] MinPlatformPkg/SpiFlashCommonLibNull: Make MODULE_TYPE BASE Thread-Topic: [edk2-platforms][PATCH v1 1/3] MinPlatformPkg/SpiFlashCommonLibNull: Make MODULE_TYPE BASE Thread-Index: AQHW/B06TeXxsCD9EUa4BKHVHMG0BapSQQfA Date: Thu, 11 Feb 2021 02:22:02 +0000 Message-ID: References: <20210206001507.1224-1-mikuback@linux.microsoft.com> <20210206001507.1224-2-mikuback@linux.microsoft.com> In-Reply-To: <20210206001507.1224-2-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 511786d1-7684-4de9-1779-08d8ce33d1af x-ms-traffictypediagnostic: BN6PR1101MB2148: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: azwG4Jg+ftTxlQBiM9U+HdCQqHFdCXREFSF+L+JeZdOsYohbrXD0MQP4HUMioKnyDxrhpOc513YF8yMmjqLpnIAQvyr3ISWO7V3HlXgOJGvwUyvvprSHv7OpXAICSo1I36WjlmnqMAbPNTMderDMI7kiMnnlBqBRmG+UtgcEaLn6/J5M2a4geNby5Qam5qzroSoKiqzpIs35B93GsOkyHSeH1j4Ea3rLCgd7KFvK8OB7wDieI1XtkKGLzKSlmv4G06/4+PHxj+csf/zEojhEDRZlVRvF+9HYaO4pdIGLXQ/NV092hsnvmSn539mtwimZt6INXDmmoXM/+cyisvKnxBYyUP2hixm80cdbpjEVlJnnjTxCV5uA/1WtcBdaZcfJ6mqeuIWaC7jKNJuq/yCrnxa0x+0Cxf8NYRjQQWL2fjjw3JPSjOtbk4ol0EjLtJrOb1KUBaBWcb1rQNhW/m/y8k7IU1yIjUa4I/TbN4EYRbi+AOGyXs5iUXrkSCBDMfUGUIktYmBxy8EEPPe8vQ2AQHKjXOJzDess2XcaPSJpAzN7V7eOjd4ioXhWZ01Y32Ou x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1101MB2147.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(396003)(346002)(39850400004)(376002)(366004)(52536014)(7696005)(64756008)(2906002)(66446008)(9686003)(33656002)(5660300002)(478600001)(76116006)(66556008)(26005)(186003)(86362001)(66476007)(8676002)(83380400001)(55016002)(110136005)(316002)(54906003)(6506007)(53546011)(4326008)(8936002)(71200400001)(66946007)(107886003)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?SD222ipKJ/wkLYIdfUCthNuvyzy9YYyD20xVo1eJqUfkQF4SuAFmot19Z5eU?= =?us-ascii?Q?08u890ewMpK9FF52X7zUMvbUSicajdshlUQYWKn09LXiUzDKvQMll7IINHcn?= =?us-ascii?Q?cNQQrhWhh5l9LY9I9IINFrD1pLhw1gD1ahwBfqwerow2WZfutZB7bXVZdQX+?= =?us-ascii?Q?lxUMf9fFYeA/DoCsEhI9P6/FlqRq7alWHvROB/4nUwzU45DJJaNDU8VBGReN?= =?us-ascii?Q?I3AEZBUywF1hwaRCheaaroscupZszrkcJZntFHYka3cPEqp1qPT6+TA12x9n?= =?us-ascii?Q?jJX1UngnnjN6Ga9peC03fE+W0gzBJshhrUz+WiAijjfi6az+kpvdth3e/tu7?= =?us-ascii?Q?jP47SAXCtCuRzcefjg23ZTCDt2DVdlejnYaGEvfUBxssmM9sDz1XUu9k9LzF?= =?us-ascii?Q?8/zGw9UdOfCRoMZsP3CsaB/anN3VOSo0gyi/QOaNF0Ju6XjYyo0zGeMcQuRF?= =?us-ascii?Q?l6Gwegs8jMdF7/VsChcnw7QwhaKNSEedDgzANtL/VgMDcwSjx/ydWbv+gCTF?= =?us-ascii?Q?dQdb4Vl0MZhR673WfBgMsE4PTQr66Xh42Hrsqy6HKNKPjhn8E1IV/qOVoZkr?= =?us-ascii?Q?VObZDYrQwZsT7ABEULMz5U20MbqAIazo46qCokiXQmi/LKzQRMyjEU7P9en8?= =?us-ascii?Q?tSMqpxPvZR/8ZvVOiCMW9YggjzzefCAaEogqWamMiMG6KbksBYw7X/Gr0wQd?= =?us-ascii?Q?GA5RTAiaM0a4tpxHqL9vIDg7TWviD+EW4XYqtiOeMq2P0bPbxEdHoZaPMsS3?= =?us-ascii?Q?awoNu5XXuJ2G4V1OhoNQb5X8kbxwlFuHuu8pajhAe60tUeAKrnUCJ2DPPfWZ?= =?us-ascii?Q?QO9iNtwU9+duwVqKOXWiL9pbORRL5VBaFg0Fnx/mBYRZ2QqmJO9Q0zFTvhuV?= =?us-ascii?Q?71Gl+w/ZXItUvP8u6f+o6QbMf5pJCIr/aQ18QOeuztd4sn+yAHqL+Eu/jgUH?= =?us-ascii?Q?jVbT34KdEQArv4W8z5EzClPiPn/BrmIVoBtP54EmRmSTt8MpL92SZQEvcYqQ?= =?us-ascii?Q?CEXqlWWrzTSVP67eXHMRwwDLMA6C2H2XySv3SZ+q647FtflTOY/D+3AhAEjL?= =?us-ascii?Q?F5+aCS3OrMHGQ7SbJpBA7i8fl85EzO1ZdzpbcDFMsX/rTO7aP2P1cSwvATcO?= =?us-ascii?Q?h78RF5FIG1quY5RG8S9X1uiL0FWPTdy/By973DAGlgb02rbEPQd0C2JpRsaE?= =?us-ascii?Q?8u1TaWDjnvlFL9Mc+ql2gmyfq6m0OLNV76poUEqozbdZyOt+8TOXMUHvPU1Q?= =?us-ascii?Q?VuwJyFCF39CGVLVjHEQmLjhHQUDU3vgapxoUlcRT/1oeTjbjjGCMtxgyrxMO?= =?us-ascii?Q?hAS5YT/17kj/Y970z6OHhKur?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR1101MB2147.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 511786d1-7684-4de9-1779-08d8ce33d1af X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2021 02:22:02.8232 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: J/OMcnt2WEuFG0RcIiZdSCs/dKAQIo8Y6utVNVTRUbrBbC8I6kOfvMPivhTzWA+Kvj76CZucMwA6TtNZgOBq+Bt1ZBiCBkdl+jcxUCweEbE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2148 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Friday, February 5, 2021 4:15 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [edk2-platforms][PATCH v1 1/3] > MinPlatformPkg/SpiFlashCommonLibNull: Make MODULE_TYPE BASE >=20 > From: Michael Kubacki >=20 > This NULL library can be used to link against a MODULE_TYPE other than BA= SE > and that would be useful as it is a NULL class instance. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Michael Kubacki > --- >=20 > Platform/Intel/MinPlatformPkg/Flash/Library/SpiFlashCommonLibNull/SpiFla > shCommonLibNull.inf | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Flash/Library/SpiFlashCommonLibNull/Spi > FlashCommonLibNull.inf > b/Platform/Intel/MinPlatformPkg/Flash/Library/SpiFlashCommonLibNull/Spi > FlashCommonLibNull.inf > index d4964681de3d..75ef1cb921df 100644 > --- > a/Platform/Intel/MinPlatformPkg/Flash/Library/SpiFlashCommonLibNull/Spi > FlashCommonLibNull.inf > +++ > b/Platform/Intel/MinPlatformPkg/Flash/Library/SpiFlashCommonLibNull/ > +++ SpiFlashCommonLibNull.inf > @@ -12,8 +12,8 @@ [Defines] > BASE_NAME =3D SpiFlashCommonLibNull > FILE_GUID =3D F35BBEE7-A681-443E-BB15-07AF9FABBDE= D > VERSION_STRING =3D 1.0 > - MODULE_TYPE =3D DXE_SMM_DRIVER > - LIBRARY_CLASS =3D SpiFlashCommonLib|DXE_SMM_DRIVER > + MODULE_TYPE =3D BASE > + LIBRARY_CLASS =3D SpiFlashCommonLib > # > # The following information is for reference only and not required by th= e > build tools. > # > -- > 2.28.0.windows.1