From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.1339.1617841762188241181 for ; Wed, 07 Apr 2021 17:29:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=swyAxfG8; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: p9xTjTR3C3STG158t1ODLPXMYW/0V4187b2tWoIhzNJIfiIZkHkc2c6SBXa4jlResjUxW9tsLF 5DvsGldI4AhA== X-IronPort-AV: E=McAfee;i="6000,8403,9947"; a="213825360" X-IronPort-AV: E=Sophos;i="5.82,204,1613462400"; d="scan'208";a="213825360" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2021 17:29:21 -0700 IronPort-SDR: osOyvip+UDCR/W1ozrwpPh+et21YM+QY+KWZmKvq0W4JdOTVUF72p0hslS7+pjc+cRZrl+IiGR rGXRc41SWJSg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,204,1613462400"; d="scan'208";a="519630866" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga001.fm.intel.com with ESMTP; 07 Apr 2021 17:29:21 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 7 Apr 2021 17:29:20 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 7 Apr 2021 17:29:20 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 7 Apr 2021 17:29:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AHSYuziqxlLd/7bqI+5H9TfH/GPgIO3T8a/nhwNnsv/IRCN4u9PTh8TYnJlcTG6BNW8ua9UClf9tRlajn+gvDekAQBa55S61judlGX5Gr5y0Jc2btNPKuTkOR5luE/jfUjEH8VI+osFqsAinG0jl9wMNmleySRW1tdWCul/aTvpQe/wOoR+iTzz54Wr1TVX92h6jIHc4EF8/fOCEfZVQMtvsZaqH1OBeeAJbXe1w4wm7VLpFL+9FVO2hZtJeLgHsT96k2AyfiM9hQ8NheyJ+B9iss5RDLnaZaO+0mWj1PssNlVFXJkWw9uRdog+X37TDK7bhgnmHtAQbpD9q01ei0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wr8PltC3tubBJbgF9SZQDoTzQSSktTb8J6FxaYEcCnc=; b=eEJkgaRsM0pqOy87O2NGOxlO087WFsy2FySKeTgoA1yf0J3Tse/pFEPcq1zmnBOzzzeH3qXv+BkMzgFK0JKXSiE8ws1F+PFr8u7EzdFQbDKyMr72yuDSwFRJzhoqJUp9EG8S0u4pnE+jyw6ES1AuSBvCK7ovAjd41huR8SXeysffkp85PJSc1YNAY/KXnhoT1BAjkIYC3UAq9A+rtb6o3paYGPqJJ6I3GMYtwNkoxQ9crVotW96nXHpSY10oILH6vsLBMbwxSSei5BB6JpPgfVnYThdvHYXxKat+Gn4iooq4XANWUoZNJzTvTj4yxi+w6aFbaujWNehwCL7/zLsPiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wr8PltC3tubBJbgF9SZQDoTzQSSktTb8J6FxaYEcCnc=; b=swyAxfG8dQ5DLSWXdWQcFz6Q6wYO/RP6I1rLCYmubbFE0y5hADcK+xY7rALHRz3WXig418U2AuSthIiyYs0km/44QyZGwDL3PiOHWodrxFeMyAPgGNZPIOnBct5F19ZFjeO/TK5aOSdCCSUIJQi/p2bwFYg7IjOiy4f78F1C4Ok= Received: from BN6PR1101MB2147.namprd11.prod.outlook.com (2603:10b6:405:57::23) by BN9PR11MB5529.namprd11.prod.outlook.com (2603:10b6:408:102::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29; Thu, 8 Apr 2021 00:29:19 +0000 Received: from BN6PR1101MB2147.namprd11.prod.outlook.com ([fe80::696f:5e7f:8139:1971]) by BN6PR1101MB2147.namprd11.prod.outlook.com ([fe80::696f:5e7f:8139:1971%6]) with mapi id 15.20.3999.033; Thu, 8 Apr 2021 00:29:19 +0000 From: "Nate DeSimone" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-platforms][PATCH v1 2/2] MinPlatformPkg/BoardAcpiTableLibNull: Improve maintainability Thread-Topic: [edk2-platforms][PATCH v1 2/2] MinPlatformPkg/BoardAcpiTableLibNull: Improve maintainability Thread-Index: AQHXK9yfrGvaeByLW0y+vrjg14F9EKqpxI6Q Date: Thu, 8 Apr 2021 00:29:19 +0000 Message-ID: References: <20210407183324.1659-1-mikuback@linux.microsoft.com> <20210407183324.1659-3-mikuback@linux.microsoft.com> In-Reply-To: <20210407183324.1659-3-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 293aecbf-b89f-4db8-7c4d-08d8fa255990 x-ms-traffictypediagnostic: BN9PR11MB5529: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: owN4RmdqSBP5QVWdWfeuLuGTDrREZVFaN4FhL/V9BY1DIFhhclRpzpFB7pGmhZ8HLj9dnFjzMo8D7pLRMoF7HjMbtWxKrtxYLk6uVcANLFzNQuN6FSlhkz+fmRkyKcet/pYV9vSTwAsg+UFX06aWgpYWCJ7Q40sYHWGFue0AZTf+i7ADFj1fKhvjqOsrkc1/AwEpKRKu63Awxv2noiAbYmlndL+TGIx2Py9J687pfY3vC57kRKfzuozG+VYwLuGXBd7Ibnbi82I9zwcwprS6WYgP9UM2qq3r9/Hr/p785UfPlhC7TE9Gbj8XYSpjZaJV47CMDWET8x74ond1jOTVdqfD1JooX3+4IOLv2bEGlD3RLs5w8+zPUO5dVG4JODo/z2FQfeDS7mBz4AhK5Y/epCwwOPQ6cbTiIIiCjy5JnBGNQmAalt6L94KhUFUEXDoxHB7ojZ83K+mg2oWsLB1yWhsltXbyxII14zVgob5QYFICNH5yaCUFjoMxuRyWoo5+nTY9G9jg3PpJrDALDgrf1R4hoCfCles1X2HNOLA7n5bkyw2Ys9Q7Izal4iMhEuK8MezvVk98r+vW8qyoht48XBeqz5k/Q/sNNjUSGqmLtoLwRLgBibTa7+if+Nn81NGs7UE+2FFJBrg8e3/mI4qp2ADVD7WHQWMsILhgvIMo5SUv6+rM1NKWJHjvoGRXdiyc x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1101MB2147.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(39860400002)(346002)(366004)(376002)(136003)(55016002)(7696005)(2906002)(5660300002)(9686003)(86362001)(83380400001)(45080400002)(71200400001)(26005)(54906003)(33656002)(316002)(110136005)(478600001)(8676002)(66446008)(107886003)(186003)(64756008)(66556008)(66476007)(4326008)(66946007)(52536014)(38100700001)(53546011)(76116006)(6506007)(8936002)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?/i8O5xiK8azWg6UvYMqJC39dF2zSx/Xe/5xo2RE3XdRv+J4mZ6z9NeRj2Zsl?= =?us-ascii?Q?faY8m6AxA7iZxhPeAxwTPrB7jMOesNw7hBFDzY4AhDQQgMS/TfzqJhdAZwLc?= =?us-ascii?Q?jS5/MDctItrGeo33+FpxNnEOD69/DVyL7b+FVP+1icUjjKmEjQtmoJqcq1v3?= =?us-ascii?Q?G7uCijXgVKVunANnBffOkmH2Q6JANmRKxdVf5Gl03G8S1/LwVXd7yFe9VU60?= =?us-ascii?Q?yykkadYlIy6qkTwANT3Bq3KuSg4oIqUoGbSRiMqWHH+IWXgcS/5/n4iKeG2r?= =?us-ascii?Q?gRoR//EjOz1mqgvx0aXBbIOrrSdVUMC2a1CrnTMCAqFDKtSN8Ku5UT+nkBL6?= =?us-ascii?Q?b4NHXjTNRoER6gqbAu4bATKOD8+CC6u1vVvqq5RfF6d3gytqYvXQHvbE7uq9?= =?us-ascii?Q?WagdKmulko0JjXVl4D67HldUcB5C7kXGuWiaP8oAR8rw5uI23dAju+zc8eeD?= =?us-ascii?Q?LuFIK5IxYF3i+0To208I30KdvDWpWV2xGfHDk0ZnzqVrUA/5T2v/dDJZ27dT?= =?us-ascii?Q?RO7S0GGxSr46f3dT/wLvNtfhlLnirchi8qUZ9myh1tJGPbgxahxb8unf4HYx?= =?us-ascii?Q?ZfrPC54/+yo4kCw2cwvRIy9VqzPbDdG9fyne1IyEqvWuZ9kM12G/xibbuqWz?= =?us-ascii?Q?lODnCgTf8sZbHQyK9CtAJlXlPW1HI4mWMSbOFRcwJQzg0Kc0hxT5iT0quhkV?= =?us-ascii?Q?xwvPrllpSunLvmBYrCAhQvn0Eu8ZtDBCceNqYTpIGbQmsOoVBkv2J/6k3VG3?= =?us-ascii?Q?3mI7PYCOyDOp7HbXz/LLQlQ0r14QhEahlZK8dF4jHhmlKN3QCCv7MJ7GXEZX?= =?us-ascii?Q?M4NpiukibR85mP9Anjb2QqqCozBDMgX8g3uALsMiOu+tmRbVuJ0a5hJNgon7?= =?us-ascii?Q?lFd+XSddZ0L6MlTIeudpAfUK1x30vj4vx4YZdfwsWWslTSrB2jknos9+YVoy?= =?us-ascii?Q?xhozcbGODHAfJ1RbboVKT1loh+aSZpwRoRUM+sE2+wUwmOpTAkrKqpEmUT0v?= =?us-ascii?Q?aqWbjwrb9l+m7EeTwXsoTL2dWIwXAwYYmGxEhl+KVfrpQJymrjNMEeZTwbME?= =?us-ascii?Q?vBJaHZZxqTxUtSqzxtqTe+XI7DFjFzjV2dy1/+18vBDn0AjRDWICLri4AWxP?= =?us-ascii?Q?poG3lXbCJvyWp57JB5XX0mWtp3AwpYbk8kuseGuhy4SJIk57Ljy4r0WzXgxS?= =?us-ascii?Q?g6kGNCI3nmC0TzJXCTHmJyq4bO0QN7quUY4dvD4TYm7S0gkWDd74cDDXAmLM?= =?us-ascii?Q?qsV6FXig5owK750lsp020eTOryXhDbanGa45YC4hrLtifO0yQYjskh8OkCqa?= =?us-ascii?Q?PXul9NJ88mrhf0bnuQqi+Mah?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR1101MB2147.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 293aecbf-b89f-4db8-7c4d-08d8fa255990 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2021 00:29:19.5190 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 53wICfwsI3Ne0qGDZhMY/whDvHJACPXeKpQ+EBJ9veRqLbSwd8AGIJ3pY45+UFABb4Cyw+CLaz8EqJDrfHrPDrfQjnCSa1gJ4MtXz2di5gA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5529 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Michael, Feedback is line. Thanks, Nate > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Wednesday, April 7, 2021 11:33 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [edk2-platforms][PATCH v1 2/2] > MinPlatformPkg/BoardAcpiTableLibNull: Improve maintainability >=20 > From: Michael Kubacki >=20 > The NULL instance of BoardAcpiTableLib in MinPlatformPkg currently has a > few organization issues that make it more difficult to find and use than = a > typical NULL library instance. >=20 > 1. It shares a directory with another unrelated library instance. > 2. The directory name "BoardAcpiLibNull" is not directly related to > either library instance name in the directory. > 3. The library instance has unnecessary dependencies. > 4. The BASE_NAME does not indicate the library instance is the NULL > instance. > 5. The C source file name does not match the INF file name making > finding the C source by search more cumbersome than needed. >=20 > This change resolves the above issues to improve use and maintainability. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Michael Kubacki > --- >=20 > Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull/BoardAcpiTa > bleLib.c =3D> BoardAcpiTableLibNull/BoardAcpiTableLibNull.c} | 4 +--- > Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull =3D> > BoardAcpiTableLibNull}/BoardAcpiTableLibNull.inf | 12 += +++-------- > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > | 4 ++-- > 3 files changed, 7 insertions(+), 13 deletions(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiLibNull/BoardAcpiT > ableLib.c > b/Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiTableLibNull/Board > AcpiTableLibNull.c > similarity index 73% > rename from > Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiLibNull/BoardAcpiTab > leLib.c > rename to > Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiTableLibNull/BoardAc > piTableLibNull.c > index e49e6ad44162..0f871b6f07ef 100644 > --- > a/Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiLibNull/BoardAcpiT > ableLib.c > +++ b/Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiTableLibNull/B > +++ oardAcpiTableLibNull.c > @@ -5,10 +5,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ >=20 > +#include Any reason for choosing Base.h? From what I see this file uses types that r= equire Uefi/UefiBaseType.h like EFI_STATUS for example. It will still compi= le fine since BoardAcpiEnableLib.h includes Uefi.h (which includes Uefi/Uef= iBaseType.h). So I wonder what the value of including only Base.h is here s= ince the file will still have implicit dependencies. > #include > -#include -#include - > #include >=20 > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiLibNull/BoardAcpiT > ableLibNull.inf > b/Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiTableLibNull/Board > AcpiTableLibNull.inf > similarity index 67% > rename from > Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiLibNull/BoardAcpiTab > leLibNull.inf > rename to > Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiTableLibNull/BoardAc > piTableLibNull.inf > index 04f55b49d5a1..6102897ab67b 100644 > --- > a/Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiLibNull/BoardAcpiT > ableLibNull.inf > +++ b/Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiTableLibNull/B > +++ oardAcpiTableLibNull.inf > @@ -1,7 +1,8 @@ > ## @file > -# Component information file for Board Acpi Library > +# Component information file for NULL instance of the Board ACPI Enable > +library > # > # Copyright (c) 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) Microsoft Corporation.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -9,20 +10,15 @@ >=20 > [Defines] > INF_VERSION =3D 0x00010005 > - BASE_NAME =3D BoardAcpiTableLib > + BASE_NAME =3D BoardAcpiTableLibNull > FILE_GUID =3D F220FAB7-F8E4-4E7A-A599-D47E2D54795= 6 > MODULE_TYPE =3D BASE > VERSION_STRING =3D 1.0 > LIBRARY_CLASS =3D BoardAcpiTableLib >=20 > -[LibraryClasses] > - BaseLib > - PcdLib > - DebugLib > - > [Packages] > MinPlatformPkg/MinPlatformPkg.dec > MdePkg/MdePkg.dec >=20 > [Sources] > - BoardAcpiTableLib.c > + BoardAcpiTableLibNull.c > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > index da27aa1c4227..cf3ff13e7b29 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > @@ -78,7 +78,7 @@ [LibraryClasses.common] >=20 > FspWrapperPlatformLib|MinPlatformPkg/FspWrapper/Library/PeiFspWrapp > erPlatformLib/PeiFspWrapperPlatformLib.inf >=20 >=20 > BoardInitLib|MinPlatformPkg/PlatformInit/Library/BoardInitLibNull/BoardIn= it > LibNull.inf > - > BoardAcpiTableLib|MinPlatformPkg/Acpi/Library/BoardAcpiLibNull/BoardAc > piTableLibNull.inf > + > + > BoardAcpiTableLib|MinPlatformPkg/Acpi/Library/BoardAcpiTableLibNull/Bo > + ardAcpiTableLibNull.inf >=20 > BoardAcpiEnableLib|MinPlatformPkg/Acpi/Library/BoardAcpiEnableLibNull/B > oardAcpiEnableLibNull.inf >=20 > SiliconPolicyInitLib|MinPlatformPkg/PlatformInit/Library/SiliconPolicyIni= tLibN > ull/SiliconPolicyInitLibNull.inf >=20 > SiliconPolicyUpdateLib|MinPlatformPkg/PlatformInit/Library/SiliconPolicyU= p > dateLibNull/SiliconPolicyUpdateLibNull.inf > @@ -151,7 +151,7 @@ [Components] > MinPlatformPkg/Acpi/AcpiSmm/AcpiStandaloneMm.inf > MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.inf >=20 > MinPlatformPkg/Acpi/Library/BoardAcpiEnableLibNull/BoardAcpiEnableLibN > ull.inf > - MinPlatformPkg/Acpi/Library/BoardAcpiLibNull/BoardAcpiTableLibNull.inf > + > + MinPlatformPkg/Acpi/Library/BoardAcpiTableLibNull/BoardAcpiTableLibNul > + l.inf >=20 > MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/DxeMultiBoardAcpi > SupportLib.inf >=20 > MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/SmmMultiBoardAc > piSupportLib.inf >=20 > -- > 2.28.0.windows.1