public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Desimone, Ashley E" <ashley.e.desimone@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Pandya, Puja" <puja.pandya@intel.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>,
	"Agyeman, Prince" <prince.agyeman@intel.com>,
	"Bjorge, Erik C" <erik.c.bjorge@intel.com>
Subject: Re: [Edk2-Staging/EdkRepo] [PATCH] EdkRepo: Show dev lead information in verbose manifest command output.
Date: Fri, 15 Jan 2021 23:27:08 +0000	[thread overview]
Message-ID: <BN6PR1101MB2147480034CAB612691B05A6CDA70@BN6PR1101MB2147.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210108191606.2011-1-ashley.e.desimone@intel.com>

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

> -----Original Message-----
> From: Ashley E Desimone <ashley.e.desimone@intel.com>
> Sent: Friday, January 8, 2021 11:16 AM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja
> <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>;
> Agyeman, Prince <prince.agyeman@intel.com>; Bjorge, Erik C
> <erik.c.bjorge@intel.com>
> Subject: [Edk2-Staging/EdkRepo] [PATCH] EdkRepo: Show dev lead
> information in verbose manifest command output.
> 
> When displaying verbose output the manifest command now shows the dev
> lead list for each project.
> 
> Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Puja Pandya <puja.pandya@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> Cc: Erik Bjorge <erik.c.bjorge@intel.com>
> Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
> ---
>  edkrepo/commands/manifest_command.py | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/edkrepo/commands/manifest_command.py
> b/edkrepo/commands/manifest_command.py
> index 5c6184f..eb192db 100644
> --- a/edkrepo/commands/manifest_command.py
> +++ b/edkrepo/commands/manifest_command.py
> @@ -9,6 +9,7 @@
> 
>  import copy
>  import os
> +import csv
> 
>  from colorama import Fore
> 
> @@ -21,8 +22,9 @@ from edkrepo.common.ui_functions import
> init_color_console  from
> edkrepo.common.workspace_maintenance.manifest_repos_maintenance
> import list_available_manifest_repos  from
> edkrepo.common.workspace_maintenance.manifest_repos_maintenance
> import pull_all_manifest_repos  from
> edkrepo.common.workspace_maintenance.manifest_repos_maintenance
> import find_source_manifest_repo
> +from
> edkrepo.common.workspace_maintenance.manifest_repos_maintenance
> +import find_project_in_single_index
>  from edkrepo.config.config_factory import get_workspace_manifest -from
> edkrepo_manifest_parser.edk_manifest import CiIndexXml
> +from edkrepo_manifest_parser.edk_manifest import CiIndexXml,
> +ManifestXml
> 
> 
>  class ManifestCommand(EdkrepoCommand):
> @@ -100,6 +102,8 @@ class ManifestCommand(EdkrepoCommand):
>                      print("  {}".format(project))
>                  if args.verbose:
>                      print("   -> {}".format(ci_index_xml.get_project_xml(project)))
> +                    proj_manifest =
> ManifestXml(find_project_in_single_index(project, ci_index_xml,
> man_repos[repo][0])[1])
> +                    print("   -> DevLead: {}".format(' '.join(x for x in
> proj_manifest.project_info.dev_leads)))
> 
>              if args.archived:
>                  print()
> @@ -111,3 +115,5 @@ class ManifestCommand(EdkrepoCommand):
>                          print("  {}".format(project))
>                      if args.verbose:
>                          print("   -> {}".format(ci_index_xml.get_project_xml(project)))
> +                        proj_manifest =
> ManifestXml(find_project_in_single_index(project, ci_index_xml,
> man_repos[repo][0])[1])
> +                        print("   -> DevLead: {}".format(' '.join(x for x in
> proj_manifest.project_info.dev_leads)))
> --
> 2.27.0.windows.1


  reply	other threads:[~2021-01-15 23:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 19:16 [Edk2-Staging/EdkRepo] [PATCH] EdkRepo: Show dev lead information in verbose manifest command output Ashley E Desimone
2021-01-15 23:27 ` Nate DeSimone [this message]
2021-01-20  0:45 ` Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN6PR1101MB2147480034CAB612691B05A6CDA70@BN6PR1101MB2147.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox