public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* Re: [edk2-devel] [edk2-platforms] [PATCH v1] IntelSiliconPkg: Add DWORD_ALIGN macro
       [not found] <16622AED19B3AE90.16853@groups.io>
@ 2021-02-09 21:33 ` Nate DeSimone
  0 siblings, 0 replies; only message in thread
From: Nate DeSimone @ 2021-02-09 21:33 UTC (permalink / raw)
  To: devel@edk2.groups.io, Desimone, Nathaniel L; +Cc: Ni, Ray, Chaganty, Rangasai V

After I sent this patch, Mike K helpfully pointed out that we already have ALIGN_VALUE() In Base.h. Therefore, please consider this patch abandoned.

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate
> DeSimone
> Sent: Tuesday, February 9, 2021 11:27 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>
> Subject: [edk2-devel] [edk2-platforms] [PATCH v1] IntelSiliconPkg: Add
> DWORD_ALIGN macro
> 
> Adds a macro that rounds a given integer up to the nearest DWORD.
> The config block data structure needs to be DWORD aligned. Since config
> blocks are run-length encoded, the size of all config blocks therefore needs
> to be in DWORD increments. This macro aids in storing arbitary data in a
> config block.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
> b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
> index 37a3968168..0233137e99 100644
> --- a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
> +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
> @@ -9,6 +9,8 @@
>  #ifndef _CONFIG_BLOCK_LIB_H_
>  #define _CONFIG_BLOCK_LIB_H_
> 
> +#define DWORD_ALIGN(x)   (((x) & 3) ? 0 : 1) ? x : (((x) + 4) & ((UINTN)
> ~0x3))
> +
>  /**
>    Create config block table.
> 
> --
> 2.27.0.windows.1
> 
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-02-09 21:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <16622AED19B3AE90.16853@groups.io>
2021-02-09 21:33 ` [edk2-devel] [edk2-platforms] [PATCH v1] IntelSiliconPkg: Add DWORD_ALIGN macro Nate DeSimone

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox