From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.18070.1612906429491374112 for ; Tue, 09 Feb 2021 13:33:49 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=HyK3XSMW; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: gVIE3wqGAz9FLsxJa1bHLAQzP3Cx8YgyWneeJCN5cUqnUL2w+18YlqEZ+ncJxYWC8Y7myOrJtc M7qL06rcw9gw== X-IronPort-AV: E=McAfee;i="6000,8403,9890"; a="243458575" X-IronPort-AV: E=Sophos;i="5.81,166,1610438400"; d="scan'208";a="243458575" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2021 13:33:45 -0800 IronPort-SDR: WboSLozhm5eeXo3RmsoIF4y0dtMQaGZkwhaJs9HTEax8ucLgjG6XAqsUlSqSvYQAvFnsfGrRAf /DWr/GYU6qyQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,166,1610438400"; d="scan'208";a="419829500" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 09 Feb 2021 13:33:44 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 9 Feb 2021 13:33:44 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 9 Feb 2021 13:33:44 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 9 Feb 2021 13:33:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ITN49qEXN75zg8t06bEcQQH15MfSiy1bbrEyCCPROedIBu2TCHDOSh6TAlUi0l797zF37U3/LQ1iDW2FXjGw3M6+sZMCN/zS7kTBN/UZwPPbGJtrylFMAOuPLR7G0TVUnEUpLJR23boeyVpNk3ye5tciPrZtM9gBIcJZvSrTkt/Y3MzvTnz3VHmxEREhtx2DtPA0dCANLvS4cvsS9cMWBaVt7qIs84D0wCynenfF45o0VYEwr8jseZqvULkn7JQGwCZhw1JYnzGqU0//e+n2YfUH6mmiLUMrcXbMUZcTSLI4H5VMue6nKsn+qvAUJhp0B4QS5WnFKdRsBRBrPyxNUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aNFaB9mjGYXAwDk+UGAfbF/h5DO/AQH3oC30SVXcbtY=; b=LOs5WzES8cCZolakauIEzF+xUAIapdIvIx028dul9wa64RL62PIsRXWLPvCgxSwskdcHqudttSyTDovnlwBu+1U/NC9iA3qWPNnHuM/PuV6oC5i7LVUv1n22HNzka0YTbEPAr6Z1mOkqFI6yShgUvfwIFGS/3avRW/py7UVGv3jlii30mMfxX8bhvpGZm2NiHGVC8uv+N4kemWpraLcA8hpvMOvHRidMTvR8UlO3Drx5FDMD4v8jEL3xI18/WOn7wBwz23yJ/m3oZEvMB8mfNEBKpzEe/ok3qivBGjc3f1rWVz3goPpzSmmJZJrcrR9oEVt2YDtNB1XR1NcS10BKmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aNFaB9mjGYXAwDk+UGAfbF/h5DO/AQH3oC30SVXcbtY=; b=HyK3XSMWIsCn7tuzyN3VBZeZ6WR4n4Xbq+bzzGWGh9p6gLj+gk00/nESEVMNKLyKE54AGQvGY8PUOiyuJTFNuloMMQFc7CvmCF6qmo4PtSpq7D9q+0GNrR1T/FjDkRrSTBJIJ+OJQ3FbxRPpTNHMMxvyq8+glr/BUSl8oovFw4g= Received: from BN6PR1101MB2147.namprd11.prod.outlook.com (2603:10b6:405:57::23) by BN6PR11MB4068.namprd11.prod.outlook.com (2603:10b6:405:7c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.23; Tue, 9 Feb 2021 21:33:43 +0000 Received: from BN6PR1101MB2147.namprd11.prod.outlook.com ([fe80::203e:ed6b:a572:6453]) by BN6PR1101MB2147.namprd11.prod.outlook.com ([fe80::203e:ed6b:a572:6453%3]) with mapi id 15.20.3825.030; Tue, 9 Feb 2021 21:33:43 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Desimone, Nathaniel L" CC: "Ni, Ray" , "Chaganty, Rangasai V" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v1] IntelSiliconPkg: Add DWORD_ALIGN macro Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH v1] IntelSiliconPkg: Add DWORD_ALIGN macro Thread-Index: AQHW/xmRsfRI9TWGzkCz7+/2rO8iM6pQWAtA Date: Tue, 9 Feb 2021 21:33:42 +0000 Message-ID: References: <16622AED19B3AE90.16853@groups.io> In-Reply-To: <16622AED19B3AE90.16853@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 76a19774-1fd3-45ff-cbc1-08d8cd425fbe x-ms-traffictypediagnostic: BN6PR11MB4068: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:117; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UzY/VwWuph7C1otdJAk++fGtk7tvhddeqXM7pX2vXl5Gk4cbP6QkYfcGfRgjTmR3/ksntp6+HT/ZIFGExHSY9rE15QcCjpsJnywonYTvzulreH6fLOv2lgHMUV5iS8dLJcWTsTJ4DKxhKgs3O4XZ7ja+2NWYUrPgDrKqdKUtKPwvOMa65RRWZCYJ9TdVjI4ladRVzfRLGjg5SAL/KRwH+RUuraLYK+akIrfhL9uHhf9tqWGOuhC7vj8EAkOLuz5pwPSIQB39iqjdAiDGmoXEO2WEhhDnI6bPBZ6qP1tm6Ji3BFz7l0uqPHKR+O5rEW+NX354XuJ0Zxa12hkvPv4CbJYllmfQ9ErGAcKO8CdzmrB29DoSFZRjOsZCcISok7d25D4aAyqcL7hA2armmZhZDxdH/HYQee7qLCJLEm6b2/hAbjO7DuU4tEvo21t5wu0HBTwJCDufKqpTM/A3Nim5E6F2rTGmMRHLGvXqlCoo3LgOu914eQQEZKWaS9YzFP9AvrDYnyPARDUs08qOsgIPeV1l8RoWaS0bsH6SJFoj7tczQCPM/JbNaZtpiv5CaDcKPj/bZ+Whgv+BXmpA/krSy7JCysHbN6WvzxNG+utd0+s= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1101MB2147.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(366004)(346002)(376002)(396003)(39860400002)(186003)(6506007)(110136005)(478600001)(86362001)(33656002)(8936002)(107886003)(26005)(76116006)(54906003)(966005)(8676002)(71200400001)(53546011)(66946007)(52536014)(66476007)(66556008)(9686003)(66446008)(64756008)(2906002)(83380400001)(316002)(4326008)(5660300002)(55016002)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?r7OvjXO+H0r5JUemw3hHJaQhFJvIunuvG45GZKFu+Chjvo3bedB/Pk3k+hhj?= =?us-ascii?Q?wXCbl12onYHogWwUbEZE+vpJyVs1vDxJ4dm4w96Ib/LWBWlbOWU3kVZI6QsS?= =?us-ascii?Q?P3M7zE8Tfxzgr2oJVagNcVXNNPi+rCHV/LR2ItHVphGRA2lwFCLefoXDAQNj?= =?us-ascii?Q?0O8ps8fSg8HGd1og4ngoi9zYceKOSYIkXPjn/q7Ie02/mNa4KdcvVuE6hMP3?= =?us-ascii?Q?08/Rg1LO7zBQjWnLvdA9BE5IKu/RJGzuzcqhEJOCEPCLmRV/xTKHFMnGh9op?= =?us-ascii?Q?kRwGJzA3VI75FRbwsgizkx9ZyTICzL/kf7fji1vT1iL/8KR0EP/t/BSBZIP6?= =?us-ascii?Q?QPbuTXEU1boMWc1G7tWMGgNEMqKN54dwGxYTt4pdhZKpGhTXek72+KrW8mnJ?= =?us-ascii?Q?vrJIUP63BmXuEV/37i3IPITScX1bl/SiUIeiF4LoChbS5gvo+HnEuCrHFq6f?= =?us-ascii?Q?KKykh8aqLJdogoD9rpeWlfYGuxFNM2H6o3xpKFCsw3xzNaUt7qysZHre0w7D?= =?us-ascii?Q?dDNjcEtgpvR8TcA0eY/jkDi114PkOPHG5/zD5CL7rw7QpAHBughM8rkzqpHE?= =?us-ascii?Q?Kbizz2jYJm53hVOjqPS/SWC5ltUQ9I618XLg6W7U1DROs+MFtbrLufZ+EVEy?= =?us-ascii?Q?1baqtv7N49NmVnibh4jLAHLTNHWcgRJRsgbZ3ZkNlH52BFekGRkbXcvvlIKz?= =?us-ascii?Q?k61lj9nvQjicHjwASKqzVub1tRGoXTqEv1/F69iNNRfI8AagSL9FrwGgrDZl?= =?us-ascii?Q?XzcSa7Wst4sKeZ0qad5Fqcje0zyIjPlrq0LvNVM1vYKi721ByGnpE7MtP64A?= =?us-ascii?Q?/HB+yCAkSxCQ/8tM0LLlVls8CDdoR5T1oqGFdLZ+01vE1j8jp+iN+Bv1xeMd?= =?us-ascii?Q?FFygjRh74smCAhMx7ih8BvkizqPq1Fiu+2z7IEZhoiGYZA/8TOTsDoCGeo+j?= =?us-ascii?Q?LJJykLOr3d7umSN5iYZDiu0bL5ytbrnOqxmljYDuuu1qSVPNKnZP73CoNEvd?= =?us-ascii?Q?ILEflprjZSuGtlWH5vb/PN7YTqzka8C1qQimhmhZR9r+cAmLjR8WbsEzvAst?= =?us-ascii?Q?z2aXdUE2UayKPF/dke+XfO1qxzLsRBsoSj4XeOajx9q+H5X3hfug1MKAr2fJ?= =?us-ascii?Q?IFuB/M0hVi9RH04aFx/LWHyXluufMNY+z5IsSgLzj/63Yqq8nvz/yFT/j1UC?= =?us-ascii?Q?knvdevvp/6BQJqDZ3NjbInCFi8DYnO3IIfM3wMlL+Y1kqimYooIy6yATWPUd?= =?us-ascii?Q?roV5zSghq1ORVM2vWMIrxJ5OteqAsZaDT/Dc1g/GEDdMaa/fpuqIEADD0PnW?= =?us-ascii?Q?3FOTBQsag8fTNfCX2d2Iruks?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR1101MB2147.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76a19774-1fd3-45ff-cbc1-08d8cd425fbe X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2021 21:33:42.5322 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: e0Ekx3seUdI7jv5/D5Zn0XhHRZx+w4MDj9AEOy7EcRrDztk3ho3hzi259BOOg4T+KrhZ547N2TJfol1bqBF1/EqwXa8uJJ38KOYNXSv7SK0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4068 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable After I sent this patch, Mike K helpfully pointed out that we already have = ALIGN_VALUE() In Base.h. Therefore, please consider this patch abandoned. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Nate > DeSimone > Sent: Tuesday, February 9, 2021 11:27 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > > Subject: [edk2-devel] [edk2-platforms] [PATCH v1] IntelSiliconPkg: Add > DWORD_ALIGN macro >=20 > Adds a macro that rounds a given integer up to the nearest DWORD. > The config block data structure needs to be DWORD aligned. Since config > blocks are run-length encoded, the size of all config blocks therefore n= eeds > to be in DWORD increments. This macro aids in storing arbitary data in a > config block. >=20 > Cc: Ray Ni > Cc: Rangasai V Chaganty > Signed-off-by: Nate DeSimone > --- > Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLi= b.h > b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > index 37a3968168..0233137e99 100644 > --- a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > @@ -9,6 +9,8 @@ > #ifndef _CONFIG_BLOCK_LIB_H_ > #define _CONFIG_BLOCK_LIB_H_ >=20 > +#define DWORD_ALIGN(x) (((x) & 3) ? 0 : 1) ? x : (((x) + 4) & ((UINTN= ) > ~0x3)) > + > /** > Create config block table. >=20 > -- > 2.27.0.windows.1 >=20 >=20 >=20 >=20 >=20