From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web09.1298.1617841750247307327 for ; Wed, 07 Apr 2021 17:29:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=I+Rf+6Cf; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: +nbvl/r9LaQFfeltMu5m/g8aOaDfBTnSlQVidIQl6r5TI6zK5Gk0fpSXxVYE/KPcTyfgdZHD/V /V1o9hOSWJ9w== X-IronPort-AV: E=McAfee;i="6000,8403,9947"; a="254767116" X-IronPort-AV: E=Sophos;i="5.82,204,1613462400"; d="scan'208";a="254767116" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2021 17:29:09 -0700 IronPort-SDR: iV5v+mhJgluCkxYncnFpxN4aD3Ypeh4OERzkdxozuOlqWs+GYJrUJtk10f72EcCVDo1pn/A2di Q/hDO7MyfuJQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,204,1613462400"; d="scan'208";a="449404363" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga002.fm.intel.com with ESMTP; 07 Apr 2021 17:29:08 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 7 Apr 2021 17:29:08 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 7 Apr 2021 17:29:08 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 7 Apr 2021 17:29:08 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 7 Apr 2021 17:29:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ixf/BjnHMh2kP0ggmUIkjbpE9hSVQ5EDNcHXgir0DsiGhT1lBaPrtwVdpCy0NngFKj5l0Vs42QYVVQFQfS0mu0K8bPIRnA8/7Sjc3g3wV6JojZllNWDYfCKAsfhL35CMLYrWYjnVnAoabshLhpEloL8Lf8B4wvP06zj9VAIuzQ3laMhCSfh64+vULCNT19J6HyrXLqQmjbuwXoUr4bQQyOvm2eRCpsyCdtXOZyR9+O9lrJjxICXHys2JpKXMz2t1RyjYxlrK/BA/Ah685wPpd+XVXhRWn+ZsMm4Lcs0W8ITdiVMf02155cIBt/sLDaniwUrnBlP006UgsAMMD6JCdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JkG8+LYLAtzfts9kLYD/Gi9hLNVk3mrOszpukf4+Hcs=; b=KKA61G/r8Qh62/hIV0aW+VPOfknkGulhbRoPofw0sn9COANePV79vrlI9smdu8zhO3PqnSCNM5a6baUmSKs0td6wJKljhK/h14p4VF5LeKGocp52/rtYWwpRcMUvZtnEZ4METdYLcBVxJzl0bheMy81fJ8YHUWm433Lg8fjDXjE28FCoRCMU4i+KFiRZXzgUPULl4Af3e/jQ6N/gVafTOyZUjDdms4/3G0If15jdnXjYDvfjtsVTePhmqqus72+ZNJcKy3JMedyBVR/QKbj6MmDQuGAl7MThASCAd6kL9v0hnZ4nBs6qIX5g6T7sNS9ePDVrGCu3pNbuRRh26x0QSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JkG8+LYLAtzfts9kLYD/Gi9hLNVk3mrOszpukf4+Hcs=; b=I+Rf+6Cfj5T/glLkkv6jAciGurp1BSZPMATBQXSWKX3PdeoL1wxdgYUR+00DzDyxG1f0+p10cqiuXYMWmecJGUTNBu3N02OlPxlxnBPYlUKyrfL6bSogsCYrjqbU32/yY2/7ye/kt/VbvsosV13ff1lfZqbZ4bvbsKRkn8IIBD0= Received: from BN6PR1101MB2147.namprd11.prod.outlook.com (2603:10b6:405:57::23) by BN9PR11MB5529.namprd11.prod.outlook.com (2603:10b6:408:102::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29; Thu, 8 Apr 2021 00:29:06 +0000 Received: from BN6PR1101MB2147.namprd11.prod.outlook.com ([fe80::696f:5e7f:8139:1971]) by BN6PR1101MB2147.namprd11.prod.outlook.com ([fe80::696f:5e7f:8139:1971%6]) with mapi id 15.20.3999.033; Thu, 8 Apr 2021 00:29:06 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/2] MinPlatformPkg/BoardAcpiEnableLibNull: Improve maintainability Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v1 1/2] MinPlatformPkg/BoardAcpiEnableLibNull: Improve maintainability Thread-Index: AQHXK9yh/TVTcyaKV0qpGdtrn4HyB6qpw3nQ Date: Thu, 8 Apr 2021 00:29:06 +0000 Message-ID: References: <20210407183324.1659-1-mikuback@linux.microsoft.com> <20210407183324.1659-2-mikuback@linux.microsoft.com> In-Reply-To: <20210407183324.1659-2-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 37271475-79cc-4dd6-86a1-08d8fa2551d0 x-ms-traffictypediagnostic: BN9PR11MB5529: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rNZy+Mh4sjZY00E7q9jE4vzuPY6WDDQDK579Q8ADgIv0bIqvyDigaT/ULFwTpQk0j0XLEC7ubFNAS2d+Vd5VKQVrzBfEhimnRrwr46Wn5f6JFirO7ExYsgHUmr6COmEbrFQxkMoN6xI0yY9qzCm5ngbqM7O7yDoQgml4tjCuXDuZThIi1gII2M01h3+cYEMzXFAiwt6SuYZDwiiQD3gib2XIhvd7pZzAsXVTsmr2XlLjZDbB8jEUTCIq51Mbp6LSz0DXIPZcBf69HQEvl6tmRQEAzt+r/gSzUMflRz4uHKCgCR5ugAOvn3/T+pZKowXzNDs8RTV8id+APF1D6cLOpWI0e0uYOh4+D5jMOw7oKAhsFLCo2W2BjNsnR1obP0Q8YBEJ0m17UUqcIQRSV9ZbM5Mo4YzWIqw6a8aZoHdv4se6gZUe9B06QNKqZ///Jn6f0cLrvBmF9+FUKztLQbNQoAMqq3pw4EbCikUsrHvahc54Ukrcqzb3Kv+MN5EFxp3yNJ6ElEsd0dsfayED6Hgy/3X3SMyBy5s8If2O+esNLiTvnS+HkLCY4L6oTD/F5NmegZP2H6m40A6+9zlBdFPtV26A7qrZN1FEvDN0GyW5uJdtPSr+clNUlwm8/HiGxd6K5t3c+kw0yy5DGfkSDnplL048/i5ii02Ot360zEIeS2rMe+YYGTohDomSrTwydWN9eugF6ujDK9vBMJ3sCGWY92VFKamNVW69jKSRV2+0vvj8SxIGdolGT/HCwV12iKvi8cpu6OqYY23mOuH0C1Bdbw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1101MB2147.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(39860400002)(346002)(366004)(376002)(136003)(55016002)(7696005)(2906002)(5660300002)(9686003)(86362001)(83380400001)(45080400002)(71200400001)(26005)(54906003)(966005)(33656002)(316002)(110136005)(478600001)(8676002)(66446008)(107886003)(186003)(64756008)(66556008)(66476007)(4326008)(66946007)(52536014)(38100700001)(53546011)(76116006)(6506007)(8936002)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?gcXESK7xpVgvMW2GJJpV2X/h4W8KAha6rYiBywFFIETS9ndbRHKBPIMRs+Mw?= =?us-ascii?Q?FvRP92+j78NO1WA8lhEpfWQQWtO8ytO1aV1SurIleLYCF1EnxbYRx8AAaP4c?= =?us-ascii?Q?949yHUFNmm+kSqelAOYGrDQsJ+q4ihU5pdjVGedFsy4DIupUBqniqIm82FHz?= =?us-ascii?Q?gaOXHAcbqgW7DTW+tQbLN7ux9Z50+C6HQ6gBR+BCHK74r7u42UPxN8b7pAfm?= =?us-ascii?Q?zUO5ETZVjqA6Y3bVkIHnsjK4RfJL1WIVQg6ye0KGhjl2MFPsYgwcSvj29Ci0?= =?us-ascii?Q?6J/eKO37433qOM5f1tGvfJSzpfH8mLX4iucTbVSiL5fhgZo9AvfIrABzEIIh?= =?us-ascii?Q?se3oZp3oTO/UYCyb7cqUOYHZ5Hb6LH/L48Q81ldHysEpxwrSm+pqJR4fcmwC?= =?us-ascii?Q?2o67Fs2X6Emub+yyySmz6Q90a0NNUZZq+e/jfewWNHtu6U+mrPDMOKCfnt52?= =?us-ascii?Q?zlqVCgGWdCXQe8d58yAHi5jh0eVQI9LNWWzRBNxlCH9IyrK1DZr0aQgaY+Qz?= =?us-ascii?Q?syfHw1XaLXOjnm+VNwDS+/v8lMBBE5fXKDlYKgPh8u/yLBuxPAsTbMdcVW/c?= =?us-ascii?Q?cgy3I2gmgIK7eQmL6g8wjEXRfASXsmPzy2gpMcTDOTtsrb9WmE/2Ika6D1zM?= =?us-ascii?Q?Tg5XV+UF2Ktt32psqOvR24qp4WniRvHS/47Hp0nHlWU054ZTFdMbsW4jgEen?= =?us-ascii?Q?SO0Luqj6nigwYe9W/fh1tWIzN9cUa/8cdS7NAUvBOqWyC5bcF7WgnChZhigV?= =?us-ascii?Q?xLG9A8OQtYQLoYnsSoSsTzBrDYACOVATO5FvrcILI6s2rOmoGLNqgjDmp7nu?= =?us-ascii?Q?dis9l48o1A3HkjMJgQSea2ZZFfU+Nv5QKr6k9kRNKUmRKOzJWxR2wb9aeAhA?= =?us-ascii?Q?KQH70lYLJEg7BN30+JUnXfujb5K8IDGKmd+XV7OlPfmVB/O797Es5Ebu14Ch?= =?us-ascii?Q?kzRBvo4c7g/i5Bk1rgJOJgVH2hXn2IfpSTUZ5pJ9DfjlV+o3TPr/HrX0MNPk?= =?us-ascii?Q?HkWBbqbk6JFVmuWeWFaxQirmjGj0vISAXur0HRHrngESMAKwW8tOVJzEQyAP?= =?us-ascii?Q?xiG6xlGrH1vls9iX0YfqXIjcHNlBAxt65X+VUOAp3qCCSnT/Nj8cEwdC8UlS?= =?us-ascii?Q?gudeoq5yvrMC7NWtNhQ10TQBo8oPAq/nZ8PpGBryF/JHNkVOyfCo1NWhkg4Q?= =?us-ascii?Q?d6SNR8ODf5tLsPDZa40CaGLI+YWvOGwbsoGsfR3UqEhBjulSwCv3nKcmybI1?= =?us-ascii?Q?80AqD9xi6bsRngD1NxigvJks2RJfmq66RmIzMaYpJz0cOiOKxb1tEDeQ8bTb?= =?us-ascii?Q?58zTepl8a+PKONgTAuJVFrVl?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR1101MB2147.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37271475-79cc-4dd6-86a1-08d8fa2551d0 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2021 00:29:06.4920 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WYnOWkCmO4dOSSNHtd5BGafOBh2TeCjZ7TXy7pOXwMY2La2XvPr6281qRAm/HNmGjDViRwYkJkJ9DVSmjkcx6xCLplzW561FwmL7bHvERB0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5529 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Michael, Feedback is line. Thanks, Nate > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Wednesday, April 7, 2021 11:33 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/2] > MinPlatformPkg/BoardAcpiEnableLibNull: Improve maintainability >=20 > From: Michael Kubacki >=20 > The NULL instance of BoardAcpiEnableLib in MinPlatformPkg currently has a > few organization issues that make it more difficult to find and use than = a > typical NULL library instance. >=20 > 1. It shares a directory with another unrelated library instance. > 2. The directory name "BoardAcpiLibNull" is not directly related to > either library instance name in the directory. > 3. The library instance has unnecessary dependencies. > 4. The BASE_NAME does not indicate the library instance is the NULL > instance. > 5. The C source file name does not match the INF file name making > finding the C source by search more cumbersome than needed. >=20 > This change resolves the above issues to improve maintainability. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Michael Kubacki > --- >=20 > Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull/BoardAcpiEn > ableLib.c =3D> BoardAcpiEnableLibNull/BoardAcpiEnableLibNull.c} | 4 +--- > Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull =3D> > BoardAcpiEnableLibNull}/BoardAcpiEnableLibNull.inf | 1= 2 ++++------ > -- > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > | 4 ++-- > 3 files changed, 7 insertions(+), 13 deletions(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiLibNull/BoardAcpiE > nableLib.c > b/Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiEnableLibNull/Boar > dAcpiEnableLibNull.c > similarity index 73% > rename from > Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiLibNull/BoardAcpiEna > bleLib.c > rename to > Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiEnableLibNull/Board > AcpiEnableLibNull.c > index 334cb21714ac..494389ae5dc8 100644 > --- > a/Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiLibNull/BoardAcpiE > nableLib.c > +++ b/Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiEnableLibNull/ > +++ BoardAcpiEnableLibNull.c > @@ -5,10 +5,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ >=20 > -#include > +#include Any reason for choosing Base.h? From what I see this file uses types that r= equire Uefi/UefiBaseType.h like EFI_STATUS for example. It will still compi= le fine since BoardAcpiEnableLib.h includes Uefi.h (which includes Uefi/Uef= iBaseType.h). So I wonder what the value of including only Base.h is here s= ince the file will still have implicit dependencies. > #include -#include - > #include >=20 > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiLibNull/BoardAcpiE > nableLibNull.inf > b/Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiEnableLibNull/Boar > dAcpiEnableLibNull.inf > similarity index 67% > rename from > Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiLibNull/BoardAcpiEna > bleLibNull.inf > rename to > Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiEnableLibNull/Board > AcpiEnableLibNull.inf > index 54985ee50d5f..90bed3760e2a 100644 > --- > a/Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiLibNull/BoardAcpiE > nableLibNull.inf > +++ b/Platform/Intel/MinPlatformPkg/Acpi/Library/BoardAcpiEnableLibNull/ > +++ BoardAcpiEnableLibNull.inf > @@ -1,7 +1,8 @@ > ## @file > -# Component information file for Board Acpi Library > +# Component information file for NULL instance of the Board ACPI Enable > +library > # > # Copyright (c) 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) Microsoft Corporation.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -9,20 +10,15 @@ >=20 > [Defines] > INF_VERSION =3D 0x00010005 > - BASE_NAME =3D BoardAcpiEnableLib > + BASE_NAME =3D BoardAcpiEnableLibNull > FILE_GUID =3D EAF8AA6D-549A-40CC-8FB2-3A1FFEC4160= 1 > MODULE_TYPE =3D BASE > VERSION_STRING =3D 1.0 > LIBRARY_CLASS =3D BoardAcpiEnableLib >=20 > -[LibraryClasses] > - BaseLib > - PcdLib > - DebugLib > - > [Packages] > MinPlatformPkg/MinPlatformPkg.dec > MdePkg/MdePkg.dec >=20 > [Sources] > - BoardAcpiEnableLib.c > + BoardAcpiEnableLibNull.c > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > index 998ee7909568..da27aa1c4227 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > @@ -79,7 +79,7 @@ [LibraryClasses.common] >=20 >=20 > BoardInitLib|MinPlatformPkg/PlatformInit/Library/BoardInitLibNull/BoardIn= it > LibNull.inf >=20 > BoardAcpiTableLib|MinPlatformPkg/Acpi/Library/BoardAcpiLibNull/BoardAc > piTableLibNull.inf > - > BoardAcpiEnableLib|MinPlatformPkg/Acpi/Library/BoardAcpiLibNull/BoardA > cpiEnableLibNull.inf > + > + > BoardAcpiEnableLib|MinPlatformPkg/Acpi/Library/BoardAcpiEnableLibNull/ > + BoardAcpiEnableLibNull.inf >=20 > SiliconPolicyInitLib|MinPlatformPkg/PlatformInit/Library/SiliconPolicyIni= tLibN > ull/SiliconPolicyInitLibNull.inf >=20 > SiliconPolicyUpdateLib|MinPlatformPkg/PlatformInit/Library/SiliconPolicyU= p > dateLibNull/SiliconPolicyUpdateLibNull.inf >=20 > @@ -150,7 +150,7 @@ [Components] > MinPlatformPkg/Acpi/AcpiSmm/AcpiSmm.inf > MinPlatformPkg/Acpi/AcpiSmm/AcpiStandaloneMm.inf > MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.inf > - MinPlatformPkg/Acpi/Library/BoardAcpiLibNull/BoardAcpiEnableLibNull.in= f > + > + > MinPlatformPkg/Acpi/Library/BoardAcpiEnableLibNull/BoardAcpiEnableLibN > + ull.inf > MinPlatformPkg/Acpi/Library/BoardAcpiLibNull/BoardAcpiTableLibNull.inf >=20 > MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/DxeMultiBoardAcpi > SupportLib.inf >=20 > MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/SmmMultiBoardAc > piSupportLib.inf > -- > 2.28.0.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#73791): https://edk2.groups.io/g/devel/message/73791 > Mute This Topic: https://groups.io/mt/81923537/1767664 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [nathaniel.l.desimone@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20