public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bob Feng" <bob.c.feng@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"ipark@nvidia.com" <ipark@nvidia.com>
Subject: Re: [edk2-devel] [PATCH v2] BaseTools/Python: sys.exit(1) when error occurred
Date: Tue, 2 Jun 2020 09:18:01 +0000	[thread overview]
Message-ID: <BN6PR11MB00681907EC0475C37A82FEBAC98B0@BN6PR11MB0068.namprd11.prod.outlook.com> (raw)
In-Reply-To: <461959c91617bf66a6a3e23c03dc80e62202302d.1591043186.git.ipark@nvidia.com>

Irene,

This patch looks good. For the subject, I think it's that the build will exit with 1 when the AutoGen error occurred.
Would you update the subject to make it more clear?

With the subject update,
Reivewed-by: Bob Feng<bob.c.feng@intel.com>

Thanks,
Bob

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Irene Park
Sent: Tuesday, June 2, 2020 4:28 AM
To: devel@edk2.groups.io
Cc: Irene Park <ipark@nvidia.com>
Subject: [edk2-devel] [PATCH v2] BaseTools/Python: sys.exit(1) when error occurred

From: Irene Park <ipark@nvidia.com>

AutoGen manager/workers halt the progress when an error occurs but doesn't propagate the error code to main and makes main sys.exit(0) and gets the build system unable to catch the occurrence of an error.
This change informs main with an error when a progress is halted and helps main sys.exit(1).

Signed-off-by: Irene Park <ipark@nvidia.com>
---
 BaseTools/Source/Python/build/build.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py
index ed3a3b9..1ab1e60 100755
--- a/BaseTools/Source/Python/build/build.py
+++ b/BaseTools/Source/Python/build/build.py
@@ -880,7 +880,10 @@ class Build():
 
             self.AutoGenMgr.join()
             rt = self.AutoGenMgr.Status
-            return rt, 0
+            err = 0
+            if not rt:
+                err = UNKNOWN_ERROR
+            return rt, err
         except FatalError as e:
             return False, e.args[0]
         except:
@@ -2724,4 +2727,3 @@ if __name__ == '__main__':
     ## 0-127 is a safe return range, and 1 is a standard default error
     if r < 0 or r > 127: r = 1
     sys.exit(r)
-
--
2.7.4





  reply	other threads:[~2020-06-02  9:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01 20:28 [PATCH v2] BaseTools/Python: sys.exit(1) when error occurred Irene Park
2020-06-02  9:18 ` Bob Feng [this message]
2020-06-02 15:32   ` [edk2-devel] " Irene Park
     [not found] <1614857659D31804.27457@groups.io>
2020-06-01 20:31 ` Irene Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN6PR11MB00681907EC0475C37A82FEBAC98B0@BN6PR11MB0068.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox