From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.1331.1588157284054669941 for ; Wed, 29 Apr 2020 03:48:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=RTn+1Zg2; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: bob.c.feng@intel.com) IronPort-SDR: BDtnOGc7lwUWmBrvbTZwWXQZTDBlTHQuU+XIQ5omNe2C7dKxI5HbFv66/ZxSmAJGWIJY3KVvWN GrhgFKtI3TUw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 03:48:03 -0700 IronPort-SDR: GVUJLSPtBC3PQvGqvrqUlqbKHZNlO1m4IpVMV1cCQqpWN2HW3G+cvpZJThIu53wWddH4qWo0Xr E0Ee6fmedc8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,331,1583222400"; d="scan'208";a="276133351" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 29 Apr 2020 03:48:03 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 03:48:02 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 03:48:02 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 03:48:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YSxcu6I0e/lYfka3WWRG9UkslwECSQqV0vL+nwwCPFRRgpAMVP1+RqLiQmeb8M1m3vr2mbtUmOx79mJ2KU17V0OB401Snbi9iPcQFceVmKtgkCH76+8LpX+/q+mVEp4yLizDAEHXeQV2Nt5GLwF1zJy+DmxGpfrKMJPCG2/fnx4WcsJPkKPkv1bvsxfjwKK3FwOX+ixZ9PspkHJTTMEjKs0bsUbQElZPEGh6vdRXwKWR0r6hpuAg72Kn+mtzZ9CW3Na0OZ+6N1P2qHMGossxg7U8Awturvwyx70GpK3upJsUrw4E9CuA+TiQ08BS7ykpnEio2HkTfOBLzChcvcW1ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OeJ2e+lovbnJ9pQO2r9/w0WExLokYAkQqvv3JhtKR7s=; b=P9YsqFk+lRLrL3gIpVLzaNFAPHbP0Re+8vbL2Ru12Gy79RS01y9si2D0wRVghTYCs4odp3pjmK2jGMtOp5tO0FtHT3iXX0/LnBb0gJ3Y7vVQ9tiS6nO5y2ZIIbVcqh+SuF7wxvUWlrvARTfKamwrcuU43GQYCa+rdvmEKlN3fPPDQj6OyDxm42muBzjeDZqkkc82FxDe2c5q2QdbeOzcRkI93cU4eMwRhlOHEDTn00rakmZqSSIlo89GTYBXD6O0hApFWhvUpiEIbYXzbjorVSJOuD7qUIribblXyLGF/Ma5ggk0h9IrtQQl/MSyRUzQRyys9SjAQOsrSVeTViREBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OeJ2e+lovbnJ9pQO2r9/w0WExLokYAkQqvv3JhtKR7s=; b=RTn+1Zg2DlXJ2m4rZUT1S5yCGj0PDgQ8/YpIcxsMTYLjqeEF4nRQrbYyJP7ghvHkexXUl5cYAg0sUXoUuDFyoi3LD2eStsslmlGCxJsYlkOuqce9eQGSV3GQR7+WyIPJw6Cmz7GxLmzqORtl0GxWbz9Wu9rw93jAZyaRWPd0szM= Received: from BN6PR11MB0068.namprd11.prod.outlook.com (2603:10b6:405:69::17) by BN6PR11MB1412.namprd11.prod.outlook.com (2603:10b6:404:48::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Wed, 29 Apr 2020 10:48:01 +0000 Received: from BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::2d53:d47c:1269:d601]) by BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::2d53:d47c:1269:d601%6]) with mapi id 15.20.2937.023; Wed, 29 Apr 2020 10:48:01 +0000 From: "Bob Feng" To: Laszlo Ersek , "abner.chang@hpe.com" CC: "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH v4 0/3] BaseTools: BaseTools changes for RISC-V platform Thread-Topic: [edk2-devel] [PATCH v4 0/3] BaseTools: BaseTools changes for RISC-V platform Thread-Index: AQHWGXvrBxpc/okLLEyBRNeJW0JcvaiP6xwAgAAGjxA= Date: Wed, 29 Apr 2020 10:48:01 +0000 Message-ID: References: <20200423135233.7342-1-abner.chang@hpe.com> <22c7b0d8-9726-a03e-a47b-fac7dcf6ff6f@redhat.com> In-Reply-To: <22c7b0d8-9726-a03e-a47b-fac7dcf6ff6f@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 851d8926-a76e-4ae8-1d06-08d7ec2ac9e0 x-ms-traffictypediagnostic: BN6PR11MB1412: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 03883BD916 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB0068.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(346002)(39860400002)(136003)(376002)(366004)(9686003)(8676002)(55016002)(64756008)(52536014)(66556008)(66446008)(66476007)(2906002)(186003)(478600001)(66946007)(76116006)(8936002)(26005)(53546011)(316002)(6506007)(7696005)(5660300002)(110136005)(966005)(19627235002)(71200400001)(33656002)(86362001)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fYYdGjwRazW7cai5GrLKDzBoEb7xQuckjGD3/8FSXmPYZDG9qmz7MCaSL2V/xnDtL8FP+Vrw7O1hPCk6T63SAoGurxzelQkLMkOQ4VLLMqCdZn19WvvU6rQ4j1Qx9NCVkisGXpO8jTj2+jRollqq/6LahO7q5zO/OOvgmy3hRB6eGVq3/MFBj6NoT4ha70ffXw2D1SvLSabFfDBYf09Tl8OP3FeVfxZKZ5OS9SYDeyQSFXzNIJxHoOrwnrWDoR8sjJV7huTNRHywHMIXe6vu7UPK0s3szWj2qNcHFE9tiAoORKAX/m219xUVo3KlLXAQNKcW+YYCOZUbtEbDyZ1JqFslO7czDvGWnIjbQ440z+C6aqFytNbbBGI42c75P7sXZc+vOJ2EVSqCIUgCHwzZ5ug541umGQDwgoQDI5sUAA3LGwJssom4x8EBal/oATj0MuV+ijAY24HgxW5HH4XKSIJc8Y+caHZ9YLOfPyndPUO1FFbDWSiZYa224f/C5BJ4+9ioyBaZjJJay+lXtSxFow== x-ms-exchange-antispam-messagedata: /mM5hLqwXtTFTFGocKwb1rU7Z6EYoZW4KXrP0nndHq28e9gFx7/SjLHh8USYdiCsiT/OiOoi4T27gdpSItWXU3oB2FO6DJi5FkQDLwxkcIRNAnEqGfWZMK1VBUzM3rrFfSFtV/t8uiaZQJfV3xxZNrFB8lxIIBLeUg0fsMhqfaDrdU0YVizguecg5RUj/L5iI72EADtkAJ3iFwGAU+c//YBqRXYRFpNl4UUcW858oa0t2OojXZKzyyqEVJbUfd/XPSFWyciGNsV21rUkF2rrqvMqh//UvGVyYVjxm0Ef44I9V7DENvy0cu0gtVmz1/G9W8YQ/OioIKlrQBABJ10SSJ0zCCLnPNkq/yRfC1MLfsTmxOVl3v2e83WpPh2yalrXiq+6pbKZlEtQx8nCOk+yVWuNELtyp2zwkx4Tz/5ynfjt/VDacHY2Vp6377MsRDyC3VaUL+mKK+wDFkSMcrcfyPHo8hgO1cwF2xf93fYd2YIxSATf2aU6hsPVSAW5S29mpTVSvBBAWyrarpEUA+gA8+OllXT/pkbxCbuesbGz1SzjW9eMlzm4NXUPVmHWaaK2UvHhACQABCxabaQVeeQ1uK9PefffttEwQFQ6B4sxzQxDsLZRcaojRjL2mSHfHI09aOowyQIdjJ9UoRcA4ZULnYaLG48enpGkE0G8fkEjSWshAwyi5TpNxnbVvwiCSKGNjKj/5oFGIiFOmhTWoeUGPgv7/4UBut3UHf3GEBfeTaYkcqmwVK0MTfeM8r2/GLj42iaHWhZGbUPjWyCa7S3Yr2Th2ANLJfFXVu2A4yUGeJI= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 851d8926-a76e-4ae8-1d06-08d7ec2ac9e0 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2020 10:48:01.4784 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XqgI7cLTc1DosfLuM+mscJr7gD53ukUs9O02uJIKqpnOpiyrp9zhSKr+vG0A81bGdqpFBqBOFhEd/u0q35ROYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1412 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Laszlo, Thanks for the reminder, I'll be more careful about the patch review.=20 Since this patch set early version cause build failure, my focus was mainly= on the code. Thanks, Bob -----Original Message----- From: Laszlo Ersek =20 Sent: Wednesday, April 29, 2020 6:15 PM To: abner.chang@hpe.com; Feng, Bob C Cc: devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH v4 0/3] BaseTools: BaseTools changes for R= ISC-V platform Hi Abner, Bob, On 04/23/20 15:52, Abner Chang wrote: > BZ for entire RISC-V edk2 port, > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2672 >=20 > These commits are verified by below PR, > https://github.com/tianocore/edk2/pull/512 >=20 > In v4, GCC5_ASM_FLAGS is replaced by GCC5_RISCV64_ASM_FLAGS in=20 > tools_def.template in 3/3 patch. >=20 > Abner Chang (3): > BaseTools: BaseTools changes for RISC-V platform. > BaseTools: BaseTools changes for RISC-V platform. > BaseTools: BaseTools changes for RISC-V platform. Please don't write patch subjects like this. If I look at the git commit hi= story now (just the subject lines), I see: $ git log --oneline --reverse cdc3fa54184a..f60d5ca97f25 ad1db975c0ca BaseTools: BaseTools changes for RISC-V platform. 178938b2b9b4 BaseTools: BaseTools changes for RISC-V platform. f60d5ca97f25 BaseTools: BaseTools changes for RISC-V platform. These subjects are nearly useless, especially three of them grouped togethe= r. The following would have been better (trivially composed from the bodies of= the commit messages): BaseTools: C code changes for building EDK2 RISC-V platform BaseTools: Tools def. template updates for building EDK2 RISC-V platform BaseTools: Python code changes for building EDK2 RISC-V platform Bob: please remember that it's reviewer / maintainer responsibility as well= to maintain a high level of commit message quality. The git commit history= is relevant to the entire community, not just BaseTools owners. Thanks Laszlo >=20 > BaseTools/Source/C/Common/PeCoffLib.h | 9 + > BaseTools/Source/C/GenFw/elf_common.h | 62 ++++ > .../C/Include/IndustryStandard/PeImage.h | 6 + > BaseTools/Source/C/Common/BasePeCoff.c | 15 +- > BaseTools/Source/C/Common/PeCoffLoaderEx.c | 86 ++++++ > BaseTools/Source/C/GenFv/GenFvInternalLib.c | 128 +++++++- > BaseTools/Source/C/GenFw/Elf32Convert.c | 5 +- > BaseTools/Source/C/GenFw/Elf64Convert.c | 282 +++++++++++++++++- > BaseTools/Conf/tools_def.template | 53 +++- > BaseTools/Source/Python/Common/DataType.py | 5 +- > BaseTools/Source/Python/build/buildoptions.py | 6 +- > 11 files changed, 638 insertions(+), 19 deletions(-) >=20