From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.20180.1595341628684488519 for ; Tue, 21 Jul 2020 07:27:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=sSqXLyJH; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: bob.c.feng@intel.com) IronPort-SDR: /8dRO+WHOs7EtYbdJKOGNWq9h2OW52g8nk5xLMfstaKvjPwKbxO9ugmdUHOnE4cfWZb5ynedQt 2CRDcAsqVkmA== X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="130207500" X-IronPort-AV: E=Sophos;i="5.75,379,1589266800"; d="scan'208";a="130207500" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2020 07:26:59 -0700 IronPort-SDR: HYxreuQNMSmy2kLgLqIxfcKOzUCVn4cNoqlzEaNOXDRCc+7uVxBhjwE9HxRJtgRY7rkLrdLYM9 FekxVBHqCAyw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,379,1589266800"; d="scan'208";a="362378808" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP; 21 Jul 2020 07:26:59 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 21 Jul 2020 07:26:58 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 21 Jul 2020 07:26:58 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Jul 2020 07:26:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=luGZwQf3qNpBwDc3W9zIDsuKyGu8MirNtLUl6AAUSLMOCOugdX9dUx66OFkU4UdPNE5kWEsMVcIIz0sNK582R/D+twbGOXEu4AA/tWJ9wcz1LAzVj12h9NqGzbLgLBfN50/tU0h5hKq0D22FpZRmjzNSeZ16mQrhi4hPTePRhoJXnFXYa7VpkCJ57Lgl+ejOonRkolwXxcSdLg25gvNIB6f+0TxulZD10NfjjbcLfV/J1vrTefnwGXZ/wQUo9SKstTLouqQrTIZdLOXVnIYp1uc0CISQJ8+MWQQU2ckYhDgNZnQDiGSt6MbzAEZ5wnwmxs5LHhKqpFocdDDzAz4UIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TdcXt+s2DxB2U2UowVYaqwL4Drv2QExfyOAPRqcdIec=; b=f4TfyMeG28Any3C1mNeXk73K5Y/LqnaLZnBdN++mA0zB3RuYlaujEXYMYrS+iO8lwjU2Fx7511qcz/m38lUcbu6kERO7Qdi3RYabjJAzEWFw1Vpr7e3TeWGTkCSBmtafoqyqYGu1w55O5UJWkT8nF6ndTRhRO22jEKgbfRZTYj1TBzGvmuw4AzQx9ohaLD9FRhsdPsRCywrrVZZwIGbcXKfVj1smGuAjB+rlniW9qEMMK5Ud5EFA39tACD4GG6B5EbNG4nXoyjF798DvJqmlucwO6b1voK3TmF2ecnrF+OtjawUTdytzgiPgQHn8uiuPhx1Jjx2Q2Cw0uziJyBkkrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TdcXt+s2DxB2U2UowVYaqwL4Drv2QExfyOAPRqcdIec=; b=sSqXLyJHT5X+4XMvezTWuMw/NBtBlQrOEdZhlo1fz3nGI/YQhsxRKunK+0Ykf+VfgS3VaxBGvVi3L2msz6sYJS62i5f6NSDTDmD3cMgIEYpnwOxhANDv5l05RMC//otq3bRhFR3VjYDnHl1xROHzIgbPMtWFnDBAmxa4mB5irFo= Received: from BN6PR11MB0068.namprd11.prod.outlook.com (2603:10b6:405:69::17) by BN6PR1101MB2161.namprd11.prod.outlook.com (2603:10b6:405:52::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Tue, 21 Jul 2020 14:26:57 +0000 Received: from BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::f4b6:406b:26fc:c069]) by BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::f4b6:406b:26fc:c069%3]) with mapi id 15.20.3195.026; Tue, 21 Jul 2020 14:26:57 +0000 From: "Bob Feng" To: Leif Lindholm , "devel@edk2.groups.io" CC: Pierre Gondois , Laszlo Ersek Subject: Re: [PATCH 1/1] EmbeddedPkg: fix gcc build errors in AndroidBootImgLib Thread-Topic: [PATCH 1/1] EmbeddedPkg: fix gcc build errors in AndroidBootImgLib Thread-Index: AQHWX12beuQEr4hZsEeifChqO0bxVqkSCpMQ Date: Tue, 21 Jul 2020 14:26:57 +0000 Message-ID: References: <20200721125056.32195-1-leif@nuviainc.com> In-Reply-To: <20200721125056.32195-1-leif@nuviainc.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a4c973b4-403d-4d9b-0086-08d82d821fab x-ms-traffictypediagnostic: BN6PR1101MB2161: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JUa/wuu2l+PSGRRj+qP5FR2eKzyB1IKPG+GTPqf3rJq9J2iSCUQpGDQQCzuuBSZSb0q4ARpJJATi07yB9IpWZnptFKESP7jBB53jeXnuQHBPdums07weHnCS3L4hPrTrGwf7zVOeCle6EloewNz0x8CL9VTLS+Nv1/nZFfpAuQC4j491NGh9aKayGWguVOnOzzfPwpaRTdWWyNSJjPCIjYYtLSsu1iGhzWfQbWX+/+kUSf728Qc23zGIvx2VUy7/bB3tkzP5iNWaZ2uWTQ9pkBUPSoNd5snNexgXK1B/lEnSBUrSTRLl9L5qUjPljl9GbNqSnfHXA5nt1lP8+9iRSA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB0068.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(376002)(346002)(136003)(366004)(396003)(6506007)(53546011)(8936002)(54906003)(186003)(8676002)(5660300002)(26005)(478600001)(71200400001)(316002)(110136005)(86362001)(4326008)(7696005)(83380400001)(2906002)(55016002)(33656002)(9686003)(66556008)(64756008)(52536014)(76116006)(19627235002)(66446008)(66946007)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: qHzVCVRc1j5zfXdjEfF4AcRga81zQE+ZDXyhZu4obtVDpPBtULlkVsnyD3kBG804wuvJLQSp60SZllI/j0v+Z2Qj+ospmwehOq/9fYbHsrRLgVDIeJgjMM+4krAlj+5YzaBCpTRQCNFlaLMlFBE5S4Udl96IjIr/Tb2ltFDFYA54nNN/Srxm7S2iS1Rl64cip7YOW46XtFK7Pk5s5U5sWeI2b7IiRmZXjYoh1y50c+GlIE0ak7L+jwoPc3Y8BPJuGJda0lnbdJtzwgusL2ActOArGFVerKCnGlI9QYqJDK4FF63xVV2zoZeChWkVSXYVBUOq8wbJbHH6YeAA3GcLZwHLAJ15as/Ty/u6UyyD2RUB2sHnu5a5BwKMX8q47yVmZFgTMj6IMfAAn0CzH5i0I6bpbUdtd1FV8ntsvoCb3toPf/NiRylLFn53b0GFO1OuDSMTJr6NxV72BbcZQ/X3XCiTRzfUyU45qXHdSCgr75qGdXUDCI0X0oDN2LuErBB+ x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0068.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4c973b4-403d-4d9b-0086-08d82d821fab X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 14:26:57.0845 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NjF8rWn0FEBnlWwYue2kQTIM8MHNpmesvyDAlviqQSU7hKIqwjYcumnqZr78DgiZF7KP/cf6hgHWhnd7sP8GAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2161 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif, Sorry about this patch cause some build break.=20 I'd agree to split the tools_def.template into multiple smaller files that = would be helpful for maintenance.=20 Thanks, Bob -----Original Message----- From: Leif Lindholm =20 Sent: Tuesday, July 21, 2020 8:51 PM To: devel@edk2.groups.io Cc: Pierre Gondois ; Laszlo Ersek ; Feng, Bob C Subject: [PATCH 1/1] EmbeddedPkg: fix gcc build errors in AndroidBootImgLib Commit dbd546a32d5a ("BaseTools: Add gcc flag to warn on void* pointer arithmetic") does its wo= rk and triggers build errors in this library. Update the affected code to build correctly again. Cc: Pierre Gondois Cc: Laszlo Ersek Cc: Bob Feng Signed-off-by: Leif Lindholm --- Pierre - can you please ensure to CC Arm maintainers when proposing changes= to Arm build flags? (And build test all the top-level edk2 packages *cough= *.) Bob - can you please ensure Arm maintainers have commented on changes to gl= obal build flags? (Would it be possible to break up tools_def.template into separate arch-spe= cific include files so we could have GetMaintainer.py be more helpful for t= his?) Laszlo - you're not formally an EmbeddedPkg reviewer, but Ard is out for an= other couple of weeks. But since the Linaro CI is currently broken and the = fix is trivial, could you have a look please? EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c b/Em= beddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c index e1036954ee58..15b5bf451330 100644 --- a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c +++ b/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c @@ -97,7 +97,7 @@ AndroidBootImgGetKernelInfo ( ASSERT (IS_VALID_ANDROID_PAGE_SIZE (Header->PageSize)); =20 *KernelSize =3D Header->KernelSize; - *Kernel =3D BootImg + Header->PageSize; + *Kernel =3D (VOID *)((UINTN)BootImg + Header->PageSize); return EFI_SUCCESS; } =20 @@ -341,7 +341,7 @@ AndroidBootImgUpdateFdt ( =20 Status =3D AndroidBootImgSetProperty64 (UpdatedFdtBase, ChosenNode, "linux,initrd-end", - (UINTN)(RamdiskData + RamdiskSize)= ); + ((UINTN)RamdiskData +=20 + RamdiskSize)); if (EFI_ERROR (Status)) { goto Fdt_Exit; } -- 2.20.1