From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.8603.1591169029800890706 for ; Wed, 03 Jun 2020 00:23:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=kVuRVca6; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: bob.c.feng@intel.com) IronPort-SDR: T393rhH7CsPUTqxi1XBKMjviPkRjIS1skHJWhK4DdfrcRmbXPOomby7N375+cQH8qzBYrsaAnS ae2/Czkrm4AA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2020 00:23:48 -0700 IronPort-SDR: P6ho2qP8AeKu/Zy3K/7J2FFNVwVd7U824O48Z9HB6Dk0PTom1RRh4krT293AJCmUzv33Culohc 62QsIlkhrOTg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,467,1583222400"; d="scan'208";a="257358735" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by fmsmga007.fm.intel.com with ESMTP; 03 Jun 2020 00:23:48 -0700 Received: from orsmsx123.amr.corp.intel.com (10.22.240.116) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 3 Jun 2020 00:23:48 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX123.amr.corp.intel.com (10.22.240.116) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 3 Jun 2020 00:23:47 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 3 Jun 2020 00:23:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WFO/xLrxDmgwoGZwS8xRCnDvv+ggwquZ6zG1XvavV1H8gaZzdp7Yoto1zktBPYQk5WGVxmAHHCEW3gUo1nbRtaR5BFLWo/F6cXRzpUc1ghgt6orXgbJbdYcv+dSn+fX5ROib3Bg4fpGB/3ku3LECSvS+00y6VUt2oBWJmSPU7bVMWYSfNSHLxtBXZlhFILxJayTbID+XMENWCIq18hVagJzLjbC6Q39qhIHvs15OgHLBwTTfHe7uD/vicoUnnDh3ACwnB9eIZQZJGgna3VvY22MGlAXSs+qhYiJ60wvdWNeM7ytXyoKzCk8FpdjhWebXEX4an2Tyn1oREPbG0S1F7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SL8PHmDRxKkILTADCEs8aDnU7ro8LxzS63avAqGcfxU=; b=aNa/IZF88yACw3MHS+smCOn8PkKds9WsToqZ3x9mKzrY3n5jwtQxFs+iwCvspieI53e8aEBCeqjgnwTg2IZQL97zchNGctjgVqRrskGaFi+CQD8EmTj+gWEAle3U3mOmFvIMZ/Zw+vI4g6xQLUZXTmHjvvAT28WsNxpwjAH0Q+3Z3W/IerAiUpVQtxYi+QL4kuZcMKllHOnJW+fb2R5lZk5Jao7tiQIdXveJ/WICC43y/EPQ1ZUFIuaz1rFYc9wEvcry+e46cZbV43CrGfzpbq9HwPmTVZrK1RFCB7Tas1mDse6YlDIXSInNi1Id376/K0ptVdcKQ1at3pqijlsNgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SL8PHmDRxKkILTADCEs8aDnU7ro8LxzS63avAqGcfxU=; b=kVuRVca6R3P/0DvP7lG6W6h8dSRB86rF7CwQfIKVJDcWIbGKvbVfkKe7SEDqgY+lQMQnSLPLYTi8UaS6GZyIQfSoZ74uDkfYTGEsCcrF9rUQulkU0JdzI52k1s8zCQLe6XkN6SPqMr7kiUgOoIb9r4XcUtsm4k6Ryr0tPqKKZmI= Received: from BN6PR11MB0068.namprd11.prod.outlook.com (2603:10b6:405:69::17) by BN6PR11MB3874.namprd11.prod.outlook.com (2603:10b6:405:81::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18; Wed, 3 Jun 2020 07:23:46 +0000 Received: from BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::2d53:d47c:1269:d601]) by BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::2d53:d47c:1269:d601%6]) with mapi id 15.20.3045.022; Wed, 3 Jun 2020 07:23:46 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "ipark@nvidia.com" Subject: Re: [edk2-devel] [PATCH] BaseTools/build.py: Exit with 1 when AutoGen error occurred Thread-Topic: [edk2-devel] [PATCH] BaseTools/build.py: Exit with 1 when AutoGen error occurred Thread-Index: AQHWOSkYQmnyNrSpzk+wAVu1hJRVF6jGfW5g Date: Wed, 3 Jun 2020 07:23:46 +0000 Message-ID: References: <09637bf9f163742b1ebdd3700441c4b808e55b50.1591135082.git.ipark@nvidia.com> In-Reply-To: <09637bf9f163742b1ebdd3700441c4b808e55b50.1591135082.git.ipark@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d3e6e0dd-1fe7-4f86-5ba9-08d8078f0de8 x-ms-traffictypediagnostic: BN6PR11MB3874: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-forefront-prvs: 04238CD941 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dhPYK9fSVxIShIIvVMITwVseaaWbxrWa9sh7Uc/NiCp3LboijXutjb2R+9jxKWdFkuVlc/mRtCeTzJulb0Y6X5KFlROqfw9kOfEpHgcCykJgsu2ETkMsskR+aGwTolSL4HYjO+ghX1+OKsoib89ePT9enmcBY/1M8oYaxBiwWc5VaaSJV7ChSj51j8Jcq/OcbdTkxAlJ4nIM3YZRLAkRW0mpVqteOvYnzlIZz45PqiYBKsLirWRQ+4ZyRIa5l9LbEuSNVZWul8o/0Go9woHXs3oyNkVdfvqLExkWw1KYLLppigVgeD45fb5AgMTPs6eMZAZ+QKUElXWj+bDJUOmoiHS67zUS8ELvhqV6mF/OeFNIONWbfI0Lf/+unTTmGgi1M2ZgxV2drrPf0KlD7pEueA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB0068.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(136003)(346002)(366004)(396003)(376002)(39860400002)(33656002)(966005)(478600001)(5660300002)(83380400001)(52536014)(71200400001)(8936002)(8676002)(7696005)(2906002)(66476007)(66556008)(9686003)(6506007)(76116006)(53546011)(26005)(110136005)(66946007)(55016002)(186003)(316002)(86362001)(64756008)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: jkOZOj9rAhFfJ+Lji8XcFrZRQWzvtJX7rZz0cDA+fgT8JhCVYve+EBx5fH4gekPtV+o+c8toVcL54IvQp/0dKKAb6i47t76NYmEqtqgHxlkcIj3ctwMy+HlD+QMCvPEfH/RX17qBRZxQHPPhTh+uX1IUaaH4Zu0y9xoxx/vmYOxsL2HG+GM6g2LwXCqhcUbvaPaBu4dqprLm+fUgC7bSZkLb3GBp17YfRppRCVyqD9MWzcr3rhu0/x9aVXtlyl1bcyrCPMuAHabbmv83I9Ld9mrZiFgFlqzSzJ1LOMHHFjgS156AzQSXHAb7VpvYfGJcI5clh4tIMwtOtnrdfaE6hfSYl52YMwQEH7X8w46GtlGr1w3P6XwwBUvZ2WmmP6oZmWiEnJJQSADLRBeDRWZIHfksVbWI9WwMOuPuY4Hn0qtwszuFlHXTP18+S7Ip6Sivo663gG8JOcJ76l7v3tbB3/kBD+RWCd/mddPxhFct8cTRkkYCBOCt1irZ3bImR+uI x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d3e6e0dd-1fe7-4f86-5ba9-08d8078f0de8 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2020 07:23:46.7254 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BJeu7ppU0Gi3OsOrZ6SEX9OZH4oERVSlo8hgTiEWPuxGeeaVLVSKmPMp8FmsqoQPtyQAgbQAF684K8P0CmlPzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3874 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io On Behalf Of Irene Park Sent: Wednesday, June 3, 2020 5:59 AM To: devel@edk2.groups.io Cc: Irene Park Subject: [edk2-devel] [PATCH] BaseTools/build.py: Exit with 1 when AutoGen= error occurred From: Irene Park AutoGen manager/workers halt the progress when an error occurs but doesn't= propagate the error code to main and allows main exit with 0 and gets the = build system unable to catch the occurrence of an error. This change informs main with an error when a progress is halted and helps= main exit with 1. Signed-off-by: Irene Park --- BaseTools/Source/Python/build/build.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Pyt= hon/build/build.py index ed3a3b9..1ab1e60 100755 --- a/BaseTools/Source/Python/build/build.py +++ b/BaseTools/Source/Python/build/build.py @@ -880,7 +880,10 @@ class Build(): =20 self.AutoGenMgr.join() rt =3D self.AutoGenMgr.Status - return rt, 0 + err =3D 0 + if not rt: + err =3D UNKNOWN_ERROR + return rt, err except FatalError as e: return False, e.args[0] except: @@ -2724,4 +2727,3 @@ if __name__ =3D=3D '__main__': ## 0-127 is a safe return range, and 1 is a standard default error if r < 0 or r > 127: r =3D 1 sys.exit(r) - -- 2.7.4