* [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by
@ 2020-07-16 3:13 Zhang, Shenglei
2020-07-16 7:19 ` Liming Gao
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Zhang, Shenglei @ 2020-07-16 3:13 UTC (permalink / raw)
To: devel; +Cc: Bob Feng, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2836
Current PatchCheck.py checks each line to ensure line's length is not
larger than 76. But there's a case that length of user's name is much
longer than that number. So enhance the script to handle this case.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
BaseTools/Scripts/PatchCheck.py | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py
index 52244b0bc4d8..7db0775d14d1 100755
--- a/BaseTools/Scripts/PatchCheck.py
+++ b/BaseTools/Scripts/PatchCheck.py
@@ -268,7 +268,14 @@ class CommitMessageCheck:
for i in range(2, count):
if (len(lines[i]) >= 76 and
len(lines[i].split()) > 1 and
- not lines[i].startswith('git-svn-id:')):
+ not lines[i].startswith('git-svn-id:') and
+ not lines[i].startswith('Reviewed-by') and
+ not lines[i].startswith('Acked-by:') and
+ not lines[i].startswith('Tested-by:') and
+ not lines[i].startswith('Reported-by:') and
+ not lines[i].startswith('Suggested-by:') and
+ not lines[i].startswith('Signed-off-by:') and
+ not lines[i].startswith('Cc:')):
#
# Print a warning if body line is longer than 75 characters
#
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by
2020-07-16 3:13 [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Zhang, Shenglei
@ 2020-07-16 7:19 ` Liming Gao
2020-07-16 8:26 ` [edk2-devel] " Yuwei Chen
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Liming Gao @ 2020-07-16 7:19 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io; +Cc: Feng, Bob C
Reviewed-by: Liming Gao <liming.gao@intel.com>
-----Original Message-----
From: Zhang, Shenglei <shenglei.zhang@intel.com>
Sent: 2020年7月16日 11:14
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2836
Current PatchCheck.py checks each line to ensure line's length is not larger than 76. But there's a case that length of user's name is much longer than that number. So enhance the script to handle this case.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
BaseTools/Scripts/PatchCheck.py | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index 52244b0bc4d8..7db0775d14d1 100755
--- a/BaseTools/Scripts/PatchCheck.py
+++ b/BaseTools/Scripts/PatchCheck.py
@@ -268,7 +268,14 @@ class CommitMessageCheck:
for i in range(2, count):
if (len(lines[i]) >= 76 and
len(lines[i].split()) > 1 and
- not lines[i].startswith('git-svn-id:')):
+ not lines[i].startswith('git-svn-id:') and
+ not lines[i].startswith('Reviewed-by') and
+ not lines[i].startswith('Acked-by:') and
+ not lines[i].startswith('Tested-by:') and
+ not lines[i].startswith('Reported-by:') and
+ not lines[i].startswith('Suggested-by:') and
+ not lines[i].startswith('Signed-off-by:') and
+ not lines[i].startswith('Cc:')):
#
# Print a warning if body line is longer than 75 characters
#
--
2.18.0.windows.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by
2020-07-16 3:13 [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Zhang, Shenglei
2020-07-16 7:19 ` Liming Gao
@ 2020-07-16 8:26 ` Yuwei Chen
2020-07-21 3:35 ` Bob Feng
2020-07-21 3:38 ` Bob Feng
3 siblings, 0 replies; 7+ messages in thread
From: Yuwei Chen @ 2020-07-16 8:26 UTC (permalink / raw)
To: devel@edk2.groups.io, Zhang, Shenglei
Reviewed-by: Yuwei Chen<yuwei.chen@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhang,
> Shenglei
> Sent: Thursday, July 16, 2020 11:14 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Skip length check
> for user name in xxx-by
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2836
> Current PatchCheck.py checks each line to ensure line's length is not larger
> than 76. But there's a case that length of user's name is much longer than
> that number. So enhance the script to handle this case.
>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> BaseTools/Scripts/PatchCheck.py | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/BaseTools/Scripts/PatchCheck.py
> b/BaseTools/Scripts/PatchCheck.py index 52244b0bc4d8..7db0775d14d1
> 100755
> --- a/BaseTools/Scripts/PatchCheck.py
> +++ b/BaseTools/Scripts/PatchCheck.py
> @@ -268,7 +268,14 @@ class CommitMessageCheck:
> for i in range(2, count):
> if (len(lines[i]) >= 76 and
> len(lines[i].split()) > 1 and
> - not lines[i].startswith('git-svn-id:')):
> + not lines[i].startswith('git-svn-id:') and
> + not lines[i].startswith('Reviewed-by') and
> + not lines[i].startswith('Acked-by:') and
> + not lines[i].startswith('Tested-by:') and
> + not lines[i].startswith('Reported-by:') and
> + not lines[i].startswith('Suggested-by:') and
> + not lines[i].startswith('Signed-off-by:') and
> + not lines[i].startswith('Cc:')):
> #
> # Print a warning if body line is longer than 75 characters
> #
> --
> 2.18.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by
2020-07-16 3:13 [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Zhang, Shenglei
2020-07-16 7:19 ` Liming Gao
2020-07-16 8:26 ` [edk2-devel] " Yuwei Chen
@ 2020-07-21 3:35 ` Bob Feng
2020-07-21 3:38 ` Bob Feng
3 siblings, 0 replies; 7+ messages in thread
From: Bob Feng @ 2020-07-21 3:35 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io; +Cc: Gao, Liming
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: Zhang, Shenglei <shenglei.zhang@intel.com>
Sent: Thursday, July 16, 2020 11:14 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2836
Current PatchCheck.py checks each line to ensure line's length is not larger than 76. But there's a case that length of user's name is much longer than that number. So enhance the script to handle this case.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
BaseTools/Scripts/PatchCheck.py | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index 52244b0bc4d8..7db0775d14d1 100755
--- a/BaseTools/Scripts/PatchCheck.py
+++ b/BaseTools/Scripts/PatchCheck.py
@@ -268,7 +268,14 @@ class CommitMessageCheck:
for i in range(2, count):
if (len(lines[i]) >= 76 and
len(lines[i].split()) > 1 and
- not lines[i].startswith('git-svn-id:')):
+ not lines[i].startswith('git-svn-id:') and
+ not lines[i].startswith('Reviewed-by') and
+ not lines[i].startswith('Acked-by:') and
+ not lines[i].startswith('Tested-by:') and
+ not lines[i].startswith('Reported-by:') and
+ not lines[i].startswith('Suggested-by:') and
+ not lines[i].startswith('Signed-off-by:') and
+ not lines[i].startswith('Cc:')):
#
# Print a warning if body line is longer than 75 characters
#
--
2.18.0.windows.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by
2020-07-16 3:13 [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Zhang, Shenglei
` (2 preceding siblings ...)
2020-07-21 3:35 ` Bob Feng
@ 2020-07-21 3:38 ` Bob Feng
2020-07-21 5:20 ` Zhang, Shenglei
3 siblings, 1 reply; 7+ messages in thread
From: Bob Feng @ 2020-07-21 3:38 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io; +Cc: Gao, Liming
Shenglei,
After you send out the patch for review, please update the Bugzilla status as in-progress and provide the code review link.
Thanks,
Bob
-----Original Message-----
From: Zhang, Shenglei <shenglei.zhang@intel.com>
Sent: Thursday, July 16, 2020 11:14 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2836
Current PatchCheck.py checks each line to ensure line's length is not larger than 76. But there's a case that length of user's name is much longer than that number. So enhance the script to handle this case.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
BaseTools/Scripts/PatchCheck.py | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index 52244b0bc4d8..7db0775d14d1 100755
--- a/BaseTools/Scripts/PatchCheck.py
+++ b/BaseTools/Scripts/PatchCheck.py
@@ -268,7 +268,14 @@ class CommitMessageCheck:
for i in range(2, count):
if (len(lines[i]) >= 76 and
len(lines[i].split()) > 1 and
- not lines[i].startswith('git-svn-id:')):
+ not lines[i].startswith('git-svn-id:') and
+ not lines[i].startswith('Reviewed-by') and
+ not lines[i].startswith('Acked-by:') and
+ not lines[i].startswith('Tested-by:') and
+ not lines[i].startswith('Reported-by:') and
+ not lines[i].startswith('Suggested-by:') and
+ not lines[i].startswith('Signed-off-by:') and
+ not lines[i].startswith('Cc:')):
#
# Print a warning if body line is longer than 75 characters
#
--
2.18.0.windows.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by
2020-07-21 3:38 ` Bob Feng
@ 2020-07-21 5:20 ` Zhang, Shenglei
2020-07-21 5:58 ` Bob Feng
0 siblings, 1 reply; 7+ messages in thread
From: Zhang, Shenglei @ 2020-07-21 5:20 UTC (permalink / raw)
To: Feng, Bob C, devel@edk2.groups.io; +Cc: Gao, Liming
Bob,
Code review is for our internal use. Should I append it on Bugzilla?
Thanks,
Shenglei
> -----Original Message-----
> From: Feng, Bob C <bob.c.feng@intel.com>
> Sent: Tuesday, July 21, 2020 11:39 AM
> To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: RE: [PATCH] BaseTools/PatchCheck.py: Skip length check for user
> name in xxx-by
>
> Shenglei,
>
> After you send out the patch for review, please update the Bugzilla status as
> in-progress and provide the code review link.
>
> Thanks,
> Bob
>
> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Thursday, July 16, 2020 11:14 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name
> in xxx-by
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2836
> Current PatchCheck.py checks each line to ensure line's length is not larger
> than 76. But there's a case that length of user's name is much longer than
> that number. So enhance the script to handle this case.
>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> BaseTools/Scripts/PatchCheck.py | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/BaseTools/Scripts/PatchCheck.py
> b/BaseTools/Scripts/PatchCheck.py index 52244b0bc4d8..7db0775d14d1
> 100755
> --- a/BaseTools/Scripts/PatchCheck.py
> +++ b/BaseTools/Scripts/PatchCheck.py
> @@ -268,7 +268,14 @@ class CommitMessageCheck:
> for i in range(2, count):
> if (len(lines[i]) >= 76 and
> len(lines[i].split()) > 1 and
> - not lines[i].startswith('git-svn-id:')):
> + not lines[i].startswith('git-svn-id:') and
> + not lines[i].startswith('Reviewed-by') and
> + not lines[i].startswith('Acked-by:') and
> + not lines[i].startswith('Tested-by:') and
> + not lines[i].startswith('Reported-by:') and
> + not lines[i].startswith('Suggested-by:') and
> + not lines[i].startswith('Signed-off-by:') and
> + not lines[i].startswith('Cc:')):
> #
> # Print a warning if body line is longer than 75 characters
> #
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by
2020-07-21 5:20 ` Zhang, Shenglei
@ 2020-07-21 5:58 ` Bob Feng
0 siblings, 0 replies; 7+ messages in thread
From: Bob Feng @ 2020-07-21 5:58 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io; +Cc: Gao, Liming
Shenglei,
I mean this link https://edk2.groups.io/g/devel/message/62647
Thanks,
Bob
-----Original Message-----
From: Zhang, Shenglei <shenglei.zhang@intel.com>
Sent: Tuesday, July 21, 2020 1:21 PM
To: Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io
Cc: Gao, Liming <liming.gao@intel.com>
Subject: RE: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by
Bob,
Code review is for our internal use. Should I append it on Bugzilla?
Thanks,
Shenglei
> -----Original Message-----
> From: Feng, Bob C <bob.c.feng@intel.com>
> Sent: Tuesday, July 21, 2020 11:39 AM
> To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: RE: [PATCH] BaseTools/PatchCheck.py: Skip length check for
> user name in xxx-by
>
> Shenglei,
>
> After you send out the patch for review, please update the Bugzilla
> status as in-progress and provide the code review link.
>
> Thanks,
> Bob
>
> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Thursday, July 16, 2020 11:14 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: [PATCH] BaseTools/PatchCheck.py: Skip length check for user
> name in xxx-by
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2836
> Current PatchCheck.py checks each line to ensure line's length is not
> larger than 76. But there's a case that length of user's name is much
> longer than that number. So enhance the script to handle this case.
>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> BaseTools/Scripts/PatchCheck.py | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/BaseTools/Scripts/PatchCheck.py
> b/BaseTools/Scripts/PatchCheck.py index 52244b0bc4d8..7db0775d14d1
> 100755
> --- a/BaseTools/Scripts/PatchCheck.py
> +++ b/BaseTools/Scripts/PatchCheck.py
> @@ -268,7 +268,14 @@ class CommitMessageCheck:
> for i in range(2, count):
> if (len(lines[i]) >= 76 and
> len(lines[i].split()) > 1 and
> - not lines[i].startswith('git-svn-id:')):
> + not lines[i].startswith('git-svn-id:') and
> + not lines[i].startswith('Reviewed-by') and
> + not lines[i].startswith('Acked-by:') and
> + not lines[i].startswith('Tested-by:') and
> + not lines[i].startswith('Reported-by:') and
> + not lines[i].startswith('Suggested-by:') and
> + not lines[i].startswith('Signed-off-by:') and
> + not lines[i].startswith('Cc:')):
> #
> # Print a warning if body line is longer than 75 characters
> #
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-07-21 5:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-16 3:13 [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Zhang, Shenglei
2020-07-16 7:19 ` Liming Gao
2020-07-16 8:26 ` [edk2-devel] " Yuwei Chen
2020-07-21 3:35 ` Bob Feng
2020-07-21 3:38 ` Bob Feng
2020-07-21 5:20 ` Zhang, Shenglei
2020-07-21 5:58 ` Bob Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox