From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.11925.1595302515673987216 for ; Mon, 20 Jul 2020 20:35:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=u2Ws8Cl7; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: bob.c.feng@intel.com) IronPort-SDR: +bS+gwUwlz+tSro/NTlacW/3RDR1YlECFNGpevXpuodA1ya5YaM1DVJXh0OSXWIiOZpSRwjE2w 2Gkx5Szl4jjQ== X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="168196519" X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="168196519" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 20:35:15 -0700 IronPort-SDR: nKhM0SAMEYpsgu0Q3Ju47o3/jkKgCTkW7RSiaHd1sLQSEKtCsiKnQKl1XvkQtQYscmvcQHW5NJ LvOmjdljpu8w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="362229920" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga001.jf.intel.com with ESMTP; 20 Jul 2020 20:35:14 -0700 Received: from orsmsx156.amr.corp.intel.com (10.22.240.22) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 20:35:14 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX156.amr.corp.intel.com (10.22.240.22) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 20:35:14 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 20:35:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d0CAcc46XmIHqz5S9tEt9D8aoWY7RWRmOfeRlJzRnmHhjBAXEhIcUGqgjyv1/ZulaOUfrHYGsUKH78d757PjmxSsOj3eR/YXuOBYjEYtYBSttuYyPDg/M19pH1r5GrJOW8muWnysCL+Rd/YXZqdpD4BVa2h2Nbwecg0QKEad05tw8ev9MJoWf+clAJSpz0us/FMeCKTiDHY/ykpdlO7jiQadNV/SXmWK0GMReR3XxiflMPs0OeuiiqjEPTmMxfcXl6AeLHEB5Ru1iYJH8Iy0twg1AEopXnrIeLUwkHdoIurZ5yFtYWCdw6dMIdCeJbvqiFNMUQ9s1Q47jrLHJN5b6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jXHvNClynSzF19paBig9r+XUwg4Xh9Zbcw/lVIpKSDA=; b=deSp2XofvCPsu0NnvzERyHwMsntJ/O0Zr3FqparpdeCC7n49NrWH7IBwRzG9yFGi1fBB+BG2ISX0lR8wPWFg2RZlJUNQAS0uLHfJDsF4aqIPr3E7JpIFo0wn065iIRLlWuHDuc8BcshUwKoXCSc/Fh8xCPqXmCrFagg+VZ9Uh0CXLMHZqh4Y4K2S5d1TBBrxZFnOA/rRKmmiLRVqfOnSeTufGeJ0E6896hZz1KbLB5GLRrAolUcCY0FfY4PC3NIPPtx/qN0obUfrmqYcjdZpQNEF6MOILL4aB2DTFNwMdBWEbA49/NgL+mB3nS6Iq1LaSRhxtByvrzthWAosIfTZ1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jXHvNClynSzF19paBig9r+XUwg4Xh9Zbcw/lVIpKSDA=; b=u2Ws8Cl7zoMMDU1+cx9KN6BII5aoxs2JX8mm170mbHiTY/17SwwjevYkPzYvpJQ9Sfo/umr6HcxWLGU6OuXyuSOXoC8qyXpoG5K3l3h0sSKhzT9de+2GfZSJTbErW+9gr3ne+Cr024iamPVen0hSiQey9IxdVmpCPthZWEtf1mc= Received: from BN6PR11MB0068.namprd11.prod.outlook.com (2603:10b6:405:69::17) by BN6PR11MB1828.namprd11.prod.outlook.com (2603:10b6:404:103::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18; Tue, 21 Jul 2020 03:35:13 +0000 Received: from BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::f4b6:406b:26fc:c069]) by BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::f4b6:406b:26fc:c069%3]) with mapi id 15.20.3195.026; Tue, 21 Jul 2020 03:35:13 +0000 From: "Bob Feng" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Thread-Topic: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Thread-Index: AQHWWx8nXHxhR0orXEWpJLKfHDlYCakRaZcQ Date: Tue, 21 Jul 2020 03:35:12 +0000 Message-ID: References: <20200716031346.40160-1-shenglei.zhang@intel.com> In-Reply-To: <20200716031346.40160-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 309110bf-cdb9-42a1-ad88-08d82d2713be x-ms-traffictypediagnostic: BN6PR11MB1828: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2089; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kqHfkPDS3SrvSG0lrGoj4OTm332DaA0ddUo4HE+dcDfi8rp3LuCePORyckZDJspVV06/wJM7EgNMj6nUN1kCFraGspUiQHG2/zROcnIVJOiCnSxh8MpZJoIH49LJWGgZRhXWWR73k/Tm4GkiZRopbnklVjwqonk9j9cZX9QDWIxSYYKDcDxe8Cncxx+Xz9LHBPJD9xyRiLrGWKZQfFNz7IOHYat82D7qlPXHExb+hMiQ9/XxqULa2frXW9QVHtEoW1zkuhMX4TUhB/HmSnJHJJUCbYuV9eeQfN8Beoxy7/zIrmO9enE+8ZtnKeRzPx8GnDNLzHCB+3m3mwOJAlUnA/f4+00H0WgrCpGatSSHLau4+ZN1YrctZpD3/dkYMuToSKQeJDRv8eSQgfJXSkjHuBVNN/ytR3B/3giUNX6jsk27KHdeoCMur2Bb6R5ckcnxLV4EsInIfDG3N3A6h7x5SYOCeN48w6YeMTDKb2YqQ4U= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB0068.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(376002)(346002)(366004)(396003)(39860400002)(4326008)(966005)(478600001)(83380400001)(2906002)(9686003)(5660300002)(110136005)(8936002)(316002)(107886003)(66476007)(66556008)(66946007)(66446008)(76116006)(8676002)(64756008)(55016002)(186003)(26005)(7696005)(33656002)(52536014)(6506007)(53546011)(71200400001)(86362001)(13513002)(21314003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: /q3s2D30dY/xqKUzukYNXhC3aTXf3ZszPGt469a3Z2tqo+qyAZnFnCgM7qiq2PqTXzZkq0N13WwjLlSGXTFXNL6DGXXLc4HEGmOFa7+L9Q9JHn5y4K37++4lqgDYcBkktj/kuCcgepPjoJhsXwZTZRYb0E3yGmsdEoiezpr3rncrSebxga/pA7Rno4euFkkq9dGJLhTxq9QgEmgDbf4xXMA+xoB1YREV7mnismv2BlEgmzCVqQFGG5sRzck9OlU2Be8rYS2Nte5n13Jkf0hQHFgI7NKKm0hF/mDzsQp8q/qaAkukgKwBROhUCQybfvGrHminLgg0SSJrIaFx6tXhpx7jB84mb5D4UiJb/ammqZ/rF8euEFWpQjXZm+Rf/r72KI6eEP7d8ndH7CVEX4JeoDKcrS0u99QKGajkXoRv3/UCchkr4Fgjo9k8jFmuCKZBlnFFAuxKedk1lm7pYx20jfaLgDugA4z/qcYePW0x8Ten1sH7drm6TLmlYodj+kJ8 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0068.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 309110bf-cdb9-42a1-ad88-08d82d2713be X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 03:35:12.8584 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8QKIHMPsbKOS55qUfoEYaS2QsXgeApf8WSV8w3sBGJQLikus6ybIAzfLBHJ41xIk7VWckI1U6FcHQ0fUn3Sjfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1828 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: Zhang, Shenglei =20 Sent: Thursday, July 16, 2020 11:14 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name i= n xxx-by REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2836 Current PatchCheck.py checks each line to ensure line's length is not large= r than 76. But there's a case that length of user's name is much longer tha= n that number. So enhance the script to handle this case. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Shenglei Zhang --- BaseTools/Scripts/PatchCheck.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index 52244b0bc4d8..7db0775d14d1 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -268,7 +268,14 @@ class CommitMessageCheck: for i in range(2, count): if (len(lines[i]) >=3D 76 and len(lines[i].split()) > 1 and - not lines[i].startswith('git-svn-id:')): + not lines[i].startswith('git-svn-id:') and + not lines[i].startswith('Reviewed-by') and + not lines[i].startswith('Acked-by:') and + not lines[i].startswith('Tested-by:') and + not lines[i].startswith('Reported-by:') and + not lines[i].startswith('Suggested-by:') and + not lines[i].startswith('Signed-off-by:') and + not lines[i].startswith('Cc:')): # # Print a warning if body line is longer than 75 character= s # -- 2.18.0.windows.1