From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.11710.1593565439577929008 for ; Tue, 30 Jun 2020 18:03:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=I6JvI3k6; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: bob.c.feng@intel.com) IronPort-SDR: fXQMIdK+3irgZWJicdw93/vXqUVBwFDr9hFkFTA6ysYCEUtJZc5PhsXhQxJA/azS9lonr9ruAN l6Akou2MkTuw== X-IronPort-AV: E=McAfee;i="6000,8403,9668"; a="207943313" X-IronPort-AV: E=Sophos;i="5.75,298,1589266800"; d="scan'208";a="207943313" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2020 18:03:23 -0700 IronPort-SDR: uqxmwbynbauHX0bb06FJoNMI9UgKS4T0wmss/BetGCdGF6aJcb6Kv6FtQnYsGNUw6bIBCuWLQC f27HZEKcOxdw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,298,1589266800"; d="scan'208";a="281429964" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by orsmga006.jf.intel.com with ESMTP; 30 Jun 2020 18:03:23 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jun 2020 18:03:22 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.55) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jun 2020 18:03:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MOBMIP7J1CyTOiOI3U+LhwIHd0HaMdz4mdvct+EP/lFVGiA8JbTLsCyUzftgUpWk8AZ1w12W409mUKkcOZBK0zEBqahUQirS3Mx2L1WDW7niRnflZsmMsWNg8yeDpkRLGQUTmzX7pY45BZU75hITjxBn33UXx5QKSYZfEsJL4rereD70DEdJsZwB0xoJ0qDJc37PX0C5s5Ow+MFadfGfeHD2ZilOSk9w7HVFD3ET4jQIt+axFHYDhFubUBwEmjsnE0E6SSxasQdj8I205+DH7LLo7NKSbg1PswEiOjX+QA0a/VkcLk8g5vD3tgD6lzh2AlcxkpCOjtktraECSy/B5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wFLOWsIZjyoeZm8hy+Xq5AYIAmVB7iaVSdxAkLh3owU=; b=aaHoUlbV65xmkE3wrUWHuAEwbEDgNLxAqZADCTlqBt4JCdoAaKuB2hiQWGj7fcapE6UdKFEBfV9/FWtHSo+Cwc/k+jdvM286j87EpOt412DBN7hFVTe8n/LxNWfq90c77b9VvD6310LWQosbFFzcMkgC409700yVBznDMbHWKs2lL1zq86/EuY/TAX7/1FGib6ombdsC5hMjbl9BYajuMl71k37goQfrbWpWdN4tL3WaL8AOTcBJAAWcUdc1arfuXraSjSky3YjP0xlPfBEHEojZZ54j2kfWrL0i2pS08UucLKY/6frNj/iA0IyF14CDPIXmRO1DD6r3uxEq9dozdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wFLOWsIZjyoeZm8hy+Xq5AYIAmVB7iaVSdxAkLh3owU=; b=I6JvI3k6dJfXaUL7H1nbw98FVxuV0S7gvM/NKNubqZsXNC+/DX2VIDplUkmltzd5qFp/todh5oB+9iCF0yGXYaSANVQ5aVOEzBzDTKBhRgpFxcC16ahD7ZfNCnX2cCAtOwx4r49ywVG0m46C8yT8Q5frFB0ILosI8i1LzpYz+Lw= Received: from BN6PR11MB0068.namprd11.prod.outlook.com (2603:10b6:405:69::17) by BN8PR11MB3540.namprd11.prod.outlook.com (2603:10b6:408:81::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20; Wed, 1 Jul 2020 01:03:20 +0000 Received: from BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::6870:82d3:5bde:4153]) by BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::6870:82d3:5bde:4153%6]) with mapi id 15.20.3131.028; Wed, 1 Jul 2020 01:03:20 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "pierre.gondois@arm.com" CC: Sami Mujawar , Tomas Pilar , "Gao, Liming" , nd Subject: Re: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into OBJ file Thread-Topic: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into OBJ file Thread-Index: AQHWSgcjA7iQ/v72okSjnvFg4182Xajn4DtwgAEyUgCABJT+4IACCKSAgAFVvJCAADJeAIAAuZXA Date: Wed, 1 Jul 2020 01:03:20 +0000 Message-ID: References: <20200624090837.124392-1-pierre.gondois@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1b35b12b-0cb5-472f-3e6a-08d81d5a8c21 x-ms-traffictypediagnostic: BN8PR11MB3540: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 04519BA941 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OFy9aMS2WR50+8Z8AxgfAEhe2V/mvfoUUWB6jVyGgaSh9dNp6I+IDwdKiM9AIQtryFWCobOuL9cO0h6ZsiCULPJCpzMh2Lvx+dL44gZY29CUNij1J7Jr6cvSlEEseGLb9V/zycwnBtjAG8HLAwQxkj7/2EHEu2mesSDXX9UDJFwXSjtAvITE2avo1fDRyRxqPTRRvgGEe/+C4iiQ/X/x2Kols3K0nkdOp33Z78oqWQ6pnNJC4f/C9KKGDVnKFzzewdoKmh52gCL2wbcpKnHgZGmYk+mgdeU0PuSuUiG/8xyaaXldthqrm/qg8cgHnKRw7C0GzYu5tbuUl1q9VD+EayYSt8fLh9BQyBIhtmZTECbh4X6wv7CSBYfIyWde5g0okGl4Uip/cViFGmFCbxNYhg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB0068.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(39860400002)(376002)(396003)(346002)(136003)(26005)(33656002)(52536014)(2906002)(478600001)(316002)(110136005)(54906003)(8676002)(7696005)(6506007)(53546011)(966005)(5660300002)(8936002)(86362001)(71200400001)(83380400001)(76116006)(64756008)(9686003)(4326008)(66946007)(66556008)(66476007)(186003)(55016002)(30864003)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 1Y7THj9fTeiY5PbMF561KCamJ35u33RPcin4zrWGoxYkXqkCNHSmALCEM6d2B+sVO0H0tTNua0xCrCVIegRchpAVcMXgsLpPcSHfLyQpMPiC00/lJJQEwxJtk5RskAYgbw0MALeOzL84Qg623IfL/6z4Lh6xoHyMkxn2P+ywCK4aqgqupiwxoL6xrozwQB479Go8cF1OJbbQyV/TsXiYUrm8WF6QJEeeI50XHHDoRv+LCVdMcrR/fZKJnVhRIdYamQTzBPnTly/pAGehMzh8D5eMEfkd+dAPwH0au8rRKVBzm7uXWlMiRrzcYXMSR0dohgGY7gzRnbB7cXpI3vuNL1ODWdPjLcFPJydnFXys/YrBFqhlFzZs6+AqVmdUcrOW99CQhwAaefBNw/tipFrgUFQHc4kuMVh/w4NcoUCFPr6rMeXKjyeSo5sYGgYfrLvUVE2XKhAQYTZUpip4sLsVci7yEVBTkb6Ynd7/e32H0d76oMuHPNSpqUD5EtqFH/DO MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0068.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b35b12b-0cb5-472f-3e6a-08d81d5a8c21 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2020 01:03:20.7256 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Wi2DEMf3+peZ299ch6SJcEJ4wKkQaCDWbzkOMwwUZyaKUTprb5lFMgjWJjLSHR92C2S77FE6wSdCXF39Joxtvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3540 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Pierre, Yes. if the patch set can't pass CI, it can't be merged. I think we can add a check for the file path. The scripts under BinWrapper= s\PosixLike are all linux shell scripts. Thanks, Bob=20 -----Original Message----- From: devel@edk2.groups.io On Behalf Of PierreGondo= is Sent: Tuesday, June 30, 2020 9:56 PM To: Feng, Bob C ; devel@edk2.groups.io Cc: Sami Mujawar ; Tomas Pilar = ; Gao, Liming ; nd Subject: Re: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into O= BJ file I agree that PatchCheck.py needs to be updated. However, this is difficult= for PatchCheck.py to know whether a file should be allowed to have LF line= endings or not. Some files currently in edk2 have LF line endings and: - have a ".sh" extension (EmulatorPkg/build.sh), some other don't (BaseTo= ols/BinWrappers/PosixLike/GenFv); - start with "#!/usr/bin/env bash" (BaseTools/BinWrappers/PosixLike/GenFv= ), some other don't (edksetup.sh); I don't see any criteria that would allo= w to identify whether a file is supposed to have LF line endings or not. Th= is is why I think creating a ".gitattribute" file in edk2 would help. In th= is file, people could identify files/folders being allowed to have LF line = endings. PatchCheck.py would parse this file to exclude them from the CRLF = check. Plus it would enforce the line ending on local copies of edk2, thus = preventing mistakes like I did when sending a bash script with CRLF line en= dings. Do you agree with this solution? Another question: does the CRLF error triggered by PatchCheck.py imply del= aying this current patch set? Indeed I'm scared trying to add a ".gitattrib= ute" file might start long discussions. Regards, Pierre -----Original Message----- From: Feng, Bob C Sent: 30 June 2020 11:59 To: devel@edk2.groups.io; Pierre Gondois Cc: Sami Mujawar ; Tomas Pilar = ; Gao, Liming ; nd Subject: RE: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into O= BJ file Hi Pierre, I think we need to update the PatchCheck.py script. The comments says, "Do= not enforce CR/LF line endings for linux shell scripts.", but that only ch= eck the file ext is .sh is not enough. if self.filename.endswith('.sh'): # # Do not enforce CR/LF line endings for linux shell sc= ripts. # self.force_crlf =3D False Thanks, Bob -----Original Message----- From: devel@edk2.groups.io On Behalf Of PierreGondo= is Sent: Monday, June 29, 2020 10:33 PM To: Feng, Bob C ; devel@edk2.groups.io Cc: Sami Mujawar ; Tomas Pilar = ; Gao, Liming ; nd Subject: Re: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into O= BJ file Hello Bob, I actually found more files having a LF line ending by running the followi= ng command: for file in `git ls-files`; do if [ "${file##*.}" !=3D bin ] && [ "${file#= #*.}" !=3D bmp ] && [ "${file##*.}" !=3D a ] && [ "${file##*.}" !=3D lib ] = && [ "${file##*.}" !=3D cer ] && [ "${file##*.}" !=3D pyd ] &&[ "${file##*.= }" !=3D pem ] && [ "${file##*.}" !=3D raw ]; then file $file | grep -v "CRL= F" | grep -v ": directory"; fi; done The command list files referenced in g= it, then excludes files with specific extensions, excludes directories, and= excludes files with CRLF line endings. I believe some of them should have CRLF line endings if this is the defaul= t in edk2. I am mainly thinking about the ".rtf", ".py" and ".txt" files. F= or the actual bash scripts, maybe a ".gitattributes" file can be created in= edk2 to explicitly make them use LF line endings. This can be done by sett= ing this attribute: "eol=3Dlf". This ".gitattributes" file would then be parsed by the PatchCHeck.py scrip= t not to trigger an error for files having the later attribute. Regards, Pierre List of files obtained by running the command above, (maybe it needs some = more filters): BaseTools/Bin/CYGWIN_NT-5.1-i686/BootSectImage: Bourne-Again shell script,= ASCII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/BuildEnv: Bourne-Again shell script, ASCI= I text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/Ecc: Bourne-Again shell script, ASCII tex= t executable BaseTools/Bin/CYGWIN_NT-5.1-i686/EfiLdrImage: Bourne-Again shell script, A= SCII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/EfiRom: Bourne-Again shell script, ASCII = text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GenCrc32: Bourne-Again shell script, ASCI= I text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GenDepex: Bourne-Again shell script, ASCI= I text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFds: Bourne-Again shell script, ASCII = text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFfs: Bourne-Again shell script, ASCII = text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFv: Bourne-Again shell script, ASCII t= ext executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFw: Bourne-Again shell script, ASCII t= ext executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GenPage: Bourne-Again shell script, ASCII= text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GenSec: Bourne-Again shell script, ASCII = text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GenVtf: Bourne-Again shell script, ASCII = text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GnuGenBootSector: Bourne-Again shell scri= pt, ASCII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaCompress: Bourne-Again shell script, = ASCII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaF86Compress: Bourne-Again shell scrip= t, ASCII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/RunBinToolFromBuildDir: Bourne-Again shel= l script, ASCII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/RunToolFromSource: Bourne-Again shell scr= ipt, ASCII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/Split: Bourne-Again shell script, ASCII t= ext executable BaseTools/Bin/CYGWIN_NT-5.1-i686/TargetTool: Bourne-Again shell script, AS= CII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/TianoCompress: Bourne-Again shell script,= ASCII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/Trim: Bourne-Again shell script, ASCII te= xt executable BaseTools/Bin/CYGWIN_NT-5.1-i686/VfrCompile: Bourne-Again shell script, AS= CII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/VolInfo: Bourne-Again shell script, ASCII= text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/build: Bourne-Again shell script, ASCII t= ext executable BaseTools/BinWrappers/PosixLike/BPDG: Bourne-Again shell script, ASCII tex= t executable BaseTools/BinWrappers/PosixLike/Brotli: Bourne-Again shell script, ASCII t= ext executable BaseTools/BinWrappers/PosixLike/BrotliCompress: Bourne-Again shell script,= ASCII text executable BaseTools/BinWrappers/PosixLike/DevicePath: Bourne-Again shell script, ASC= II text executable BaseTools/BinWrappers/PosixLike/Ecc: Bourne-Again shell script, ASCII text= executable BaseTools/BinWrappers/PosixLike/EfiRom: Bourne-Again shell script, ASCII t= ext executable BaseTools/BinWrappers/PosixLike/GenCrc32: Bourne-Again shell script, ASCII= text executable BaseTools/BinWrappers/PosixLike/GenDepex: Bourne-Again shell script, ASCII= text executable BaseTools/BinWrappers/PosixLike/GenFds: Bourne-Again shell script, ASCII t= ext executable BaseTools/BinWrappers/PosixLike/GenFfs: Bourne-Again shell script, ASCII t= ext executable BaseTools/BinWrappers/PosixLike/GenFv: Bourne-Again shell script, ASCII te= xt executable BaseTools/BinWrappers/PosixLike/GenFw: Bourne-Again shell script, ASCII te= xt executable BaseTools/BinWrappers/PosixLike/GenPatchPcdTable: Bourne-Again shell scrip= t, ASCII text executable BaseTools/BinWrappers/PosixLike/GenSec: Bourne-Again shell script, ASCII t= ext executable BaseTools/BinWrappers/PosixLike/GenerateCapsule: Bourne-Again shell script= , ASCII text executable BaseTools/BinWrappers/PosixLike/LzmaCompress: Bourne-Again shell script, A= SCII text executable BaseTools/BinWrappers/PosixLike/LzmaF86Compress: Bourne-Again shell script= , ASCII text executable BaseTools/BinWrappers/PosixLike/PatchPcdValue: Bourne-Again shell script, = ASCII text executable BaseTools/BinWrappers/PosixLike/Pkcs7Sign: Bourne-Again shell script, ASCI= I text executable BaseTools/BinWrappers/PosixLike/Rsa2048Sha256GenerateKeys: Bourne-Again sh= ell script, ASCII text executable BaseTools/BinWrappers/PosixLike/Rsa2048Sha256Sign: Bourne-Again shell scri= pt, ASCII text executable BaseTools/BinWrappers/PosixLike/Split: Bourne-Again shell script, ASCII te= xt executable BaseTools/BinWrappers/PosixLike/TargetTool: Bourne-Again shell script, ASC= II text executable BaseTools/BinWrappers/PosixLike/TianoCompress: Bourne-Again shell script, = ASCII text executable BaseTools/BinWrappers/PosixLike/Trim: Bourne-Again shell script, ASCII tex= t executable BaseTools/BinWrappers/PosixLike/UPT: Bourne-Again shell script, ASCII text= executable BaseTools/BinWrappers/PosixLike/VfrCompile: Bourne-Again shell script, ASC= II text executable BaseTools/BinWrappers/PosixLike/VolInfo: Bourne-Again shell script, ASCII = text executable BaseTools/BinWrappers/PosixLike/build: Bourne-Again shell script, ASCII te= xt executable BaseTools/BuildEnv: ASCII text BaseTools/Source/C/VfrCompile/Pccts/KNOWN_PROBLEMS.txt: data BaseTools/Source/C/VfrCompile/Pccts/history.ps: PostScript document text c= onforming DSC level 3.0 BaseTools/Source/Python/Ecc/CParser3/__init__.py: empty BaseTools/Source/Python/Ecc/CParser4/__init__.py: empty BaseTools/Source/Python/Eot/CParser3/__init__.py: empty BaseTools/Source/Python/Eot/CParser4/__init__.py: empty BaseTools/Source/Python/Pkcs7Sign/TestRoot.cer.gEfiSecurityPkgTokenSpaceGu= id.PcdPkcs7CertBuffer.inc: ASCII text, with very long lines, with no line t= erminators BaseTools/Source/Python/Pkcs7Sign/TestRoot.cer.gFmpDevicePkgTokenSpaceGuid= .PcdFmpDevicePkcs7CertBufferXdr.inc: ASCII text, with very long lines, with= no line terminators BaseTools/UserManuals/Build_Utility_Man_Page.rtf: Rich Text Format data, v= ersion 1, unknown character set BaseTools/UserManuals/EfiRom_Utility_Man_Page.rtf: Rich Text Format data, = version 1, unknown character set BaseTools/UserManuals/GenCrc32_Utility_Man_Page.rtf: Rich Text Format data= , version 1, unknown character set BaseTools/UserManuals/GenDepex_Utility_Man_Page.rtf: Rich Text Format data= , version 1, unknown character set BaseTools/UserManuals/GenFds_Utility_Man_Page.rtf: Rich Text Format data, = version 1, unknown character set BaseTools/UserManuals/GenFfs_Utility_Man_Page.rtf: Rich Text Format data, = version 1, unknown character set BaseTools/UserManuals/GenFv_Utility_Man_Page.rtf: Rich Text Format data, v= ersion 1, unknown character set BaseTools/UserManuals/GenFw_Utility_Man_Page.rtf: Rich Text Format data, v= ersion 1, unknown character set BaseTools/UserManuals/GenPatchPcdTable_Utility_Man_Page.rtf: Rich Text For= mat data, version 1, unknown character set BaseTools/UserManuals/GenSec_Utility_Man_Page.rtf: Rich Text Format data, = version 1, unknown character set BaseTools/UserManuals/Intel_UEFI_Packaging_Tool_Man_Page.rtf: Rich Text Fo= rmat data, version 1, unknown character set BaseTools/UserManuals/LzmaCompress_Utility_Man_Page.rtf: Rich Text Format = data, version 1, unknown character set BaseTools/UserManuals/PatchPcdValue_Utility_Man_Page.rtf: Rich Text Format= data, version 1, unknown character set BaseTools/UserManuals/SplitFile_Utility_Man_Page.rtf: Rich Text Format dat= a, version 1, unknown character set BaseTools/UserManuals/TargetTool_Utility_Man_Page.rtf: Rich Text Format da= ta, version 1, unknown character set BaseTools/UserManuals/TianoCompress_Utility_Man_Page.rtf: Rich Text Format= data, version 1, unknown character set BaseTools/UserManuals/Trim_Utility_Man_Page.rtf: Rich Text Format data, ve= rsion 1, unknown character set BaseTools/UserManuals/UtilityManPage_template.rtf: Rich Text Format data, = version 1, unknown character set BaseTools/UserManuals/VfrCompiler_Utility_Man_Page.rtf: Rich Text Format d= ata, version 1, unknown character set BaseTools/UserManuals/VolInfo_Utility_Man_Page.rtf: Rich Text Format data,= version 1, unknown character set CryptoPkg/Library/Include/internal/dso_conf.h: C source, ASCII text CryptoPkg/Library/OpensslLib/process_files.pl: Perl script text executable EmbeddedPkg/Library/FdtLib/TODO: ASCII text EmbeddedPkg/Library/FdtLib/fdt_overlay.c: C source, ASCII text EmulatorPkg/Unix/.gdbinit: ASCII text EmulatorPkg/Unix/GdbRun.sh: ASCII text EmulatorPkg/Unix/Host/X11IncludeHack: ASCII text, with no line terminators EmulatorPkg/Unix/Xcode/xcode_project32/XcodeBuild.sh: Bourne-Again shell s= cript, ASCII text executable EmulatorPkg/Unix/Xcode/xcode_project32/xcode_project.xcodeproj/default.pbx= user: ASCII text EmulatorPkg/Unix/Xcode/xcode_project32/xcode_project.xcodeproj/project.pbx= proj: ASCII text EmulatorPkg/Unix/Xcode/xcode_project64/XcodeBuild.sh: Bourne-Again shell s= cript, ASCII text executable EmulatorPkg/Unix/Xcode/xcode_project64/xcode_project.xcodeproj/default.pbx= user: ASCII text EmulatorPkg/Unix/Xcode/xcode_project64/xcode_project.xcodeproj/project.pbx= proj: ASCII text EmulatorPkg/Unix/lldbinit: ASCII text EmulatorPkg/build.sh: Bourne-Again shell script, ASCII text executable OvmfPkg/QemuVideoDxe/VbeShim.sh: POSIX shell script, ASCII text executable OvmfPkg/build.sh: Bourne-Again shell script, ASCII text executable edksetup.sh: ASCII text -----Original Message----- From: Feng, Bob C Sent: 28 June 2020 08:34 To: devel@edk2.groups.io; Pierre Gondois Cc: Sami Mujawar ; Tomas Pilar = ; Gao, Liming ; nd Subject: RE: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into O= BJ file Hi Pierre, I met a problem when I push your patch set. If I change the CRLF to a unix format EOL, the patch can't pass PatchCheck= .py. If I don't change the CRLF, The build on Linux will fail. So I can't make the patch set pass the CI. Could you share me how did you do to make your PR 729 pass? Thanks, Bob -----Original Message----- From: devel@edk2.groups.io On Behalf Of PierreGondo= is Sent: Thursday, June 25, 2020 5:31 PM To: devel@edk2.groups.io; Feng, Bob C Cc: Sami Mujawar ; Tomas Pilar = ; Gao, Liming ; nd Subject: Re: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into O= BJ file Hello Bob, I believe the line endings of the BaseTools/BinWrappers/PosixLike/AmlToC s= cript have been modified to CRLF when I sent the patch. I created a pull re= quest from the linked github branch noted in the patches. It is available a= t https://github.com/PierreARM/edk2/commits/803_Compile_AML_bytecode_array_= into_OBJ_file_v3 . The pull request is available here (to show the result o= f the CI tests) https://github.com/tianocore/edk2/pull/729 . Do you want a v4 or is it possible to pull the patches from the github rep= ository? Sorry for the inconvenience. Regards, Pierre -----Original Message----- From: devel@edk2.groups.io On Behalf Of Bob Feng vi= a groups.io Sent: 24 June 2020 16:16 To: devel@edk2.groups.io; Pierre Gondois Cc: Sami Mujawar ; Tomas Pilar = ; Gao, Liming ; nd Subject: Re: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into O= BJ file Hi Pierre, There are some build failed in OpenCI. Would you please check it? https://github.com/tianocore/edk2/pull/727 Thanks, Bob -----Original Message----- From: devel@edk2.groups.io On Behalf Of PierreGondo= is Sent: Wednesday, June 24, 2020 5:09 PM To: devel@edk2.groups.io Cc: Pierre Gondois ; sami.mujawar@arm.com; tomas.p= ilar@arm.com; Feng, Bob C ; Gao, Liming ; nd@arm.com Subject: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into OBJ f= ile Following the BZ at https://bugzilla.tianocore.org/show_bug.cgi?id=3D2425 This patch serie is a another way to solve the dependency of C files over = ASL files. With this new method, the dependency is resolved at the linking = stage. The last method to solve this dependency was to add the possibility to mod= ify INF files to depict such a dependency. This method was not accepted. Th= e discussion is available at https://edk2.groups.io/g/devel/topic/72655342#= 56658 The last patch modifying the INF specification and INF parsing are availab= le at: https://edk2.groups.io/g/devel/topic/72655342#56658 https://edk2.groups.io/g/devel/topic/72656060#56662 Pierre Gondois (4): BaseTools: Generate multiple rules when multiple output files BaseTools: Rename AmlToHex script to AmlToC BaseTools: Compile AML bytecode arrays into .obj file BaseTools: Fix string concatenation BaseTools/BinWrappers/PosixLike/{AmlToHex =3D> AmlToC} | 28= +++---- BaseTools/BinWrappers/WindowsLike/{AmlToHex.bat =3D> AmlToC.bat} | 0 BaseTools/Conf/build_rule.template | 15 += ++- BaseTools/Source/Python/{AmlToHex/AmlToHex.py =3D> AmlToC/AmlToC.py} | 82= ++++++++------------ BaseTools/Source/Python/AutoGen/BuildEngine.py | 2 += - BaseTools/Source/Python/AutoGen/GenMake.py | 6 += + BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 38 += ++++---- 7 files changed, 89 insertions(+), 82 deletions(-) rename BaseTools/BinW= rappers/PosixLike/{AmlToHex =3D> AmlToC} (97%) rename BaseTools/BinWrapper= s/WindowsLike/{AmlToHex.bat =3D> AmlToC.bat} (100%) rename BaseTools/Sourc= e/Python/{AmlToHex/AmlToHex.py =3D> AmlToC/AmlToC.py} (52%) -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'