From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web12.13364.1595311087935960976 for ; Mon, 20 Jul 2020 22:58:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ai+bdI5o; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: bob.c.feng@intel.com) IronPort-SDR: qM0/hss051XcgS/DB6G0h9a8+/gqXp7H8f06Rj4ZvX+xJ9sjiecpc7RhOHMgNeyPDaRq0OD1aq Joos+mqtfhtA== X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="151412726" X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="151412726" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 22:58:07 -0700 IronPort-SDR: gP8oXKhtR6uNcRRCPQwmAYIgRv4KoA5de9Opm6Kox3BMC2h3GiMMU61M0ud0joIURPpxI6rYn5 lx+S3j7s/L5A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="461956561" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga005.jf.intel.com with ESMTP; 20 Jul 2020 22:58:07 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 20 Jul 2020 22:58:06 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 20 Jul 2020 22:58:06 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 22:58:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=npV7L+TOTGpw+ge62TNaO6CSnpzGzL6lIeicZNE2vrv7jx2Zz2Crok4XiYsl9QVzxUPNs4OYF7kc4LCvSVoze23VuYoaoSXZiet+tettj6sggc/nMZtnXS8j2NYm+lbOa9tJPHISc5YfA5IgWoZhYHWmLG4BAymwMncNz/gBmEM8kndM1uOATFHNz6Q4pBS5nrt8YXT7GSZw9KhcAA+GXvvN/UzcCawVdQqjRA6uhf/2KnlNZnPIf86g7gycVFz4EtwRHcGURn6wu5EtKprqhWJEYQkuzmc2mInMngl2H5EjNn4yodnYjfN2kP4Y9TbfoePZMzwxNlkz+7Z8GoSQ3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uDJxUsWcz105JUBUlDKcxQ4TKgnThhV4srIbwdu0TD8=; b=ZXRwN9PMR5LdEr0FQcme7vVs44U1+h1//VmMl4zujgfUKhXOltmm8hgF0L4gqT7UkWy1dgREPBHifAa3JczOlGc/7btCVi66gY+LwhGK5NA1WJ+auUUnDbi5XRt1DS98ycdPIqPtPkulPilcum6oXeHYTD6ew5orBZClNOdf7ggXsI6+YS9yJAOS1IZK/McnN8KNbeg+baGWosFBevfzlwg1mjiKuUA0gZn1z9d23lxl1hj5aE6oSzpzlrjfifelH6EtSubK8PmgYxZ7BpnoMAKU4Oa3HwFLhl+mdXfZZPivCkS6dw3/lCmhCUl6oZnve6FZdaPhni/hrBXhzwV91A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uDJxUsWcz105JUBUlDKcxQ4TKgnThhV4srIbwdu0TD8=; b=ai+bdI5oaCnD/oLtZOHdzkzlD/gtfl99t5tjz6yOE4yVKfCiE1pZpFaGwE/qTIrDRjlr/R/pH7Cr+0Gzq38+AsbmETgzfOx9rTABfJxSrkG1GdlatWASZaEj/TJdJA8DwPSdTNAdmxiN2tBsYEdmM08oQNUUNyj5CnH0/RKWDFs= Received: from BN6PR11MB0068.namprd11.prod.outlook.com (10.161.155.145) by BN6PR11MB1825.namprd11.prod.outlook.com (10.175.100.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Tue, 21 Jul 2020 05:58:05 +0000 Received: from BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::f4b6:406b:26fc:c069]) by BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::f4b6:406b:26fc:c069%3]) with mapi id 15.20.3195.026; Tue, 21 Jul 2020 05:58:05 +0000 From: "Bob Feng" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Thread-Topic: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Thread-Index: AQHWWx8nXHxhR0orXEWpJLKfHDlYCakRadpQgAAdQACAAApN0A== Date: Tue, 21 Jul 2020 05:58:04 +0000 Message-ID: References: <20200716031346.40160-1-shenglei.zhang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 74e1b834-66d3-4176-f6d1-08d82d3b090c x-ms-traffictypediagnostic: BN6PR11MB1825: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zz12D6UrGxEk17KULPRS9BGEvkhel5ezNRUpLRcPlLl16rxxVQMccK2nHDMQlxoPZ51o9ElIGExsTtPtYSGLuatB4MQ1RgeWdu9icTHe/9IuWWnDpQimfz/7L+5CTRHqhjZ3/yP6g/7gTwNkcZz5JzzE+UEww3So4Sa81RhHt+1MMvNhtaqopCxDVTHDv23VgbnfPgQEtd38O+5H6jR8kNxmg0Bob6h81kJhtlvB1JQJx/nJ0Rwv+JMYLcmIUQF5B8Uim5AJfXdIAEVQNJq/++MnR2CHvuc4Bj48jIxLqcOLXTiZPONhd1FxrRl1OtZ+vmOoPhMO7A8p2ncfmvZJ9WgFA83YUVMSeYKLoqWRHVRjt2wRpwoppQU64LdHMl+PzVRvJ8nZa2UTQMsSF82JynvkwJZd6hNCqAHIOVAX2US4TgnZp8DRm0nOgiOPQoB8HX5SjrQSIbzp4gVwmfV50Wp7ZZqO6lMeP7Xi76eN7Uc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB0068.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(39860400002)(346002)(396003)(366004)(376002)(316002)(110136005)(9686003)(4326008)(71200400001)(186003)(26005)(66476007)(2906002)(76116006)(66446008)(64756008)(66556008)(66946007)(52536014)(55016002)(6506007)(8676002)(83380400001)(33656002)(966005)(5660300002)(478600001)(86362001)(107886003)(7696005)(8936002)(53546011)(13513002)(21314003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: tYi5SAVX0UvhYU3wyrI0OQ1YmGthu2HWGAQM269ZC5AC/WN/589sOthb2b5w3ui4R+4Z3sO5/hml00KGZLeecfXT8Tr61og5f+YBhXJLY8tVJtBEf0X3OtiLhXuhcGzhv1lJIVOTtKOgL4i6g9obIEI2/9sAzJJ3ef3bpQde9OAb+5GpAaYyQbeEuG3Vj99tumg5vCN2jsuWAlq0Z1Abr4nkl4p6cGMMCa0ysFvb2j5pBYAhT2m1ORdhPJMuxAW7XomV8lD29FH2yEgWc3Jh0ECWHmIi7Z0hVyrmfEtXCyRytsHct9tUXYdbtm1IQLDeU6lQvsr3Hh0wHb3YkqBaukZuePfYxATPgAAI88BvMWpHuahBkx08PdofM8j4LhibHCA9jI8FYfkxUXTE1EK3h66DlbbrNCE7KdJgZ5msA4N4ZURvV89r/Q7b4rxZsZ54+WrEHFz6IG/XX5/iGdtQ7h8SIDeeptsJdZ/fN2/2Ci7/OV3/DFr6VUMMitP+zlEW MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0068.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74e1b834-66d3-4176-f6d1-08d82d3b090c X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 05:58:04.9790 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IuUK9OtWxGkheQzbV9Y6LD6KvbmUqD5E1erBDMiAGtqyQvRJGP73fktCuIVzQ7eJZLSedQwE/fMGjH6EoeuojQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1825 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Shenglei, I mean this link https://edk2.groups.io/g/devel/message/62647=20 Thanks, Bob -----Original Message----- From: Zhang, Shenglei =20 Sent: Tuesday, July 21, 2020 1:21 PM To: Feng, Bob C ; devel@edk2.groups.io Cc: Gao, Liming Subject: RE: [PATCH] BaseTools/PatchCheck.py: Skip length check for user na= me in xxx-by Bob, Code review is for our internal use. Should I append it on Bugzilla? Thanks, Shenglei > -----Original Message----- > From: Feng, Bob C > Sent: Tuesday, July 21, 2020 11:39 AM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Gao, Liming > Subject: RE: [PATCH] BaseTools/PatchCheck.py: Skip length check for=20 > user name in xxx-by >=20 > Shenglei, >=20 > After you send out the patch for review, please update the Bugzilla=20 > status as in-progress and provide the code review link. >=20 > Thanks, > Bob >=20 > -----Original Message----- > From: Zhang, Shenglei > Sent: Thursday, July 16, 2020 11:14 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming=20 > > Subject: [PATCH] BaseTools/PatchCheck.py: Skip length check for user=20 > name in xxx-by >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2836 > Current PatchCheck.py checks each line to ensure line's length is not=20 > larger than 76. But there's a case that length of user's name is much=20 > longer than that number. So enhance the script to handle this case. >=20 > Cc: Bob Feng > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- > BaseTools/Scripts/PatchCheck.py | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Scripts/PatchCheck.py=20 > b/BaseTools/Scripts/PatchCheck.py index 52244b0bc4d8..7db0775d14d1 > 100755 > --- a/BaseTools/Scripts/PatchCheck.py > +++ b/BaseTools/Scripts/PatchCheck.py > @@ -268,7 +268,14 @@ class CommitMessageCheck: > for i in range(2, count): > if (len(lines[i]) >=3D 76 and > len(lines[i].split()) > 1 and > - not lines[i].startswith('git-svn-id:')): > + not lines[i].startswith('git-svn-id:') and > + not lines[i].startswith('Reviewed-by') and > + not lines[i].startswith('Acked-by:') and > + not lines[i].startswith('Tested-by:') and > + not lines[i].startswith('Reported-by:') and > + not lines[i].startswith('Suggested-by:') and > + not lines[i].startswith('Signed-off-by:') and > + not lines[i].startswith('Cc:')): > # > # Print a warning if body line is longer than 75 charact= ers > # > -- > 2.18.0.windows.1