From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.11943.1595302717304007573 for ; Mon, 20 Jul 2020 20:38:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=wwjTsR3+; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: bob.c.feng@intel.com) IronPort-SDR: hUKTZyB2ExMJkpxp8MJYgxGM77/QQQvpCE7NSMURz4WKuudQ8IccB738FelK9tTpwbX0euxup3 P0pcztI4SLXw== X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="147559335" X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="147559335" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 20:38:36 -0700 IronPort-SDR: I6fhhZhGmxcGTdxkluwXsunBAZGxYPVIq3xecDXdjgzQ1lvxMqC9DaWlfKD3LWNsjWx+QzkjcR /sFesn/gk5mQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="283728422" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 20 Jul 2020 20:38:36 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 20:38:35 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 20:38:35 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 20:38:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ixU0sgXlhfx9/pkkKDmMXqiqJ3ZN+ONGbnFl/3UZZZXvZTs+rhH6yjG3VcOHGtWCRMWzdstbAICRFgdaO5oBPlcka4gBP9ScyQaTt0Ex5Gu+OiywMALr3gVJ+CQUSuyrQpNzi6SFDdYTE0jS7v4M9x9dXUlSqrz/yEHuWt/dbX6OQo1m13B9UTEvxXz+5G2gT21E/4A1kgWgbI1/t+v1tLmm9Y021h061I2031tY9DbfntNOexbk8ApMqIDFBKVWGQYjZsEUur4vCK3wkns2LJSrd0t6ueuUQ//nSb77t3MRg2squ4rZJD3u+HsRpkSgSHP456aUe+53lFyCJg51Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s3GEqmNgqB4510dJ9QP+UXo3l1+s4EvrFs4Q+1LgbhQ=; b=A04qFG1B/Z2gLH1Cn8u10tqzrTd7LgvhOnyKR1HGtDv9rmkozDw6hyC22YKIQH3+qx7faq25oMhBB7WWnEwiO6jRtCy16ij/fZFcGJHXHK7aX2r/Jk9A449/Ci14gicjpZ61wTZ2HGrnfRSZZzwN3no+TynmGWKxwts1OCzxoSqrtsO/fdSBWDl+cqJHMSBSK0QPbj5GsDGdw4f85xvu7bdgNURIU8DBn5qGiMqt5bOIANPtoohATNZ6rDw/igXTjFKpk2eALP0+Wpbk3jS02WN74s1zTrxxkVxii46bvpHYOzXzB5ABIgdgE2L7X7ADXVfOIRQl6ZTeVy+HdUh+tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s3GEqmNgqB4510dJ9QP+UXo3l1+s4EvrFs4Q+1LgbhQ=; b=wwjTsR3+TSJF7HmJeP+wwfI867EIUaNVX0hDXeh6Cah9oEu1Wvd2EoMiXOHViDYnL/e1i9RGlVG1uB73X29FjY21ObNKZT4yZS19JxRhYA217vL0tE8VeZz15JqFUn0Gl/6FAy3XYnSlLS1TavojSwSGK7/sNmobG7bDdXP+qsQ= Received: from BN6PR11MB0068.namprd11.prod.outlook.com (2603:10b6:405:69::17) by BN6PR11MB1828.namprd11.prod.outlook.com (2603:10b6:404:103::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18; Tue, 21 Jul 2020 03:38:34 +0000 Received: from BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::f4b6:406b:26fc:c069]) by BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::f4b6:406b:26fc:c069%3]) with mapi id 15.20.3195.026; Tue, 21 Jul 2020 03:38:34 +0000 From: "Bob Feng" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Thread-Topic: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Thread-Index: AQHWWx8nXHxhR0orXEWpJLKfHDlYCakRadpQ Date: Tue, 21 Jul 2020 03:38:34 +0000 Message-ID: References: <20200716031346.40160-1-shenglei.zhang@intel.com> In-Reply-To: <20200716031346.40160-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9d8da20a-295e-49f9-80ac-08d82d278b9f x-ms-traffictypediagnostic: BN6PR11MB1828: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O4Rm895wSjixbYMed5fWE/o66lfncXCbAcKK3FI2uX6HHsmNy/3SyxqO44PM5B6ucxCUYOeZeno+sduKUmZuOFed2if/6PY8iqplC0l1Aike13YPCP5YByq4JwMHqfaWDaFJ+JkPCUrB9HwQvxzHLl7xYgmsO4AVLnfBJFoH++j+3+uQ5lAx6v4hRyx0nbR+BPeJ1xVJmxLi+yEadzrs+Hj8EVY2hbUc78oYyQUVgvDSxJ77UIqzhjkFHTMntGbUhQro+Ijmxt2O/X2M6yf6VDTmz0/YX6z5upseaPPB82n8qhlOnXDwBD4++6WodZlt+n8yu8pj7BRf9xCy8QlmaKaQoDWO1zlN0CjlZ44WYviHxglRIPuPMkak1zrmUWR6GJqNViHRoq1Q9X1eNtlWqN/+q3Fm4bYRsrMejb6IOXSfzBl4hwLh4eq2pVUK7yARLZ4ECrRf5G7TxYsBod4Ou1RS0C9Zoai++362A9wdi6c= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB0068.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(376002)(346002)(366004)(396003)(39860400002)(4326008)(966005)(478600001)(83380400001)(2906002)(9686003)(5660300002)(110136005)(8936002)(316002)(107886003)(66476007)(66556008)(66946007)(66446008)(76116006)(8676002)(64756008)(55016002)(186003)(26005)(7696005)(33656002)(52536014)(6506007)(53546011)(71200400001)(86362001)(13513002)(21314003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: ZgTcVraJJxqu9azXa888P3dlAgwJfiHMXmEEvYKAOBPIp/yQYcVvPXD4LDKZLN6oCwtnqEE12A+FFHK0Lheh8FpxOKBiQT47FecQ22zo1300spIICFw8liJG8z+rB4tDybo+0PgXP2qWToFoSndstPLdWvCpnx3uq1FuAoGO02UoKEAgUZBApMJPKNjcHIEVsmIJHEg1iDyDJ30UHEBHuwLuX6h4hkeoOWgOFk0g8tV3TBd1l/QHjEqOKqvh6xGOmrmJlBkPdYhsatcYZF2P1/8rgSaxUAEjGxq0bsDeqUcRQazQ1xwfTl+rUjO0e7Ad9CsXJMxvFVJ1nsay2y7S6fkfJgQrDjHFdGEVnHc3sIJLJjoT2fBP1nRScehzAMFND+rS3BO32BYe/21CwxqefQBrPReV46pkr/HiEwlEWw1hyZ7LmK2IghVJcYKCEPnndzKWilgKKh4ohDpYN6AqJo+YcjI3Qh5kt0dHsdijOcrBdfjT05oxWuGa3Tqj/I6K MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0068.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d8da20a-295e-49f9-80ac-08d82d278b9f X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 03:38:34.0446 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zI2XhkcHllW2tNJvQNUt2g8vNj//85jD7LdBBd37ps23VRxl64cEBXlvG7Rd0BuS5zbhXyo/W/NomRfVn/+rYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1828 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Shenglei, After you send out the patch for review, please update the Bugzilla status = as in-progress and provide the code review link. Thanks, Bob -----Original Message----- From: Zhang, Shenglei =20 Sent: Thursday, July 16, 2020 11:14 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name i= n xxx-by REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2836 Current PatchCheck.py checks each line to ensure line's length is not large= r than 76. But there's a case that length of user's name is much longer tha= n that number. So enhance the script to handle this case. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Shenglei Zhang --- BaseTools/Scripts/PatchCheck.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index 52244b0bc4d8..7db0775d14d1 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -268,7 +268,14 @@ class CommitMessageCheck: for i in range(2, count): if (len(lines[i]) >=3D 76 and len(lines[i].split()) > 1 and - not lines[i].startswith('git-svn-id:')): + not lines[i].startswith('git-svn-id:') and + not lines[i].startswith('Reviewed-by') and + not lines[i].startswith('Acked-by:') and + not lines[i].startswith('Tested-by:') and + not lines[i].startswith('Reported-by:') and + not lines[i].startswith('Suggested-by:') and + not lines[i].startswith('Signed-off-by:') and + not lines[i].startswith('Cc:')): # # Print a warning if body line is longer than 75 character= s # -- 2.18.0.windows.1