From: "Bob Feng" <bob.c.feng@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"rebecca@bsdio.com" <rebecca@bsdio.com>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH 0/2] BaseTools: Convert ReadMe.txt to reStructuredText
Date: Tue, 21 Jul 2020 03:20:50 +0000 [thread overview]
Message-ID: <BN6PR11MB0068A4187A4458E522A23298C9780@BN6PR11MB0068.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200707231315.235989-1-rebecca@bsdio.com>
Rebecca,
Thanks for updating this file.
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
Thanks,
Bob
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
Sent: Wednesday, July 8, 2020 7:13 AM
To: devel@edk2.groups.io
Cc: Rebecca Cran <rebecca@bsdio.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [edk2-devel] [PATCH 0/2] BaseTools: Convert ReadMe.txt to reStructuredText
I noticed ReadMe.txt was a little outdated. I updated it to match current functionality (e.g. BaseTools works on both 32-bit and 64-bit Windows). Since the formatting was neither RST or MD, I converted it to RST and renamed to ReadMe.rst to match the edk2 ReadMe.rst.
Some (most?) sqlite use was removed in commit 2f818ed0fb57d98985d151781a2ce9b8683129ee in 2018, but there are still some modules (Ecc/Database.py, Eoc/Database.py and
UPT/Core/IpiDb,py) that do require it, so I'm not sure if the part about sqlite3 should still be present in the ReadMe file. If so, I think the text about cx_freeze might be obsolete.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Rebecca Cran (2):
BaseTools: Update ReadMe.txt to match current functionality
BaseTools: rename ReadMe.txt to ReadMe.rst
BaseTools/ReadMe.rst | 41 ++++++++++++++++++++++++++++++++++++++
BaseTools/ReadMe.txt | 47 --------------------------------------------
2 files changed, 41 insertions(+), 47 deletions(-) create mode 100644 BaseTools/ReadMe.rst delete mode 100644 BaseTools/ReadMe.txt
--
2.25.1
prev parent reply other threads:[~2020-07-21 3:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 23:13 [PATCH 0/2] BaseTools: Convert ReadMe.txt to reStructuredText Rebecca Cran
2020-07-07 23:13 ` [PATCH 1/2] BaseTools: Update ReadMe.txt to match current functionality Rebecca Cran
2020-07-07 23:13 ` [PATCH 2/2] BaseTools: rename ReadMe.txt to ReadMe.rst Rebecca Cran
2020-07-16 15:44 ` [PATCH 0/2] BaseTools: Convert ReadMe.txt to reStructuredText Rebecca Cran
2020-07-21 3:20 ` Bob Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR11MB0068A4187A4458E522A23298C9780@BN6PR11MB0068.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox