From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.2683.1591324003073185345 for ; Thu, 04 Jun 2020 19:26:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=y4V4tNm5; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: bob.c.feng@intel.com) IronPort-SDR: 4ApEa5Nf7aW443ecc7melTe8zMPxX96e+w/mgnJXzcVHmQOAbYMkKCbldTnUKPQq3hzVDS2OaD 18kLpiy6hrlw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2020 19:26:42 -0700 IronPort-SDR: tQyITpAF2iW6FDv1sjsLNvtwGV0q6LVU1+l/1Mb+pj/rDVg48LLOC/+bqMFeNcdBan2uxUKywM Eg4313WHxkrQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,474,1583222400"; d="scan'208";a="269613297" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga003.jf.intel.com with ESMTP; 04 Jun 2020 19:26:41 -0700 Received: from orsmsx111.amr.corp.intel.com (10.22.240.12) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 4 Jun 2020 19:26:41 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX111.amr.corp.intel.com (10.22.240.12) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 4 Jun 2020 19:26:41 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 4 Jun 2020 19:26:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BelqCh1+ssuCJ25bBiVyS6UcS/s2oEYFd26CSZL+J0nbmKspZxnfVP1SuzFCCBuw1KDCV7Cz404IdGG25awAkkGb8ZbELMz7714L/fyXQIrHSbYG7HpCYDF2HLdoqbxTYSQ2plwDc8RTOX2btLtJEtCU5uKy3ZHJ1fDUmhUnqR/wWT1FlLRMIKUNiT26EuFRj8PUJnwrNpIjSn8ShUdBt/jOC0SG5lr3hs2wNXqIQVqUQqvPv5hZaEh9bHUud+x+1zt/nUHN/rW4mzDd+Y0Lirw91+7S7oRP36FwzBNOS1z5GaN+Y2pVYIJaN9OnSuBQ69izhRS35y7Aw4xaFJHtag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jbrM+6q8vblQLJ0EQNnJn0C/5P7fsoFnX4Om4J/ZSco=; b=AOyESg1QsdYzj2cW3142myi1sHnFooUn5r5aReToyFGsoKBBVxX1h6rorKmZELmHVRycWTwjKmLePtjwKQezxaQZ7OEzoF6j6r3d0f2exzqmw+/NN/iFOH7wj/2oQ/eiKpD1Am81uYq2JZa0KN/iIjdQB+yiST1gsKrOfMTUs76X5ZDCrhEUo0ssyoWClLwk23tsMWy3BfajqWpWYpm8PtcOmrgYVwt6vtMn7gjzWCvbJGk4p4vcGEqb6HnDSvs0RvAIwP4LvpSac++5PKObfVVLLNxzS7nSl2p/xXkxcGx1tlVX5+/J0uTzsXE6YcySZAz4Y0IEQTCDzpgbtvQ6ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jbrM+6q8vblQLJ0EQNnJn0C/5P7fsoFnX4Om4J/ZSco=; b=y4V4tNm5YabiUOJOppSgkWV2Sakgx4u4a3yNMGeeZER4mcsYTqAyTi/KfQ0jF6i1ikVJ/TAMJEtU9UoUoC5x5mSffBlJqCxR0yD0SShko9yMofUrFXfEb9RwLz/g5Z8c8Zp0fNw1hzgZolXJqNikn2WIDSkOV2Bd8R2DVIf2KyQ= Received: from BN6PR11MB0068.namprd11.prod.outlook.com (2603:10b6:405:69::17) by BN6PR11MB1233.namprd11.prod.outlook.com (2603:10b6:404:44::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18; Fri, 5 Jun 2020 02:26:39 +0000 Received: from BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::2d53:d47c:1269:d601]) by BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::2d53:d47c:1269:d601%6]) with mapi id 15.20.3045.022; Fri, 5 Jun 2020 02:26:39 +0000 From: "Bob Feng" To: "Chen, Yuwei" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [PATCH 1/1] BaseTools: Warn user the file not found issue instead of break build. Thread-Topic: [PATCH 1/1] BaseTools: Warn user the file not found issue instead of break build. Thread-Index: AQHWN9+PLUfMYmsS4UaWu/GwQKyL6ajJUZ5g Date: Fri, 5 Jun 2020 02:26:39 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8806d107-2bb9-4946-cb06-08d808f7e112 x-ms-traffictypediagnostic: BN6PR11MB1233: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1201; x-forefront-prvs: 0425A67DEF x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fHdhvXI3ynwTFkBjOoJURn3Yv5bhilll+ELafPvCKhONG8r5syf363uqU0dJSuWowtCkHZt2eMfyUmIQtVlNtDeVWYPhNeKCv/Noj2XsBHDfN3zDTWeAOB1AhphOPRAtu5TLGMY9I4ZeCvQ5rJ21TKzxjQoX3rjtIzZ573ATi+38iu/J2Hn0Xt0ektvgckt0sHRI7MMZJF/vMA0umvQVQcuEPCAbtLQUOg6gSGUTM+/nuykhxmnTGSXAxqcX5cfAhmtoep7Cui2WpB1St0AFjWq6UiO4LbLtnSwVtPr4WBewJ+ti5JrhHL3f6kUtBfqNm/DMqiGiYScbO/xNmlRZMfhC55zOlYwkOAB73PJzo+nnA3CoeXTvJm8kf9mdmqH0T1hsQNecFK1B2VYM9jDN6A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB0068.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(376002)(396003)(136003)(39860400002)(346002)(366004)(52536014)(2906002)(110136005)(64756008)(66946007)(76116006)(66556008)(4326008)(186003)(71200400001)(66476007)(33656002)(5660300002)(7696005)(8676002)(55016002)(316002)(9686003)(107886003)(66446008)(83380400001)(478600001)(86362001)(8936002)(26005)(6506007)(53546011)(966005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: O7lQpR8imitUYTxcNKWy6jKG19s1Hxf34Y74+stI+k0WQk0FCmskvo79AqmLFTXrNQ1ae6bpmyJ9v0e2yi1bOdTpfFi9QYhCqJA4Hu9BdHx/3HjP0ME9YGFIVYxyPXSWqtQfo4lM+zTe9tRlJdQwZ6XL7M1z/eDMVLxLitxYZxR3XnxhZOAiWQl9tW6Zn/NybQmrvE5iR9nDHiL/+Hl6W0ceUzGdqZZzx3mNDoIqZ50LPDK+E2TGgJK3VHa/lDjtLMyYE33HmXynm5kkyXDoaeIFEpJX3hR6R1uoaiDoAPVcKU0m8I6gdSO1DkQpYthMVk+nGBSj0wVAGm7JsJvFbS/g8y0Thk4N4d18tob+q0yysoAqXb2s6ccjTvqPdhVDuqhoTezE/nQ/hgdIwwNDlK5ooe1igzvoTDbyEsbHfaNUo6RGgXUci286UF+6Bu3qSsv6uSvSAie1MlPA7vzf91rJ5j6BmL7SdgvpUR3NmOwnA2jt6CvoMF/vjI0aNjTX MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 8806d107-2bb9-4946-cb06-08d808f7e112 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2020 02:26:39.7895 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qI9Id2miQcP8ahLQ7sSdxJyv805hMM117nP2pwH+inGkssqAonIOlDl/idbcNrEdjeyvrIzuASG6sLs0mQvYGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1233 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: Chen, Yuwei =20 Sent: Monday, June 1, 2020 2:40 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH 1/1] BaseTools: Warn user the file not found issue instead = of break build. From: Bob Feng REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2770 The Trim.py would break the build process when the file not found issue occ= ures, however sometimes we do not care about this issue. This patch changes the error with warning in order to solve this kind of br= eak. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yuwei Chen --- BaseTools/Source/Python/Trim/Trim.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/Trim/Trim.py b/BaseTools/Source/Python= /Trim/Trim.py index c5638376e41a..776474b20349 100644 --- a/BaseTools/Source/Python/Trim/Trim.py +++ b/BaseTools/Source/Python/Trim/Trim.py @@ -281,9 +281,11 @@ def DoInclude(Source, Indent=3D'', IncludePathList=3D[= ], LocalSearchPath=3DNone, Inclu F =3D File.readlines() break else: - EdkLogger.error("Trim", "Failed to find include file %s" % Sou= rce) + EdkLogger.warn("Trim", "Failed to find include file %s" % Sour= ce) + return [] except: - EdkLogger.error("Trim", FILE_OPEN_FAILURE, ExtraData=3DSource) + EdkLogger.warn("Trim", FILE_OPEN_FAILURE, ExtraData=3DSource) + return [] =20 =20 # avoid A "include" B and B "include" A -- 2.26.1.windows.1