From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.9864.1593704895626676437 for ; Thu, 02 Jul 2020 08:48:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=RPnvFr7t; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: bob.c.feng@intel.com) IronPort-SDR: MVh1WXq6sbpAermDpQ0RKzrGmV5rrMRNq/9PUiTO9SSpjP+r75rfuU7Z9Rn0Y9WQTkg1HjS/Z2 iH50lIr1WT5Q== X-IronPort-AV: E=McAfee;i="6000,8403,9670"; a="126554417" X-IronPort-AV: E=Sophos;i="5.75,304,1589266800"; d="scan'208";a="126554417" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2020 08:48:14 -0700 IronPort-SDR: wP9BtzCnRDFCxq4HC8FfYJj+tS8My7jR905xEdk2w8D4uVGn0e98g/JVPrDCrXIe0+GtAEkNYN iVMOWzDI54Vg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,304,1589266800"; d="scan'208";a="455563385" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga005.jf.intel.com with ESMTP; 02 Jul 2020 08:48:14 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 2 Jul 2020 08:48:14 -0700 Received: from orsmsx111.amr.corp.intel.com (10.22.240.12) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 2 Jul 2020 08:48:14 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX111.amr.corp.intel.com (10.22.240.12) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Jul 2020 08:48:13 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.53) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Jul 2020 08:48:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RTAaeH+f70AwsTsyTq9zVmprEWIToGx7/oUFdlfOd6waNc33vl6vrsLKGWGlfG1+OD/IcvD3f9RRh5KwaBMLBA0YMq5CkxTKvIiugJubRiPa9BfOPTXJejxRDK4gQpm4lvTeMUxwP3W/s32bOpoJZ0QgJQvE+8ww8Q4YdHRGojgNZSpEBdbIh4ABxLaW5nsRp/6GRvJCoO6m49smvymnnSyuE4PlmM6n1keE/lOnNDswfITiThr+rDhunethM+Zu0HnhOz27lylVTRwGz//ArVVI7rZvcCuAA5o7AFDCBe353ycUnWcY9kKSgUOQ6hECzVPh6ZfbT1JAwH/n8Wke6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YDb9uWEQaCPqUmF94PKE8GjzIMzKoJTDlUSTLKDneUI=; b=ZeoVx+v6CEmN2+jC2QwNkHlFqnDjamZnsttpa1nhUE7vD3ryKBtfyxqYf/dcvcpJw8GQYzyPXMT+v6ALvb1BnzOlU6PlK6eqw/NcCrOatUx7WTXvO6HkM4sJovRKNIbwCO1gFXvsBxm/XOst3b5q101B26144SbLateAIRT3iBo+YAii+i2AMeLNIUOpn8MFixgI+soqzICJzWZW/J1mPQpq0+G0UEA2qk+hytoUi5JrjtO0IcHAzRgf4hBjrSbF2smWtM0Ivnc3ZjQ6F3YNlviEKyry51EMStNbnlP7pv6Qym+1AgUMWIWNubKAf3AgXTqNOBapv3C1PwJCFmZ2TA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YDb9uWEQaCPqUmF94PKE8GjzIMzKoJTDlUSTLKDneUI=; b=RPnvFr7tulM7Mw5bNlRceIM2GFX9B9MA+fZSv7ofwDtK6l9OvtwUEdfB82DyUU0oCGUEPgPujBwcB/AiHctMs6O01a9dK+NhScCrVzxg2/lR5fnFGISjmgTvTMxf6v9lirhoDmclMfvUjcj1h6k/36FCZGqgELNgSwi6YCBTNfI= Received: from BN6PR11MB0068.namprd11.prod.outlook.com (2603:10b6:405:69::17) by BN6PR11MB4034.namprd11.prod.outlook.com (2603:10b6:405:7d::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.20; Thu, 2 Jul 2020 15:48:12 +0000 Received: from BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::6870:82d3:5bde:4153]) by BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::6870:82d3:5bde:4153%6]) with mapi id 15.20.3131.034; Thu, 2 Jul 2020 15:48:12 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "leif@nuviainc.com" CC: "Gao, Liming" Subject: Re: [edk2-devel] [PATCH 2/2] BaseTools: explicitly import email.header PatchCheck.py Thread-Topic: [edk2-devel] [PATCH 2/2] BaseTools: explicitly import email.header PatchCheck.py Thread-Index: AQHWUIcT14UmaAKjJUOdSo9at7TADaj0b0MQ Date: Thu, 2 Jul 2020 15:48:12 +0000 Message-ID: References: <20200702153934.25262-1-leif@nuviainc.com> <20200702153934.25262-3-leif@nuviainc.com> In-Reply-To: <20200702153934.25262-3-leif@nuviainc.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8c712e58-37ee-466d-74f2-08d81e9f53cf x-ms-traffictypediagnostic: BN6PR11MB4034: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1923; x-forefront-prvs: 0452022BE1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7bQhVt+mbesEZ/jUYd31nmmTer7qGOZ7oObhXWs8SP2+FUb8+qDcWzKXVMIruV+uC8Mt2a967z5XI07d+RLI1UpzKEAU1yPdtXjmo9nFaGvwa73H5J05wHYMHbiFZJJu+nIxrD2dYnUIeMy7q1cMjGF8EtoYyfG8vvWy3d6gd4LyE9l/PqNDG0G3jAuAGzYzNVaSf20HTT/ewECLd18VOaUBsRkOZPRL3b+tPa9SIBCq76oQYkj8Qky8Ic2Dhk7mvOzgrPjWeBK56B50EWQPPX6UOsWzKhxbhwAI4QAnXpEkdnYuJrxvMOygqwqo09XAmZdkXpEqUSsGfOTN6aioZyhktDuKIgUHpGr9PTGhh9L9EvW91FPcbAvx9JJlnX/WxuZA02DZakdxomUwJ9F+XQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB0068.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(136003)(366004)(396003)(376002)(39860400002)(7696005)(8676002)(33656002)(107886003)(4326008)(55016002)(66946007)(9686003)(66446008)(64756008)(66556008)(66476007)(26005)(76116006)(186003)(71200400001)(86362001)(5660300002)(53546011)(6506007)(83380400001)(2906002)(8936002)(52536014)(966005)(478600001)(110136005)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 6omHAXQ8VNRCQIBH/ATcwq9bDcX1SaO/x4B1e36bQXvF9qZqmQjhmqVt822v7zkp7jK8g0ePN1rqkssBFyzrj9RhevxG2ISapTmy0sodZ5ePanshLK1dtIYmPR+9xaeuDsk/uxIYYTbg5OKRKx+57fdfURAOLP+LdAuw2JlNPhM5AVOb3dqzxl11A12MvVRicDhKJ35TjsCguiQo3xHo+rDnicnAcgAr9yUBMiiogXnYbyTTbigebdr5PV0Bq15LYdk0zkMHA2S3VEEkoSAxg83illc7yt0k+T6FHGuVMrAcDJ+EqlOL1nlFpMouU0Fg+NPwH6d+Kwu2LAyjIj8SZQBIZNfCamAM3CC8H+1w+seRmqJ5WQ4ooHld4P8nt6VFFxNV1etQYadyn1d1lzrsFyH8LJdKsp6QyZV+K3cGEY1x/l13Rd8iPEg+kAVj9r1naWBp9yzpLoVjCk6x22Wju8o+NV+SdVI5PlzvNR/Ejg4hPMPZUXi4I0CV/7Smk6yM MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0068.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c712e58-37ee-466d-74f2-08d81e9f53cf X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2020 15:48:12.5614 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mJXyRUq6eeJlVeKUgHVKTXE7jf/GzTGl5lSTPM5ZeC9m24fOjnN7q4f60n27gutHeEQf5myyIkHB7e6atXagLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4034 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io On Behalf Of Leif Lindho= lm Sent: Thursday, July 2, 2020 11:40 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [edk2-devel] [PATCH 2/2] BaseTools: explicitly import email.heade= r PatchCheck.py On Debian 10 (Buster), when running PatchCheck.py with python2, a backtrac= e is printed, starting from: File "../edk2/BaseTools/Scripts/PatchCheck.py", line 595, in find_patch_pieces parts =3D email.header.decode_header(pmail.get('subject')) AttributeError: 'module' object has no attribute 'header' When using python3, this backtrace does not appear. Explicitly importing email.header resolves this for python2 and does not a= ppear to cause any issues with python3. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Leif Lindholm --- BaseTools/Scripts/PatchCheck.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchChec= k.py index 527761986d4c..52244b0bc4d8 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -20,6 +20,8 @@ import re import subprocess import sys =20 +import email.header + class Verbose: SILENT, ONELINE, NORMAL =3D range(3) level =3D NORMAL -- 2.20.1