From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.2620.1589336069541645316 for ; Tue, 12 May 2020 19:14:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=FhYOsBuJ; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: bob.c.feng@intel.com) IronPort-SDR: TXlYaTmW/J6JZPv35rhLWsKsJHXswMykw/WYEyXP/pSbZMccai2sOW7ISiXwEMsLwmc/E+obJw iMchJ2fn2t8Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2020 19:14:28 -0700 IronPort-SDR: t4k6uAUORJrS4f1dBFZD5B9ipxSeYBC3xr56WITINoQgi1eU8WNt3w06f6hrFlPxTHdEfa+R9j lpQL25S1JVpA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,385,1583222400"; d="scan'208";a="265709735" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga006.jf.intel.com with ESMTP; 12 May 2020 19:14:28 -0700 Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 19:14:28 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX151.amr.corp.intel.com (10.22.226.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 19:14:28 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 19:14:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O1/XWVCxEcQSvCHrlpi0APUJWPTeYu9dEY9o4iQzwhUsKNQ7OWLGJcxuaG8nJJmuU1TMEio4jmQ6tP6FItDOTIv5421/fVc5rrV5K1Xdt5YGjnxxDdUDcxTUlukqjFgAptNaeXhy+jnQgVwKtBbwJ7l6us2t8yQaJPwdh4QLiEuelSRMmrpIbHDliJsOh3eSvZi9ZDW+FOaBgEPjQ9ysqEXYqYTU9DjFtIXQA5ldynhmw1l8k9Y+9ErbrxrJdP4vie2XzSIeQV5K/lTmuhxEcczt3IDOqLUV6aNEEU5W404W999lD23VIA8QsAgtGdoT6/7195bIVbUrEn+Nskr/Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rBAyvzKlLt3lIIBJyB++0fN5xCTDR4mOxc/Xcjv1R1w=; b=SPtXDMeohkcwx8mCZ1DsnvhpUsQdb8K4TMjNffCj11+TuwVO+n51abYHPLU1huExhS3oQXsTZuCzcKbnry3/ckxUmEEWKYClrCZh+Teoj2Cyv4V13ASALkE2hcTgRQN0olXog4rS1XdLtVkARgCFH3ERt44gG/Pa8Uvs5yJPu51fOVrD72jiRYsMGU2j3C/kpk1/ji9AWlPyWQ6OttHG+uW0nbh8YzBuUp/rBHZqcr8Mtk/9kakQJCrnM6nAGHvVtum5wBSxWEjt4kW6f8CZXuk8i3wh9nsb6g96M0l5r5cFgceR6dJyoCdfOA9828LHNWT+unHTEaGZdoXxWDtMUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rBAyvzKlLt3lIIBJyB++0fN5xCTDR4mOxc/Xcjv1R1w=; b=FhYOsBuJG2D43WQuDhlV9i2U5r+i1CQ8nU7BDJpvtG0AY2j5PFWmN7NjDqJ93AWJn79lCByY+mflOJXEqu/gZkTWvIub+xjH7zSvG3xpEvv4KagZjDHYs4ylqE84st5txNK2G+Z4V2CJZ3fZ9dt8465RBmn6QjQm5C9qk/cq88Y= Received: from BN6PR11MB0068.namprd11.prod.outlook.com (2603:10b6:405:69::17) by BN6PR11MB1716.namprd11.prod.outlook.com (2603:10b6:404:4a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.33; Wed, 13 May 2020 02:14:26 +0000 Received: from BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::2d53:d47c:1269:d601]) by BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::2d53:d47c:1269:d601%6]) with mapi id 15.20.2958.034; Wed, 13 May 2020 02:14:26 +0000 From: "Bob Feng" To: "Feng, YunhuaX" , "devel@edk2.groups.io" CC: "Gao, Liming" , Bret Barkelew Subject: Re: [PATCH] BaseTools: Fix binary file not generate map file issue Thread-Topic: [PATCH] BaseTools: Fix binary file not generate map file issue Thread-Index: AdYl5PjqIQz7Q0UrTT6GMm5Gsdqf3QC5yN8w Date: Wed, 13 May 2020 02:14:26 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9c7604c1-10e5-4370-38de-08d7f6e35cb4 x-ms-traffictypediagnostic: BN6PR11MB1716: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1122; x-forefront-prvs: 0402872DA1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: moJoTl/MrgxUooDTZ5gsUAaaqJey9aR+QN0y+GhO+ptHQ73OMmdgUN0XHHP/q2CeFDoxrVjRL3d4DbYmjQEwzVKdVJ92ZYPZXf9W/kw47iEgXG0td+K0fOhYbpEgKfxZyq4axmvOwA6zA6pwqzM4bwFs0GsL3Bdf+IeQb7+LlSklgc6Ku6mYZSwqvZPqOZ6WOmEU20/S/NYTcHm+K2UmeYb0bjHe7DZKrICP4iNONPzxSd97bO5iSUALZ9qsvS5OwPgkDpPzwIo1yQ6zdXKAaUtSHj1vU2LZBfvkiHIebm9a72Yr8t+W+pfmfg0D927v3GtDs80VHenYs2ndVmAT9pR1g4aScNOJzjs67CW4jHYngkJr88WjvOmbIoVq+1UhHRfH/aiZZ3N1qMUaIcz3DBXixkBZltiBCYYEe47nkr+d6+E/x25Ve4UW5LboljAkJeZ24+XVjSXDlLLShQSsb1qs4tfLG6RlX9fN44RbemD7efpry0n9T10ZVO9sFv/W70r0J3vBOJgPwK2sP2APeFDDj0ofhaqiZ20xE4gl+5N+5wi1ry7gkKFX1G4ULfheDtDDdXGJ1rZ7/3C4MgQzVVn/HNI3FrVmiPa228vR+0I= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB0068.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(366004)(136003)(39860400002)(396003)(346002)(376002)(33430700001)(86362001)(186003)(6506007)(55016002)(8676002)(26005)(8936002)(7696005)(316002)(71200400001)(9686003)(5660300002)(4326008)(66446008)(54906003)(2906002)(53546011)(478600001)(110136005)(966005)(64756008)(52536014)(66556008)(66476007)(33440700001)(33656002)(66946007)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: jXmTae6pD8ycbMJDpq15ECbmiMpgONvKwAEs0v3onU+XPRKORV58OOPnAyJpvK3vlZqeu6Cn9MjozwZHAzEbvXbboLkG5ir6N9vWn0v6Tg2AtQ0DGOjaoCDAQu97HOC53tXmERPY66CxsFkydc50sIi8b9c/jU4qgQCcvizpKarmkHFC404EvoZZWmFKcNB4zf0XtetCvQqzIDIa8T2jA5hdBurCpNCM/TZy9qoU9uSIL2Pyf46z224BYw6ZlLejuqGt4g1EUVzYjXcMEvGPEnxCJ96f/lDrn64cXagM/rSkyTBRyiqVfdFC9A+a2aqNhmC0ywJpveJVyhoORUL+tlKFKFkheDLaa/AOLdIO05q9BjySIJiz4Ezt1BGtQ2BghFlp7eaDp6vupnS9HSUjmj2Vmv7ep3J8WnBwJe6q5skY5iAF5NE8zWBYOnu6jlaojrUBieTqdW1jK2R5HhqDTEBHA9rOZ6I3XMig6wgVyDaWEQar4YxrBOQiPz0dtW4C MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 9c7604c1-10e5-4370-38de-08d7f6e35cb4 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2020 02:14:26.7891 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8Z84fk7VFYJNGFa72cGUxD/GtFFK0xO8QyzvAc88So1XkA5HIAZ6hdcNFilbhoMBdBgg/OAzqCSj93se2RA4lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1716 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This patch looks fine. Reviewed-by: Bob Feng -----Original Message----- From: Feng, YunhuaX =20 Sent: Saturday, May 9, 2020 5:34 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH] BaseTools: Fix binary file not generate map file issue REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2624 When EFI file come from binary file, not generate .map file, so need ignore= the map file. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yunhua Feng --- BaseTools/Source/Python/GenFds/EfiSection.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/GenFds/EfiSection.py b/BaseTools/Sourc= e/Python/GenFds/EfiSection.py index db892df345..e7d4639041 100644 --- a/BaseTools/Source/Python/GenFds/EfiSection.py +++ b/BaseTools/Source/Python/GenFds/EfiSection.py @@ -266,11 +266,11 @@ class EfiSection (EfiSectionClassObject): elif ImageObj.SectionAlignment < 0x100000: Align =3D str (ImageObj.SectionAlignment // 0x= 400) + 'K' else: Align =3D str (ImageObj.SectionAlignment // 0x= 100000) + 'M' =20 - if File[(len(File)-4):] =3D=3D '.efi': + if File[(len(File)-4):] =3D=3D '.efi' and FfsInf.InfMo= dule.BaseName =3D=3D os.path.basename(File)[:-4]: MapFile =3D File.replace('.efi', '.map') CopyMapFile =3D os.path.join(OutputPath, ModuleNam= e + '.map') if IsMakefile: if GenFdsGlobalVariable.CopyList =3D=3D []: GenFdsGlobalVariable.CopyList =3D [(MapFil= e, CopyMapFile)] --=20 2.12.2.windows.2