From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.7425.1595489579903095080 for ; Thu, 23 Jul 2020 00:33:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=OYQIAlXy; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: bob.c.feng@intel.com) IronPort-SDR: WOdYu8KtRBryPnECgbf6gvh/d32PWnWoHfoIDuPoDJ2bP5zjIENOUiLC95gs5O8XqzQTYR1S7y SWdhAnlwmVnQ== X-IronPort-AV: E=McAfee;i="6000,8403,9690"; a="130550420" X-IronPort-AV: E=Sophos;i="5.75,385,1589266800"; d="scan'208";a="130550420" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2020 00:32:59 -0700 IronPort-SDR: 27taMpcwHFZGuFpgwa5vsktLjEuQ8rjouEpJLHpms2WIuAS3Rytueg6ystAZg5ezQkpOKINQrp WwCgdyoT/Fsw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,385,1589266800"; d="scan'208";a="328474478" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga007.jf.intel.com with ESMTP; 23 Jul 2020 00:32:59 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 23 Jul 2020 00:32:58 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 23 Jul 2020 00:32:58 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Jul 2020 00:32:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bSZlZLhoYFqqaYnUQfxyDUiOv4uHaFsCHgHY3fiDepHiA8mKIhIhLEBANCuph/oWW9ITkqq7FrWCr/EXYtkYdZ1BQaUnaHU06HQWx2ytPyF/1VE8oyi7IkS1JauA5l+I/fmWw2m0w+Ps2fx0bh3X3JdoVJuzhYBOO9UEZWGoU4w8RVJM/ZI5ijL5pvBLmkOtd0hXGo/m+20en0a2qq+xlj2PQKCnjglAoLG/NC+VLzDjKezvcDs49kAhvWk6TT3LpUbsFmRdsLpJwsd8XZx+YeIPwdJyc1cn0RLTh1dBHA4fIMtx8fHUghZhOkGG5AIEQawobYHcJh7LbzGweVa9FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rxh4274RtOR3E5Xs9UdIBrjtdjXP+erFZGD0W/gcnJs=; b=T0H62bqS4UqUWstP2qPgomK1UJtz6tdkjGsyzruVmSMa7mTKsCWND8rE7Ksk4qpLLskl4nvR/KE3qTKol6QtqMeu4IDnc/t1ee72NeSFAAnGzemN6mbqKqomVCVfpvg0szyLUsTsYHoGY6zwsaETfXLdjOOeNqFenhI7q5MGNgFQstqOWGwoB9CcWNZwr+Rez46qsX3ege3HnGmXRY9WKgL5ZXLWk2/y3oxrlUUGk6EXcn5daMgUJNcw3pBqnANV6K7IhkYS5XW5wNf3T0bTE5T8toJlkzFCVKnaVw9OdXbe1kHOML1tJ+RrT15g/iyqOe8qH0d4uBVqofBujp2R0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rxh4274RtOR3E5Xs9UdIBrjtdjXP+erFZGD0W/gcnJs=; b=OYQIAlXygB++ZvtEP6CljFI0fZrV6zswS//Dm8iMED6Hxk1lFwqNc6ryvUPzHFB1tPLqIarTaxWsZdkiW2GHWb15RWmNHSLDX95D5Opjveovwd8dQX37swlMSFY1MVUwHqwEnc+wQMsjt64zd+pAQuyrPM7eXwNSCBDGY2cfQ3c= Received: from BN6PR11MB0068.namprd11.prod.outlook.com (2603:10b6:405:69::17) by BN6PR11MB1891.namprd11.prod.outlook.com (2603:10b6:404:107::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Thu, 23 Jul 2020 07:32:48 +0000 Received: from BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::f4b6:406b:26fc:c069]) by BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::f4b6:406b:26fc:c069%3]) with mapi id 15.20.3216.023; Thu, 23 Jul 2020 07:32:48 +0000 From: "Bob Feng" To: "Jiang, Guomin" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [PATCH v3 1/1] BaseTools/Scripts: Ignore the CRLF check when upgrade submodule. Thread-Topic: [PATCH v3 1/1] BaseTools/Scripts: Ignore the CRLF check when upgrade submodule. Thread-Index: AQHWYBOLGmKocirBAE6JsZlPvcxoeakUxq6Q Date: Thu, 23 Jul 2020 07:32:48 +0000 Message-ID: References: <20200722103326.1311-1-guomin.jiang@intel.com> In-Reply-To: <20200722103326.1311-1-guomin.jiang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 951925ac-3c4c-4ef9-6b7d-08d82eda994f x-ms-traffictypediagnostic: BN6PR11MB1891: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:439; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VS7a1Pgiu4VqAwneso5vy2MbIxkGmZho6IQ9KF2fwRtQrQkZoKW05wPGzt5m6/rnuPqVMEV4RYmQNdtXdQQwdvPP3icxcuslsh32h5Zl+QL2KvfzbP1/7I+WqB3YQpVphd5K7CiUmHwD3vTh2cMGlt0rJprTHSae3OHrFpMbKCX8wbPS5+d8hM2AbBzf/876Sqm4hXB2EjzR+wdo3+zZEKsrNRR87TxNU24HoVe0U/jqIuHkpivtILSYyvLaNXbGZNbbcKvnRqX2JfgF7GSEy1wLNOczYhxNzddTiM/rLG/q1VhTTavbBgBscHTmaqASUyuYyOUbxrCGNh3Sqxl6XQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB0068.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(136003)(396003)(366004)(376002)(346002)(64756008)(76116006)(66946007)(66446008)(66476007)(66556008)(4326008)(9686003)(6506007)(4744005)(478600001)(8676002)(7696005)(55016002)(52536014)(83380400001)(2906002)(26005)(5660300002)(186003)(53546011)(33656002)(110136005)(316002)(71200400001)(8936002)(107886003)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: a8WP/o3gftv9x8llirdTvy8SMExDM/UhFzmsTFXbJWynbfvWIg8FDyYxlx8bRaqOI1LtBLIa9l/zyGL883W/OIMFxTUo3EfnAZLdMkQFC30LkmVqVZNDSNHarL99b/UVN5KGQk0Dj1UYaS3jc/AGmPeYt4vJpn5dvdbe32gsSIvwJM77GJxHxCMoVLXNtE6Z7mt0RUfQXGfwKyNSBhr1HohQHozNuUvowCM4LwUMYpVB43Bi2jju8IuFq0TCLo3Q7a5AFW7LHa6NQDGfz5sq4/JxZ3lRNuW5IAUOjNP5O7qdVcFOHSDX6ekbqYmTKjLT71vIC6tabH+8y/GVBjMWNroAvE4rDRyn7TRvlxdINtIb0JjrWv5TVOWOK2kEftXxzp4wAN6cxZkp0ceqXbOKBFoioy2CMDqen/t4UACZaP49WsMjyDAjzTfjzrNF6Y6oIse4jj8NUKZfh+yYGRx/zidfeUgENXMUTpHvA/TgC9I9xWo/bGIbBnbQpd3cqxCb MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0068.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 951925ac-3c4c-4ef9-6b7d-08d82eda994f X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2020 07:32:48.1053 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mI5dbFqMiGnZE45mgIGLkPH4DGwE4knMojPIbTMFFSEqupQIEvV3+anBveg0IQ1/CtDvC+I5K1nTa/U9JwNYIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1891 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: Jiang, Guomin =20 Sent: Wednesday, July 22, 2020 6:33 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH v3 1/1] BaseTools/Scripts: Ignore the CRLF check when upgra= de submodule. If the submodule is upgraded, skip the CRLF check as it isn't change for fi= le. Signed-off-by: Guomin Jiang Cc: Bob Feng Cc: Liming Gao --- BaseTools/Scripts/PatchCheck.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index 7db0775d14d1..ca0849b77bbe 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -502,7 +502,7 @@ class GitDiffCheck: =20 stripped =3D line.rstrip() =20 - if self.force_crlf and eol !=3D '\r\n': + if self.force_crlf and eol !=3D '\r\n' and (line.find('Subproject = commit') =3D=3D -1): self.added_line_error('Line ending (%s) is not CRLF' % repr(eo= l), line) if self.force_notabs and '\t' in line: -- 2.25.1.windows.1