From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.4811.1593663665437480725 for ; Wed, 01 Jul 2020 21:21:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=FsO8K9/F; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: bob.c.feng@intel.com) IronPort-SDR: ptuAAi352MfxsaWHlhw81Tj60JtO3ZzT1jmBsnGOLq1o1w1aPjTDxVSHDQvntcR5OYfddPTSkA KWj3PQX/1QJA== X-IronPort-AV: E=McAfee;i="6000,8403,9669"; a="126407146" X-IronPort-AV: E=Sophos;i="5.75,302,1589266800"; d="scan'208";a="126407146" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2020 21:21:04 -0700 IronPort-SDR: avwFIr5LFHMRum7Rq0flZ3Joxx77yh+avDdl6bAW2309+fWBgRQXxO6kha4/uRt7bcxjX7lnpK HPeQRq3W0NLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,302,1589266800"; d="scan'208";a="321968977" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga007.jf.intel.com with ESMTP; 01 Jul 2020 21:21:04 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jul 2020 21:21:03 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jul 2020 21:21:03 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jul 2020 21:21:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QYOxZpKyQ0sI04Kaxa7yo7oOQ+Jwl8aaEgCNhcVoIyLi4q5Cs29WvRnS6LuDb9eENRxTSZaIKx0xtMnAjJKmiL9wvJXOznTpz2Kvvb8h0d1crNM5lum6ez+RL6oiIkw+ogiksTV1nysEFdzwymhPClLLuS+IKC+crjysf6GPIPAljtbJosEAw6NJok5IWWVnT/C275JbDqcoDeORXYNKGVJiGr4LfHVSzbkTXPnqnkZYEOBz7ViJFvgP6nNKvq7FUh1NytU1WQbiCf4YWRr8LtgsO2oyhjSomchjHkCjpCJhJXsQHQl53HZy0DywXSG6TPQOCLrXBoUklAGBcbYaEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E0E9hv5m46ilHNCpVqZz1lWUvu/iusH+HAdfTR6YrGI=; b=DaEFz+0kAN/5nX6sADcJEyf03QWWsN6QdWkH7mohQ2udRh1ntztxd1ziAOw7MDzGnAHrJdXqG8fAGxba2oHAGd4HAMjmtY7oG7kiBdZpWL1/e6AwwUFSYHnHr0zccOckHBVQa6XkHSJUkiJ0z4XEoc8WpNXY1Y3fDfCGTR/HFmVTTxVP6asvliPth6S8B9GKtNIn0fkg5ifbJf7pb0qem3vmTQ9gEzY67tGS+Ivv6VfAERtlmCEt5xqb7ZCYqufEOkQU/WxiCFDlbqD+SIo63ZQ1lh9osPpJk/5I7wMvObKYpbdGbXIpyzRnlD/kgXlN98cA0mK6VSe+5lKLMHyyhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E0E9hv5m46ilHNCpVqZz1lWUvu/iusH+HAdfTR6YrGI=; b=FsO8K9/Fipfa1lmJZ/wEICn99D1IqHVXwA99a7oVQ9JBgQyxMKxSlM3mtP45C1erNIdzJs9D2Pfdc5nnFAIfMdj4KYFBTu3ptTSY+1pFtJ43vzj8n3DhGywquZX+WdoYjOl0hOlUdSrXMh0z32ChqyYerQKkpioTVgBKPlbfseM= Received: from BN6PR11MB0068.namprd11.prod.outlook.com (2603:10b6:405:69::17) by BN6PR11MB1362.namprd11.prod.outlook.com (2603:10b6:404:3c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.20; Thu, 2 Jul 2020 04:21:02 +0000 Received: from BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::6870:82d3:5bde:4153]) by BN6PR11MB0068.namprd11.prod.outlook.com ([fe80::6870:82d3:5bde:4153%6]) with mapi id 15.20.3131.034; Thu, 2 Jul 2020 04:21:02 +0000 From: "Bob Feng" To: PierreGondois , "devel@edk2.groups.io" CC: "sami.mujawar@arm.com" , "tomas.pilar@arm.com" , "Gao, Liming" , "nd@arm.com" Subject: Re: [PATCH v5 1/5] BaseTools: PatchCheck: Exclude bash scripts from CRLF check Thread-Topic: [PATCH v5 1/5] BaseTools: PatchCheck: Exclude bash scripts from CRLF check Thread-Index: AQHWT7DeGOcMXjQmXUyVBaG9HmzU46jzsMgA Date: Thu, 2 Jul 2020 04:21:02 +0000 Message-ID: References: <20200701140604.5292-1-pierre.gondois@arm.com> <20200701140604.5292-2-pierre.gondois@arm.com> In-Reply-To: <20200701140604.5292-2-pierre.gondois@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7b058cd9-198d-4a4a-a86e-08d81e3f5499 x-ms-traffictypediagnostic: BN6PR11MB1362: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0452022BE1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NiacRdtxfDz/o6HbLKGco/X0EwFtpSCslvwIrUuPTD7vBRuZ4fLp85LlS5hlvi+jVKrwV118PhugpWaALTdj04jFpfy02cpyxNdqmjjvU2dn3eopfZtYLSfLUrgOTLR1hxsSihqRHzyyhhXhZ6OV83ITgfXQMMqlVqA9h7x70r8KDLQo3fLj2gblMYFeYfrNgQvzu39hGREX6+CLCErXn8W0r5N083ExUxTdb/gzhNP7ruRcAp09bdn8mSeBzSOxtCyUBD2DMvKC64hYnj1fyXl4L1hsDhLey6S8VyXKGYrkm20dxJUCEg/Z1I3Wt+XjKXLR2isA+Pe5CHs4L5cM6mJJpKLIck1l5jUmUPfTBJ2WHQGWWQ3RmaGYHybihUoQ4Cfd2XqxYJumR0r88+VamA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB0068.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(366004)(396003)(136003)(39860400002)(376002)(186003)(71200400001)(7696005)(6506007)(4326008)(86362001)(316002)(110136005)(33656002)(8676002)(52536014)(9686003)(5660300002)(53546011)(83380400001)(54906003)(55016002)(66446008)(26005)(66476007)(2906002)(66556008)(64756008)(66946007)(478600001)(966005)(8936002)(76116006)(19627235002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: ROg4f6mf3dfMrMKda1we0kacboKQ0HX7GHwZ97GjnGZ43IBhRzWYmRgXfR4eA5qeW8RpVqCXBY2HZjizafB9H6G6SHBf1Fr+8lo8YiDPzfuO1PPYzD58E3+AQj4zk/8J08Zi1jo4aww5EUqfmizFmY1aS1WBXSiQ/k1LxnE3P+CRrt0+OhEi0lyP1rKbW29ljhVPgFwaPJ9J/hcqF/X89EGYhyQGPJFo7femBAkqU/Zp0iFA+mbYm4wzdlCwPQR4uRlDnK2rgsmB73kT2WOtjruhv4aFYVTmBL2E0ItPDHFEbwWKYA9M7nhfbfYJT6rA1W8pzcj1hGaO6JdritBEa7q9CCqHFSLg2W8aiYjcF5jlx6ONVDcfbPKNlwisO0mFrO9qiGumfS4nuPIlUtxG+BsDXm8sjqhdO7mlvgt88tXxi8z/362hms8B2UcrOr/NdvnfMAIL6bFgL+cns4HKJIw8peYkrBYq4YiTZWOi3S5oW+kwNUL5txUPYq77qAUL MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0068.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b058cd9-198d-4a4a-a86e-08d81e3f5499 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2020 04:21:02.1325 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Lyuv0Q3InygYPjzo78tVyhFkxoskSPa8zcLDls42CT80GrfL6QAdzctXnwI+CiNK8tXRTb+82CA3McgD13lmLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1362 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: PierreGondois =20 Sent: Wednesday, July 1, 2020 10:06 PM To: devel@edk2.groups.io Cc: Pierre Gondois ; sami.mujawar@arm.com; tomas.pi= lar@arm.com; Feng, Bob C ; Gao, Liming ; nd@arm.com Subject: [PATCH v5 1/5] BaseTools: PatchCheck: Exclude bash scripts from CR= LF check From: Pierre Gondois Bash scripts require LF line endings to work. PatchCheck.py checks that the files added in a patch have CRLF line endings= . It excludes files ending with the ".sh" extension from this check. Some bash script don't have a ".sh" extension. Most of them are located in: - BaseTools/BinWrappers/PosixLike/ - BaseTools/Bin/CYGWIN_NT-5.1-i686/ This patch excludes these folder plus BaseTools/BuildEnv from this CRLF che= ck. Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/803_C= ompile_AML_bytecode_array_into_OBJ_file_v5 Notes: v5: - Exclude some directories/files having LF line endings from the PatchCheck,py script. [Bob] BaseTools/Scripts/PatchCheck.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index 106b434c750d71d8aa1658109f146dc066633c2c..e38cf61f93da50f77d4e1e2= e37de5f6a08d25408 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -3,6 +3,7 @@ # # Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.
= # Copyright (C) 2020, Red Hat, Inc.
+# Copyright (c) 2020, ARM Ltd. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -384,9 +385,14 @@ cl= ass GitDiffCheck: self.is_newfile =3D False self.force_crlf =3D True self.force_notabs =3D True - if self.filename.endswith('.sh'): + if self.filename.endswith('.sh') or \ + self.filename.startswith('BaseTools/BinWrappers/PosixL= ike/') or \ + self.filename.startswith('BaseTools/Bin/CYGWIN_NT-5.1-= i686/') or \ + self.filename =3D=3D 'BaseTools/BuildEnv': # # Do not enforce CR/LF line endings for linux shell sc= ripts. + # Some linux shell scripts don't end with the ".sh" ex= tension, + # they are identified by their path. # self.force_crlf =3D False if self.filename =3D=3D '.gitmodules': -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'