From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.4545.1591767120149252752 for ; Tue, 09 Jun 2020 22:32:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=w8soscEj; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: dandan.bi@intel.com) IronPort-SDR: CpoLP0a/eq9y5TlAOKFnkvVEEBj1FLHXxYn+I1bBBKv8zXiJAiesEHBBq02/wiFWUDAmHwc3XF IMXsdfVtLkyg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2020 22:31:58 -0700 IronPort-SDR: GX7dtfbgeCO5pbO7axpwF9tPhWbyqjociaAD18kNtBBW5VCRpVYyud3/5qRpjtd0HOxlNQkDAl vROeG6fVHPSQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,494,1583222400"; d="scan'208";a="447371242" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 09 Jun 2020 22:31:58 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 22:31:58 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 22:31:57 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 22:31:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R8Y22m4XAr3CmnekMWe4w/cl+KQPHDjtkvOaN/svAQHeVogqe0IcW5+NBq58iTijThC0znwVvsXjH1NU+fAVTHcKuCdvWqqSMoSORZQzHzzrqAvIEp16HL0vS0fVaPgL0J+JjLNWUO6juTuguSay11Hyc8kdxkP/QSsvld3cgHbSpr8mWLLQvF90XJl6aER/1CHyplIOt6xC8E1CTiSNX2TIAhevRCMAfo9ijecpQECrLefPvqm1sOLPsD8erjcW7DDueJ39mCnGx2TcjmDk2pi4vPXWkBNO+ZQV9xIM8ieNSuvNSj5UEdovPOchC4cP1mqjRWLfcvbDLbBTYMUQlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tuMBDQdE27Zs2Hg6zcsEt41gjD8F7nkVAPGRQhw2HH4=; b=LtUDX1XHsamWuEWuNkq1UpDfGEnfZjW+Ktx8ROQShZQ2Rc+fUKAwcCTyF2QrzM6QlqEomT697zDoHS5R4oQd1K97DbhOIYVAJlEEREjXyGPPb8x1TLxWdc8JhDXgQJDhyJ9AWwU+DMT5rtDwVmrd9HxpXTmjiXqleMWgKdpCmo/keUimg1jIWaWQ0k7ojUtK9J3UPjrdpQ/MqN3TzaylYibj9TkHZOjWxnfENilQDWm1CuAlGM8lRe6HQG7/L8FKGIQSvzmR9fZ1EFjBCiarlWZUk8kb/kF27et9tgQ5sbvLAGUvUN1hTZ+2NDnGlw4QUJYGF23kRlh5eYcDOdyRTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tuMBDQdE27Zs2Hg6zcsEt41gjD8F7nkVAPGRQhw2HH4=; b=w8soscEjvq6rGpzzuJid42yMFuvQVQAJjkwAcvSaVEXNLRNnj5t4F9e01PKUhckPkKRJCK30F8DCtZM5E3/W5amamdMbQXW0L61IRz+/ehmsLtGpWIjEdWjQRQWR99eW9bTzoZk0bQcDzehA49uL3yAs3LRtFx7PpSjFkhAHv8g= Received: from BN6PR11MB1393.namprd11.prod.outlook.com (2603:10b6:404:3c::12) by BN6PR11MB1297.namprd11.prod.outlook.com (2603:10b6:404:4a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.23; Wed, 10 Jun 2020 05:31:56 +0000 Received: from BN6PR11MB1393.namprd11.prod.outlook.com ([fe80::a1f4:15d6:9a79:de03]) by BN6PR11MB1393.namprd11.prod.outlook.com ([fe80::a1f4:15d6:9a79:de03%11]) with mapi id 15.20.3066.023; Wed, 10 Jun 2020 05:31:56 +0000 From: "Dandan Bi" To: "devel@edk2.groups.io" , Abdul Lateef Attar CC: "Dong, Eric" , "Wang, Jian J" , "Wu, Hao A" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Sets the Cursor to selected BootOption. Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg: Sets the Cursor to selected BootOption. Thread-Index: AQHWFuH++8YTEXpYSkSvcLypmLv8n6ica3bAgDIwftCAAwbeQA== Date: Wed, 10 Jun 2020 05:31:56 +0000 Message-ID: References: <20200420070555.23046-1-abdul@marvell.com> <160CB30545BDC239.3224@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 81958a63-49c1-45bb-95ce-08d80cff971a x-ms-traffictypediagnostic: BN6PR11MB1297: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:363; x-forefront-prvs: 0430FA5CB7 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pEPmYaLoA9RinquuHpAlLJYp2f0zrrmIDv31sdR5pow9raVOMiCITA0RKmLtAQVkhANKQRbovb9cRnxRAIFjUF36XE9OcAR2ajZ9TI3PmShR5jWsVuZOMmJ46ITWb1azvnsW+xdugx4I72tSeLbsO73KSTyP3jeqb/mZbBd3VKlYGycj38sHMnEl19ooCHD9MApv/HSUF6g43t5bvNa5Nxk3Yku47z2+sXXPU69QspmZNBqTnNULRz9YYaq6YZS3rSCuLXRfB/d4tyTr/IqW5QojiQbDnP2iseWn8dDRL1SigJZdZzuOwb9P1Zwkwx4eTmNby2/f/3W0gGY2x1tbWyImTIKokVorUmt7yraFu9p9YBjfV7UB3uUmi0WYdyaH+jyEYIFSp49ueu00v3tFbA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB1393.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(376002)(366004)(136003)(346002)(39860400002)(478600001)(966005)(186003)(26005)(71200400001)(2906002)(8936002)(110136005)(9686003)(7696005)(8676002)(83380400001)(5660300002)(54906003)(66946007)(4326008)(86362001)(52536014)(316002)(64756008)(53546011)(107886003)(6506007)(33656002)(66446008)(66556008)(66476007)(55016002)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: v0Bbh/N9cEHPddy7QtlakCjFnNxUaUiIvp/xYsNhjMFXkUx3WJcKjvPT8LELLJSEy44GoCGJJiS8xlSPEaVaXoE/puyh4aFtTS/T9dqKHL91zlsuXj7QZRgtzmFzneBiGl2wpZN56acYm3cOSCEuLwzqFDWkKmFpAlKPI+56fcSu8w2gZ0vXQJ9tpkm0rO1TqwfaK8aGG8zLH0a6PaZloA2ayfTmN9LqCTvoAFBzEDbOwQwcUiNDP88Lk7Du+rBmhrVgt95bN2lNA1eWdDDQsz9uXKX8Vm+J/FlWgvwmsajwQTmIHaKbE/+kXUqddCiPKoJyDKsfuocDBVTKQ9zmUV4p0WbjaIzo4nfwdqOKZcDWBDHZlCLjllEua1ZNSnKJN6TeQiue6tIKK4iQuSTKhzghrC/SFdw7HT9q+S4uyD8J7sMqb1VrOTkrkgIm9mG1Vm71VXHLjseE09xI0WGjaqZ8Ibp3OOgnUOM3BJzn2AU= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 81958a63-49c1-45bb-95ce-08d80cff971a X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2020 05:31:56.2841 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SR4l3a6uZQSdg1VDKvKqn6T8EGO0Uk0QC4Wdd0LJQypATJxt/ruYzbOeqsnDxQO7ebXu+mD/bVh3QFyC/+hZUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1297 Return-Path: dandan.bi@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This patch is committed via 9b52b06f964226780b7047e10be0c1a65e223eb1 Thanks, Dandan > -----Original Message----- > From: Bi, Dandan > Sent: Monday, June 8, 2020 3:19 PM > To: devel@edk2.groups.io; Bi, Dandan ; Abdul Lateef > Attar > Cc: Dong, Eric ; Wang, Jian J ; > Wu, Hao A > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Sets the Cursor to > selected BootOption. >=20 > Hi All, >=20 > I will push the patch tomorrow if don't get any objection. >=20 >=20 > Thanks, > Dandan > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > Dandan > > Bi > > Sent: Thursday, May 7, 2020 4:52 PM > > To: Abdul Lateef Attar ; devel@edk2.groups.io > > Cc: Dong, Eric ; Wang, Jian J > > ; Wu, Hao A > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Sets the Cursor to > > selected BootOption. > > > > Reviewed-by: Dandan Bi > > > > > > Thanks, > > Dandan > > > -----Original Message----- > > > From: Abdul Lateef Attar > > > Sent: Monday, April 20, 2020 3:06 PM > > > To: devel@edk2.groups.io > > > Cc: Bi, Dandan ; Dong, Eric > > > ; Wang, Jian J ; Wu, Hao > > > A ; Abdul Lateef Attar > > > Subject: [PATCH] MdeModulePkg: Sets the Cursor to selected > BootOption. > > > > > > Its been observed that in MenuManagerMenuApp when user selects a > > > different BootOption using Up/Down key, the current Cursor position > > > is not chaning. > > > Still points to the old BootOption. > > > > > > This changes first dispalys/redraws the old BootOption followed by > > > new BootOption. Doing so will make current cursor pointing to the > > > user selected BootOption. > > > > > > Signed-off-by: Abdul Lateef Attar > > > --- > > > .../BootManagerMenuApp/BootManagerMenu.c | 22 > +++++++++++- > > -- > > > -------- > > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > > > diff --git > > > > > > a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu. > > > c > > > > > > b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu. > > > c > > > index 34d4089a55..9e729074ec 100644 > > > --- > > > > > > a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu. > > > c > > > +++ > > > > > > b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu. > > > c > > > @@ -451,20 +451,10 @@ BootMenuSelectItem ( > > > } > > > > > > // > > > - // Print want to select item > > > - // > > > - FirstItem =3D BootMenuData->ScrollBarControl.FirstItem; > > > - gST->ConOut->SetAttribute (gST->ConOut, EFI_WHITE | > > > EFI_BACKGROUND_BLACK); > > > - String =3D HiiGetString (gStringPackHandle, BootMenuData- > > > >PtrTokens[WantSelectItem], NULL); > > > - PrintCol =3D StartCol + 1; > > > - PrintRow =3D StartRow + TITLE_TOKEN_COUNT + 2 + WantSelectItem - > > > FirstItem; > > > - PrintStringAt (PrintCol, PrintRow, String); > > > - FreePool (String); > > > - > > > - // > > > // if Want Select and selected item isn't the same and doesn't > > > re-draw selectable > > > // items, clear select item > > > // > > > + FirstItem =3D BootMenuData->ScrollBarControl.FirstItem; > > > if (WantSelectItem !=3D BootMenuData->SelectItem && !RePaintItems= ) { > > > gST->ConOut->SetAttribute (gST->ConOut, EFI_WHITE | > > > EFI_BACKGROUND_BLUE); > > > String =3D HiiGetString (gStringPackHandle, BootMenuData- > > > >PtrTokens[BootMenuData->SelectItem], NULL); @@ -474,6 +464,16 > @@ > > > BootMenuSelectItem ( > > > FreePool (String); > > > } > > > > > > + // > > > + // Print want to select item > > > + // > > > + gST->ConOut->SetAttribute (gST->ConOut, EFI_WHITE | > > > + EFI_BACKGROUND_BLACK); String =3D HiiGetString (gStringPackHandle= , > > > + BootMenuData->PtrTokens[WantSelectItem], NULL); PrintCol =3D > > > + BootMenuData->StartCol > > > + + 1; PrintRow =3D StartRow + TITLE_TOKEN_COUNT + 2 + WantSelectIt= em > > > + + - > > > + FirstItem; PrintStringAt (PrintCol, PrintRow, String); FreePool > > > + (String); > > > + > > > gST->ConOut->SetAttribute (gST->ConOut, SavedAttribute); > > > BootMenuData->SelectItem =3D WantSelectItem; > > > return EFI_SUCCESS; > > > -- > > > 2.11.0 > > > > > >=20