[PATCH] Features/Intel/UserInterface/UserAuthFeaturePkg: Add RngLib instance to DSC

[PATCH] Features/Intel/UserInterface/UserAuthFeaturePkg: Add RngLib instance to DSC

[Zhiguang Liu]

The UserAuthFeaturePkg build currently fails since it does not specify
a RngLib instance and OpensslLib links against RngLib.

Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
---
 Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeature.dsc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeature.dsc b/Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeature.dsc
index e8d9a639bc..7d784f4dff 100644
--- a/Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeature.dsc
+++ b/Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeature.dsc
@@ -6,7 +6,7 @@
 # INF files to generate AutoGen.c and AutoGen.h files
 # for the build infrastructure.
 #
-# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -50,6 +50,7 @@
   UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
   UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
   UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
+  RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf
 
   #####################################
   # User Authentication Feature Package
-- 
2.25.1.windows.1

回复: [PATCH] Features/Intel/UserInterface/UserAuthFeaturePkg: Add RngLib instance to DSC

[gaoliming]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: Zhiguang Liu <zhiguang.liu@intel.com>
> 发送时间: 2020年10月19日 14:17
> 收件人: devel@edk2.groups.io
> 抄送: Dandan Bi <dandan.bi@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>
> 主题: [PATCH] Features/Intel/UserInterface/UserAuthFeaturePkg: Add RngLib
> instance to DSC
> 
> The UserAuthFeaturePkg build currently fails since it does not specify
> a RngLib instance and OpensslLib links against RngLib.
> 
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
> 
> Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeature.
> dsc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git
> a/Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeatu
> re.dsc
> b/Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeatu
> re.dsc
> index e8d9a639bc..7d784f4dff 100644
> ---
> a/Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeatu
> re.dsc
> +++
> b/Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeatu
> re.dsc
> @@ -6,7 +6,7 @@
>  # INF files to generate AutoGen.c and AutoGen.h files
> 
>  # for the build infrastructure.
> 
>  #
> 
> -# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> 
> +# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> 
>  #
> 
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  #
> 
> @@ -50,6 +50,7 @@
> 
> UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServices
> Lib.inf
> 
>    UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> 
> 
> UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/
> UefiRuntimeServicesTableLib.inf
> 
> +  RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf
> 
> 
> 
>    #####################################
> 
>    # User Authentication Feature Package
> 
> --
> 2.25.1.windows.1

Re: [PATCH] Features/Intel/UserInterface/UserAuthFeaturePkg: Add RngLib instance to DSC

[Dandan Bi]

Reviewed-by: Dandan Bi <dandan.bi@intel.com>


Thanks,
Dandan
> -----Original Message-----
> From: Liu, Zhiguang <zhiguang.liu@intel.com>
> Sent: Monday, October 19, 2020 2:17 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>
> Subject: [PATCH] Features/Intel/UserInterface/UserAuthFeaturePkg: Add
> RngLib instance to DSC
> 
> The UserAuthFeaturePkg build currently fails since it does not specify a
> RngLib instance and OpensslLib links against RngLib.
> 
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
> 
> Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeatur
> e.dsc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git
> a/Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeat
> ure.dsc
> b/Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFea
> ture.dsc
> index e8d9a639bc..7d784f4dff 100644
> ---
> a/Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeat
> ure.dsc
> +++
> b/Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFe
> +++ ature.dsc
> @@ -6,7 +6,7 @@
>  # INF files to generate AutoGen.c and AutoGen.h files # for the build
> infrastructure. #-# Copyright (c) 2019, Intel Corporation. All rights
> reserved.<BR>+# Copyright (c) 2020, Intel Corporation. All rights
> reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -50,6
> +50,7 @@
> 
> UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiService
> sLib.inf   UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib
> /UefiRuntimeServicesTableLib.inf+
> RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf
> #####################################   # User Authentication
> Feature Package--
> 2.25.1.windows.1