From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.24849.1591600571623434861 for ; Mon, 08 Jun 2020 00:16:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=EmhnSmE/; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: dandan.bi@intel.com) IronPort-SDR: y4IECVo0VZl4LeQHcMH94UDOPwDE9GrMGLnP3s++/2hxxwuwroFvYakBko6HW35cvBvuPcTSrd D1ML9dERQVhw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2020 00:16:10 -0700 IronPort-SDR: Z1Q477r/6/ZHw0IbcTGq8+eb4UxYSLXXvIHsZSJTqNbFnQLZUsctHSBqxromXqyC1p35J5J3nQ VzGyEG4hiSHw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,487,1583222400"; d="scan'208";a="349081120" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 08 Jun 2020 00:16:10 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 8 Jun 2020 00:16:10 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 8 Jun 2020 00:16:09 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 8 Jun 2020 00:16:09 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 8 Jun 2020 00:16:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iYZtYHmHP68PVxXnIGJ+ypI+iaMoEik+lckOytzCiKspIFxdmMzgNdZdKvsl1bQXQt3jjqA58jjoyjXqY3om30gBiXfkBJllAeMcf3vRfRdSXwkrrapLNynbTTkNOeLvXS3xLOZDG92ki2qu1ath5P8n95Q5l2oLCBLfZQHK25LNFz6I1roN9nSzUSQOtNwpLS3naH/QtNp2gv6bM7Oy0Q6sGZJmnkbkJ1Rkvpbi+fUHblgZNZ4ibHtmeZm6YoOUO1K8Bq4w/ecZh/fGjpcqeUXs4BzCYzuy0ABUnezXvDxZ/HEu738/NTif8Lqo5aiBWLMh3A7swvznqsfdnca4Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nfL6ywH+S73xBd4Z8hBpibShWoXlY4xDwXpZ1xxXTw8=; b=VHLfJ6ST3veDFM7Ag045+qKprCK97sM8UOKEMboNDJpJv9Cu7ZqB0bwzqHUfZy1QTV8y9XJT9d79OaTI4rfYeJ96jxDfCIEr9dRG2MknfBRzmF7xVnQbiO8mKyzqcpa6WfezsEVtRXPAgQ3FpsGky1nApYA+7HcI7hHAgN/7y7ggk6/Q1xXjE4Uc32E4+ijhzhQlvNH0PLHDHiVBG4q11oNQHfYadmQLvBw8n7NqhHlD1nzdZdDf+u2X+miDxXCaxXghkDlcB8sFBiiq1v1ajHAcbdzW47nkrnRxC9D//e6/KOyn2M6G5cJ39eEvOTY6JKSGNDPAS86qk5x2IbgTWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nfL6ywH+S73xBd4Z8hBpibShWoXlY4xDwXpZ1xxXTw8=; b=EmhnSmE/1VeThdQk6BfG9dLcMBi5J4JEFQXUDtrYoYhpLNdYLZJrDyEh6xiuGyGZCvpxkorfiDU88vqZkpu3T+WeimfKZ6tz+mOD5ab3MfKNlGQNaH4zfRfhADllEo0fxQ/t2mVOGFFrpkNOwfdwXuOXMm5AftX6FPVip7LKbik= Received: from BN6PR11MB1393.namprd11.prod.outlook.com (2603:10b6:404:3c::12) by BN6PR11MB1812.namprd11.prod.outlook.com (2603:10b6:404:101::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18; Mon, 8 Jun 2020 07:16:07 +0000 Received: from BN6PR11MB1393.namprd11.prod.outlook.com ([fe80::a1f4:15d6:9a79:de03]) by BN6PR11MB1393.namprd11.prod.outlook.com ([fe80::a1f4:15d6:9a79:de03%11]) with mapi id 15.20.3066.023; Mon, 8 Jun 2020 07:16:07 +0000 From: "Dandan Bi" To: "Li, Walon" , "devel@edk2.groups.io" , "Gao, Liming" CC: "Wang, Nickle (HPS SW)" , "Chang, Abner (HPS SW/FW Technologist)" , "Wang, Sunny (HPS SW)" , "Dong, Eric" , "Wang, Jian J" , "Wu, Hao A" Subject: Re: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect driver with form-update Thread-Topic: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect driver with form-update Thread-Index: AQHWLl7IYBL1bOepQkyMkHngPJlol6i22bVwgA/0kYCAB51yoA== Date: Mon, 8 Jun 2020 07:16:07 +0000 Message-ID: References: <20200520042447.1017-1-walon.li@hpe.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: hpe.com; dkim=none (message not signed) header.d=none;hpe.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b8e6b92e-4e44-4dd9-09e3-08d80b7bd04b x-ms-traffictypediagnostic: BN6PR11MB1812: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 042857DBB5 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8LWSDsCmyYfrpO0JJYHCm9YoCPTdD6J1hSkkzsBIzHjBEI3dKfosl5a+6PgWiieceH0LtXdSofyKonPAHSmt98kW6eM725ulDV8HEMXjnCR64X5vFXNdWCxlGo00VfNk2jm+3VrTNwkzcmpmLxSJ1jgDy30X22bKlqZ2fhiQRSlFMQXIMdUMnSdhd8l8NDMoJ+NGCdODLU2CgPnrA6+qvKBBOSYNkzGSammj/6Xgahi8pYBwaQ+gGJxq9UYF+UIiOawQGJ9aWY3Mj4KC6MZyOSblug2s3Mushg8HsSWdXnjGDcrFyjTPntZMThb2v+iNdkESNnT175L4ViccJpddDoZSj5+bJTs1kgXcX9ky76z5bYqsgXhi2stZPEaf4bVe1xZmZe36dDxxj/AQyplrag== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB1393.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(366004)(396003)(39860400002)(136003)(346002)(376002)(33656002)(5660300002)(6636002)(83380400001)(52536014)(15650500001)(71200400001)(2906002)(19627235002)(66574014)(8676002)(54906003)(76116006)(7696005)(296002)(316002)(55016002)(110136005)(64756008)(4326008)(9686003)(86362001)(6506007)(478600001)(66556008)(66946007)(186003)(107886003)(66446008)(66476007)(26005)(8936002)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 3AKhkgF8KTl9JQeoGI85lmfd70YSq+FmOm8ZM2WtbQ+R9lIGQxxIX5NPTK0Ow1+mrQO2Wsn4HJy0ny5DYUc+tE5daTFUT6ru5ofxHs+tQtdyAUoaaF73wdLp5zE7o5PwMEg6D0rCk3kGw94wWBr7koEQ6+fFl/3LWwAMI5K13ZlWzHwbstaTyuQjwIXB6lZKFPum3fbwB3CLS9bdDLfvPrcL9C8u94wPDmIAxPIjtySehEg3VigQszamtrscjVDpe0xcStXy8qaDOpuyigRZ+3x1dDwe0lDWeoMH4Y5suhtHFHA8uECnqnb8nT1d3pUPyWI+0H7y+28pfn9eA/8s/y1m63AWJn95ON/zXPSrzyXTcI6Sc1OMrUEGcZgJ7g2cVrZUjpBjlo8kMOudx2RQbGl84TUuXiq7dUn12Au9j+T1/QdqtzdKtnfeyGetEhkyXp/pS5kwOBPmi/ZzIBA70NsBqXU9MZsDhlLOkT7CWyM= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: b8e6b92e-4e44-4dd9-09e3-08d80b7bd04b X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2020 07:16:07.2848 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +Uy+Xw6KEhgzNn697YGtRFnpGsXmLHs7s5ZacEe90Q8nFaNP+ZoQ0ndrWQ5ZtCWRnl93mpdXTW0aA3d0d8sGTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1812 Return-Path: dandan.bi@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi All, Is there any concern for this patch? I will push this patch tomorrow if don't get any objection? Thanks, Dandan > -----Original Message----- > From: Li, Walon > Sent: Wednesday, June 3, 2020 6:56 PM > To: Bi, Dandan ; devel@edk2.groups.io; Gao, Liming > > Cc: Wang, Nickle (HPS SW) ; Chang, Abner (HPS > SW/FW Technologist) ; Wang, Sunny (HPS SW) > > Subject: RE: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect > driver with form-update >=20 > May I know the schedule of pushing this change to edk2-master? Or what's > next step I should do? >=20 > Thanks, > Walon > -----Original Message----- > From: Bi, Dandan [mailto:dandan.bi@intel.com] > Sent: Sunday, May 24, 2020 3:17 PM > To: Li, Walon ; devel@edk2.groups.io > Cc: Wang, Nickle (HPS SW) ; Chang, Abner (HPS > SW/FW Technologist) ; Wang, Sunny (HPS SW) > > Subject: RE: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect > driver with form-update >=20 > Reviewed-by: Dandan Bi >=20 >=20 > Thanks, > Dandan > > -----Original Message----- > > From: Walon Li > > Sent: Wednesday, May 20, 2020 12:25 PM > > To: devel@edk2.groups.io > > Cc: walon.li@hpe.com; Bi, Dandan ; > > nickle.wang@hpe.com; abner.chang@hpe.com; sunnywang@hpe.com > > Subject: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect > driver > > with form-update > > > > REF:https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__bugzilla.tia= n > > ocore.org_show-5Fbug.cgi-3Fid- > 3D2701&d=3DDwIFAg&c=3DC5b8zRQO1miGmBeVZ2LFWg > > > &r=3DnGx4G_nX3rQG_ai3uSb52w&m=3Dj34dsoHyXFEvnpFmkT_iUSnMAF1kWbm > BFnMbHVJkJx > > U&s=3DV7D879dizWzD8-fTk-wXmw5sypK5jfdtjWAENVbXntQ&e=3D > > > > Recording to the spec, the reconnect is activated upon exiting of the > > formset or the browser. Exiting is by user but form-browser internal > > logic. That means the reconnection is only happened when user press > > ESC or _EXIT action to exit form. > > Driver callback may update HII form dynamically so form-browser needs > > to refresh its internal data. It's not exiting formset for user > > exactly and they didn't know what happened. So use a flag to record > > that and do not reconnect driver if updated by callback. > > > > Signed-off-by: Walon Li > > --- > > MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 2 ++ > > MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 8 +++++++- > > 2 files changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > > b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > > index bafee4c612..7f85873730 100644 > > --- a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > > @@ -19,6 +19,7 @@ LIST_ENTRY mRefreshEventList =3D > > INITIALIZE_LIST_HEAD_VARIABLE (mRefreshEv > > UINT16 mCurFakeQestId; FORM_DISPLAY_ENGINE_FORM > > gDisplayFormData; BOOLEAN mFinishRetrieveCall =3D FALSE;+BOO= LEAN > > mDynamicFormUpdated =3D FALSE; /** Check whether the ConfigAccess > > protocol is available.@@ -1762,6 +1763,7 @@ FormUpdateNotify ( > > ) { mHiiPackageListUpdated =3D TRUE;+ mDynamicFormUpdated =3D TRU= E; > > return EFI_SUCCESS; }diff --git > > a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > index 82067b541c..f936a4b8e8 100644 > > --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > @@ -68,6 +68,7 @@ extern EFI_GUID mCurrentFormSetGuid; > > extern EFI_HII_HANDLE mCurrentHiiHandle; extern UINT16 > > mCurrentFormId; extern FORM_DISPLAY_ENGINE_FORM > > gDisplayFormData;+extern BOOLEAN mDynamicFormUpdated; /** > > Create a menu with specified formset GUID and form ID, and add it as a > > child@@ -536,6 +537,7 @@ SendForm ( > > } Selection->FormSet =3D FormSet; mSystemLevelFormSe= t =3D > > FormSet;+ mDynamicFormUpdated =3D FALSE; // // Displa= y this > > formset@@ -547,7 +549,11 @@ SendForm ( > > gCurrentSelection =3D NULL; mSystemLevelFormSet =3D NULL; = - if > > (gFlagReconnect || gCallbackReconnect) {+ //+ // If callback = update > > form dynamically, it's not exiting of the formset for user so system do= not > > reconnect driver hanlde+ // this time.+ //+ if > > (!mDynamicFormUpdated && (gFlagReconnect || gCallbackReconnect)) > > { RetVal =3D ReconnectController (FormSet->DriverHandle); = if > (!RetVal) > > { PopupErrorMessage(BROWSER_RECONNECT_FAIL, NULL, NULL, > > NULL);-- > > 2.23.0.windows.1 >=20