From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web12.4504.1591767174094955541 for ; Tue, 09 Jun 2020 22:32:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=CdG901zK; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: dandan.bi@intel.com) IronPort-SDR: oZkSJbrEY6l+vHAAKgMOBpbNVvXW3FdkHJCxdqCRtWmetA7GWktSnCoAxw/wKXP3XKjKVmgsVB wnoYEzBiPlZg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2020 22:32:52 -0700 IronPort-SDR: afs5ynNAR7j9YjHc2LjX/C9MrgPjH1B6tWx29mwDYavs28QNcwAmCThpUfRa4kcQaVCZ3MrJyo YBcKMEqcLEsw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,494,1583222400"; d="scan'208";a="473220220" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga006.fm.intel.com with ESMTP; 09 Jun 2020 22:32:52 -0700 Received: from orsmsx122.amr.corp.intel.com (10.22.225.227) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 22:32:51 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX122.amr.corp.intel.com (10.22.225.227) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 22:32:51 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.55) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 22:32:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QZ7+8SWm337wmSXGkoxVQeHIJJsrS3ecdCs6SR8nbCVVHqvHSaQa0Mv/FYcpGvuPild32T4xTEPYZi9dfWkwcMOl2aKbxc6fXnDrbkX08/J6Zsn96oaMk1ZWKPDevVRDH9sQKBz1q41ugGP0LRTY26JWB/4+yZ5I3wVh124yWJZY1G3mvyqmIkSln7YjkJ5J2dtOmVvNrMV2jYHvCCZmxW0MOp657cm4fhH0Jj1K64wGFcQFwq7jMpNnjX491GAOyAFl+G1qhsL/SSWtmzQ4kuCoDaz7FvZAx+wrD2yBTBAh7fbfbM4e5TLsAnAEkDOKAvsL7mxFJmSDO8P9T1rzRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ByDCh4ZsLpfRQPvvuJCSdEil6etvbXDMazar/5ZmfJ0=; b=nOighOCb6bbI2AZfUxdkfZkaGMqmBnIu9y1CRtPwsT8fhhm0b675F1YnhxGbfYal0FhjAncUX1j/8g8+rc01Hqh7pLjh+09fOF9R+/IVXeCa+Q+HmjydEpVLi5UPnqE1fkl/WXkOBbdFSkr5fLIq97ldWmxakCT7WjWDgYoahRyKFdm89Ql0opD15T3LrhnAlqjKArgAi3GKS5Sdgg+LXTmIM1CebqhSKk7U3gDT3WWmN6iAj95tMKq1l92v8sPaT3KkrnhTZa0Ym3yVq3myRx60Tqaxhje81y7r7VLi0rGhuFM3Xgbx1y6ufwdIQ7QWf0PH+uLmZmQpyvBrCjjClw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ByDCh4ZsLpfRQPvvuJCSdEil6etvbXDMazar/5ZmfJ0=; b=CdG901zKhwPM22m4Al+82+q3J5WKc9PZmoGHn/S9s9mIYbZZaZf7WVEHAsRFn02H4zkv7NdrnWEptNyD0Lx17Lx8V7pCDJIxt8dvTRTbyt7LneIRTLxz3L95/gKqaCGyeCKRfiycRkUVbzRcoa31PHEosNPB8wIqE877f6Wr8Zc= Received: from BN6PR11MB1393.namprd11.prod.outlook.com (2603:10b6:404:3c::12) by BN6PR11MB1297.namprd11.prod.outlook.com (2603:10b6:404:4a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.23; Wed, 10 Jun 2020 05:32:47 +0000 Received: from BN6PR11MB1393.namprd11.prod.outlook.com ([fe80::a1f4:15d6:9a79:de03]) by BN6PR11MB1393.namprd11.prod.outlook.com ([fe80::a1f4:15d6:9a79:de03%11]) with mapi id 15.20.3066.023; Wed, 10 Jun 2020 05:32:47 +0000 From: "Dandan Bi" To: "Li, Walon" , "devel@edk2.groups.io" , "Gao, Liming" CC: "Wang, Nickle (HPS SW)" , "Chang, Abner (HPS SW/FW Technologist)" , "Wang, Sunny (HPS SW)" , "Dong, Eric" , "Wang, Jian J" , "Wu, Hao A" Subject: Re: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect driver with form-update Thread-Topic: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect driver with form-update Thread-Index: AQHWLl7IYBL1bOepQkyMkHngPJlol6i22bVwgA/0kYCAB51yoIADCH6w Date: Wed, 10 Jun 2020 05:32:47 +0000 Message-ID: References: <20200520042447.1017-1-walon.li@hpe.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: hpe.com; dkim=none (message not signed) header.d=none;hpe.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 39123f77-5ea6-45da-ec6e-08d80cffb59d x-ms-traffictypediagnostic: BN6PR11MB1297: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 0430FA5CB7 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b8vCzVlhHqqiUQ12tabap6U4dc23cY5FJLacm4e7dAUbWdZGy+3qcPenJL8Fty0lVoHBPV/vI24sd9qJa7PJP5JlHAJLAbcyEZ0+/lLgadtdMPYBQPCKLWO2sdnMk0pbk4a50xz9nuE4Obg/ejWVKYmdZEe3yW1VhuaQPZhRNG2DseVrDzRNvOgPgmWaYl+xVOpNamSGSD2bPNZ7bv0vlCBEuU3RRuDqH01y00vC7GoQpsmo/eeKfAy2wDxPsV8nMiT9d87tXZMUhVwQxbSSDn+iMz9Tc+AeC2ix6ktKFMLLbwVUxsZMnaFWkl76bmFiBy4gjM3Zmsy5RzNuiGq8tFeaVjioezzaAC8bIdbL9KvZvIPWTtU5D8sFCBMJ+JvEC0g2RfPG6+cDnxMk+uNyaw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB1393.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(376002)(366004)(136003)(346002)(39860400002)(19627235002)(15650500001)(478600001)(186003)(26005)(6636002)(71200400001)(2906002)(66574014)(8936002)(110136005)(9686003)(7696005)(8676002)(83380400001)(5660300002)(54906003)(66946007)(4326008)(86362001)(52536014)(316002)(64756008)(296002)(53546011)(107886003)(6506007)(33656002)(66446008)(66556008)(66476007)(55016002)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: HYxXfPAn3BoWdGMAKp13Z6bwVZ+bF1iovByeMJc4MhPpzVZc8f7vbIRX3lkrwK09YTJ9Q4ILb7D3yIdtD6eYCTedJSnoLjCusSdHJxKrWarQgxotQhL2aA4aqJOKrdRyfWtrZLDGBHV01QrFJVr5oV4olirlbT/l6aa6Gbvx7KRjHFSma1Ctw87/BAoe3jrx8IrM+VA2uEEFyBg1Nr5lAIDfgBBJSyQpBCMY7LoKpFdlEKqNRn9BfmQrtSvIcwABt5oNbSaq8569PPJzRVenD6AsV+WT2zZdg1TGLcF6ZCNSxipX1n6ARaqx7X8t+EjiGbwcVxV5DRCchLWlI87Ia3uvxSrrAfUnpWntqof/XuBk8XQmaEZ7vPj3lSGQWyM4LKuDHgx07FTtE4kJUuWuWtEAs2SDEcvyK7GUbtQ5W+jsYuzAqdiCKsy3gyG9brqJWNLFuTDlA1+0mZSY4RiGsFgLH1kS0BIumay5NvmDKQ0= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 39123f77-5ea6-45da-ec6e-08d80cffb59d X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2020 05:32:47.3905 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5EAl/isR65Gs03bizHFIzTACTPM0FcSfnQP2DXWC2ECoFgqyCf0EwpxRVTVkX6RENqX5lHGZ5TX5BEu0bHULJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1297 Return-Path: dandan.bi@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This patch is committed via 365fdb0f939cf00b26d37f27adbf579aa984221b Thanks, Dandan > -----Original Message----- > From: Bi, Dandan > Sent: Monday, June 8, 2020 3:16 PM > To: Li, Walon ; devel@edk2.groups.io; Gao, Liming > > Cc: Wang, Nickle (HPS SW) ; Chang, Abner (HPS > SW/FW Technologist) ; Wang, Sunny (HPS SW) > ; Dong, Eric ; Wang, Jian J > ; Wu, Hao A > Subject: RE: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect > driver with form-update >=20 > Hi All, >=20 > Is there any concern for this patch? > I will push this patch tomorrow if don't get any objection? >=20 >=20 >=20 > Thanks, > Dandan >=20 > > -----Original Message----- > > From: Li, Walon > > Sent: Wednesday, June 3, 2020 6:56 PM > > To: Bi, Dandan ; devel@edk2.groups.io; Gao, > > Liming > > Cc: Wang, Nickle (HPS SW) ; Chang, Abner (HPS > > SW/FW Technologist) ; Wang, Sunny (HPS SW) > > > > Subject: RE: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect > > driver with form-update > > > > May I know the schedule of pushing this change to edk2-master? Or > > what's next step I should do? > > > > Thanks, > > Walon > > -----Original Message----- > > From: Bi, Dandan [mailto:dandan.bi@intel.com] > > Sent: Sunday, May 24, 2020 3:17 PM > > To: Li, Walon ; devel@edk2.groups.io > > Cc: Wang, Nickle (HPS SW) ; Chang, Abner (HPS > > SW/FW Technologist) ; Wang, Sunny (HPS SW) > > > > Subject: RE: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect > > driver with form-update > > > > Reviewed-by: Dandan Bi > > > > > > Thanks, > > Dandan > > > -----Original Message----- > > > From: Walon Li > > > Sent: Wednesday, May 20, 2020 12:25 PM > > > To: devel@edk2.groups.io > > > Cc: walon.li@hpe.com; Bi, Dandan ; > > > nickle.wang@hpe.com; abner.chang@hpe.com; sunnywang@hpe.com > > > Subject: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect > > driver > > > with form-update > > > > > > REF:https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__bugzilla.t= i > > > an > > > ocore.org_show-5Fbug.cgi-3Fid- > > 3D2701&d=3DDwIFAg&c=3DC5b8zRQO1miGmBeVZ2LFWg > > > > > > &r=3DnGx4G_nX3rQG_ai3uSb52w&m=3Dj34dsoHyXFEvnpFmkT_iUSnMAF1kWbm > > BFnMbHVJkJx > > > U&s=3DV7D879dizWzD8-fTk-wXmw5sypK5jfdtjWAENVbXntQ&e=3D > > > > > > Recording to the spec, the reconnect is activated upon exiting of > > > the formset or the browser. Exiting is by user but form-browser > > > internal logic. That means the reconnection is only happened when > > > user press ESC or _EXIT action to exit form. > > > Driver callback may update HII form dynamically so form-browser > > > needs to refresh its internal data. It's not exiting formset for > > > user exactly and they didn't know what happened. So use a flag to > > > record that and do not reconnect driver if updated by callback. > > > > > > Signed-off-by: Walon Li > > > --- > > > MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 2 ++ > > > MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 8 +++++++- > > > 2 files changed, 9 insertions(+), 1 deletion(-) > > > > > > diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > > > b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > > > index bafee4c612..7f85873730 100644 > > > --- a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > > > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > > > @@ -19,6 +19,7 @@ LIST_ENTRY mRefreshEventList =3D > > > INITIALIZE_LIST_HEAD_VARIABLE (mRefreshEv > > > UINT16 mCurFakeQestId; FORM_DISPLAY_ENGINE_FORM > > > gDisplayFormData; BOOLEAN mFinishRetrieveCall =3D > FALSE;+BOOLEAN > > > mDynamicFormUpdated =3D FALSE; /** Check whether the ConfigAccess > > > protocol is available.@@ -1762,6 +1763,7 @@ FormUpdateNotify ( > > > ) { mHiiPackageListUpdated =3D TRUE;+ mDynamicFormUpdated =3D T= RUE; > > > return EFI_SUCCESS; }diff --git > > > a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > > b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > > index 82067b541c..f936a4b8e8 100644 > > > --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > > @@ -68,6 +68,7 @@ extern EFI_GUID mCurrentFormSetGuid; > > > extern EFI_HII_HANDLE mCurrentHiiHandle; extern UINT16 > > > mCurrentFormId; extern FORM_DISPLAY_ENGINE_FORM > > > gDisplayFormData;+extern BOOLEAN mDynamicFormUpdated; /** > > > Create a menu with specified formset GUID and form ID, and add it as > > > a child@@ -536,6 +537,7 @@ SendForm ( > > > } Selection->FormSet =3D FormSet; mSystemLevelForm= Set =3D > > > FormSet;+ mDynamicFormUpdated =3D FALSE; // // Disp= lay this > > > formset@@ -547,7 +549,11 @@ SendForm ( > > > gCurrentSelection =3D NULL; mSystemLevelFormSet =3D NULL= ; - if > > > (gFlagReconnect || gCallbackReconnect) {+ //+ // If callbac= k update > > > form dynamically, it's not exiting of the formset for user so system = do not > > > reconnect driver hanlde+ // this time.+ //+ if > > > (!mDynamicFormUpdated && (gFlagReconnect || gCallbackReconnect)) > > > { RetVal =3D ReconnectController (FormSet->DriverHandle); = if > > (!RetVal) > > > { PopupErrorMessage(BROWSER_RECONNECT_FAIL, NULL, NULL, > > > NULL);-- > > > 2.23.0.windows.1 > >