Re: [PATCH V3 2/2] MdePkg/Include/IndustryStandard: Main CXL header

["Javeed, Ashraf" <ashraf.javeed@intel.com>]

Liming.
Thanks for completing the review.
This is just a comment change ask and I can mend the comment to send again.

Ashraf

> -----Original Message-----
> From: Gao, Liming <liming.gao@intel.com>
> Sent: Thursday, July 23, 2020 3:18 PM
> To: Javeed, Ashraf <ashraf.javeed@intel.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [PATCH V3 2/2] MdePkg/Include/IndustryStandard: Main CXL
> header
> 
> Asharf:
> 
> 
> -----Original Message-----
> From: Javeed, Ashraf <ashraf.javeed@intel.com>
> Sent: 2020年7月22日 23:22
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: [PATCH V3 2/2] MdePkg/Include/IndustryStandard: Main CXL header
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2611
> 
> Introducing the Cxl.h as the main header file to support all versions of Compute
> Express Link Specification register definitions.
> 
> Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> --
> 
> V2: Indentation and double declaration fix, copyright date update
> 
> V3: Copyright date fix
> ---
>  MdePkg/Include/IndustryStandard/Cxl.h | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Cxl.h
> b/MdePkg/Include/IndustryStandard/Cxl.h
> new file mode 100644
> index 0000000000..632aa146d0
> --- /dev/null
> +++ b/MdePkg/Include/IndustryStandard/Cxl.h
> @@ -0,0 +1,22 @@
> +/** @file
> +  Support for the latest CXL standard
> +
> +  The main header to reference all versions of CXL Base specification
> + registers  from the MDE
> 
> Does MDE means MdePkg? I think "from the MDE" can be removed.
> With this change, Reviewed-by: Liming Gao <liming.gao@intel.com>
> 
> Thanks
> Liming
> +
> +Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> +SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#ifndef _CXL_MAIN_H_
> +#define _CXL_MAIN_H_
> +
> +#include <IndustryStandard/Cxl11.h>
> +//
> +// CXL assigned new Vendor ID
> +//
> +#define CXL_DVSEC_VENDOR_ID                                             0x1E98
> +
> +#endif
> +
> --
> 2.21.0.windows.1