From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.10713.1595505829585052434 for ; Thu, 23 Jul 2020 05:03:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=kuHZKBNa; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ashraf.javeed@intel.com) IronPort-SDR: tlaoLrQTEZ6DapIzj3xm0OikE1W5c5J55Tg4MRs4jsc2JFnyCkonzEMZfY7zFxEpxuu5s1DK0o qBx/ySr86xLw== X-IronPort-AV: E=McAfee;i="6000,8403,9690"; a="150492067" X-IronPort-AV: E=Sophos;i="5.75,386,1589266800"; d="scan'208";a="150492067" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2020 05:03:48 -0700 IronPort-SDR: rb1mRKF1ZEPB6Xi2Mecgf+PaNCdG/JHGjLa4TS7i/imNLb9hEAEnMLVfmHYjgj1CS6/TgKz7RD 14E78Ro7LhJQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,386,1589266800"; d="scan'208";a="320630064" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 23 Jul 2020 05:03:48 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 23 Jul 2020 05:03:48 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 23 Jul 2020 05:03:48 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Jul 2020 05:03:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nRseHuPE2yIfM7hrnCRMZES34Hs0/OgINPIVnHgUrJBBWXACAaOSxH2PcfKygRAoGALGFPEwGy1JInbDVPYgJxdXBM2EyVjXR34gtsL26BXGcmZxKXp3YK7MmqqARfmXxhX+Qq8kWmiqyVyz/AWpQkAHw2u2BoH3FQVAcK6lAtCPaR5qvlXmm0cmtpG3irYCTSG0dzIYBf5afDmL8DZKJ1DEAb267nKdaPz59Dekwk1EnEC1zGGWsbikmYU3wjX35WFwe5ehubUYHY1DyD1dTX6NGzSzaXwVksmdhM4nO6h7nfzLQC5vhskut577pOq1B2gyibQWpB7pNW8yoLvEcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fak88rp1bozDy0anX32PEWWRjpRrVdK8mxDrWb2fsAc=; b=ntvfRgYnxfgbGEo4m4eIyJaC0ncA3CoZ7gGA2GC5vW0c5L5Dfe2ba3dGVDe+btM+c8aM0Y31CUIblyfT+Cqwr+qigvB5FnLW0CYYkagYrbTki2x0lga32TtczcCVldHSdjc8fZAjLYPdIQ0OHwOvFOJmcg0wQG5tD2FRQNUqw1w9xM1UabgBZ4fiJTIrLVWONSSguIWZLs/+B5SxdrlWRzgVIr+8QB4R5lbnx/LuNfWaay6n+eEw4SayH8qMqcPFSEm1Tz7kPTOF1sV+kjRpd3erUVqnEJuQFvmCOflkAm1pfm4zAZOVl1LtmYPy/oqca/qX1zZlvZgmSunMHGLKDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fak88rp1bozDy0anX32PEWWRjpRrVdK8mxDrWb2fsAc=; b=kuHZKBNaNgnqaMECecwxeT3clDDydO0iEgu8C2ZJ4kBcM6fK4dmaxO8g1RSD9EVjnCRaULozoI0ufacPWbtz33gsSCwtY6NYfUWLEKMYkvXr6u4PWVrCwlmvehKOU/iMhvIw5ccIwV5kFAYSHQWeLCaxBRZmxK2g9TIC2Erj0yY= Received: from BN6PR11MB1873.namprd11.prod.outlook.com (2603:10b6:404:106::19) by BN6PR1101MB2067.namprd11.prod.outlook.com (2603:10b6:405:58::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Thu, 23 Jul 2020 12:03:47 +0000 Received: from BN6PR11MB1873.namprd11.prod.outlook.com ([fe80::e905:14db:71a9:6efa]) by BN6PR11MB1873.namprd11.prod.outlook.com ([fe80::e905:14db:71a9:6efa%2]) with mapi id 15.20.3216.023; Thu, 23 Jul 2020 12:03:47 +0000 From: "Javeed, Ashraf" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Kinney, Michael D" Subject: Re: [PATCH V3 2/2] MdePkg/Include/IndustryStandard: Main CXL header Thread-Topic: [PATCH V3 2/2] MdePkg/Include/IndustryStandard: Main CXL header Thread-Index: AQHWYDvuhBuZjQAhtEagK43OeY2QUKkU6SGwgAAomjA= Date: Thu, 23 Jul 2020 12:03:46 +0000 Message-ID: References: <20200722152139.16496-1-ashraf.javeed@intel.com> <20200722152139.16496-3-ashraf.javeed@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [49.207.197.101] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e35e9a05-f1c0-40b3-c59f-08d82f007459 x-ms-traffictypediagnostic: BN6PR1101MB2067: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SdamtaCg3whVQfJ8HlwcsAeVtcSLQIqQD746e+DUg+xFmjzMP6VEpPNF6D10jo3V/FdFeOg7uKB3j+45H7ZGvRVI0e/YRgmohhFFFT+H/2duDXE6dCvq2tsdiJ03GBa5ZwdajVW4ODokf879Iefpba0JoxCZ4JoaTFD9ANwFt9HP6Hjwphb3M4BzxZWeW0Xy7UfFhTvJ7ATCbhbRaSkUXDP4p3mf+X74rZ5GjuLTQIsT9xB6lERgPl3PKe8qxtgmL+Bu9ICrrCP0gW90lPC0MmmsL0w7jycxB0pL+dsyZ2alt2HxtQJJkPf1iwahOFDVnRj59hIi2cZ6oVqZhSkgHuEkPiiOqx+xvNWf3o2/qK8iTKX3dmvtvcE49nd+ODlNVZr+RiRkrRsCv6vFuJmINQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB1873.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(376002)(346002)(39860400002)(136003)(396003)(52536014)(7696005)(478600001)(26005)(76116006)(966005)(71200400001)(5660300002)(9686003)(2906002)(33656002)(55016002)(186003)(86362001)(316002)(110136005)(4326008)(66476007)(64756008)(66556008)(8676002)(66446008)(8936002)(55236004)(107886003)(53546011)(66946007)(6506007)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: VzXsV2BNeUacqOPMnOg74w6w56fkMgCnZsR8hLYRmmRta6aQrzRIxxaMkaNd0l/+MAojfdvu/5nqhr62t+JShl1xaAQkgzc4V1JVLoqe4yDtQljfNel3rv2sfVx0eq89FLyxqbbPM3Q6/Zl54gX1hw7QcdcpzySP52uukzFQg27J1I5eLZqUmoNLiEiDdZ+ZHG5qrt1piHEHG7RE3V5jjQ47ruqwT2hrx7UOGQbzt1R5ssIPkw6RSdOzzk8FwIW0KN+M0BvEj6kPEi6tIu1/fs9+WEQL+yWEcjXb966m+HFGpqmqNQi+iwnvTamnO4gS7hbJeN5spwN3V/VC0rRWUjOTZPCRA+ylWdUnCnrT9I92fm6YpgSR3lb/HydkunqcojkduyuUZLlYmhq5gAxKK3ivMH/lTWGmFAF/cxOhmsnlN//0nF1NUmfnctvUaQ6lQs6j8Q7FkpGClmuTrtQNNsoBB0tZGonxPf80jXWz8WMF0lNnb2M0/3+kc7upejU1 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1873.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e35e9a05-f1c0-40b3-c59f-08d82f007459 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2020 12:03:46.9341 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UOmGF+cJIXYYFUcmaYpArZ+f4lYM8UMvZtt+P9kTI8N6jveF1iufr9+jJ/piI9vNHJbncLhABkSq7s2wRbfOVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2067 Return-Path: ashraf.javeed@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Liming. Thanks for completing the review. This is just a comment change ask and I can mend the comment to send again. Ashraf > -----Original Message----- > From: Gao, Liming > Sent: Thursday, July 23, 2020 3:18 PM > To: Javeed, Ashraf ; devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: RE: [PATCH V3 2/2] MdePkg/Include/IndustryStandard: Main CXL > header >=20 > Asharf: >=20 >=20 > -----Original Message----- > From: Javeed, Ashraf > Sent: 2020=1B$BG/=1B(B7=1B$B7n=1B(B22=1B$BF|=1B(B 23:22 > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [PATCH V3 2/2] MdePkg/Include/IndustryStandard: Main CXL header >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2611 >=20 > Introducing the Cxl.h as the main header file to support all versions of = Compute > Express Link Specification register definitions. >=20 > Signed-off-by: Ashraf Javeed > Cc: Michael D Kinney > Cc: Liming Gao > -- >=20 > V2: Indentation and double declaration fix, copyright date update >=20 > V3: Copyright date fix > --- > MdePkg/Include/IndustryStandard/Cxl.h | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) >=20 > diff --git a/MdePkg/Include/IndustryStandard/Cxl.h > b/MdePkg/Include/IndustryStandard/Cxl.h > new file mode 100644 > index 0000000000..632aa146d0 > --- /dev/null > +++ b/MdePkg/Include/IndustryStandard/Cxl.h > @@ -0,0 +1,22 @@ > +/** @file > + Support for the latest CXL standard > + > + The main header to reference all versions of CXL Base specification > + registers from the MDE >=20 > Does MDE means MdePkg? I think "from the MDE" can be removed. > With this change, Reviewed-by: Liming Gao >=20 > Thanks > Liming > + > +Copyright (c) 2020, Intel Corporation. All rights reserved.
> +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#ifndef _CXL_MAIN_H_ > +#define _CXL_MAIN_H_ > + > +#include > +// > +// CXL assigned new Vendor ID > +// > +#define CXL_DVSEC_VENDOR_ID = 0x1E98 > + > +#endif > + > -- > 2.21.0.windows.1