From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.1322.1589353852065654591 for ; Wed, 13 May 2020 00:10:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=PSeWMz1+; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: ashraf.javeed@intel.com) IronPort-SDR: 4Qg1S8FEj72rgOlXBwEecZXDwJptdbuIIapGGzJGwR3My25faNhH64YxuWXqbmjRHS6fBdkqEW Q0yc1fpnqHgQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 00:10:51 -0700 IronPort-SDR: labgJOZT4EAqyW225veGPwQQVKsNy0iV5iuXEbe1zZS4fDJQV57klkVZ+ih1QUFyz/AEEBpv38 yph9gR0efqyg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,386,1583222400"; d="scan'208";a="262388612" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga003.jf.intel.com with ESMTP; 13 May 2020 00:10:51 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 00:10:50 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 00:10:50 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 00:10:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cVQvokqjlNmDGlRpd922Jaagma7BusvVafTezRLGAeSCj998SxrEwXwrulsELrtYV2itlEMqiyWSoWqS+Ya9bpcW/0epUEKirVnpJTsoML374S4+CKaltnu2mPY8NNbXFEoze5XuKKjBQGJJSR1If38ztWpupjzWz6+UoowgKIkkYDeKcbCYuqm3arv5oo28E9yOzctpLIFvTQOcGquprsqYiDRIBS3JDqygmQGmCykm57n8r39QHZjSDGU2fsejhRnnuDMMhbac+BRTD2PQaxpR4i2Jzmij7yuvS/8Lq9dMKs0MuKDsqNw8aUaIvrDeJl3D0BT1nTGbQPxkHC/fyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bm7K4N2/IcNhYgZaRoFuFrLFevKAp5S7cCxIKiS6c50=; b=BKIOKmJ83gqfmLvQ/ucUknzC14j/wIKxIvsGo+jq4u4Jt8ZjDGJgdP73SJn4ZRNHKW937io2VocW0qfsMxzHvnk6AVmTWVfHl1Fm4Uwf9cxBWhcJPlzxFVZ8YFD5tBqS09zt5LpPwnLsngk3IIDUUG96JkmSjO0n+4gpVa5Kx+jDqEak8xP29MD/lOoqoPNfLRUOENkDMo4CPdzX1D1Bg58Ukw936WovO2wU0bzvZAGxq/etBSU+cqX7hTrykOU9pKNDml5jUer7jt93NJBs3W1LFqA2G8dUvsjJBljKU3eKnEINdImH835cQ4K9WOqr2Zv4tswWxZMUq+mexVwp2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bm7K4N2/IcNhYgZaRoFuFrLFevKAp5S7cCxIKiS6c50=; b=PSeWMz1+8jZA4liXyO+eHZtdATCLw/2o/cjhpLsWp+pdYO4tVRIy77lTOJiL/nlwxbKXwR95l670+WuMCipk+XHokvlNZOFw9iu5HKwqBWan2v6JgtiLIOWj3j+wnCTnNrPe07IjRZuxqyuep3XCJ6+1nxVaSvGux4GSmEA9iwQ= Received: from BN6PR11MB1873.namprd11.prod.outlook.com (2603:10b6:404:106::19) by BN6PR11MB0004.namprd11.prod.outlook.com (2603:10b6:405:68::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.34; Wed, 13 May 2020 07:10:47 +0000 Received: from BN6PR11MB1873.namprd11.prod.outlook.com ([fe80::a4da:4ed1:ebed:4bee]) by BN6PR11MB1873.namprd11.prod.outlook.com ([fe80::a4da:4ed1:ebed:4bee%12]) with mapi id 15.20.2979.033; Wed, 13 May 2020 07:10:47 +0000 From: "Javeed, Ashraf" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" Subject: Re: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 12/15] MdeModulePkg/PciBusDxe: Enable LTR feature Thread-Topic: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 12/15] MdeModulePkg/PciBusDxe: Enable LTR feature Thread-Index: AQHWJuYUJe62JSGvi0ytnelqFKTApKig+CmAgASfJACAAALA0A== Date: Wed, 13 May 2020 07:10:47 +0000 Message-ID: References: <20200510161412.13832-1-ashraf.javeed@intel.com> <20200510161412.13832-13-ashraf.javeed@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C53AE6E@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C53AE6E@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [49.207.51.27] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 58d5fbcb-c86a-4af5-5f23-08d7f70cc2c0 x-ms-traffictypediagnostic: BN6PR11MB0004: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0402872DA1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pniyJu7Iavh902FXGrAiFIH88SuZeFRj0ZkMss9GnWzKE6yPQt4xCS5rMWu/A7IrJFNTqrIGZ6v2fpTP2X4fDTkkqNGjwbohYkxLnlRzdDDOWOwXEzBv3a9PDCbv4I74PFciKXJfGBRfrqfWuUJsi++D9q/qyIKScFzFoNnVShVpSm/p4O1S2PUfE3C2WDlDS4HfxhMCyMcSYGDbWAVWGlA/X8d0O14sHYI2vtRK6EXrkfwzFvdmssi/Kx+xYMhYIvCofGcGCkOBwo3XXDQrT89o8Sp+uMncQmkwzt2gqzwAdXpGi8uGKBhbQr4HqoXOIOFxBwQThctOdSc8NefEqmXLP7u4dleZmdJ3VFt6cN9expcbpfitb4SysqTjZ0hw9epf6LQSZDpAibULtPUZgWpeXv06XGnW1FfgmlKqWXSP0jK3vzVRe4dpZsbB6QHsL0AQtp+SVpq4hKwO4Pt2yazK/UaM8xYORRpSyNCwA0W3dLaZ2CBy8SMowH9wHqOeZZDctfRDrypeI1+XEA8wCQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB1873.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(136003)(366004)(346002)(39860400002)(376002)(33430700001)(4744005)(26005)(33656002)(64756008)(7696005)(54906003)(5660300002)(66556008)(86362001)(76116006)(110136005)(8676002)(52536014)(55016002)(66946007)(66446008)(8936002)(316002)(66476007)(6506007)(2906002)(33440700001)(71200400001)(4326008)(55236004)(478600001)(53546011)(186003)(9686003)(107886003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 7w5dCnRMB+1dSP7nlSG08FUteFBSGtrtfEJMT38UP7T93IpnfRsjrtMer4bunb9EewQSy3Zzoc/wqoPrygvDR+hYCYHqqkQxG08L/hDUjNk7e15T0REFw5a9mdeLkQ7Kj/NdhWD2UnXTuOPWNiaE83+OeVsdkaAB6k+066+VYaroInCeX+NZBca4ReUiPZgUxtWEvOsfu96YrkPg2we89dxo7K0J49iGCN6JW3EypD6kcnIXTgbJanMibGg21qn8zplvDG2Rbg5c02ozN1Q9ny52VZ/aaP8IjNXUn+4lyNFzA77Xm895EkBBbZO2sJSLzhTkC+y3R0SE03J7VuZWZvpmjZAg8AcxFkXaeqcmtzFwrTdrXaLysSKLTFE5TIicN7vJbN2FipLvCmNODnPDC8h6NkXniO9wMSSKxiExMmj8QVldYh/jxgDXxLwQGuXgcx0iwQkLON5ZBe3PSriTa70fEllA7Rwf5VSHWdG9mlo= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 58d5fbcb-c86a-4af5-5f23-08d7f70cc2c0 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2020 07:10:47.2601 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5/NQSMK7lLDEoTpQXV0J5oQeISxMGYVjiTPEggShyQ7RU/ve7f15UzIWuEUrZJ5zETBeNb9EKFZM9eDDlBsC6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB0004 Return-Path: ashraf.javeed@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Ashraf > -----Original Message----- > From: Ni, Ray > Sent: Wednesday, May 13, 2020 12:19 PM > To: Javeed, Ashraf ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > > Subject: RE: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 12/15] > MdeModulePkg/PciBusDxe: Enable LTR feature >=20 > > +EFI_STATUS > > +LtrScan ( > > + IN PCI_IO_DEVICE *PciIoDevice, > > + IN UINTN Level, > > + IN VOID **Context > > + ) > > +{ > > + BOOLEAN *Ltr; > > + ASSERT (Level <=3D PCI_MAX_BUS); > > + //ASSERT (Context !=3D NULL); >=20 > Why the "ASSERT (Context !=3D NULL)" is commented out? >=20 I thought this check is not necessary for LTR alone, wanted to remove this = later but missed. What is your suggestion? If it is used for LTR Scan than it has to also use= d for other features. > Thanks, > Ray >=20