From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.1222.1589352887197483938 for ; Tue, 12 May 2020 23:54:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=LHAyUD0C; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: ashraf.javeed@intel.com) IronPort-SDR: jHCIeGUwA0dScQpmu6pP7Cc5iA1as4YXZWMXFDd4mwZmJbLUzV9sgjTNIdBEu3bgJYHVK1Yohw qDLHjj5946bg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2020 23:54:46 -0700 IronPort-SDR: Rl8CtQidXPnwARwP9y3rZ6XGiR5vJsQqiabQ3qjI3B4iqMo82rr5Nz/uJm7ZV3hs1NxRfDtOjJ E6913niW/mvA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,386,1583222400"; d="scan'208";a="251684497" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga007.fm.intel.com with ESMTP; 12 May 2020 23:54:45 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 23:54:44 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 12 May 2020 23:54:44 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 12 May 2020 23:54:44 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 23:54:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hmZZRlJWBWtRR7d7HKSnA+jWY1hk/Zt7pSe/PF+rvaHQ+qF6H+65uX7082KiTHCq+xXJQqiST28SpDSwq3Z9vqzEcRiG6PqLaa/0I/3JP34/P34Fjhu2RZnUVVVMXSfKOdh7YMnl2ZxTi8rkdVcNGbM3H/JL4gBRoyNQO+APFCr18q9TMuxHH7Tw8wZPQTdKKap9HcLjQkaMfmLms9OeBvebzwhhjjex7QQrXhYGwwbVZEFqohYYzKMa1m7WvrNW/b+eylXO4ROV9H0BNgB+qV9kfnAZ0zcDwxRy1SENdK4UQXY36Y6XbOHXlrweKGxSq4HN4sN5RN2V9wCa5svtjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CX4LNMQHRpxpURIlDEduGYNktjwrn0WhuKKP+HtECU0=; b=NlXQ2XLbUJRKb24pWt+MIKD6jglufg+hD7vB8gZheibxlkppH82lc9XDdeADUmLfT/YDL9vGV1QLMWC79W8XseCOMmtdwTNw00trnOTseDrXarnPQvbzLBzkIA9fE2JRNqTuI3a1lF9b/RsESXuHLL/JB4+O7BCw5U9cmWdufTSQGZJc7SviWZQ94XxcbNH2mXg8XWLzVuAo5T58MD6eDvYxiGHPRPyqfWRBHKk53UZl6S+EJWnvK+M24A7E9jn22LAEhDTfYtfUHx0UAlSeeDSHAsGgI6TNEjtiknCYWuAqDr1OIWMasqrV5AVau1oc3Nt0qUCXos+UwUY1RoBdgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CX4LNMQHRpxpURIlDEduGYNktjwrn0WhuKKP+HtECU0=; b=LHAyUD0CEUsAb7SWAnxs4WzqvwGvzup6amPhfzAg0XsW11s3tpYUFHhvCkL5/ixfKEdpJPO5EOdvgO6dus7SyLeWtjIoU85QgoWWHbK4wZgWbEwz6Ilu3jVhWW3RA8bsCMI0DElzhXEpXc/CKg74Knq2rblE/bh2WCXtLFxst8c= Received: from BN6PR11MB1873.namprd11.prod.outlook.com (2603:10b6:404:106::19) by BN6PR11MB1235.namprd11.prod.outlook.com (2603:10b6:404:3c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.34; Wed, 13 May 2020 06:54:42 +0000 Received: from BN6PR11MB1873.namprd11.prod.outlook.com ([fe80::a4da:4ed1:ebed:4bee]) by BN6PR11MB1873.namprd11.prod.outlook.com ([fe80::a4da:4ed1:ebed:4bee%12]) with mapi id 15.20.2979.033; Wed, 13 May 2020 06:54:42 +0000 From: "Javeed, Ashraf" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" Subject: Re: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 07/15] MdeModulePkg/PciBusDxe: Enable MaxPayloadSize feature Thread-Topic: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 07/15] MdeModulePkg/PciBusDxe: Enable MaxPayloadSize feature Thread-Index: AQHWJuYUJe62JSGvi0ytnelqFKTApKig+CMAgASdH8CAAAHuEA== Date: Wed, 13 May 2020 06:54:42 +0000 Message-ID: References: <20200510161412.13832-1-ashraf.javeed@intel.com> <20200510161412.13832-8-ashraf.javeed@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C53ADFC@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C53ADFC@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [49.207.51.27] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f9840534-1b01-4d5b-8e17-08d7f70a83bc x-ms-traffictypediagnostic: BN6PR11MB1235: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 0402872DA1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xmGzltdAoKhBYWn872wNtLxCFMfhB+NS9oDeCN1bYvtle0KBdklUrcnTYNIPEfE6W81crffRFij3Dnn6WAIuo/bkgLN8eJvv/mY2N65uuTD84ez+OEvtoGt1BttNH70ID3bi+JHt2dgNPZeAi2Ke6vzJm3X4mK17J3YlR8fpZhaBonsn5eWsDz3AnxwaJNCBYEB+vNa178dkJ1JesBxEEH9H27vTQShIIL2PL8WSvy8BlvgqtqnhFOhabVdlsX/tm5P1Qd0lJqe5kFws3vrQUCrqlvNaSxJg3Ie+JFwm9R5O0Z41uHi9cGWTVY/P9p5cVtPfjd9U9XRe1EqIh5fb3oxw+MBog8CPXJFuAeQYGEnnpLCn80/1howgRbNlAuXpZV1BzDOdqBuhG3jSE03/bXwdtJtXn7Bv2EEFRR7ralXOvtSloNW0TKqCmyN5+h77BP+7hdUVWQSqB8bwoQk1uW+4NM9bz8gbD9tLItfgde/2+p+YyZ9qpau/FFW2WWL7mYzq9Z0g6FJw6VPiaCYNUw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB1873.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(136003)(396003)(39860400002)(346002)(376002)(366004)(33430700001)(6506007)(66946007)(26005)(4326008)(8936002)(76116006)(54906003)(5660300002)(71200400001)(7696005)(110136005)(86362001)(107886003)(316002)(186003)(55016002)(66556008)(64756008)(53546011)(55236004)(66476007)(33440700001)(52536014)(8676002)(2906002)(478600001)(33656002)(9686003)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: Y9pY4GIlTPf6VyX2Vnh7W6QJaUXS1CyvGuw6Ipk/wTV2d9qDyOWegm2EIJGRmtIrRq6sJNgEy0f3nMst3CFsv22fEiQbnok/1anFjlWmttNQk7Xf8Rst8kNaSfLXGYwK4OhsSSGzoBjsTruh+uD1r+pyaRr5xrItKuXiPtCn9l0ew8luseIkkNvt+7dozeTC9dFkuKtuxmSidgPHLATGNFRC864EC9i0yPSeXkx4OdS6rImVtpvCRfRl+l/4Ya633a14RrcjXIvXSJQXcZE9Y/Rt1zkq7cBKmtxZbUz/8XuD1PCwrjjTVX99L17gJrjqaydeKr50LrZ/BCklHZiDm80noPwhYiXz0GPRjAU86kx2qyFsym65TjnB7CZZbbvuDnhxqnBKJSWwEn30AFfcHHFZ5/NGYPh83VzUgWEd+U0iw52cxQKOuVJVNBi75PcElA68c5TgnvDVxMOdYpnqJarsty0V9D2AzVLzJgex3yI= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f9840534-1b01-4d5b-8e17-08d7f70a83bc X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2020 06:54:42.4862 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xCMEc5xaERN0KMMwNizHyGr92Er/iQ6WAMrXtzM824zLIXMi30ob85FotuUh4nz8Wck64cjk12JVQS7CBjktww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1235 Return-Path: ashraf.javeed@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable My response in line. Thanks Ashraf > -----Original Message----- > From: Ni, Ray > Sent: Wednesday, May 13, 2020 12:16 PM > To: Javeed, Ashraf ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > > Subject: RE: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 07/15] > MdeModulePkg/PciBusDxe: Enable MaxPayloadSize feature >=20 > > /** > > @@ -220,6 +226,7 @@ PcieNotifyDeviceState ( > > > > CopyMem (&PcieDeviceState, &PciIoDevice->DeviceState, sizeof > (PciIoDevice->DeviceState)); > > > > + PcieDeviceState.MaxPayloadSize =3D (UINT8)PciIoDevice- > >PciExpressCapability.DeviceControl.Bits.MaxPayloadSize; >=20 > My original idea is to directly use the PciIoDevice->DeviceState. > Your patch is even better because if the policy value is AUTO, it's bette= r to > report the actual value in HW to platform instead of AUTO. >=20 Yes, that was the intent. > Can you remove the CopyMem() call? >=20 The CopyMem() shall maintain the PCIe features that are not yet supported b= y the driver, or if the platform has chose to not initialize that PCIe feat= ure(s) using the NOT_APPLICABLE. Are you suggesting to explicitly assign NOT_APPLICABLE to those features? > Thanks, > Ray