From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.1099.1589352376534866152 for ; Tue, 12 May 2020 23:46:16 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=p9nfxKxL; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ashraf.javeed@intel.com) IronPort-SDR: +5qo3QQR6euww3HwhO704n4+cAwgHfwWhXhtHPcushvtHSTa1C8fESV2uCJP/vtKQ83x6x2pL8 XNL7r6NI7aLw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2020 23:46:16 -0700 IronPort-SDR: 6AywKMyiXftVW+E5b0ao1fP1J2W0X2ACpdayxGIizaCx0+cS2jPFuo/mOBuWg2xNSkoIyzrRba srdcxCUQHd/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,386,1583222400"; d="scan'208";a="437387518" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 12 May 2020 23:46:15 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 23:46:15 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 23:46:15 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 23:46:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JrAVDYZtCNWHc4OvBjpIAuRJH1Hq0sqATyw0WxDqygb2BNaB8Fi6qRZx9PemvrfT2wZgU/joxsBThiYmi4TS5lvXZgbVour6/Lxp+drtmkkg0w2UOsfU77AbFHt02NYJaXKMf9XAnMwIGZ2a/Rcwruh1YDb/C6OpcsnWqeJFZJ4kpjXFF3MyPyKgibPVNZ7mvJUPbYZNU3u4OphZsX+NoVptSj+LW30r43AmMDyENZHxvEDeXimRFZUL0Av6WsQlY8sYYB7Nlugw2grkTgm35WtCAKYVQHAQsrJU75PDSkkY/FHctATOCZQPBPdYwFN+hMST1PA+P2Vwve7gt7OqQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VTQPHBaedpCb9/kUSoZ+pMCBakfTjoRH4OHjnR8hdIU=; b=RspJQZJRDMD0Apl/RW0HvSOQBZKOLBz8ly5B2dYl3IgV/QqJf7DRQQrcv8tpmYolFVPvMS2C/IsGzxjH10NG8M6pU2FtfDNdwhjHyZhImwEZCtnqNw5maSLDdWAVbjlEjd8RlEPFemN1dgLr2pvDddkMSbDD4bWZhm+GmViqvo2AkYYsZ7o0h0ORQdCImQW4+E567z5xVWoOkuadqNj7EnCWEMG+KFdntV2ESLD1VqHdG35iygQ1fRRC1UFvgGsT2Sl2Pb4gMEbkMa7hXohynBs+YEqSKU6RehLko+kSuLX68akh+z7SBx1/26H+6gB76UxXV5FxOV9Ynyb2yzjF4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VTQPHBaedpCb9/kUSoZ+pMCBakfTjoRH4OHjnR8hdIU=; b=p9nfxKxLtwFQlNMDOqqkyihouXQ+/7l9YPorKtYjCme8KZtBP0HaaLIF9x6Q2rsvqywB3pqoOmXnEQ4EvtVz/7zfyVsglz5xYS/WM5ouraw4Kc3V4CeVLEpGajvxC9yjDtH4Ogdv6SHFA/ShuBLXywwYhcc+ZfwPub21jLW3X3s= Received: from BN6PR11MB1873.namprd11.prod.outlook.com (2603:10b6:404:106::19) by BN6PR11MB1826.namprd11.prod.outlook.com (2603:10b6:404:102::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.33; Wed, 13 May 2020 06:46:13 +0000 Received: from BN6PR11MB1873.namprd11.prod.outlook.com ([fe80::a4da:4ed1:ebed:4bee]) by BN6PR11MB1873.namprd11.prod.outlook.com ([fe80::a4da:4ed1:ebed:4bee%12]) with mapi id 15.20.2979.033; Wed, 13 May 2020 06:46:13 +0000 From: "Javeed, Ashraf" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" Subject: Re: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 06/15] MdeModulePkg/PciBusDxe: Add the framework to init PCIe features Thread-Topic: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 06/15] MdeModulePkg/PciBusDxe: Add the framework to init PCIe features Thread-Index: AQHWJuYUJe62JSGvi0ytnelqFKTApKig+CKAgASaqbCAAAOW0A== Date: Wed, 13 May 2020 06:46:13 +0000 Message-ID: References: <20200510161412.13832-1-ashraf.javeed@intel.com> <20200510161412.13832-7-ashraf.javeed@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C53ADAB@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C53ADAB@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [49.207.51.27] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 97e0b3c1-a7d6-4c76-5451-08d7f7095435 x-ms-traffictypediagnostic: BN6PR11MB1826: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0402872DA1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9jS5NIAEHNAVxeTMjUa2svMEJcVsCLPkRDcTepZijy+Aywxs5bnA744gx1hqyZD2H4GY9YkoBbHoDsaWs7vZl8sj7q4tztVKm2zOWK5hhHKGadHKkMvoYVbXW+JCilR8+k4fj/Khhllvq28TrGMmDJ1KoT4d7PNByPIarJE5hZQ1zdzhurz2cpMhmtp1ilFKRa3iEuIiLYtQ5sBa8SFrxqAIZFmh+oG6+Jyd4oSoVa3fdIGS0PsGEvIn23a+k1RYOLhjFAW29spmgzXU4pokzVMUckshL00Olozf4uiOJGm+ucWT8jNPhADrNFkLtLTqja+WlminLCZEH3LOuL3jE26llRRJkNFjon2vcEEevTidg7og20VNKkAg9+bOt4drqM9VGyfmqd8TA4fQ0iZnSKBysekeqkU1ibLMBGlyHuFrKFhjJtqFDPEkgOA4PXh5y0Z6RD4z4w08iop7IhSMYmW6vZ7qfwmKdWpXs76L32u+BkCupoZiUGDJ7f246aF5CAZ/SiHC/5G8ki22i5wLAQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB1873.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(39860400002)(366004)(376002)(396003)(136003)(346002)(33430700001)(9686003)(478600001)(55016002)(7696005)(4326008)(71200400001)(4744005)(33440700001)(33656002)(107886003)(5660300002)(86362001)(8676002)(2906002)(26005)(54906003)(6506007)(110136005)(76116006)(55236004)(52536014)(66556008)(66946007)(316002)(66446008)(64756008)(53546011)(8936002)(186003)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: AAWyrfgqB5x+MqE7D0eG+hX0XoV2nr0y6B7zM5h/EHpkItOWnqBWf3o4tNv7q9K/mrA9K10eDrYEJVZjsNuAkJi3rLnZsXHDxpwCJB2zfdDKt9UNpwLvMaNCBw5Z4cvfd52FscLlT4Yatj4fzwWI+4/sOd238EBUnC/Y4OpdmSEsrTykyF/dDLQdFdJxbupXfanVFNVq4lEQs9skblY3mlLii2FaI54PNWidkSXxvOqZlW1j9RI9b3gbLkN5qNg5df3Kp6RkKMUFXdBpumApaYJmd1GkWKFiH+oxOyZQ1NS1aQ45WHgGzJIRB6IMB0yFv/Kn27hQCQ35X4BOtb9AsgUQh1ur/bunTOkki9h0mobHtKd0JtBpuq5bZzA7NOupzuja1btLFzoLfnl0/5jtXHXDweNqQ0TrVPi+LsAAmoQkqsERidbq9eMZrIf4KnKII6o354UQCz3Gi5nuby1WCPq+huvGAK4hMlhw2ucVCpA= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 97e0b3c1-a7d6-4c76-5451-08d7f7095435 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2020 06:46:13.4492 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cXP2A4kxFEnxXfVw8NDCQxvpncxdKudVEVY19JXtM8w27OWe8Lnu03eKZzvxeBDGjxznejpf60MZErtYx0gD9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1826 Return-Path: ashraf.javeed@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes, both the comments shall be fixed. Thanks Ashraf > -----Original Message----- > From: Ni, Ray > Sent: Wednesday, May 13, 2020 12:09 PM > To: Javeed, Ashraf ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > > Subject: RE: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 06/15] > MdeModulePkg/PciBusDxe: Add the framework to init PCIe features >=20 > > + // " Device MPS MRRS RO NS CTO LTR\n" > 1. Can you update above comments to below? > // "Device MPS MRRS RO NS CTO LTR AtomicOp ExtT= ag > CCC\n" > It explains why "%03x" or "%08x" is chosen in below DEBUG output. >=20 > > + DEBUG (( > > + DEBUG_INFO, " %02x|%02x|%02x %03x %04x %02x %02x %03x %03x > %08x %06x %03x\n", >=20 >=20 > > +} > > + } > > + //DEBUG ((DEBUG_INFO, " PCIe %s feature...\n", > mPcieFeatureStr[Index])); > 2. Can you please remove the above commented debug message? >=20 > With the two comments addressed, Reviewed-by: Ray Ni >